MB-19503: Fix ConnMap so notifications don't go missing. 25/64025/2
authorJim Walker <jim@couchbase.com>
Wed, 11 May 2016 15:26:47 +0000 (16:26 +0100)
committerDave Rigby <daver@couchbase.com>
Fri, 13 May 2016 19:47:50 +0000 (19:47 +0000)
commit0856e0b3d3fc62a50677a9be7963be3d5c04d041
tree15cc18db30b1c683239aed1bc0422e6a4d5091f1
parent00272e095b58fb5267b950b0511a0b9147b40dd5
MB-19503: Fix ConnMap so notifications don't go missing.

There's a reliance on an atomic bool and cmpxchg to
prevent the producer of notification from queueing
himself if he's already got a notification scheduled.

There's an ordering issue though where the producers code
can execute, see the flag is true and not bother queueing
a notification, yet the consumer side is about to clear the
flag and finish. The notification thus never gets queued
and the producer side thinks he will get a notification.

In my terminology:
producer is ConnMap::notifyPausedConnection
consumer is ConnMap::notifyAllPausedConnections

Change-Id: Id324b6369c5ee3a6b6758a7a93e017a4ff7c4a78
Reviewed-on: http://review.couchbase.org/64025
Well-Formed: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: buildbot <build@couchbase.com>
src/connmap.cc