MB-23905: getWithMeta doesn't need to bgFetch for datatype 82/77182/2
authorJim Walker <jim@couchbase.com>
Fri, 21 Apr 2017 09:41:38 +0000 (10:41 +0100)
committerJim Walker <jim@couchbase.com>
Fri, 21 Apr 2017 15:41:57 +0000 (15:41 +0000)
commit3eeff0fa5968384c7d454639669fa4bf6b1f445a
treee157966600c33bd3ca5a4f174bce5ed34561654b
parentb02ac3b36e71bdb82ec38f4362db0c7e9a0b266b
MB-23905: getWithMeta doesn't need to bgFetch for datatype

Some more code left-over from when datatype was part of the value
is now removed. getMeta only needs to perform a meta-data fetch
and have no special case for datatype requests.

A test is added which recreates what happened to trigger the MB.
A getMeta was returning key_enoent instead of the datatype because
it was doing a full bgFetch against a deleted value.

Change-Id: I6715d789f6cb8503cd44b860fd78ae3224d9bc67
Reviewed-on: http://review.couchbase.org/77182
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>
src/ep_engine.cc
src/kv_bucket.cc
src/kv_bucket.h
src/kv_bucket_iface.h
src/vbucket.cc
src/vbucket.h
tests/ep_testsuite_xdcr.cc
tests/module_tests/evp_store_single_threaded_test.cc
tests/module_tests/kv_bucket_test.cc