MB-16181: Filters with deleted collections 70/78570/2 master
authorJim Walker <jim@couchbase.com>
Wed, 24 May 2017 16:10:50 +0000 (17:10 +0100)
committerDave Rigby <daver@couchbase.com>
Thu, 25 May 2017 09:15:13 +0000 (09:15 +0000)
commit5cf47c058c3cc73d4fb90f7d295530f395808526
tree967c176b80e10fcb7f7f52655744e9171c8af35a
parenta5493828daed68ec522870190878edb5c63b603e
MB-16181: Filters with deleted collections

Upstream integration revealed an issue with the VB::Filter.
If we construct a filter with a collection "X" and "X" is actually
marked as deleted, "X" should not be part of the filter.

We fix this by replacing VB::Manifest::doesCollectionExist with
VB::Manifest::isCollectionOpen which performs the correct checks.

Tests updated to cover this case.

Change-Id: I38d4ba025805da7653bf3a84053d4280f4f547d7
Reviewed-on: http://review.couchbase.org/78570
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>
src/collections/vbucket_filter.cc
src/collections/vbucket_manifest.h
tests/module_tests/collections/filter_test.cc