MB-20852 [7/N]: CheckpointManager::queueDirty: Pass vb by reference 16/69016/5
authorDave Rigby <daver@couchbase.com>
Wed, 19 Oct 2016 10:26:33 +0000 (11:26 +0100)
committerDave Rigby <daver@couchbase.com>
Mon, 31 Oct 2016 15:36:27 +0000 (15:36 +0000)
commit6db62e1091e9591bedd69733cf38f78d1f3f65f4
treed7c600e4ade36308872c1f359c86de77d4af5e37
parent4a7d52e97fe00ce3a8773711d1900efc77ee76f7
MB-20852 [7/N]: CheckpointManager::queueDirty: Pass vb by reference

The VBucket argument to queueDirty is passed via a (reference to) a
ref-counted pointer. Nothing in this function modifies the arguments'
ref count, or passes it another owner; moreover it is also never null.

Therefore change to pass as a reference.

See also:
http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rr-smartptrparam

Change-Id: Iccfeb42922da558b6e9ab430b96829002e85af4a
Reviewed-on: http://review.couchbase.org/69016
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Reviewed-by: Jim Walker <jim@couchbase.com>
Tested-by: buildbot <build@couchbase.com>
src/checkpoint.cc
src/checkpoint.h
src/ep.cc
src/ep.h
tests/module_tests/checkpoint_test.cc