MB-19503: Fix ConnMap so notifications don't go missing [2] 15/64115/2
authorJim Walker <jim@couchbase.com>
Mon, 16 May 2016 15:24:35 +0000 (16:24 +0100)
committerDave Rigby <daver@couchbase.com>
Tue, 17 May 2016 15:17:32 +0000 (15:17 +0000)
commitc99b61d1795407f042e66d44c3375cc834c901e4
tree3c72fbcb6022fb14a673b58bd0633343cd9ff174
parentf02711fd22118e2ac076c882c28232909985fd65
MB-19503: Fix ConnMap so notifications don't go missing [2]

Previous patch[1] cleared the isNotificationScheduled flag
at the wrong place and meant things could then never
again get scheduled.

This is because we only cleared the flag if tp->isPaused()
yet we still pop the notification from the queue, so we
left tp->isNotificationScheduled yet the queue is empty.
Now no more notifications will ever get scheduled!

So we need to clear the notification scheduled boolean
unconditionally of the other flags on tp.

[1] - Commit 0856e0b3d3fc6

Change-Id: I11c9fd72f4b35102328022bd4c334a9e09a61cd0
Reviewed-on: http://review.couchbase.org/64115
Well-Formed: buildbot <build@couchbase.com>
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
src/connmap.cc