MB-19503: Fix ConnMap so notifications don't go missing [2] 72/64072/3
authorJim Walker <jim@couchbase.com>
Mon, 16 May 2016 15:24:35 +0000 (16:24 +0100)
committerDave Rigby <daver@couchbase.com>
Tue, 17 May 2016 13:35:35 +0000 (13:35 +0000)
commitd4bd08b8bac570010c39e16d4f3c8ac511f2ed7f
treebe2ff85c82f26d935f768522ca7a1582d7e61499
parent0856e0b3d3fc62a50677a9be7963be3d5c04d041
MB-19503: Fix ConnMap so notifications don't go missing [2]

Previous patch[1] cleared the isNotificationScheduled flag
at the wrong place and meant things could then never
again get scheduled.

This is because we only cleared the flag if tp->isPaused()
yet we still pop the notification from the queue, so we
left tp->isNotificationScheduled yet the queue is empty.
Now no more notifications will ever get scheduled!

So we need to clear the notification scheduled boolean
unconditionally of the other flags on tp.

[1] - Commit 0856e0b3d3fc6

Change-Id: I11c9fd72f4b35102328022bd4c334a9e09a61cd0
Reviewed-on: http://review.couchbase.org/64072
Well-Formed: buildbot <build@couchbase.com>
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Will Gardner <will.gardner@couchbase.com>
src/connmap.cc