MB-19503: Fix ConnMap so notifications don't go missing. 34/63934/4
authorJim Walker <jim@couchbase.com>
Wed, 11 May 2016 15:26:47 +0000 (16:26 +0100)
committerDave Rigby <daver@couchbase.com>
Fri, 13 May 2016 15:09:07 +0000 (15:09 +0000)
commitf02711fd22118e2ac076c882c28232909985fd65
treed918e43a3ae67bb9ede8fb5aa888a29189195dc9
parentc8f6dbf342655505c8cf4ad6bc91d67f0073bb35
MB-19503: Fix ConnMap so notifications don't go missing.

There's a reliance on an atomic bool and cmpxchg to
prevent the producer of notification from queueing
himself if he's already got a notification scheduled.

There's an ordering issue though where the producers code
can execute, see the flag is true and not bother queueing
a notification, yet the consumer side is about to clear the
flag and finish. The notification thus never gets queued
and the producer side thinks he will get a notification.

In my terminology:
producer is ConnMap::notifyPausedConnection
consumer is ConnMap::notifyAllPausedConnections

Change-Id: Id324b6369c5ee3a6b6758a7a93e017a4ff7c4a78
Reviewed-on: http://review.couchbase.org/63934
Well-Formed: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: buildbot <build@couchbase.com>
src/connmap.cc