MB-23863: Make DCP backfill read deleted documents 09/76709/4
authorJim Walker <jim@couchbase.com>
Tue, 18 Apr 2017 09:12:31 +0000 (10:12 +0100)
committerDave Rigby <daver@couchbase.com>
Tue, 18 Apr 2017 12:14:05 +0000 (12:14 +0000)
commitfe7cbc834ad4dc376fc79e2267416d21478741bd
tree4200f4e25ec4d955f12515a5d72eba6eef46ed1e
parent72a3b4281633cd8c3e6703eb03ea222db95c10da
MB-23863: Make DCP backfill read deleted documents

recordDbDump is invoked for KVStore::scan (backfill) and was coded to
skip opening of the document if the docinfo says deleted.

This commit then removes the error case where
couchstore_open_doc_with_docinfo returns -5
(COUCHSTORE_ERROR_DOC_NOT_FOUND) as that just means the document has
no-value and we still need to continue to creating the Item.

Change-Id: I6e2e563ef68f9bc4404c5e59480f8c6fb2dd36e4
Reviewed-on: http://review.couchbase.org/76709
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
src/couch-kvstore/couch-kvstore.cc
tests/ep_test_apis.cc
tests/ep_test_apis.h
tests/ep_testsuite_dcp.cc
tests/mock/mock_dcp.cc