Code Review
/
ep-engine.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
review
|
tree
raw
|
patch
| inline |
side by side
(parent:
44bd072
)
MB-15171: [BP] Initialize dcpConnMap_ to NULL in engine constructor
71/56171/3
author
Sriram Ganesan
<sriram@couchbase.com>
Thu, 28 May 2015 01:51:23 +0000
(18:51 -0700)
committer
Chiyoung Seo
<chiyoung@couchbase.com>
Thu, 15 Oct 2015 21:41:45 +0000
(21:41 +0000)
Not initializing this variable to NULL can cause access to an
invalid pointer during engine destroy.
Change-Id: Icc5d848f7826bb6331deb40b4832efcf64622dea
Reviewed-on: http://review.couchbase.org/51492
Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Reviewed-by: abhinav dangeti <abhinav@couchbase.com>
Tested-by: buildbot <build@couchbase.com>
Reviewed-on: http://review.couchbase.org/56171
src/ep_engine.cc
patch
|
blob
|
history
diff --git
a/src/ep_engine.cc
b/src/ep_engine.cc
index
664f9df
..
044a548
100644
(file)
--- a/
src/ep_engine.cc
+++ b/
src/ep_engine.cc
@@
-1833,7
+1833,7
@@
EventuallyPersistentEngine::EventuallyPersistentEngine(
clusterConfig(), epstore(NULL), workload(NULL),
workloadPriority(NO_BUCKET_PRIORITY),
tapThrottle(NULL), getServerApiFunc(get_server_api),
- tapConnMap(NULL), tapConfig(NULL), checkpointConfig(NULL),
+
dcpConnMap_(NULL),
tapConnMap(NULL), tapConfig(NULL), checkpointConfig(NULL),
trafficEnabled(false), flushAllEnabled(false), startupTime(0)
{
interface.interface = 1;