)]}'
{"pindex_bleve.go":[{"author":{"_account_id":1004804,"name":"Thejas-bhat","email":"thejas.orkombu@couchbase.com","username":"Thejas-bhat","avatars":[{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e4e468224dc362d0626f2ff0e515aa07c4ce348f","unresolved":true,"context_lines":[{"line_number":97,"context_line":"var BlevePreferredZapVersion \u003d int(15)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"var DefaultLimitingMinTime \u003d time.Duration(200 * time.Millisecond)"},{"line_number":100,"context_line":"var DefaultLimitingMaxTime \u003d time.Duration(30 * time.Second)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"// BleveParams represents the bleve index params.  See also"},{"line_number":103,"context_line":"// cbgt.IndexDef.Params.  A JSON\u0027ified BleveParams looks like..."}],"source_content_type":"text/x-go","patch_set":2,"id":"dc605709_de319346","line":100,"updated":"2022-08-03 04:45:17.000000000","message":"Is the time.Duration type casting necessary over here? It\u0027s already in time.Duration type right?","commit_id":"df3e8b8c23ae0596e4f71bebaa38681fb298ad51"},{"author":{"_account_id":1004875,"name":"Aditi Ahuja","email":"aditi.ahuja@couchbase.com","username":"metonymic-smokey","avatars":[{"url":"https://www.gravatar.com/avatar/d69696fe9a465a59dc6666b355fb6d71.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d69696fe9a465a59dc6666b355fb6d71.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d69696fe9a465a59dc6666b355fb6d71.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d69696fe9a465a59dc6666b355fb6d71.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"6b801a9790bc662e337cd5ae0825bb44bfc2cb96","unresolved":false,"context_lines":[{"line_number":97,"context_line":"var BlevePreferredZapVersion \u003d int(15)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"var DefaultLimitingMinTime \u003d time.Duration(200 * time.Millisecond)"},{"line_number":100,"context_line":"var DefaultLimitingMaxTime \u003d time.Duration(30 * time.Second)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"// BleveParams represents the bleve index params.  See also"},{"line_number":103,"context_line":"// cbgt.IndexDef.Params.  A JSON\u0027ified BleveParams looks like..."}],"source_content_type":"text/x-go","patch_set":2,"id":"75d1ce4c_7867fdd2","line":100,"in_reply_to":"dc605709_de319346","updated":"2022-08-03 04:57:09.000000000","message":"Done","commit_id":"df3e8b8c23ae0596e4f71bebaa38681fb298ad51"},{"author":{"_account_id":1004804,"name":"Thejas-bhat","email":"thejas.orkombu@couchbase.com","username":"Thejas-bhat","avatars":[{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e4e468224dc362d0626f2ff0e515aa07c4ce348f","unresolved":true,"context_lines":[{"line_number":2612,"context_line":"\tMeterWrites(bdp[0].bdest.sourceName, index)"},{"line_number":2613,"context_line":"}"},{"line_number":2614,"context_line":""},{"line_number":2615,"context_line":"func exponentialBackoffTimes() (time.Duration, time.Duration) {"},{"line_number":2616,"context_line":"\tmgr :\u003d CurrentNodeDefsFetcher.GetManager()"},{"line_number":2617,"context_line":"\tvar minTime, maxTime time.Duration"},{"line_number":2618,"context_line":"\tvar err error"}],"source_content_type":"text/x-go","patch_set":2,"id":"604af2a9_4b0cd2f9","line":2615,"updated":"2022-08-03 04:45:17.000000000","message":"This name could be something more specific, since its used only for limiting, like serverlessLimitingBounds() or something.","commit_id":"df3e8b8c23ae0596e4f71bebaa38681fb298ad51"},{"author":{"_account_id":1004875,"name":"Aditi Ahuja","email":"aditi.ahuja@couchbase.com","username":"metonymic-smokey","avatars":[{"url":"https://www.gravatar.com/avatar/d69696fe9a465a59dc6666b355fb6d71.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d69696fe9a465a59dc6666b355fb6d71.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d69696fe9a465a59dc6666b355fb6d71.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d69696fe9a465a59dc6666b355fb6d71.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"6b801a9790bc662e337cd5ae0825bb44bfc2cb96","unresolved":false,"context_lines":[{"line_number":2612,"context_line":"\tMeterWrites(bdp[0].bdest.sourceName, index)"},{"line_number":2613,"context_line":"}"},{"line_number":2614,"context_line":""},{"line_number":2615,"context_line":"func exponentialBackoffTimes() (time.Duration, time.Duration) {"},{"line_number":2616,"context_line":"\tmgr :\u003d CurrentNodeDefsFetcher.GetManager()"},{"line_number":2617,"context_line":"\tvar minTime, maxTime time.Duration"},{"line_number":2618,"context_line":"\tvar err error"}],"source_content_type":"text/x-go","patch_set":2,"id":"0a3cd73d_1b95274d","line":2615,"in_reply_to":"604af2a9_4b0cd2f9","updated":"2022-08-03 04:57:09.000000000","message":"Done","commit_id":"df3e8b8c23ae0596e4f71bebaa38681fb298ad51"},{"author":{"_account_id":1004804,"name":"Thejas-bhat","email":"thejas.orkombu@couchbase.com","username":"Thejas-bhat","avatars":[{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e4e468224dc362d0626f2ff0e515aa07c4ce348f","unresolved":true,"context_lines":[{"line_number":2620,"context_line":"\tif min, exists :\u003d mgr.Options()[\"serverlessLimitingMinTime\"]; exists {"},{"line_number":2621,"context_line":"\t\tminTime, err \u003d time.ParseDuration(min)"},{"line_number":2622,"context_line":"\t\tif err !\u003d nil {"},{"line_number":2623,"context_line":"\t\t\tlog.Printf(\"limiting/throttling: error parsing minimum time for \"+"},{"line_number":2624,"context_line":"\t\t\t\t\"exponential backoff, returning defaults: %#v\", err)"},{"line_number":2625,"context_line":"\t\t\tminTime \u003d DefaultLimitingMinTime"},{"line_number":2626,"context_line":"\t\t}"}],"source_content_type":"text/x-go","patch_set":2,"id":"b6ad17b8_d7a0e1ce","line":2623,"updated":"2022-08-03 04:45:17.000000000","message":"This could be log.Errorf","commit_id":"df3e8b8c23ae0596e4f71bebaa38681fb298ad51"},{"author":{"_account_id":1004875,"name":"Aditi Ahuja","email":"aditi.ahuja@couchbase.com","username":"metonymic-smokey","avatars":[{"url":"https://www.gravatar.com/avatar/d69696fe9a465a59dc6666b355fb6d71.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d69696fe9a465a59dc6666b355fb6d71.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d69696fe9a465a59dc6666b355fb6d71.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d69696fe9a465a59dc6666b355fb6d71.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"6b801a9790bc662e337cd5ae0825bb44bfc2cb96","unresolved":false,"context_lines":[{"line_number":2620,"context_line":"\tif min, exists :\u003d mgr.Options()[\"serverlessLimitingMinTime\"]; exists {"},{"line_number":2621,"context_line":"\t\tminTime, err \u003d time.ParseDuration(min)"},{"line_number":2622,"context_line":"\t\tif err !\u003d nil {"},{"line_number":2623,"context_line":"\t\t\tlog.Printf(\"limiting/throttling: error parsing minimum time for \"+"},{"line_number":2624,"context_line":"\t\t\t\t\"exponential backoff, returning defaults: %#v\", err)"},{"line_number":2625,"context_line":"\t\t\tminTime \u003d DefaultLimitingMinTime"},{"line_number":2626,"context_line":"\t\t}"}],"source_content_type":"text/x-go","patch_set":2,"id":"bd2cc2c0_da88b947","line":2623,"in_reply_to":"b6ad17b8_d7a0e1ce","updated":"2022-08-03 04:57:09.000000000","message":"Done","commit_id":"df3e8b8c23ae0596e4f71bebaa38681fb298ad51"},{"author":{"_account_id":1003912,"name":"Sreekanth Sivasankaran","email":"sreekanth.sivasankaran@couchbase.com","username":"sreekanth-cb","avatars":[{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b18eb9e0da65f7db1b79161337e7d2f23b53fae4","unresolved":true,"context_lines":[{"line_number":97,"context_line":"var BlevePreferredZapVersion \u003d int(15)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"var DefaultLimitingMinTime \u003d 200 * time.Millisecond"},{"line_number":100,"context_line":"var DefaultLimitingMaxTime \u003d 30 * time.Second"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"// BleveParams represents the bleve index params.  See also"},{"line_number":103,"context_line":"// cbgt.IndexDef.Params.  A JSON\u0027ified BleveParams looks like..."}],"source_content_type":"text/x-go","patch_set":3,"id":"f74a41ae_eebb8f02","line":100,"updated":"2022-08-03 07:57:39.000000000","message":"Shall we raise the min to 500 and max to 2 mins ?","commit_id":"be13ff3a4bf01d68ccff2772330429cb78c05292"},{"author":{"_account_id":1004875,"name":"Aditi Ahuja","email":"aditi.ahuja@couchbase.com","username":"metonymic-smokey","avatars":[{"url":"https://www.gravatar.com/avatar/d69696fe9a465a59dc6666b355fb6d71.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d69696fe9a465a59dc6666b355fb6d71.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d69696fe9a465a59dc6666b355fb6d71.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d69696fe9a465a59dc6666b355fb6d71.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"802895d414b76f68db49ae1876c1d4f8846ad5d0","unresolved":false,"context_lines":[{"line_number":97,"context_line":"var BlevePreferredZapVersion \u003d int(15)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"var DefaultLimitingMinTime \u003d 200 * time.Millisecond"},{"line_number":100,"context_line":"var DefaultLimitingMaxTime \u003d 30 * time.Second"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"// BleveParams represents the bleve index params.  See also"},{"line_number":103,"context_line":"// cbgt.IndexDef.Params.  A JSON\u0027ified BleveParams looks like..."}],"source_content_type":"text/x-go","patch_set":3,"id":"7dfd2155_ff20bf55","line":100,"in_reply_to":"f74a41ae_eebb8f02","updated":"2022-08-03 08:21:47.000000000","message":"Done","commit_id":"be13ff3a4bf01d68ccff2772330429cb78c05292"},{"author":{"_account_id":1003912,"name":"Sreekanth Sivasankaran","email":"sreekanth.sivasankaran@couchbase.com","username":"sreekanth-cb","avatars":[{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b18eb9e0da65f7db1b79161337e7d2f23b53fae4","unresolved":true,"context_lines":[{"line_number":2626,"context_line":"\t\t}"},{"line_number":2627,"context_line":"\t} else {"},{"line_number":2628,"context_line":"\t\t// Return the defaults if options not available."},{"line_number":2629,"context_line":"\t\tminTime \u003d DefaultLimitingMinTime"},{"line_number":2630,"context_line":"\t}"},{"line_number":2631,"context_line":""},{"line_number":2632,"context_line":"\tif max, exists :\u003d mgr.Options()[\"serverlessLimitingMaxTime\"]; exists {"}],"source_content_type":"text/x-go","patch_set":3,"id":"91724a34_a0e7dfd7","line":2629,"updated":"2022-08-03 07:57:39.000000000","message":"directly initialise the variable with the defaults so that we can avoid this else blocks..","commit_id":"be13ff3a4bf01d68ccff2772330429cb78c05292"},{"author":{"_account_id":1004875,"name":"Aditi Ahuja","email":"aditi.ahuja@couchbase.com","username":"metonymic-smokey","avatars":[{"url":"https://www.gravatar.com/avatar/d69696fe9a465a59dc6666b355fb6d71.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d69696fe9a465a59dc6666b355fb6d71.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d69696fe9a465a59dc6666b355fb6d71.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d69696fe9a465a59dc6666b355fb6d71.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"802895d414b76f68db49ae1876c1d4f8846ad5d0","unresolved":false,"context_lines":[{"line_number":2626,"context_line":"\t\t}"},{"line_number":2627,"context_line":"\t} else {"},{"line_number":2628,"context_line":"\t\t// Return the defaults if options not available."},{"line_number":2629,"context_line":"\t\tminTime \u003d DefaultLimitingMinTime"},{"line_number":2630,"context_line":"\t}"},{"line_number":2631,"context_line":""},{"line_number":2632,"context_line":"\tif max, exists :\u003d mgr.Options()[\"serverlessLimitingMaxTime\"]; exists {"}],"source_content_type":"text/x-go","patch_set":3,"id":"4d04c2ef_131e62f2","line":2629,"in_reply_to":"91724a34_a0e7dfd7","updated":"2022-08-03 08:21:47.000000000","message":"Done","commit_id":"be13ff3a4bf01d68ccff2772330429cb78c05292"},{"author":{"_account_id":1004875,"name":"Aditi Ahuja","email":"aditi.ahuja@couchbase.com","username":"metonymic-smokey","avatars":[{"url":"https://www.gravatar.com/avatar/d69696fe9a465a59dc6666b355fb6d71.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d69696fe9a465a59dc6666b355fb6d71.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d69696fe9a465a59dc6666b355fb6d71.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d69696fe9a465a59dc6666b355fb6d71.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"99e64ebf748b7795d9561f652f205ed6f5f1c2c4","unresolved":false,"context_lines":[{"line_number":2638,"context_line":"\t\t}"},{"line_number":2639,"context_line":"\t}"},{"line_number":2640,"context_line":""},{"line_number":2641,"context_line":"\t// Dividing by 10^6 since Go converts to ns on converting to int."},{"line_number":2642,"context_line":"\tminTimeMS :\u003d int(minTime) / int(math.Pow(10, 6))"},{"line_number":2643,"context_line":"\tmaxTimeMS :\u003d int(maxTime) / int(math.Pow(10, 6))"},{"line_number":2644,"context_line":"\treturn minTimeMS, maxTimeMS"}],"source_content_type":"text/x-go","patch_set":7,"id":"a142d55a_c91d83ba","line":2641,"updated":"2022-08-11 10:57:18.000000000","message":"Introduced this change looking at Thejas\u0027 latest PR.","commit_id":"63ef966a6b86756591e6e91e6577108d27d9519d"},{"author":{"_account_id":1003912,"name":"Sreekanth Sivasankaran","email":"sreekanth.sivasankaran@couchbase.com","username":"sreekanth-cb","avatars":[{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"3be3f4e8bb829a41ef5e034f0103da154205010a","unresolved":true,"context_lines":[{"line_number":2640,"context_line":""},{"line_number":2641,"context_line":"\t// Dividing by 10^6 since Go converts to ns on converting to int."},{"line_number":2642,"context_line":"\tminTimeMS :\u003d int(minTime) / int(math.Pow(10, 6))"},{"line_number":2643,"context_line":"\tmaxTimeMS :\u003d int(maxTime) / int(math.Pow(10, 6))"},{"line_number":2644,"context_line":"\treturn minTimeMS, maxTimeMS"},{"line_number":2645,"context_line":"}"},{"line_number":2646,"context_line":""}],"source_content_type":"text/x-go","patch_set":7,"id":"16bda793_f8dc9765","line":2643,"updated":"2022-08-11 11:39:29.000000000","message":"Do we really need to do all these Pow/costly operations here?\nLet\u0027s keep this simple and the configs itself could mention that the unit is milliseconds.\n\nmaxBackoffTimeInMSForDCPLimiting or something better.\n\ndefaults could also be defined as int vars, right?","commit_id":"63ef966a6b86756591e6e91e6577108d27d9519d"},{"author":{"_account_id":1004875,"name":"Aditi Ahuja","email":"aditi.ahuja@couchbase.com","username":"metonymic-smokey","avatars":[{"url":"https://www.gravatar.com/avatar/d69696fe9a465a59dc6666b355fb6d71.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d69696fe9a465a59dc6666b355fb6d71.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d69696fe9a465a59dc6666b355fb6d71.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d69696fe9a465a59dc6666b355fb6d71.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"93ccb54567f69cf5d01effdd5bdb97c0c1dfc7ba","unresolved":true,"context_lines":[{"line_number":2640,"context_line":""},{"line_number":2641,"context_line":"\t// Dividing by 10^6 since Go converts to ns on converting to int."},{"line_number":2642,"context_line":"\tminTimeMS :\u003d int(minTime) / int(math.Pow(10, 6))"},{"line_number":2643,"context_line":"\tmaxTimeMS :\u003d int(maxTime) / int(math.Pow(10, 6))"},{"line_number":2644,"context_line":"\treturn minTimeMS, maxTimeMS"},{"line_number":2645,"context_line":"}"},{"line_number":2646,"context_line":""}],"source_content_type":"text/x-go","patch_set":7,"id":"bb19027f_a7bc7aaf","line":2643,"in_reply_to":"16bda793_f8dc9765","updated":"2022-08-11 12:45:21.000000000","message":"it becomes a little cumbersome/error prone for the user to enter milliseconds if the max time is large, so I preferred this way of configuring(specify time as a string, eg. 10m, 30s) which seems more intuitive.","commit_id":"63ef966a6b86756591e6e91e6577108d27d9519d"},{"author":{"_account_id":1004875,"name":"Aditi Ahuja","email":"aditi.ahuja@couchbase.com","username":"metonymic-smokey","avatars":[{"url":"https://www.gravatar.com/avatar/d69696fe9a465a59dc6666b355fb6d71.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d69696fe9a465a59dc6666b355fb6d71.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d69696fe9a465a59dc6666b355fb6d71.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d69696fe9a465a59dc6666b355fb6d71.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c40168d5ba43746a6ebbb0805f6ec9b573965b59","unresolved":false,"context_lines":[{"line_number":2640,"context_line":""},{"line_number":2641,"context_line":"\t// Dividing by 10^6 since Go converts to ns on converting to int."},{"line_number":2642,"context_line":"\tminTimeMS :\u003d int(minTime) / int(math.Pow(10, 6))"},{"line_number":2643,"context_line":"\tmaxTimeMS :\u003d int(maxTime) / int(math.Pow(10, 6))"},{"line_number":2644,"context_line":"\treturn minTimeMS, maxTimeMS"},{"line_number":2645,"context_line":"}"},{"line_number":2646,"context_line":""}],"source_content_type":"text/x-go","patch_set":7,"id":"de5aa0c2_d8b068ed","line":2643,"in_reply_to":"bb19027f_a7bc7aaf","updated":"2022-08-12 12:11:20.000000000","message":"Made these changes in the current patch, thanks.","commit_id":"63ef966a6b86756591e6e91e6577108d27d9519d"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7ce4fbfa7ea42c16ba557effd1caa3a6a832b83c","unresolved":true,"context_lines":[{"line_number":97,"context_line":"var BlevePreferredZapVersion \u003d int(15)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"var DefaultLimitingMinTime \u003d 500"},{"line_number":100,"context_line":"var DefaultLimitingMaxTime \u003d 120000"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"// BleveParams represents the bleve index params.  See also"},{"line_number":103,"context_line":"// cbgt.IndexDef.Params.  A JSON\u0027ified BleveParams looks like..."}],"source_content_type":"text/x-go","patch_set":9,"id":"6dc37ed0_d1d3061b","line":100,"updated":"2022-08-12 15:27:39.000000000","message":"These 2 variables don\u0027t need to be exported, and can be consts.","commit_id":"75a62fba50b0457eee30d9c5429cce99e6e2f396"},{"author":{"_account_id":1004875,"name":"Aditi Ahuja","email":"aditi.ahuja@couchbase.com","username":"metonymic-smokey","avatars":[{"url":"https://www.gravatar.com/avatar/d69696fe9a465a59dc6666b355fb6d71.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d69696fe9a465a59dc6666b355fb6d71.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d69696fe9a465a59dc6666b355fb6d71.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d69696fe9a465a59dc6666b355fb6d71.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"9afee80dcac2da1727ed84b2984cf7364eea69f9","unresolved":false,"context_lines":[{"line_number":97,"context_line":"var BlevePreferredZapVersion \u003d int(15)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"var DefaultLimitingMinTime \u003d 500"},{"line_number":100,"context_line":"var DefaultLimitingMaxTime \u003d 120000"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"// BleveParams represents the bleve index params.  See also"},{"line_number":103,"context_line":"// cbgt.IndexDef.Params.  A JSON\u0027ified BleveParams looks like..."}],"source_content_type":"text/x-go","patch_set":9,"id":"ec710859_ecd11fb0","line":100,"in_reply_to":"6dc37ed0_d1d3061b","updated":"2022-08-16 04:56:21.000000000","message":"Done","commit_id":"75a62fba50b0457eee30d9c5429cce99e6e2f396"}]}