)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1003912,"name":"Sreekanth Sivasankaran","email":"sreekanth.sivasankaran@couchbase.com","username":"sreekanth-cb","avatars":[{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"597938a73c4f3a92590c2a405677f527d7bcb0ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0e75be04_9b8c81f6","updated":"2022-08-08 12:58:54.000000000","message":"Let\u0027s create a ticket to make the control knobs tuneable so that we don\u0027t miss that.","commit_id":"3fdc5c73095526db931284387ce79ca672eb7d68"}],"metering_ee.go":[{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"040afbb69d3ea82b1be66cb617ac11749a06483c","unresolved":true,"context_lines":[{"line_number":162,"context_line":"\t\t}"},{"line_number":163,"context_line":"\t\treturn nil"},{"line_number":164,"context_line":"\t}"},{"line_number":165,"context_line":"\twcus, err :\u003d metering.SearchWriteToWU(bytes - prevBytesMetered)"},{"line_number":166,"context_line":"\tif err !\u003d nil {"},{"line_number":167,"context_line":"\t\treturn err"},{"line_number":168,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":5,"id":"8e7da3af_70af0440","line":165,"updated":"2022-08-08 15:27:24.000000000","message":"If you\u0027re refactoring rcu -\u003e ru, I\u0027d rename wcu -\u003e wu in this change as well.","commit_id":"3fdc5c73095526db931284387ce79ca672eb7d68"},{"author":{"_account_id":1004804,"name":"Thejas-bhat","email":"thejas.orkombu@couchbase.com","username":"Thejas-bhat","avatars":[{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"dd45ead352c6c57bc7695b91143f3057bec8a5c7","unresolved":false,"context_lines":[{"line_number":162,"context_line":"\t\t}"},{"line_number":163,"context_line":"\t\treturn nil"},{"line_number":164,"context_line":"\t}"},{"line_number":165,"context_line":"\twcus, err :\u003d metering.SearchWriteToWU(bytes - prevBytesMetered)"},{"line_number":166,"context_line":"\tif err !\u003d nil {"},{"line_number":167,"context_line":"\t\treturn err"},{"line_number":168,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":5,"id":"33ec911c_f39e3c72","line":165,"in_reply_to":"8e7da3af_70af0440","updated":"2022-08-08 15:52:58.000000000","message":"Done","commit_id":"3fdc5c73095526db931284387ce79ca672eb7d68"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"040afbb69d3ea82b1be66cb617ac11749a06483c","unresolved":true,"context_lines":[{"line_number":199,"context_line":"\t// high wait times."},{"line_number":200,"context_line":"\t// the formula for capping off -\u003e"},{"line_number":201,"context_line":"\t// \t\t\tftsThrottleLimit/(#indexesPerTenant * #queriesAllowed)"},{"line_number":202,"context_line":"\tif rus.Whole() \u003e 5000 {"},{"line_number":203,"context_line":"\t\trus, err \u003d regulator.NewUnits(regulator.Search, 0, 5000/(20*10))"},{"line_number":204,"context_line":"\t\tif err !\u003d nil {"},{"line_number":205,"context_line":"\t\t\treturn fmt.Errorf(\"metering: failed to cap the RUs %v\\n\", err)"}],"source_content_type":"text/x-go","patch_set":5,"id":"fc1785d5_bf2db6b6","line":202,"updated":"2022-08-08 15:27:24.000000000","message":"Is this 5000 subject to change? If so perhaps it\u0027s best if we use a regulator variable here?","commit_id":"3fdc5c73095526db931284387ce79ca672eb7d68"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"8a9d009aa06f8b88b0cd236e1929e6228d2077af","unresolved":false,"context_lines":[{"line_number":199,"context_line":"\t// high wait times."},{"line_number":200,"context_line":"\t// the formula for capping off -\u003e"},{"line_number":201,"context_line":"\t// \t\t\tftsThrottleLimit/(#indexesPerTenant * #queriesAllowed)"},{"line_number":202,"context_line":"\tif rus.Whole() \u003e 5000 {"},{"line_number":203,"context_line":"\t\trus, err \u003d regulator.NewUnits(regulator.Search, 0, 5000/(20*10))"},{"line_number":204,"context_line":"\t\tif err !\u003d nil {"},{"line_number":205,"context_line":"\t\t\treturn fmt.Errorf(\"metering: failed to cap the RUs %v\\n\", err)"}],"source_content_type":"text/x-go","patch_set":5,"id":"590e5d6c_99f2961e","line":202,"in_reply_to":"e398ac33_a6ebf597","updated":"2022-08-08 17:35:34.000000000","message":"Ack","commit_id":"3fdc5c73095526db931284387ce79ca672eb7d68"},{"author":{"_account_id":1004804,"name":"Thejas-bhat","email":"thejas.orkombu@couchbase.com","username":"Thejas-bhat","avatars":[{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"25e7547a0f59c1c4ae6a4a7d8b23fd03e3981618","unresolved":true,"context_lines":[{"line_number":199,"context_line":"\t// high wait times."},{"line_number":200,"context_line":"\t// the formula for capping off -\u003e"},{"line_number":201,"context_line":"\t// \t\t\tftsThrottleLimit/(#indexesPerTenant * #queriesAllowed)"},{"line_number":202,"context_line":"\tif rus.Whole() \u003e 5000 {"},{"line_number":203,"context_line":"\t\trus, err \u003d regulator.NewUnits(regulator.Search, 0, 5000/(20*10))"},{"line_number":204,"context_line":"\t\tif err !\u003d nil {"},{"line_number":205,"context_line":"\t\t\treturn fmt.Errorf(\"metering: failed to cap the RUs %v\\n\", err)"}],"source_content_type":"text/x-go","patch_set":5,"id":"e398ac33_a6ebf597","line":202,"in_reply_to":"fc1785d5_bf2db6b6","updated":"2022-08-08 15:51:24.000000000","message":"I talked to michael about getting this particular throttleLimit value, which is set via ns_server, however the regulator stores this as a private variable, so can\u0027t access it directly from regulator. The way to do this now, is through an ns_server endpoint, which michael said might be subjected to change as well. Since this is a quick fix for Jon to work on, these endpoint access to fetch the latest ftsThrottleLimit is something I\u0027ll be working on immediately after this PR.","commit_id":"3fdc5c73095526db931284387ce79ca672eb7d68"}]}
