)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1003912,"name":"Sreekanth Sivasankaran","email":"sreekanth.sivasankaran@couchbase.com","username":"sreekanth-cb","avatars":[{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"45e1614cc2c6f2040886632e1104df7c3996e1d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"d55cb856_66cfd3b9","updated":"2022-08-16 14:06:51.000000000","message":"I propose, let\u0027s have a dev call on this to understand this better. 😊\nPerhaps,the meeting with Thejas tomorrow can be used for this.","commit_id":"db5c149d5e938941dd324f96d1a8675026ae6612"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4fa0a31c146977960b05689703792b63d5d2a044","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"c4254aaa_e1eece86","in_reply_to":"d55cb856_66cfd3b9","updated":"2022-08-16 15:23:21.000000000","message":"Not tomorrow, but we can certainly chat a bit on this on our dev call on Thursday.","commit_id":"db5c149d5e938941dd324f96d1a8675026ae6612"}],"cmd/cbft/init_serverless.go":[{"author":{"_account_id":1003912,"name":"Sreekanth Sivasankaran","email":"sreekanth.sivasankaran@couchbase.com","username":"sreekanth-cb","avatars":[{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"45e1614cc2c6f2040886632e1104df7c3996e1d7","unresolved":true,"context_lines":[{"line_number":92,"context_line":"\t\tnodeWeights :\u003d make(map[string]int)"},{"line_number":93,"context_line":"\t\tfor _, nodeDef :\u003d range in.NodeDefs.NodeDefs {"},{"line_number":94,"context_line":"\t\t\t// Initialize to (0 - total number of existing index partitions in the system)"},{"line_number":95,"context_line":"\t\t\tnodeWeights[nodeDef.UUID] \u003d -(numPlanPIndexes * 4)"},{"line_number":96,"context_line":"\t\t\tnodePartitionCount[nodeDef.UUID] \u003d 0 // initialize"},{"line_number":97,"context_line":"\t\t}"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-go","patch_set":13,"id":"81a0029c_699fb80f","line":95,"updated":"2022-08-16 14:06:51.000000000","message":"what is the significance of 4 here?","commit_id":"db5c149d5e938941dd324f96d1a8675026ae6612"},{"author":{"_account_id":1003912,"name":"Sreekanth Sivasankaran","email":"sreekanth.sivasankaran@couchbase.com","username":"sreekanth-cb","avatars":[{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"763d7a54d5de33a2fb567fa3410eef52756ac03c","unresolved":false,"context_lines":[{"line_number":92,"context_line":"\t\tnodeWeights :\u003d make(map[string]int)"},{"line_number":93,"context_line":"\t\tfor _, nodeDef :\u003d range in.NodeDefs.NodeDefs {"},{"line_number":94,"context_line":"\t\t\t// Initialize to (0 - total number of existing index partitions in the system)"},{"line_number":95,"context_line":"\t\t\tnodeWeights[nodeDef.UUID] \u003d -(numPlanPIndexes * 4)"},{"line_number":96,"context_line":"\t\t\tnodePartitionCount[nodeDef.UUID] \u003d 0 // initialize"},{"line_number":97,"context_line":"\t\t}"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-go","patch_set":13,"id":"2f25d541_53b59dae","line":95,"in_reply_to":"5878fb02_892ad2c0","updated":"2022-09-01 11:11:09.000000000","message":"Ack","commit_id":"db5c149d5e938941dd324f96d1a8675026ae6612"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"259e9bf9d3babad47b4bca9473e9cfe5dccf3b3d","unresolved":false,"context_lines":[{"line_number":92,"context_line":"\t\tnodeWeights :\u003d make(map[string]int)"},{"line_number":93,"context_line":"\t\tfor _, nodeDef :\u003d range in.NodeDefs.NodeDefs {"},{"line_number":94,"context_line":"\t\t\t// Initialize to (0 - total number of existing index partitions in the system)"},{"line_number":95,"context_line":"\t\t\tnodeWeights[nodeDef.UUID] \u003d -(numPlanPIndexes * 4)"},{"line_number":96,"context_line":"\t\t\tnodePartitionCount[nodeDef.UUID] \u003d 0 // initialize"},{"line_number":97,"context_line":"\t\t}"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-go","patch_set":13,"id":"85d3a061_10185cc7","line":95,"in_reply_to":"5878fb02_892ad2c0","updated":"2022-08-18 14:07:28.000000000","message":"Ack","commit_id":"db5c149d5e938941dd324f96d1a8675026ae6612"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4fa0a31c146977960b05689703792b63d5d2a044","unresolved":true,"context_lines":[{"line_number":92,"context_line":"\t\tnodeWeights :\u003d make(map[string]int)"},{"line_number":93,"context_line":"\t\tfor _, nodeDef :\u003d range in.NodeDefs.NodeDefs {"},{"line_number":94,"context_line":"\t\t\t// Initialize to (0 - total number of existing index partitions in the system)"},{"line_number":95,"context_line":"\t\t\tnodeWeights[nodeDef.UUID] \u003d -(numPlanPIndexes * 4)"},{"line_number":96,"context_line":"\t\t\tnodePartitionCount[nodeDef.UUID] \u003d 0 // initialize"},{"line_number":97,"context_line":"\t\t}"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-go","patch_set":13,"id":"5878fb02_892ad2c0","line":95,"in_reply_to":"81a0029c_699fb80f","updated":"2022-08-16 15:23:21.000000000","message":"Nothing super significant, just choosing a big enough number so the default weight of the node would not prioritize it high.","commit_id":"db5c149d5e938941dd324f96d1a8675026ae6612"},{"author":{"_account_id":1003912,"name":"Sreekanth Sivasankaran","email":"sreekanth.sivasankaran@couchbase.com","username":"sreekanth-cb","avatars":[{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"45e1614cc2c6f2040886632e1104df7c3996e1d7","unresolved":true,"context_lines":[{"line_number":104,"context_line":"\t\t\t\tif _, exists :\u003d nodeAssignments[nodeUUID]; !exists {"},{"line_number":105,"context_line":"\t\t\t\t\tnodeAssignments[nodeUUID] \u003d make(map[string]struct{})"},{"line_number":106,"context_line":"\t\t\t\t}"},{"line_number":107,"context_line":"\t\t\t\tnodeAssignments[nodeUUID][pindex.SourceName] \u003d struct{}{}"},{"line_number":108,"context_line":"\t\t\t}"},{"line_number":109,"context_line":"\t\t}"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-go","patch_set":13,"id":"b19bdf96_8cb9ee98","line":107,"updated":"2022-08-16 14:06:51.000000000","message":"A simpler map looks enough here?\nnodeAssignments[nodeUUID+pindex.SourceName] \u003d struct{}{}","commit_id":"db5c149d5e938941dd324f96d1a8675026ae6612"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e3549a086a1fbcc124527c3e90005f98b3688fef","unresolved":true,"context_lines":[{"line_number":104,"context_line":"\t\t\t\tif _, exists :\u003d nodeAssignments[nodeUUID]; !exists {"},{"line_number":105,"context_line":"\t\t\t\t\tnodeAssignments[nodeUUID] \u003d make(map[string]struct{})"},{"line_number":106,"context_line":"\t\t\t\t}"},{"line_number":107,"context_line":"\t\t\t\tnodeAssignments[nodeUUID][pindex.SourceName] \u003d struct{}{}"},{"line_number":108,"context_line":"\t\t\t}"},{"line_number":109,"context_line":"\t\t}"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-go","patch_set":13,"id":"9e23dae8_b1e2f3e4","line":107,"in_reply_to":"1420866e_c721778b","updated":"2022-08-17 14:12:23.000000000","message":"Yea I mean, your suggestion was to use nodeUUID+pindex.SourceName as the map key - which would mean string concatenation and splitting.","commit_id":"db5c149d5e938941dd324f96d1a8675026ae6612"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b21de63fcc21f59d16562d1d506ab09512b0deb7","unresolved":false,"context_lines":[{"line_number":104,"context_line":"\t\t\t\tif _, exists :\u003d nodeAssignments[nodeUUID]; !exists {"},{"line_number":105,"context_line":"\t\t\t\t\tnodeAssignments[nodeUUID] \u003d make(map[string]struct{})"},{"line_number":106,"context_line":"\t\t\t\t}"},{"line_number":107,"context_line":"\t\t\t\tnodeAssignments[nodeUUID][pindex.SourceName] \u003d struct{}{}"},{"line_number":108,"context_line":"\t\t\t}"},{"line_number":109,"context_line":"\t\t}"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-go","patch_set":13,"id":"fc20dfe6_17408801","line":107,"in_reply_to":"2f79705b_298b0ff4","updated":"2022-08-17 17:52:38.000000000","message":"Ack","commit_id":"db5c149d5e938941dd324f96d1a8675026ae6612"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"5b8b265466c9a279335ec2ce819b7ea4746168f7","unresolved":true,"context_lines":[{"line_number":104,"context_line":"\t\t\t\tif _, exists :\u003d nodeAssignments[nodeUUID]; !exists {"},{"line_number":105,"context_line":"\t\t\t\t\tnodeAssignments[nodeUUID] \u003d make(map[string]struct{})"},{"line_number":106,"context_line":"\t\t\t\t}"},{"line_number":107,"context_line":"\t\t\t\tnodeAssignments[nodeUUID][pindex.SourceName] \u003d struct{}{}"},{"line_number":108,"context_line":"\t\t\t}"},{"line_number":109,"context_line":"\t\t}"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-go","patch_set":13,"id":"2f79705b_298b0ff4","line":107,"in_reply_to":"9e23dae8_b1e2f3e4","updated":"2022-08-17 15:15:07.000000000","message":"Perhaps you\u0027re right, let me change this.","commit_id":"db5c149d5e938941dd324f96d1a8675026ae6612"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4fa0a31c146977960b05689703792b63d5d2a044","unresolved":true,"context_lines":[{"line_number":104,"context_line":"\t\t\t\tif _, exists :\u003d nodeAssignments[nodeUUID]; !exists {"},{"line_number":105,"context_line":"\t\t\t\t\tnodeAssignments[nodeUUID] \u003d make(map[string]struct{})"},{"line_number":106,"context_line":"\t\t\t\t}"},{"line_number":107,"context_line":"\t\t\t\tnodeAssignments[nodeUUID][pindex.SourceName] \u003d struct{}{}"},{"line_number":108,"context_line":"\t\t\t}"},{"line_number":109,"context_line":"\t\t}"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-go","patch_set":13,"id":"c28853bb_99827381","line":107,"in_reply_to":"b19bdf96_8cb9ee98","updated":"2022-08-16 15:23:21.000000000","message":"For faster lookup.","commit_id":"db5c149d5e938941dd324f96d1a8675026ae6612"},{"author":{"_account_id":1003912,"name":"Sreekanth Sivasankaran","email":"sreekanth.sivasankaran@couchbase.com","username":"sreekanth-cb","avatars":[{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"2f187f64b14c9d67faf8a4f32c88a0b933921986","unresolved":true,"context_lines":[{"line_number":104,"context_line":"\t\t\t\tif _, exists :\u003d nodeAssignments[nodeUUID]; !exists {"},{"line_number":105,"context_line":"\t\t\t\t\tnodeAssignments[nodeUUID] \u003d make(map[string]struct{})"},{"line_number":106,"context_line":"\t\t\t\t}"},{"line_number":107,"context_line":"\t\t\t\tnodeAssignments[nodeUUID][pindex.SourceName] \u003d struct{}{}"},{"line_number":108,"context_line":"\t\t\t}"},{"line_number":109,"context_line":"\t\t}"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-go","patch_set":13,"id":"1420866e_c721778b","line":107,"in_reply_to":"c28853bb_99827381","updated":"2022-08-17 03:07:38.000000000","message":"Are you saying that two levels of map lookup as here would be faster than a \nsingle map look-up?","commit_id":"db5c149d5e938941dd324f96d1a8675026ae6612"},{"author":{"_account_id":1003912,"name":"Sreekanth Sivasankaran","email":"sreekanth.sivasankaran@couchbase.com","username":"sreekanth-cb","avatars":[{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"45e1614cc2c6f2040886632e1104df7c3996e1d7","unresolved":true,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"\t\t\t\t// No node available with index partitions sharing the same source with"},{"line_number":128,"context_line":"\t\t\t\t// the current index, so prefer a node whose partition count is lesser"},{"line_number":129,"context_line":"\t\t\t\tnodeWeights[uuid] -\u003d count"},{"line_number":130,"context_line":"\t\t\t}"},{"line_number":131,"context_line":"\t\t}"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-go","patch_set":13,"id":"61ebf95d_6362d96d","line":129,"updated":"2022-08-16 14:06:51.000000000","message":"The part isn\u0027t clear here is - how does the newly added node is supposed to get a higher weight with fewer/zero partition count?  Won\u0027t it have a more -ve weight value(smaller value)?\n\nCurrent logic continues to assign partitions to the original sub cluster with more partitions from the current source as long as it is not beyond the HWM, right?\n\n(We would have triggered the last rebalance seeing the threshold breach of load on LWM)\n\nBalanced partition assignment happens here?","commit_id":"db5c149d5e938941dd324f96d1a8675026ae6612"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"5b8b265466c9a279335ec2ce819b7ea4746168f7","unresolved":true,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"\t\t\t\t// No node available with index partitions sharing the same source with"},{"line_number":128,"context_line":"\t\t\t\t// the current index, so prefer a node whose partition count is lesser"},{"line_number":129,"context_line":"\t\t\t\tnodeWeights[uuid] -\u003d count"},{"line_number":130,"context_line":"\t\t\t}"},{"line_number":131,"context_line":"\t\t}"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-go","patch_set":13,"id":"47d08346_d0a92a0a","line":129,"in_reply_to":"1b5185c6_c992a186","updated":"2022-08-17 15:15:07.000000000","message":"I\u0027ll put together a few illustrations of how node weights would look for this scenario and the rebalance scenario with the current code.","commit_id":"db5c149d5e938941dd324f96d1a8675026ae6612"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"6799056662082c1be2c3b090aa8702fd614cedc9","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"\t\t\t\t// No node available with index partitions sharing the same source with"},{"line_number":128,"context_line":"\t\t\t\t// the current index, so prefer a node whose partition count is lesser"},{"line_number":129,"context_line":"\t\t\t\tnodeWeights[uuid] -\u003d count"},{"line_number":130,"context_line":"\t\t\t}"},{"line_number":131,"context_line":"\t\t}"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-go","patch_set":13,"id":"e55d7dc8_cf5e6145","line":129,"in_reply_to":"47d08346_d0a92a0a","updated":"2022-08-17 17:49:43.000000000","message":"Ack.","commit_id":"db5c149d5e938941dd324f96d1a8675026ae6612"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4fa0a31c146977960b05689703792b63d5d2a044","unresolved":true,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"\t\t\t\t// No node available with index partitions sharing the same source with"},{"line_number":128,"context_line":"\t\t\t\t// the current index, so prefer a node whose partition count is lesser"},{"line_number":129,"context_line":"\t\t\t\tnodeWeights[uuid] -\u003d count"},{"line_number":130,"context_line":"\t\t\t}"},{"line_number":131,"context_line":"\t\t}"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-go","patch_set":13,"id":"e6344129_4d6a901c","line":129,"in_reply_to":"61ebf95d_6362d96d","updated":"2022-08-16 15:23:21.000000000","message":"This is not necessarily a newly added node. It\u0027s one where there\u0027re no index partitions whose source is same as the current index definition.\n\nRemember at this point node weight is initialized to -(numPlanPIndexes*4). By subtracting count to that value will make the planner prioritize nodes with lesser partitions over nodes with higher partition count.\n\nThis is still index provisioning and not the rebalance path.","commit_id":"db5c149d5e938941dd324f96d1a8675026ae6612"},{"author":{"_account_id":1003912,"name":"Sreekanth Sivasankaran","email":"sreekanth.sivasankaran@couchbase.com","username":"sreekanth-cb","avatars":[{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"2f187f64b14c9d67faf8a4f32c88a0b933921986","unresolved":true,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"\t\t\t\t// No node available with index partitions sharing the same source with"},{"line_number":128,"context_line":"\t\t\t\t// the current index, so prefer a node whose partition count is lesser"},{"line_number":129,"context_line":"\t\t\t\tnodeWeights[uuid] -\u003d count"},{"line_number":130,"context_line":"\t\t\t}"},{"line_number":131,"context_line":"\t\t}"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-go","patch_set":13,"id":"1b5185c6_c992a186","line":129,"in_reply_to":"e6344129_4d6a901c","updated":"2022-08-17 03:07:38.000000000","message":"Looks like it doesn\u0027t matter which planner case it is, \nPlease check the example in the rebalance comment.","commit_id":"db5c149d5e938941dd324f96d1a8675026ae6612"},{"author":{"_account_id":1003912,"name":"Sreekanth Sivasankaran","email":"sreekanth.sivasankaran@couchbase.com","username":"sreekanth-cb","avatars":[{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"45e1614cc2c6f2040886632e1104df7c3996e1d7","unresolved":true,"context_lines":[{"line_number":237,"context_line":""},{"line_number":238,"context_line":"\t\t\t\t// No node available with index partitions sharing the same source with"},{"line_number":239,"context_line":"\t\t\t\t// the current index, so prefer a node whose partition count is lesser"},{"line_number":240,"context_line":"\t\t\t\tnodeWeights[uuid] -\u003d count"},{"line_number":241,"context_line":"\t\t\t}"},{"line_number":242,"context_line":"\t\t}"},{"line_number":243,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":13,"id":"5b85c0a5_c3dd7d01","line":240,"updated":"2022-08-16 14:06:51.000000000","message":"I think the current logic here would favour a node with higher partition count over a node with lesser partition count due to the SourceName based allocations.\n\nTotal Partitions \u003d 20, \nNodeWeights[uuid1]  \u003d -80 (10 * 4)\nNodeWeights[uuid3]  \u003d -80 (10 * 4)\n\nNodeWeights[uuid1] \u003d -8 (since 8 partitions were there from the same bucket)\nNodeWeights[uuid3] \u003d -80 - 8 \u003d\u003e -88 \n\nSimilar logic/perceived flaw in the above index creation logic too?","commit_id":"db5c149d5e938941dd324f96d1a8675026ae6612"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4fa0a31c146977960b05689703792b63d5d2a044","unresolved":true,"context_lines":[{"line_number":237,"context_line":""},{"line_number":238,"context_line":"\t\t\t\t// No node available with index partitions sharing the same source with"},{"line_number":239,"context_line":"\t\t\t\t// the current index, so prefer a node whose partition count is lesser"},{"line_number":240,"context_line":"\t\t\t\tnodeWeights[uuid] -\u003d count"},{"line_number":241,"context_line":"\t\t\t}"},{"line_number":242,"context_line":"\t\t}"},{"line_number":243,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":13,"id":"e05f49bf_ea302ed2","line":240,"in_reply_to":"5b85c0a5_c3dd7d01","updated":"2022-08-16 15:23:21.000000000","message":"Yes this is certainly a case I can do more thinking about.\n\nThese first set of changes just groups like index partitions (same source) together. That can\u0027t be the only way we do - we\u0027d need to take into account perhaps thresholds as well, but that\u0027ll be subsequent patches.","commit_id":"db5c149d5e938941dd324f96d1a8675026ae6612"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"6799056662082c1be2c3b090aa8702fd614cedc9","unresolved":false,"context_lines":[{"line_number":237,"context_line":""},{"line_number":238,"context_line":"\t\t\t\t// No node available with index partitions sharing the same source with"},{"line_number":239,"context_line":"\t\t\t\t// the current index, so prefer a node whose partition count is lesser"},{"line_number":240,"context_line":"\t\t\t\tnodeWeights[uuid] -\u003d count"},{"line_number":241,"context_line":"\t\t\t}"},{"line_number":242,"context_line":"\t\t}"},{"line_number":243,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":13,"id":"8987b57d_daf8cce5","line":240,"in_reply_to":"e05f49bf_ea302ed2","updated":"2022-08-17 17:49:43.000000000","message":"Ack.","commit_id":"db5c149d5e938941dd324f96d1a8675026ae6612"},{"author":{"_account_id":1003912,"name":"Sreekanth Sivasankaran","email":"sreekanth.sivasankaran@couchbase.com","username":"sreekanth-cb","avatars":[{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"45e1614cc2c6f2040886632e1104df7c3996e1d7","unresolved":true,"context_lines":[{"line_number":245,"context_line":"\t// Boost weight of the nodes holding the index\u0027s partitions that"},{"line_number":246,"context_line":"\t// were untouched by the rebalance, to keep the already resident"},{"line_number":247,"context_line":"\t// partitions where they are."},{"line_number":248,"context_line":"\tfor nodeUUID :\u003d range indexNodeUUIDs {"},{"line_number":249,"context_line":"\t\tnodeWeights[nodeUUID] \u003d 2"},{"line_number":250,"context_line":"\t}"},{"line_number":251,"context_line":""}],"source_content_type":"text/x-go","patch_set":13,"id":"c89adad5_cb215cc9","line":248,"updated":"2022-08-16 14:06:51.000000000","message":"Looks like we are overridding all the node weight adjustments performed in the above loops during a node removal rebalance?\n\nIf so, why adjust node weights for nodes that are getting removed?","commit_id":"db5c149d5e938941dd324f96d1a8675026ae6612"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"6799056662082c1be2c3b090aa8702fd614cedc9","unresolved":false,"context_lines":[{"line_number":245,"context_line":"\t// Boost weight of the nodes holding the index\u0027s partitions that"},{"line_number":246,"context_line":"\t// were untouched by the rebalance, to keep the already resident"},{"line_number":247,"context_line":"\t// partitions where they are."},{"line_number":248,"context_line":"\tfor nodeUUID :\u003d range indexNodeUUIDs {"},{"line_number":249,"context_line":"\t\tnodeWeights[nodeUUID] \u003d 2"},{"line_number":250,"context_line":"\t}"},{"line_number":251,"context_line":""}],"source_content_type":"text/x-go","patch_set":13,"id":"b679dc5e_41c694ae","line":248,"in_reply_to":"0e5004af_74007974","updated":"2022-08-17 17:49:43.000000000","message":"This boosting of node weights is only for node(s) holding the current index definition that are to remain unaltered after rebalance.\n\nThis is needed to handle the corner case when node weights of all the nodes end up being equal - we want to NOT move the pre-existing partitions of the index.\n\nI hope to explain this better with some illustrations.","commit_id":"db5c149d5e938941dd324f96d1a8675026ae6612"},{"author":{"_account_id":1003912,"name":"Sreekanth Sivasankaran","email":"sreekanth.sivasankaran@couchbase.com","username":"sreekanth-cb","avatars":[{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"2f187f64b14c9d67faf8a4f32c88a0b933921986","unresolved":true,"context_lines":[{"line_number":245,"context_line":"\t// Boost weight of the nodes holding the index\u0027s partitions that"},{"line_number":246,"context_line":"\t// were untouched by the rebalance, to keep the already resident"},{"line_number":247,"context_line":"\t// partitions where they are."},{"line_number":248,"context_line":"\tfor nodeUUID :\u003d range indexNodeUUIDs {"},{"line_number":249,"context_line":"\t\tnodeWeights[nodeUUID] \u003d 2"},{"line_number":250,"context_line":"\t}"},{"line_number":251,"context_line":""}],"source_content_type":"text/x-go","patch_set":13,"id":"0e5004af_74007974","line":248,"in_reply_to":"27af4c1c_ed08b796","updated":"2022-08-17 03:07:38.000000000","message":"I am referring to the node weight adjustments performed in 221 - 243?\n\nMeaning - All nodesToAdd are getting set to constant value here and for all the nodes to remove there is no point in setting any weights.\n\nThen what are we doing in block 221-243.","commit_id":"db5c149d5e938941dd324f96d1a8675026ae6612"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4fa0a31c146977960b05689703792b63d5d2a044","unresolved":true,"context_lines":[{"line_number":245,"context_line":"\t// Boost weight of the nodes holding the index\u0027s partitions that"},{"line_number":246,"context_line":"\t// were untouched by the rebalance, to keep the already resident"},{"line_number":247,"context_line":"\t// partitions where they are."},{"line_number":248,"context_line":"\tfor nodeUUID :\u003d range indexNodeUUIDs {"},{"line_number":249,"context_line":"\t\tnodeWeights[nodeUUID] \u003d 2"},{"line_number":250,"context_line":"\t}"},{"line_number":251,"context_line":""}],"source_content_type":"text/x-go","patch_set":13,"id":"27af4c1c_ed08b796","line":248,"in_reply_to":"c89adad5_cb215cc9","updated":"2022-08-16 15:23:21.000000000","message":"These are not nodes that are being removed anymore, but are the ones being added (replacing the removed nodes).\n\nSee line 204 on the right above, the removed nodes are removed from this map.","commit_id":"db5c149d5e938941dd324f96d1a8675026ae6612"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"d328008d42fb2a39313cbb911df8d07ead4a0177","unresolved":false,"context_lines":[{"line_number":108,"context_line":"\t\t// Check if there\u0027re nodes out there that already hold index"},{"line_number":109,"context_line":"\t\t// partitions whose source is the same as the current index definition"},{"line_number":110,"context_line":"\t\tfor uuid, count :\u003d range nodePartitionCount {"},{"line_number":111,"context_line":"\t\t\tif shouldNodeAccommodateIndexPartition(in.NodeDefs.NodeDefs[uuid]) {"},{"line_number":112,"context_line":"\t\t\t\tnodeWeights[uuid] \u003d minNodeWeight // this node has reached it\u0027s HWM threshold"},{"line_number":113,"context_line":"\t\t\t} else {"},{"line_number":114,"context_line":"\t\t\t\t// Higher the resident partition count, lower the node weight"}],"source_content_type":"text/x-go","patch_set":16,"id":"1cea3003_ef64d125","line":111,"updated":"2022-08-18 14:04:01.000000000","message":"!","commit_id":"ba780a063d356b52c48381ca557d066b890c7a16"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"d328008d42fb2a39313cbb911df8d07ead4a0177","unresolved":false,"context_lines":[{"line_number":201,"context_line":"\t\treturn in, nil"},{"line_number":202,"context_line":"\t}"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"\tif len(in.NodeUUIDsToAdd) \u003d\u003d len(in.NodeUUIDsToRemove) {"},{"line_number":205,"context_line":"\t\t// SWAP REBALANCE;"},{"line_number":206,"context_line":"\t\t// p.s. This only comes into play when there\u0027s no node"},{"line_number":207,"context_line":"\t\t// at the beginning of rebalance without resident pindexes"}],"source_content_type":"text/x-go","patch_set":16,"id":"61c25329_625ed4a6","line":204,"updated":"2022-08-18 14:04:01.000000000","message":"what about a mismatched swap rebalance?","commit_id":"ba780a063d356b52c48381ca557d066b890c7a16"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"d328008d42fb2a39313cbb911df8d07ead4a0177","unresolved":false,"context_lines":[{"line_number":214,"context_line":"\t\t// Check if there\u0027re nodes out there that already hold index"},{"line_number":215,"context_line":"\t\t// partitions whose source is the same as the current index definition"},{"line_number":216,"context_line":"\t\tfor uuid, count :\u003d range nodePartitionCount {"},{"line_number":217,"context_line":"\t\t\tif shouldNodeAccommodateIndexPartition(in.BegNodeDefs.NodeDefs[uuid]) {"},{"line_number":218,"context_line":"\t\t\t\tnodeWeights[uuid] \u003d minNodeWeight // this node has reached it\u0027s HWM threshold"},{"line_number":219,"context_line":"\t\t\t} else {"},{"line_number":220,"context_line":"\t\t\t\t// Higher the resident partition count, lower the node weight"}],"source_content_type":"text/x-go","patch_set":16,"id":"c17c7d4d_3b5c4261","line":217,"updated":"2022-08-18 14:04:01.000000000","message":"!","commit_id":"ba780a063d356b52c48381ca557d066b890c7a16"}],"pindex_bleve.go":[{"author":{"_account_id":1003912,"name":"Sreekanth Sivasankaran","email":"sreekanth.sivasankaran@couchbase.com","username":"sreekanth-cb","avatars":[{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"45e1614cc2c6f2040886632e1104df7c3996e1d7","unresolved":true,"context_lines":[{"line_number":1299,"context_line":"\t\t},"},{"line_number":1300,"context_line":"\t}"},{"line_number":1301,"context_line":""},{"line_number":1302,"context_line":"\tqueryCtlParams \u003d adjustCtlParams(queryCtlParams)"},{"line_number":1303,"context_line":""},{"line_number":1304,"context_line":"\terr :\u003d UnmarshalJSON(req, \u0026queryCtlParams)"},{"line_number":1305,"context_line":"\tif err !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":13,"id":"41d7868c_2b46a8f7","line":1302,"updated":"2022-08-16 14:06:51.000000000","message":"You are proposing replica reads in Serverless now? \n\nBut doing this at the server side for single partitioned indexes are counter productive/performance regressive in nature since the coordinating node has to do additional layer of GC just for scatter-gather for no real benefit. You are loading both the nodes.\n\nFor single partitioned indexes, this has to be handled at the SDK side/N1QL side to meet some real gains.","commit_id":"db5c149d5e938941dd324f96d1a8675026ae6612"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"259e9bf9d3babad47b4bca9473e9cfe5dccf3b3d","unresolved":false,"context_lines":[{"line_number":1299,"context_line":"\t\t},"},{"line_number":1300,"context_line":"\t}"},{"line_number":1301,"context_line":""},{"line_number":1302,"context_line":"\tqueryCtlParams \u003d adjustCtlParams(queryCtlParams)"},{"line_number":1303,"context_line":""},{"line_number":1304,"context_line":"\terr :\u003d UnmarshalJSON(req, \u0026queryCtlParams)"},{"line_number":1305,"context_line":"\tif err !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":13,"id":"6c886178_9852145b","line":1302,"in_reply_to":"170cd76a_cbea1276","updated":"2022-08-18 14:07:28.000000000","message":"Removing this for now.","commit_id":"db5c149d5e938941dd324f96d1a8675026ae6612"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4fa0a31c146977960b05689703792b63d5d2a044","unresolved":true,"context_lines":[{"line_number":1299,"context_line":"\t\t},"},{"line_number":1300,"context_line":"\t}"},{"line_number":1301,"context_line":""},{"line_number":1302,"context_line":"\tqueryCtlParams \u003d adjustCtlParams(queryCtlParams)"},{"line_number":1303,"context_line":""},{"line_number":1304,"context_line":"\terr :\u003d UnmarshalJSON(req, \u0026queryCtlParams)"},{"line_number":1305,"context_line":"\tif err !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":13,"id":"170cd76a_cbea1276","line":1302,"in_reply_to":"41d7868c_2b46a8f7","updated":"2022-08-16 15:23:21.000000000","message":"Ya, shoot. This was the bit I forgot to talk about yesterday.\n\nI see, so would it make sense to set the PartitionSelection to \"local\".\n\nSDK wouldn\u0027t know where a certain index is resident on in a cluster of nodes though, so scatter-gather would be involved anyway.","commit_id":"db5c149d5e938941dd324f96d1a8675026ae6612"},{"author":{"_account_id":1003912,"name":"Sreekanth Sivasankaran","email":"sreekanth.sivasankaran@couchbase.com","username":"sreekanth-cb","avatars":[{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"763d7a54d5de33a2fb567fa3410eef52756ac03c","unresolved":true,"context_lines":[{"line_number":1290,"context_line":"\t\t\tTimeout: cbgt.QUERY_CTL_DEFAULT_TIMEOUT_MS,"},{"line_number":1291,"context_line":"\t\t},"},{"line_number":1292,"context_line":"\t}"},{"line_number":1293,"context_line":""},{"line_number":1294,"context_line":"\terr :\u003d UnmarshalJSON(req, \u0026queryCtlParams)"},{"line_number":1295,"context_line":"\tif err !\u003d nil {"},{"line_number":1296,"context_line":"\t\treturn fmt.Errorf(\"bleve: QueryBleve\"+"}],"source_content_type":"text/x-go","patch_set":24,"id":"b2faf95e_cd901e15","line":1293,"updated":"2022-09-01 11:11:09.000000000","message":"intentional?","commit_id":"2194349c693b03c7dc55b5457148eceac291a6d7"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e16fe0db6fa6254a5a1205a84cc39ca31f29f678","unresolved":true,"context_lines":[{"line_number":1290,"context_line":"\t\t\tTimeout: cbgt.QUERY_CTL_DEFAULT_TIMEOUT_MS,"},{"line_number":1291,"context_line":"\t\t},"},{"line_number":1292,"context_line":"\t}"},{"line_number":1293,"context_line":""},{"line_number":1294,"context_line":"\terr :\u003d UnmarshalJSON(req, \u0026queryCtlParams)"},{"line_number":1295,"context_line":"\tif err !\u003d nil {"},{"line_number":1296,"context_line":"\t\treturn fmt.Errorf(\"bleve: QueryBleve\"+"}],"source_content_type":"text/x-go","patch_set":24,"id":"cfb9f72f_a4572a05","line":1293,"in_reply_to":"b2faf95e_cd901e15","updated":"2022-09-01 13:03:44.000000000","message":"No, think it got left behind after I removed the replica reads bit.","commit_id":"2194349c693b03c7dc55b5457148eceac291a6d7"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"2995408fe4b5f3c276c69996cab159e788d5550a","unresolved":false,"context_lines":[{"line_number":1290,"context_line":"\t\t\tTimeout: cbgt.QUERY_CTL_DEFAULT_TIMEOUT_MS,"},{"line_number":1291,"context_line":"\t\t},"},{"line_number":1292,"context_line":"\t}"},{"line_number":1293,"context_line":""},{"line_number":1294,"context_line":"\terr :\u003d UnmarshalJSON(req, \u0026queryCtlParams)"},{"line_number":1295,"context_line":"\tif err !\u003d nil {"},{"line_number":1296,"context_line":"\t\treturn fmt.Errorf(\"bleve: QueryBleve\"+"}],"source_content_type":"text/x-go","patch_set":24,"id":"eaf97ee1_c152c4cc","line":1293,"in_reply_to":"cfb9f72f_a4572a05","updated":"2022-09-01 16:30:15.000000000","message":"Ack","commit_id":"2194349c693b03c7dc55b5457148eceac291a6d7"}]}