)]}'
{"cache_bleve.go":[{"author":{"_account_id":1003912,"name":"Sreekanth Sivasankaran","email":"sreekanth.sivasankaran@couchbase.com","username":"sreekanth-cb","avatars":[{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"790f70ce57d1ced91eb10854a8236c915c17122d","unresolved":true,"context_lines":[{"line_number":152,"context_line":"\t\t\tstopCh \u003d bdest.stopCh"},{"line_number":153,"context_line":"\t\t}"},{"line_number":154,"context_line":"\t}"},{"line_number":155,"context_line":"\tMeterReads(stopCh, m.pindex.SourceName, m.bindex)"},{"line_number":156,"context_line":"\tif len(res.Hits) \u003c BleveResultCacheMaxHits { // Don\u0027t cache overly large results."},{"line_number":157,"context_line":"\t\tResultCache.encache(key, func() []byte {"},{"line_number":158,"context_line":"\t\t\t// TODO: Use something better than JSON to copy a search result."}],"source_content_type":"text/x-go","patch_set":1,"id":"38e6d461_2ba5fd38","line":155,"updated":"2022-08-22 15:02:18.000000000","message":"we don\u0027t need this in search path, right?\nsince the index is closed, this flow won\u0027t even hit and there is no delayed and deferred execution like that in an executeBatch?\n\nOr am I overlooking something?","commit_id":"3250de378c4bc8756d00f6e234ce0ebc506081c6"},{"author":{"_account_id":1004804,"name":"Thejas-bhat","email":"thejas.orkombu@couchbase.com","username":"Thejas-bhat","avatars":[{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"97740bb3758f043df19f30c29cf02c9b7c366a33","unresolved":false,"context_lines":[{"line_number":152,"context_line":"\t\t\tstopCh \u003d bdest.stopCh"},{"line_number":153,"context_line":"\t\t}"},{"line_number":154,"context_line":"\t}"},{"line_number":155,"context_line":"\tMeterReads(stopCh, m.pindex.SourceName, m.bindex)"},{"line_number":156,"context_line":"\tif len(res.Hits) \u003c BleveResultCacheMaxHits { // Don\u0027t cache overly large results."},{"line_number":157,"context_line":"\t\tResultCache.encache(key, func() []byte {"},{"line_number":158,"context_line":"\t\t\t// TODO: Use something better than JSON to copy a search result."}],"source_content_type":"text/x-go","patch_set":1,"id":"4044581c_bee7a654","line":155,"in_reply_to":"38e6d461_2ba5fd38","updated":"2022-08-23 05:49:37.000000000","message":"Yeah makes sense, my bad.","commit_id":"3250de378c4bc8756d00f6e234ce0ebc506081c6"}],"metering_ee.go":[{"author":{"_account_id":1003912,"name":"Sreekanth Sivasankaran","email":"sreekanth.sivasankaran@couchbase.com","username":"sreekanth-cb","avatars":[{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"8c800146458e4ccf25623e149e5bc844df496f06","unresolved":true,"context_lines":[{"line_number":150,"context_line":"\t\treturn"},{"line_number":151,"context_line":"\t}"},{"line_number":152,"context_line":"\tif isClosed(stopCh) {"},{"line_number":153,"context_line":"\t\tlog.Warnf(\"metering: a pindex was closed, so ignoring its metering\")"},{"line_number":154,"context_line":"\t\treturn"},{"line_number":155,"context_line":"\t}"},{"line_number":156,"context_line":"\tscorchStats :\u003d index.StatsMap()"}],"source_content_type":"text/x-go","patch_set":3,"id":"7a668689_2745e7b1","line":153,"updated":"2022-08-23 08:40:25.000000000","message":"a pindex -\u003e pindex already closed?","commit_id":"923a33f24a569391c7f76e23a0527bd23f31af27"},{"author":{"_account_id":1004804,"name":"Thejas-bhat","email":"thejas.orkombu@couchbase.com","username":"Thejas-bhat","avatars":[{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f28a45c0188256c73aecf7f42fbeab814f35e9aa","unresolved":false,"context_lines":[{"line_number":150,"context_line":"\t\treturn"},{"line_number":151,"context_line":"\t}"},{"line_number":152,"context_line":"\tif isClosed(stopCh) {"},{"line_number":153,"context_line":"\t\tlog.Warnf(\"metering: a pindex was closed, so ignoring its metering\")"},{"line_number":154,"context_line":"\t\treturn"},{"line_number":155,"context_line":"\t}"},{"line_number":156,"context_line":"\tscorchStats :\u003d index.StatsMap()"}],"source_content_type":"text/x-go","patch_set":3,"id":"91657322_896d1e37","line":153,"in_reply_to":"7a668689_2745e7b1","updated":"2022-08-23 08:45:54.000000000","message":"Done","commit_id":"923a33f24a569391c7f76e23a0527bd23f31af27"},{"author":{"_account_id":1003912,"name":"Sreekanth Sivasankaran","email":"sreekanth.sivasankaran@couchbase.com","username":"sreekanth-cb","avatars":[{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"2e9e3400d9608f514f0addfbf672a5ef0fb6e0f5","unresolved":true,"context_lines":[{"line_number":368,"context_line":"\t\t\t// no progress has been made and needs a retry."},{"line_number":369,"context_line":"\t\t\tcheckQuotaExponentialBackoff :\u003d func() int {"},{"line_number":370,"context_line":"\t\t\t\tif isClosed(stopCh) {"},{"line_number":371,"context_line":"\t\t\t\t\taction \u003d regulator.CheckResultError"},{"line_number":372,"context_line":"\t\t\t\t\treturn -1"},{"line_number":373,"context_line":"\t\t\t\t}"},{"line_number":374,"context_line":"\t\t\t\tvar err error"}],"source_content_type":"text/x-go","patch_set":6,"id":"b0b07f4f_e80df234","line":371,"updated":"2022-08-25 02:24:41.000000000","message":"this action would get overwritten to \naction \u003d regulator.CheckResultNormal inside the default block, isn\u0027t it?","commit_id":"76c55305e747b69c697e12d720c7a773205f712a"},{"author":{"_account_id":1004804,"name":"Thejas-bhat","email":"thejas.orkombu@couchbase.com","username":"Thejas-bhat","avatars":[{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"fb18477ec2a76907239d08dd23e0a578eea08518","unresolved":false,"context_lines":[{"line_number":368,"context_line":"\t\t\t// no progress has been made and needs a retry."},{"line_number":369,"context_line":"\t\t\tcheckQuotaExponentialBackoff :\u003d func() int {"},{"line_number":370,"context_line":"\t\t\t\tif isClosed(stopCh) {"},{"line_number":371,"context_line":"\t\t\t\t\taction \u003d regulator.CheckResultError"},{"line_number":372,"context_line":"\t\t\t\t\treturn -1"},{"line_number":373,"context_line":"\t\t\t\t}"},{"line_number":374,"context_line":"\t\t\t\tvar err error"}],"source_content_type":"text/x-go","patch_set":6,"id":"cf9b86cf_ea030d63","line":371,"in_reply_to":"7f51cf01_b08c24ea","updated":"2022-08-25 14:42:06.000000000","message":"Yeah, I believe so since before hitting the default case it will always do that isClosed check right before the next iteration.","commit_id":"76c55305e747b69c697e12d720c7a773205f712a"},{"author":{"_account_id":1004804,"name":"Thejas-bhat","email":"thejas.orkombu@couchbase.com","username":"Thejas-bhat","avatars":[{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"92501edfd3e8a57fead02605f4dda954556b3176","unresolved":false,"context_lines":[{"line_number":368,"context_line":"\t\t\t// no progress has been made and needs a retry."},{"line_number":369,"context_line":"\t\t\tcheckQuotaExponentialBackoff :\u003d func() int {"},{"line_number":370,"context_line":"\t\t\t\tif isClosed(stopCh) {"},{"line_number":371,"context_line":"\t\t\t\t\taction \u003d regulator.CheckResultError"},{"line_number":372,"context_line":"\t\t\t\t\treturn -1"},{"line_number":373,"context_line":"\t\t\t\t}"},{"line_number":374,"context_line":"\t\t\t\tvar err error"}],"source_content_type":"text/x-go","patch_set":6,"id":"e6073ce3_62e13088","line":371,"in_reply_to":"b0b07f4f_e80df234","updated":"2022-08-25 12:38:37.000000000","message":"Done","commit_id":"76c55305e747b69c697e12d720c7a773205f712a"},{"author":{"_account_id":1003912,"name":"Sreekanth Sivasankaran","email":"sreekanth.sivasankaran@couchbase.com","username":"sreekanth-cb","avatars":[{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"26c40cb019d0823ea4dd0bf45ff79bb71c8897ea","unresolved":true,"context_lines":[{"line_number":368,"context_line":"\t\t\t// no progress has been made and needs a retry."},{"line_number":369,"context_line":"\t\t\tcheckQuotaExponentialBackoff :\u003d func() int {"},{"line_number":370,"context_line":"\t\t\t\tif isClosed(stopCh) {"},{"line_number":371,"context_line":"\t\t\t\t\taction \u003d regulator.CheckResultError"},{"line_number":372,"context_line":"\t\t\t\t\treturn -1"},{"line_number":373,"context_line":"\t\t\t\t}"},{"line_number":374,"context_line":"\t\t\t\tvar err error"}],"source_content_type":"text/x-go","patch_set":6,"id":"7f51cf01_b08c24ea","line":371,"in_reply_to":"b0b07f4f_e80df234","updated":"2022-08-25 13:44:56.000000000","message":"So, the fix will be futile?","commit_id":"76c55305e747b69c697e12d720c7a773205f712a"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"a50dff34ac698e89ac61c3488f40d8aca4155313","unresolved":true,"context_lines":[{"line_number":150,"context_line":"\t\t// no metering for non-serverless versions."},{"line_number":151,"context_line":"\t\treturn"},{"line_number":152,"context_line":"\t}"},{"line_number":153,"context_line":"\tif isClosed(stopCh) {"},{"line_number":154,"context_line":"\t\tlog.Warnf(\"metering: pindex was closed, so ignoring its metering\")"},{"line_number":155,"context_line":"\t\treturn"},{"line_number":156,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":7,"id":"90f14b6d_cde4578b","line":153,"updated":"2022-08-25 16:27:30.000000000","message":"Will isClosed(..) now need to check for stopCh \u003d\u003d nil before the select?","commit_id":"c8d05979b5d7f61a8fc72a69ed1d4ed945edfa5a"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"32131198e7348b97d7ba8aac7ff46d3955a2aadc","unresolved":false,"context_lines":[{"line_number":150,"context_line":"\t\t// no metering for non-serverless versions."},{"line_number":151,"context_line":"\t\treturn"},{"line_number":152,"context_line":"\t}"},{"line_number":153,"context_line":"\tif isClosed(stopCh) {"},{"line_number":154,"context_line":"\t\tlog.Warnf(\"metering: pindex was closed, so ignoring its metering\")"},{"line_number":155,"context_line":"\t\treturn"},{"line_number":156,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":7,"id":"56185547_e0cdfc3e","line":153,"in_reply_to":"1d7101c9_de92c31f","updated":"2022-08-25 21:13:17.000000000","message":"p.s. you call CheckQuotaWrite() with stopCh\u003dnil from limits.go:354.\n\nBut I agree no changes needed within isClosed(..), the default path executes on nil.","commit_id":"c8d05979b5d7f61a8fc72a69ed1d4ed945edfa5a"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f37e41cfbf14c9397dbb346ee8eecd335c71d1dc","unresolved":false,"context_lines":[{"line_number":150,"context_line":"\t\t// no metering for non-serverless versions."},{"line_number":151,"context_line":"\t\treturn"},{"line_number":152,"context_line":"\t}"},{"line_number":153,"context_line":"\tif isClosed(stopCh) {"},{"line_number":154,"context_line":"\t\tlog.Warnf(\"metering: pindex was closed, so ignoring its metering\")"},{"line_number":155,"context_line":"\t\treturn"},{"line_number":156,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":7,"id":"1d7101c9_de92c31f","line":153,"in_reply_to":"3895f51a_9336a8c9","updated":"2022-08-25 21:11:21.000000000","message":"Ack","commit_id":"c8d05979b5d7f61a8fc72a69ed1d4ed945edfa5a"},{"author":{"_account_id":1004804,"name":"Thejas-bhat","email":"thejas.orkombu@couchbase.com","username":"Thejas-bhat","avatars":[{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"30b1d254d713b19e4e644606ac9cb8b8cd599ca8","unresolved":true,"context_lines":[{"line_number":150,"context_line":"\t\t// no metering for non-serverless versions."},{"line_number":151,"context_line":"\t\treturn"},{"line_number":152,"context_line":"\t}"},{"line_number":153,"context_line":"\tif isClosed(stopCh) {"},{"line_number":154,"context_line":"\t\tlog.Warnf(\"metering: pindex was closed, so ignoring its metering\")"},{"line_number":155,"context_line":"\t\treturn"},{"line_number":156,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":7,"id":"3895f51a_9336a8c9","line":153,"in_reply_to":"90f14b6d_cde4578b","updated":"2022-08-25 17:45:23.000000000","message":"According to a small code snippet that I ran, isClosed returns false called like isClosed(nil). Another thing is, in this section the channel is passed from bleveDest, which I think is a non-nil value.","commit_id":"c8d05979b5d7f61a8fc72a69ed1d4ed945edfa5a"}],"pindex_bleve.go":[{"author":{"_account_id":1003912,"name":"Sreekanth Sivasankaran","email":"sreekanth.sivasankaran@couchbase.com","username":"sreekanth-cb","avatars":[{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"3c2ea0929ae0b33c9f511fcf06bce027565d110b","unresolved":true,"context_lines":[{"line_number":2623,"context_line":"\t\treturn"},{"line_number":2624,"context_line":"\t}"},{"line_number":2625,"context_line":""},{"line_number":2626,"context_line":"\tresult, _, err :\u003d CheckQuotaWrite(bdp[0].bdest.stopCh, bdp[0].bdest.sourceName, \"\", true, nil)"},{"line_number":2627,"context_line":""},{"line_number":2628,"context_line":"\t// NOTE: At this point, it\u0027s guaranteed that the action is either"},{"line_number":2629,"context_line":"\t// CheckResultError (which is the case when the bdp\u0027s bleve index is closed)"}],"source_content_type":"text/x-go","patch_set":6,"id":"732916c2_ae6cce1e","line":2626,"updated":"2022-08-24 05:44:58.000000000","message":"\u003e\u003e 80 ch line?\n\nAlso, this would result in regression as the original regulator errors could now result in exit here,but earlier we had decided to index even when the regulator error out??","commit_id":"76c55305e747b69c697e12d720c7a773205f712a"},{"author":{"_account_id":1004804,"name":"Thejas-bhat","email":"thejas.orkombu@couchbase.com","username":"Thejas-bhat","avatars":[{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"a862d6c8e679f934ae51ff01cef110a3d6529260","unresolved":true,"context_lines":[{"line_number":2623,"context_line":"\t\treturn"},{"line_number":2624,"context_line":"\t}"},{"line_number":2625,"context_line":""},{"line_number":2626,"context_line":"\tresult, _, err :\u003d CheckQuotaWrite(bdp[0].bdest.stopCh, bdp[0].bdest.sourceName, \"\", true, nil)"},{"line_number":2627,"context_line":""},{"line_number":2628,"context_line":"\t// NOTE: At this point, it\u0027s guaranteed that the action is either"},{"line_number":2629,"context_line":"\t// CheckResultError (which is the case when the bdp\u0027s bleve index is closed)"}],"source_content_type":"text/x-go","patch_set":6,"id":"ab04d886_c6eae3ca","line":2626,"in_reply_to":"732916c2_ae6cce1e","updated":"2022-08-24 06:02:58.000000000","message":"In case the regulator returns a CheckResultError, we are logging the error inside CheckQuotaWrite and then changing the action to CheckResultNormal and exit the CheckQuotaWrite method with action \u003d CheckResultNormal. Now, over here in executeBatch method, the CheckResultError would not be hit since its not CheckResultError, which would be returned only when the bdest\u0027s stopCh is closed. So my thinking is that previous behaviour would be conserved.","commit_id":"76c55305e747b69c697e12d720c7a773205f712a"},{"author":{"_account_id":1003912,"name":"Sreekanth Sivasankaran","email":"sreekanth.sivasankaran@couchbase.com","username":"sreekanth-cb","avatars":[{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"2e9e3400d9608f514f0addfbf672a5ef0fb6e0f5","unresolved":true,"context_lines":[{"line_number":2623,"context_line":"\t\treturn"},{"line_number":2624,"context_line":"\t}"},{"line_number":2625,"context_line":""},{"line_number":2626,"context_line":"\tresult, _, err :\u003d CheckQuotaWrite(bdp[0].bdest.stopCh, bdp[0].bdest.sourceName, \"\", true, nil)"},{"line_number":2627,"context_line":""},{"line_number":2628,"context_line":"\t// NOTE: At this point, it\u0027s guaranteed that the action is either"},{"line_number":2629,"context_line":"\t// CheckResultError (which is the case when the bdp\u0027s bleve index is closed)"}],"source_content_type":"text/x-go","patch_set":6,"id":"6f3df444_5c7cefe4","line":2626,"in_reply_to":"ab04d886_c6eae3ca","updated":"2022-08-25 02:24:41.000000000","message":"hm..not sure.. Let me put a comment there..","commit_id":"76c55305e747b69c697e12d720c7a773205f712a"}]}