)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"77092a69d942762d35380ed5053d65135458d65b","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Thejas-bhat \u003cthejas.orkombu@couchbase.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-08-25 23:25:19 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"MB-53022 - [FTS-Limiting] Expose FTS storage usage per-bucket via a prometheus stat"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I82633686da631d03231aebec2264eacaf96f12a1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"cfbe02f0_575f290f","line":7,"updated":"2022-08-25 21:19:26.000000000","message":"Limit commit header to 80 characters and explain in detail (if necessary) within a commit message - also wrapped to 80 characters.","commit_id":"e52c8d40d3d9ded6653c31c2d6e2ddeda9778cfd"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4b74ed9e391e300a4f2ff0c299e649fb3d349686","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ead372c3_03220eb7","updated":"2022-08-25 15:28:22.000000000","message":"Naming suggestions for grep-pability with existing stats.","commit_id":"85289495b8e98a651a83c66ffb8c32b85b9e8980"},{"author":{"_account_id":1004804,"name":"Thejas-bhat","email":"thejas.orkombu@couchbase.com","username":"Thejas-bhat","avatars":[{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"8abd0bdb35edd648e92043f21482b2ac13352757","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"35c034f9_e551b744","updated":"2022-08-25 15:35:45.000000000","message":"Yep, thanks","commit_id":"85289495b8e98a651a83c66ffb8c32b85b9e8980"}],"metering_ee.go":[{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4b74ed9e391e300a4f2ff0c299e649fb3d349686","unresolved":true,"context_lines":[{"line_number":258,"context_line":"\t\trv[k] \u003d v"},{"line_number":259,"context_line":"\t}"},{"line_number":260,"context_line":"\trv[\"total_units_metered\"] \u003d totalUnitsMetered"},{"line_number":261,"context_line":"\trv[\"total_storage_bytes_used\"] \u003d totalStorageBytesPerNode"},{"line_number":262,"context_line":"\treturn rv"},{"line_number":263,"context_line":"}"},{"line_number":264,"context_line":""}],"source_content_type":"text/x-go","patch_set":2,"id":"21b54141_ef62dc42","line":261,"updated":"2022-08-25 15:28:22.000000000","message":"total_bytes_used_disk","commit_id":"85289495b8e98a651a83c66ffb8c32b85b9e8980"},{"author":{"_account_id":1004804,"name":"Thejas-bhat","email":"thejas.orkombu@couchbase.com","username":"Thejas-bhat","avatars":[{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"8abd0bdb35edd648e92043f21482b2ac13352757","unresolved":false,"context_lines":[{"line_number":258,"context_line":"\t\trv[k] \u003d v"},{"line_number":259,"context_line":"\t}"},{"line_number":260,"context_line":"\trv[\"total_units_metered\"] \u003d totalUnitsMetered"},{"line_number":261,"context_line":"\trv[\"total_storage_bytes_used\"] \u003d totalStorageBytesPerNode"},{"line_number":262,"context_line":"\treturn rv"},{"line_number":263,"context_line":"}"},{"line_number":264,"context_line":""}],"source_content_type":"text/x-go","patch_set":2,"id":"35f8de53_136137fd","line":261,"in_reply_to":"21b54141_ef62dc42","updated":"2022-08-25 15:35:45.000000000","message":"Ack","commit_id":"85289495b8e98a651a83c66ffb8c32b85b9e8980"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4b74ed9e391e300a4f2ff0c299e649fb3d349686","unresolved":true,"context_lines":[{"line_number":454,"context_line":"\t}"},{"line_number":455,"context_line":"\treg.handler.WriteMetrics(w)"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"\tstatName :\u003d \"num_storage_bytes_used_per_bucket\""},{"line_number":458,"context_line":"\ttotalStorageBytesPerNode \u003d 0"},{"line_number":459,"context_line":"\tfor bucket, storageBytes :\u003d range storageStats {"},{"line_number":460,"context_line":"\t\ttotalStorageBytesPerNode +\u003d storageBytes"}],"source_content_type":"text/x-go","patch_set":2,"id":"165430fe_824630a5","line":457,"updated":"2022-08-25 15:28:22.000000000","message":"num_bytes_used_disk_for_bucket","commit_id":"85289495b8e98a651a83c66ffb8c32b85b9e8980"},{"author":{"_account_id":1004804,"name":"Thejas-bhat","email":"thejas.orkombu@couchbase.com","username":"Thejas-bhat","avatars":[{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"8abd0bdb35edd648e92043f21482b2ac13352757","unresolved":false,"context_lines":[{"line_number":454,"context_line":"\t}"},{"line_number":455,"context_line":"\treg.handler.WriteMetrics(w)"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"\tstatName :\u003d \"num_storage_bytes_used_per_bucket\""},{"line_number":458,"context_line":"\ttotalStorageBytesPerNode \u003d 0"},{"line_number":459,"context_line":"\tfor bucket, storageBytes :\u003d range storageStats {"},{"line_number":460,"context_line":"\t\ttotalStorageBytesPerNode +\u003d storageBytes"}],"source_content_type":"text/x-go","patch_set":2,"id":"eb53d54b_0e05019a","line":457,"in_reply_to":"165430fe_824630a5","updated":"2022-08-25 15:35:45.000000000","message":"Ack","commit_id":"85289495b8e98a651a83c66ffb8c32b85b9e8980"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"de433741f8504080a45344881f07df4f7341098a","unresolved":true,"context_lines":[{"line_number":43,"context_line":"\toperation uint"},{"line_number":44,"context_line":"}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"var totalStorageBytesPerNode uint64"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"type regulatorStats struct {"},{"line_number":49,"context_line":"\tTotalRUsMetered                uint64 `json:\"total_RUs_metered\"`"}],"source_content_type":"text/x-go","patch_set":3,"id":"8ce70c3b_5d0d3fba","line":46,"updated":"2022-08-25 16:20:50.000000000","message":"Let\u0027s keep the naming uniform - totalBytesUsedDisk.\n\nNo need to say per node, because there\u0027s only one instance of this process per node :).","commit_id":"89a86223a1529e5213b02f6d6d88277bb697fd9c"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f513f6d6c0fd4742fafcc290e5de44d70dd3efc2","unresolved":true,"context_lines":[{"line_number":43,"context_line":"\toperation uint"},{"line_number":44,"context_line":"}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"var totalStorageBytesPerNode uint64"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"type regulatorStats struct {"},{"line_number":49,"context_line":"\tTotalRUsMetered                uint64 `json:\"total_RUs_metered\"`"}],"source_content_type":"text/x-go","patch_set":3,"id":"e838e843_29df80e4","line":46,"in_reply_to":"8ce70c3b_5d0d3fba","updated":"2022-08-25 16:22:08.000000000","message":"Also, this stat is NOT going to be reachable in CE builds will need to address that. I\u0027m thinking if the best way forward is to not do this global var - and calculate disk usage on the fly on a stats call.","commit_id":"89a86223a1529e5213b02f6d6d88277bb697fd9c"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"1ea9b7f20f7eeb0651624beb7ff00c0914d35d60","unresolved":true,"context_lines":[{"line_number":43,"context_line":"\toperation uint"},{"line_number":44,"context_line":"}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"var totalStorageBytesPerNode uint64"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"type regulatorStats struct {"},{"line_number":49,"context_line":"\tTotalRUsMetered                uint64 `json:\"total_RUs_metered\"`"}],"source_content_type":"text/x-go","patch_set":3,"id":"0816a041_4485cf76","line":46,"in_reply_to":"e838e843_29df80e4","updated":"2022-08-25 16:24:37.000000000","message":"Perhaps we need not worry about it in CE builds for now. \n\nBut a separate question - how often is WriteRegulatorMetrics called? Because if it isn\u0027t called often enough regulatorAggregateStats could reflect a pretty stale value for totalBytesUsedDisk.\n\nI\u0027m thinking this may not be a good approach.","commit_id":"89a86223a1529e5213b02f6d6d88277bb697fd9c"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"de433741f8504080a45344881f07df4f7341098a","unresolved":true,"context_lines":[{"line_number":258,"context_line":"\t\trv[k] \u003d v"},{"line_number":259,"context_line":"\t}"},{"line_number":260,"context_line":"\trv[\"total_units_metered\"] \u003d totalUnitsMetered"},{"line_number":261,"context_line":"\trv[\"total_bytes_used_disk\"] \u003d totalStorageBytesPerNode"},{"line_number":262,"context_line":"\treturn rv"},{"line_number":263,"context_line":"}"},{"line_number":264,"context_line":""}],"source_content_type":"text/x-go","patch_set":3,"id":"6a76d16a_ae0f2998","line":261,"updated":"2022-08-25 16:20:50.000000000","message":"This\u0027ll be race-y.\n\natomic.LoadUint64(\u0026totalBytesUsedDisk)","commit_id":"89a86223a1529e5213b02f6d6d88277bb697fd9c"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"de433741f8504080a45344881f07df4f7341098a","unresolved":true,"context_lines":[{"line_number":455,"context_line":"\treg.handler.WriteMetrics(w)"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"\tstatName :\u003d \"num_bytes_used_disk_for_bucket\""},{"line_number":458,"context_line":"\ttotalStorageBytesPerNode \u003d 0"},{"line_number":459,"context_line":"\tfor bucket, storageBytes :\u003d range storageStats {"},{"line_number":460,"context_line":"\t\ttotalStorageBytesPerNode +\u003d storageBytes"},{"line_number":461,"context_line":"\t\tb, err :\u003d json.Marshal(storageBytes)"}],"source_content_type":"text/x-go","patch_set":3,"id":"d57441a2_0a24b427","line":458,"updated":"2022-08-25 16:20:50.000000000","message":"Update a local variable and then atomic.StoreUint64 that local variable into totalBytesUsedDisk.","commit_id":"89a86223a1529e5213b02f6d6d88277bb697fd9c"},{"author":{"_account_id":1003912,"name":"Sreekanth Sivasankaran","email":"sreekanth.sivasankaran@couchbase.com","username":"sreekanth-cb","avatars":[{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"8e0f82cb0fe7810f15b818699d35fe375c078bc7","unresolved":true,"context_lines":[{"line_number":451,"context_line":"\t}"},{"line_number":452,"context_line":"\treg.handler.WriteMetrics(w)"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"\tstatName :\u003d \"num_bytes_used_disk_for_bucket\""},{"line_number":455,"context_line":"\tfor bucket, storageBytes :\u003d range storageStats {"},{"line_number":456,"context_line":"\t\tb, err :\u003d json.Marshal(storageBytes)"},{"line_number":457,"context_line":"\t\tif err !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":8,"id":"f48a4bd8_f56e6076","line":454,"updated":"2022-08-26 11:31:32.000000000","message":"num_bytes_used_disk_for_bucket Vs num_disk_bytes_used_for_bucket?","commit_id":"dc993748a58084dd0de8c28c3ad85e30bf903a2c"},{"author":{"_account_id":1003912,"name":"Sreekanth Sivasankaran","email":"sreekanth.sivasankaran@couchbase.com","username":"sreekanth-cb","avatars":[{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7b26368ae8e6576e798efea5e428d069b8cb912f","unresolved":true,"context_lines":[{"line_number":451,"context_line":"\t}"},{"line_number":452,"context_line":"\treg.handler.WriteMetrics(w)"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"\tstatName :\u003d \"num_bytes_used_disk_for_bucket\""},{"line_number":455,"context_line":"\tfor bucket, storageBytes :\u003d range storageStats {"},{"line_number":456,"context_line":"\t\tb, err :\u003d json.Marshal(storageBytes)"},{"line_number":457,"context_line":"\t\tif err !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":8,"id":"c6d1fb77_e5221e92","line":454,"in_reply_to":"095ac9a9_96ff6ac3","updated":"2022-09-06 10:45:49.000000000","message":"Good point! As both these stats are different why share the same prefix? \nI meant,\nWouldn\u0027t it just be noise while grepping for \"num_disk_bytes_used_\" in serverless for a bucket and then the not very relevant index level stat also shows up?","commit_id":"dc993748a58084dd0de8c28c3ad85e30bf903a2c"},{"author":{"_account_id":1004804,"name":"Thejas-bhat","email":"thejas.orkombu@couchbase.com","username":"Thejas-bhat","avatars":[{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"3c8eefa0f2cee69f5ff478612b1a55303c30d2b5","unresolved":true,"context_lines":[{"line_number":451,"context_line":"\t}"},{"line_number":452,"context_line":"\treg.handler.WriteMetrics(w)"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"\tstatName :\u003d \"num_bytes_used_disk_for_bucket\""},{"line_number":455,"context_line":"\tfor bucket, storageBytes :\u003d range storageStats {"},{"line_number":456,"context_line":"\t\tb, err :\u003d json.Marshal(storageBytes)"},{"line_number":457,"context_line":"\t\tif err !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":8,"id":"8a3de839_3737993a","line":454,"in_reply_to":"c6d1fb77_e5221e92","updated":"2022-09-07 15:20:25.000000000","message":"Using num_disk_bytes_used_per_bucket, since its seems a bit more readable and the thinking is that these two stats are different","commit_id":"dc993748a58084dd0de8c28c3ad85e30bf903a2c"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"8c798f532c33a2ab3fc2e6f24c490fede2d5cf42","unresolved":true,"context_lines":[{"line_number":451,"context_line":"\t}"},{"line_number":452,"context_line":"\treg.handler.WriteMetrics(w)"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"\tstatName :\u003d \"num_bytes_used_disk_for_bucket\""},{"line_number":455,"context_line":"\tfor bucket, storageBytes :\u003d range storageStats {"},{"line_number":456,"context_line":"\t\tb, err :\u003d json.Marshal(storageBytes)"},{"line_number":457,"context_line":"\t\tif err !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":8,"id":"095ac9a9_96ff6ac3","line":454,"in_reply_to":"f48a4bd8_f56e6076","updated":"2022-08-26 16:16:42.000000000","message":"num_bytes_used_disk is the current naming we use, so should stick with it\u0027s format for greppability.","commit_id":"dc993748a58084dd0de8c28c3ad85e30bf903a2c"}],"ns_server.go":[{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"77092a69d942762d35380ed5053d65135458d65b","unresolved":true,"context_lines":[{"line_number":437,"context_line":""},{"line_number":438,"context_line":"\tregulatorStats :\u003d GetRegulatorStats()"},{"line_number":439,"context_line":"\tif ServerlessMode {"},{"line_number":440,"context_line":"\t\tregulatorStats[\"total_bytes_used_disk\"] \u003d totalBytesUsedDisk"},{"line_number":441,"context_line":"\t}"},{"line_number":442,"context_line":"\tnsIndexStats[\"regulatorStats\"] \u003d regulatorStats"},{"line_number":443,"context_line":""}],"source_content_type":"text/x-go","patch_set":5,"id":"f6a67308_3a143c3d","line":440,"updated":"2022-08-25 21:19:26.000000000","message":"Ah now I see why you asked if I should include this in my commit. Tell you what - let me move this to my commit (seeing that it\u0027s unrelated to this MB) and you wouldn\u0027t need to add this to the regulator stats.","commit_id":"e52c8d40d3d9ded6653c31c2d6e2ddeda9778cfd"}],"prometheus.go":[{"author":{"_account_id":1003912,"name":"Sreekanth Sivasankaran","email":"sreekanth.sivasankaran@couchbase.com","username":"sreekanth-cb","avatars":[{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"8e0f82cb0fe7810f15b818699d35fe375c078bc7","unresolved":true,"context_lines":[{"line_number":128,"context_line":"\t\t\t\treturn"},{"line_number":129,"context_line":"\t\t\t}"},{"line_number":130,"context_line":"\t\t\tif typ, ok :\u003d prometheusStats[nsik]; ok {"},{"line_number":131,"context_line":"\t\t\t\tif nsik \u003d\u003d \"num_bytes_used_disk\" {"},{"line_number":132,"context_line":"\t\t\t\t\tstart :\u003d strings.Index(k, \"bucket\u003d\") + len(\"bucket\u003d\")"},{"line_number":133,"context_line":"\t\t\t\t\tend :\u003d strings.Index(k, \",scope\u003d\")"},{"line_number":134,"context_line":"\t\t\t\t\tstorageBytes, _ :\u003d nsiv.(float64)"}],"source_content_type":"text/x-go","patch_set":8,"id":"f4d326a2_ffc0f7eb","line":131,"updated":"2022-08-26 11:31:32.000000000","message":"num_bytes_used_disk Vs num_disk_bytes_used ?","commit_id":"dc993748a58084dd0de8c28c3ad85e30bf903a2c"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"8c798f532c33a2ab3fc2e6f24c490fede2d5cf42","unresolved":true,"context_lines":[{"line_number":128,"context_line":"\t\t\t\treturn"},{"line_number":129,"context_line":"\t\t\t}"},{"line_number":130,"context_line":"\t\t\tif typ, ok :\u003d prometheusStats[nsik]; ok {"},{"line_number":131,"context_line":"\t\t\t\tif nsik \u003d\u003d \"num_bytes_used_disk\" {"},{"line_number":132,"context_line":"\t\t\t\t\tstart :\u003d strings.Index(k, \"bucket\u003d\") + len(\"bucket\u003d\")"},{"line_number":133,"context_line":"\t\t\t\t\tend :\u003d strings.Index(k, \",scope\u003d\")"},{"line_number":134,"context_line":"\t\t\t\t\tstorageBytes, _ :\u003d nsiv.(float64)"}],"source_content_type":"text/x-go","patch_set":8,"id":"480e9553_e4e59273","line":131,"in_reply_to":"f4d326a2_ffc0f7eb","updated":"2022-08-26 16:16:42.000000000","message":"num_bytes_used_disk is the current naming we use, so should stick with it\u0027s format for greppability.","commit_id":"dc993748a58084dd0de8c28c3ad85e30bf903a2c"}]}