)]}'
{"metering_ee.go":[{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"3dd336b9a324f5b0966c84764d730a582c2ec706","unresolved":true,"context_lines":[{"line_number":95,"context_line":"}"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"func (sr *serviceRegulator) allowMetering() bool {"},{"line_number":98,"context_line":"\tif v, ok :\u003d sr.mgr.Options()[\"toggleRegulatorState\"]; ok {"},{"line_number":99,"context_line":"\t\tval, err :\u003d strconv.ParseBool(v)"},{"line_number":100,"context_line":"\t\tif err \u003d\u003d nil \u0026\u0026 !val {"},{"line_number":101,"context_line":"\t\t\treturn false"}],"source_content_type":"text/x-go","patch_set":1,"id":"47b1e53c_9d47a90d","line":98,"updated":"2022-08-26 16:14:48.000000000","message":"Poor naming :)","commit_id":"4e7552b8431cb7628143bd700f0477b883ef3441"},{"author":{"_account_id":1004804,"name":"Thejas-bhat","email":"thejas.orkombu@couchbase.com","username":"Thejas-bhat","avatars":[{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"a2557afa933b3ad79954f2788bbb011b86285bea","unresolved":false,"context_lines":[{"line_number":95,"context_line":"}"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"func (sr *serviceRegulator) allowMetering() bool {"},{"line_number":98,"context_line":"\tif v, ok :\u003d sr.mgr.Options()[\"toggleRegulatorState\"]; ok {"},{"line_number":99,"context_line":"\t\tval, err :\u003d strconv.ParseBool(v)"},{"line_number":100,"context_line":"\t\tif err \u003d\u003d nil \u0026\u0026 !val {"},{"line_number":101,"context_line":"\t\t\treturn false"}],"source_content_type":"text/x-go","patch_set":1,"id":"52cb2fa2_20da8cca","line":98,"in_reply_to":"47b1e53c_9d47a90d","updated":"2022-08-26 16:41:31.000000000","message":"Ack","commit_id":"4e7552b8431cb7628143bd700f0477b883ef3441"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"3dd336b9a324f5b0966c84764d730a582c2ec706","unresolved":true,"context_lines":[{"line_number":156,"context_line":"// so that further experiments or observations may lead to"},{"line_number":157,"context_line":"// them behaving differently from each other"},{"line_number":158,"context_line":"func MeterWrites(bucket string, index bleve.Index) {"},{"line_number":159,"context_line":"\tif !ServerlessMode || !reg.allowMetering() {"},{"line_number":160,"context_line":"\t\t// no metering for non-serverless versions"},{"line_number":161,"context_line":"\t\t// and when regulator\u0027s disabled."},{"line_number":162,"context_line":"\t\treturn"}],"source_content_type":"text/x-go","patch_set":1,"id":"96e6c416_9d20e47c","line":159,"updated":"2022-08-26 16:14:48.000000000","message":"I believe we still want to metering, it\u0027s just that we won\u0027t throttle or limit - so I advise we change this var\u0027s name too.","commit_id":"4e7552b8431cb7628143bd700f0477b883ef3441"},{"author":{"_account_id":1004804,"name":"Thejas-bhat","email":"thejas.orkombu@couchbase.com","username":"Thejas-bhat","avatars":[{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"a2557afa933b3ad79954f2788bbb011b86285bea","unresolved":true,"context_lines":[{"line_number":156,"context_line":"// so that further experiments or observations may lead to"},{"line_number":157,"context_line":"// them behaving differently from each other"},{"line_number":158,"context_line":"func MeterWrites(bucket string, index bleve.Index) {"},{"line_number":159,"context_line":"\tif !ServerlessMode || !reg.allowMetering() {"},{"line_number":160,"context_line":"\t\t// no metering for non-serverless versions"},{"line_number":161,"context_line":"\t\t// and when regulator\u0027s disabled."},{"line_number":162,"context_line":"\t\treturn"}],"source_content_type":"text/x-go","patch_set":1,"id":"e8739cca_61b7beef","line":159,"in_reply_to":"96e6c416_9d20e47c","updated":"2022-08-26 16:41:31.000000000","message":"Cool. I\u0027ll move this check to CheckQuotaRead/Write.","commit_id":"4e7552b8431cb7628143bd700f0477b883ef3441"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b167f8387211948e9a69e7214d6dc619effc13eb","unresolved":true,"context_lines":[{"line_number":97,"context_line":"func (sr *serviceRegulator) disableLimitingThrottling() bool {"},{"line_number":98,"context_line":"\tif v, ok :\u003d sr.mgr.Options()[\"disableRegulatorControl\"]; ok {"},{"line_number":99,"context_line":"\t\tval, err :\u003d strconv.ParseBool(v)"},{"line_number":100,"context_line":"\t\tif err \u003d\u003d nil \u0026\u0026 val {"},{"line_number":101,"context_line":"\t\t\treturn true"},{"line_number":102,"context_line":"\t\t}"},{"line_number":103,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":2,"id":"98245a5f_51a87c5d","line":100,"updated":"2022-08-26 17:18:58.000000000","message":"Nit*\n    if err \u003d\u003d nil {\n        return val\n    }","commit_id":"9022b765872327b1707131a34d7d764f466b455e"},{"author":{"_account_id":1004804,"name":"Thejas-bhat","email":"thejas.orkombu@couchbase.com","username":"Thejas-bhat","avatars":[{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b9a24adec298e06dedf40bfb272696b8aa261f71","unresolved":true,"context_lines":[{"line_number":97,"context_line":"func (sr *serviceRegulator) disableLimitingThrottling() bool {"},{"line_number":98,"context_line":"\tif v, ok :\u003d sr.mgr.Options()[\"disableRegulatorControl\"]; ok {"},{"line_number":99,"context_line":"\t\tval, err :\u003d strconv.ParseBool(v)"},{"line_number":100,"context_line":"\t\tif err \u003d\u003d nil \u0026\u0026 val {"},{"line_number":101,"context_line":"\t\t\treturn true"},{"line_number":102,"context_line":"\t\t}"},{"line_number":103,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":2,"id":"ce91b1d8_2fdd163d","line":100,"in_reply_to":"7824d7b1_3d1ded43","updated":"2022-08-26 17:26:31.000000000","message":"yikes. yeah, thanks for that :p","commit_id":"9022b765872327b1707131a34d7d764f466b455e"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"a351b8e158c1eb9fd0f5a95f40194f89ca98ef88","unresolved":true,"context_lines":[{"line_number":97,"context_line":"func (sr *serviceRegulator) disableLimitingThrottling() bool {"},{"line_number":98,"context_line":"\tif v, ok :\u003d sr.mgr.Options()[\"disableRegulatorControl\"]; ok {"},{"line_number":99,"context_line":"\t\tval, err :\u003d strconv.ParseBool(v)"},{"line_number":100,"context_line":"\t\tif err \u003d\u003d nil \u0026\u0026 val {"},{"line_number":101,"context_line":"\t\t\treturn true"},{"line_number":102,"context_line":"\t\t}"},{"line_number":103,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":2,"id":"7824d7b1_3d1ded43","line":100,"in_reply_to":"98245a5f_51a87c5d","updated":"2022-08-26 17:21:14.000000000","message":"One better:\n\n  if val, err :\u003d strconv.ParseBool(v); err \u003d\u003d nil {\n      return val\n  }","commit_id":"9022b765872327b1707131a34d7d764f466b455e"}]}