)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1003912,"name":"Sreekanth Sivasankaran","email":"sreekanth.sivasankaran@couchbase.com","username":"sreekanth-cb","avatars":[{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f1cadfe4a60fd7111375f0727cd6f7b1f7ddeb9a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b70ee59b_ff6490fb","updated":"2022-09-06 08:56:52.000000000","message":"minor refactor comment ...","commit_id":"b7c23f86cb4a8b647e9fa1786fbd6ccbf91e5966"}],"metering_ee.go":[{"author":{"_account_id":1003912,"name":"Sreekanth Sivasankaran","email":"sreekanth.sivasankaran@couchbase.com","username":"sreekanth-cb","avatars":[{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"6c345eee531b62d3ad6c88983fc81b3cc39aadb8","unresolved":true,"context_lines":[{"line_number":298,"context_line":""},{"line_number":299,"context_line":"\tfor k :\u003d range reg.stats {"},{"line_number":300,"context_line":"\t\tif _, ok :\u003d existingBuckets[k]; !ok {"},{"line_number":301,"context_line":"\t\t\treg.m.Lock()"},{"line_number":302,"context_line":"\t\t\tdelete(reg.stats, k)"},{"line_number":303,"context_line":"\t\t\treg.m.Unlock()"},{"line_number":304,"context_line":"\t\t}"}],"source_content_type":"text/x-go","patch_set":5,"id":"e5353ee4_09b9887f","line":301,"updated":"2022-09-06 10:50:34.000000000","message":"move this lock outside and do it only once.\nlock/unlock multiple times won\u0027t be efficient I suppose.","commit_id":"37c46b2ebb01c8d6b972df61e0e5e4c9ab0b25fc"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"3122ba05e37fe2b944a4c7599d484534a57d092c","unresolved":true,"context_lines":[{"line_number":298,"context_line":""},{"line_number":299,"context_line":"\tfor k :\u003d range reg.stats {"},{"line_number":300,"context_line":"\t\tif _, ok :\u003d existingBuckets[k]; !ok {"},{"line_number":301,"context_line":"\t\t\treg.m.Lock()"},{"line_number":302,"context_line":"\t\t\tdelete(reg.stats, k)"},{"line_number":303,"context_line":"\t\t\treg.m.Unlock()"},{"line_number":304,"context_line":"\t\t}"}],"source_content_type":"text/x-go","patch_set":5,"id":"a11f01db_72c8c6e0","line":301,"in_reply_to":"3810bc03_82aacb74","updated":"2022-09-07 21:02:05.000000000","message":"Not sure I follow why the original comment is not valid here.\n\nIsn\u0027t access to stats supposed to be guarded by the lock? So the lock should be acquired prior to iterating over the map.","commit_id":"37c46b2ebb01c8d6b972df61e0e5e4c9ab0b25fc"},{"author":{"_account_id":1004804,"name":"Thejas-bhat","email":"thejas.orkombu@couchbase.com","username":"Thejas-bhat","avatars":[{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"cab98dec5c26f2e2afcf4cfdeadbec552733b74d","unresolved":false,"context_lines":[{"line_number":298,"context_line":""},{"line_number":299,"context_line":"\tfor k :\u003d range reg.stats {"},{"line_number":300,"context_line":"\t\tif _, ok :\u003d existingBuckets[k]; !ok {"},{"line_number":301,"context_line":"\t\t\treg.m.Lock()"},{"line_number":302,"context_line":"\t\t\tdelete(reg.stats, k)"},{"line_number":303,"context_line":"\t\t\treg.m.Unlock()"},{"line_number":304,"context_line":"\t\t}"}],"source_content_type":"text/x-go","patch_set":5,"id":"299e470c_b158c995","line":301,"in_reply_to":"a11f01db_72c8c6e0","updated":"2022-09-08 03:43:46.000000000","message":"Done","commit_id":"37c46b2ebb01c8d6b972df61e0e5e4c9ab0b25fc"},{"author":{"_account_id":1003912,"name":"Sreekanth Sivasankaran","email":"sreekanth.sivasankaran@couchbase.com","username":"sreekanth-cb","avatars":[{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"d7fd925ab488dd922812e5f4c060781c6be27946","unresolved":true,"context_lines":[{"line_number":298,"context_line":""},{"line_number":299,"context_line":"\tfor k :\u003d range reg.stats {"},{"line_number":300,"context_line":"\t\tif _, ok :\u003d existingBuckets[k]; !ok {"},{"line_number":301,"context_line":"\t\t\treg.m.Lock()"},{"line_number":302,"context_line":"\t\t\tdelete(reg.stats, k)"},{"line_number":303,"context_line":"\t\t\treg.m.Unlock()"},{"line_number":304,"context_line":"\t\t}"}],"source_content_type":"text/x-go","patch_set":5,"id":"3810bc03_82aacb74","line":301,"in_reply_to":"e5353ee4_09b9887f","updated":"2022-09-06 10:52:32.000000000","message":"Or maybe that is not right as the amortized time would be better this way.\nIgnore my comment.","commit_id":"37c46b2ebb01c8d6b972df61e0e5e4c9ab0b25fc"}]}