)]}'
{"limits.go":[{"author":{"_account_id":1004804,"name":"Thejas-bhat","email":"thejas.orkombu@couchbase.com","username":"Thejas-bhat","avatars":[{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"2af3b8a1ed6f4bca80a06b15b813affe10cd9ab0","unresolved":true,"context_lines":[{"line_number":238,"context_line":"\t}"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"\tvar m sync.Mutex"},{"line_number":241,"context_line":"\trv :\u003d map[*cbgt.NodeDef]*NodeUtilStats{}"},{"line_number":242,"context_line":"\taddToRV :\u003d func(n *cbgt.NodeDef, s *NodeUtilStats) {"},{"line_number":243,"context_line":"\t\tm.Lock()"},{"line_number":244,"context_line":"\t\trv[n] \u003d s"}],"source_content_type":"text/x-go","patch_set":7,"id":"f5f303a8_03ce7111","line":241,"updated":"2022-09-21 08:28:24.000000000","message":"I\u0027m just wondering, is it better to key the rv against nodeDef.UUID string rather than the bulkier nodeDef. I see that this would fall in the path of ns_server polling (I\u0027m guessing) the defrag endpoint to see the benefits of a rebalance. So, we would be doing quite a bit of operations on this returned map overall, so I\u0027m wondering if it\u0027s fine to have the key as *cbgt.NodeDef rather than string (which is nodeDef.UUID)","commit_id":"394869ff0e89ba1ed03d7ee48be8c7bc349ec8a5"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ee8814beaa81286935d2ee63e81ffad9018ea95d","unresolved":false,"context_lines":[{"line_number":238,"context_line":"\t}"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"\tvar m sync.Mutex"},{"line_number":241,"context_line":"\trv :\u003d map[*cbgt.NodeDef]*NodeUtilStats{}"},{"line_number":242,"context_line":"\taddToRV :\u003d func(n *cbgt.NodeDef, s *NodeUtilStats) {"},{"line_number":243,"context_line":"\t\tm.Lock()"},{"line_number":244,"context_line":"\t\trv[n] \u003d s"}],"source_content_type":"text/x-go","patch_set":7,"id":"30869978_09812c62","line":241,"in_reply_to":"f5f303a8_03ce7111","updated":"2022-09-21 15:05:51.000000000","message":"Ack","commit_id":"394869ff0e89ba1ed03d7ee48be8c7bc349ec8a5"}]}