)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e400a6be2171ca6a7cb2f2679154956adb40d228","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"8134c4cf_094629a0","updated":"2025-08-30 01:00:24.000000000","message":"scatter gather code likely needs fixes after testing","commit_id":"a558fa099b848452b113b5772da471d863bafddd"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"3edd3a42b257267080690746b83f5e68b0dffb60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"30ad6b6c_b974bc3d","updated":"2025-11-10 17:38:18.000000000","message":"Thanks for the review @rahul.rampure@couchbase.com. New patch coming in soon.","commit_id":"353a681ff0201ad2e7266039f0b85973f7d53f6b"}],"remote.go":[{"author":{"_account_id":1005103,"name":"Rahul Rampure","email":"rahul.rampure@couchbase.com","username":"CascadingRadium","avatars":[{"url":"https://www.gravatar.com/avatar/d0777f6a957e1a1575c17016512bf8dd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d0777f6a957e1a1575c17016512bf8dd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d0777f6a957e1a1575c17016512bf8dd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d0777f6a957e1a1575c17016512bf8dd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"812601aa751d6b915b766020eac0dada6a49021a","unresolved":true,"context_lines":[{"line_number":519,"context_line":"\treturn rv"},{"line_number":520,"context_line":"}"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"func (r *IndexClient) TermFrequencies(field string, limit int, descending bool) ("},{"line_number":523,"context_line":"\t[]index.TermFreq, error) {"},{"line_number":524,"context_line":"\tu, err :\u003d UrlWithAuth(r.AuthType(), r.InsightsURL)"},{"line_number":525,"context_line":"\tif err !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":28,"id":"3714b8c5_75602b2c","line":522,"updated":"2025-11-10 15:46:40.000000000","message":"duplicate code \n\n```\nfunc (r *IndexClient) fetchInsight(\n\tinsight InsightType,\n\tfield string,\n\tlimit int,\n\tdescending bool,\n\tout any,\n) error {\n\tu, err :\u003d UrlWithAuth(r.AuthType(), r.InsightsURL)\n\tif err !\u003d nil {\n\t\treturn fmt.Errorf(\"remote: auth for query, insightsURL: %s, authType: %s, err: %w\",\n\t\t\tr.InsightsURL, r.AuthType(), err)\n\t}\n\n\tbody, err :\u003d json.Marshal(map[string]any{\n\t\t\"field\":      field,\n\t\t\"insight\":    insight,\n\t\t\"limit\":      limit,\n\t\t\"descending\": descending,\n\t\t\"local-only\": true,\n\t})\n\tif err !\u003d nil {\n\t\treturn fmt.Errorf(\"remote: marshal request, err: %w\", err)\n\t}\n\n\treq, err :\u003d http.NewRequest(\"POST\", u, bytes.NewReader(body))\n\tif err !\u003d nil {\n\t\treturn fmt.Errorf(\"remote: new request, err: %w\", err)\n\t}\n\treq.Header.Set(\"Content-Type\", \"application/json\")\n\n\tresp, err :\u003d r.httpClient.Do(req)\n\tif err !\u003d nil {\n\t\treturn fmt.Errorf(\"remote: http request, err: %w\", err)\n\t}\n\tdefer resp.Body.Close()\n\n\tif resp.StatusCode !\u003d http.StatusOK {\n\t\tio.Copy(io.Discard, resp.Body)\n\t\treturn fmt.Errorf(\"remote: insights got status code %d, insightsURL: %s\", resp.StatusCode, r.InsightsURL)\n\t}\n\n\tdata, err :\u003d io.ReadAll(resp.Body)\n\tif err !\u003d nil {\n\t\treturn fmt.Errorf(\"remote: read response, err: %w\", err)\n\t}\n\n\tif err :\u003d UnmarshalJSON(data, out); err !\u003d nil {\n\t\treturn fmt.Errorf(\"remote: parse response, err: %w\", err)\n\t}\n\n\treturn nil\n}\n\nfunc (r *IndexClient) TermFrequencies(field string, limit int, descending bool) ([]index.TermFreq, error) {\n\tvar rv struct {\n\t\tStatus          string           `json:\"status\"`\n\t\tTermFrequencies []index.TermFreq `json:\"termFrequencies\"`\n\t}\n\n\tif err :\u003d r.fetchInsight(InsightTermFrequencies, field, limit, descending, \u0026rv); err !\u003d nil {\n\t\treturn nil, err\n\t}\n\tif rv.Status !\u003d \"ok\" {\n\t\treturn nil, fmt.Errorf(\"remote: insights unsupported\")\n\t}\n\treturn rv.TermFrequencies, nil\n}\n\nfunc (r *IndexClient) CentroidCardinalities(field string, limit int, descending bool) ([]index.CentroidCardinality, error) {\n\tvar rv struct {\n\t\tStatus                string                      `json:\"status\"`\n\t\tCentroidCardinalities []index.CentroidCardinality `json:\"centroidCardinalities\"`\n\t}\n\n\tif err :\u003d r.fetchInsight(InsightCentroidCardinalities, field, limit, descending, \u0026rv); err !\u003d nil {\n\t\treturn nil, err\n\t}\n\tif rv.Status !\u003d \"ok\" {\n\t\treturn nil, fmt.Errorf(\"remote: insights unsupported\")\n\t}\n\treturn rv.CentroidCardinalities, nil\n}\n\n```","commit_id":"353a681ff0201ad2e7266039f0b85973f7d53f6b"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7b9b16bab8d05cc378d34d8eb7a8f70090fef722","unresolved":false,"context_lines":[{"line_number":519,"context_line":"\treturn rv"},{"line_number":520,"context_line":"}"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"func (r *IndexClient) TermFrequencies(field string, limit int, descending bool) ("},{"line_number":523,"context_line":"\t[]index.TermFreq, error) {"},{"line_number":524,"context_line":"\tu, err :\u003d UrlWithAuth(r.AuthType(), r.InsightsURL)"},{"line_number":525,"context_line":"\tif err !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":28,"id":"f2d57213_e306c334","line":522,"in_reply_to":"022d16a0_5bc9dbfd","updated":"2025-11-10 16:57:47.000000000","message":"Acknowledged","commit_id":"353a681ff0201ad2e7266039f0b85973f7d53f6b"},{"author":{"_account_id":1005103,"name":"Rahul Rampure","email":"rahul.rampure@couchbase.com","username":"CascadingRadium","avatars":[{"url":"https://www.gravatar.com/avatar/d0777f6a957e1a1575c17016512bf8dd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d0777f6a957e1a1575c17016512bf8dd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d0777f6a957e1a1575c17016512bf8dd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d0777f6a957e1a1575c17016512bf8dd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4d28c8ec69597b71c86448e535185bf1113b61be","unresolved":true,"context_lines":[{"line_number":519,"context_line":"\treturn rv"},{"line_number":520,"context_line":"}"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"func (r *IndexClient) TermFrequencies(field string, limit int, descending bool) ("},{"line_number":523,"context_line":"\t[]index.TermFreq, error) {"},{"line_number":524,"context_line":"\tu, err :\u003d UrlWithAuth(r.AuthType(), r.InsightsURL)"},{"line_number":525,"context_line":"\tif err !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":28,"id":"022d16a0_5bc9dbfd","line":522,"in_reply_to":"3714b8c5_75602b2c","updated":"2025-11-10 15:47:27.000000000","message":"use `MarshalJSON`","commit_id":"353a681ff0201ad2e7266039f0b85973f7d53f6b"}],"vectors_sup.go":[{"author":{"_account_id":1005103,"name":"Rahul Rampure","email":"rahul.rampure@couchbase.com","username":"CascadingRadium","avatars":[{"url":"https://www.gravatar.com/avatar/d0777f6a957e1a1575c17016512bf8dd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d0777f6a957e1a1575c17016512bf8dd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d0777f6a957e1a1575c17016512bf8dd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d0777f6a957e1a1575c17016512bf8dd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"812601aa751d6b915b766020eac0dada6a49021a","unresolved":true,"context_lines":[{"line_number":236,"context_line":""},{"line_number":237,"context_line":"\trequestBody, err :\u003d io.ReadAll(req.Body)"},{"line_number":238,"context_line":"\tif err !\u003d nil {"},{"line_number":239,"context_line":"\t\trest.ShowErrorBody(w, nil, fmt.Sprintf(\"indexInsights,\"+"},{"line_number":240,"context_line":"\t\t\t\" could not read request body, indexName: %s, err: %v\","},{"line_number":241,"context_line":"\t\t\tindexName, err), http.StatusBadRequest)"},{"line_number":242,"context_line":"\t\treturn"}],"source_content_type":"text/x-go","patch_set":28,"id":"4a17df87_6017a2a9","line":239,"updated":"2025-11-10 15:46:40.000000000","message":"use `rest.ShowError`","commit_id":"353a681ff0201ad2e7266039f0b85973f7d53f6b"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7b9b16bab8d05cc378d34d8eb7a8f70090fef722","unresolved":false,"context_lines":[{"line_number":236,"context_line":""},{"line_number":237,"context_line":"\trequestBody, err :\u003d io.ReadAll(req.Body)"},{"line_number":238,"context_line":"\tif err !\u003d nil {"},{"line_number":239,"context_line":"\t\trest.ShowErrorBody(w, nil, fmt.Sprintf(\"indexInsights,\"+"},{"line_number":240,"context_line":"\t\t\t\" could not read request body, indexName: %s, err: %v\","},{"line_number":241,"context_line":"\t\t\tindexName, err), http.StatusBadRequest)"},{"line_number":242,"context_line":"\t\treturn"}],"source_content_type":"text/x-go","patch_set":28,"id":"c81f72d3_08d85681","line":239,"in_reply_to":"4a17df87_6017a2a9","updated":"2025-11-10 16:57:47.000000000","message":"Acknowledged","commit_id":"353a681ff0201ad2e7266039f0b85973f7d53f6b"},{"author":{"_account_id":1005103,"name":"Rahul Rampure","email":"rahul.rampure@couchbase.com","username":"CascadingRadium","avatars":[{"url":"https://www.gravatar.com/avatar/d0777f6a957e1a1575c17016512bf8dd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d0777f6a957e1a1575c17016512bf8dd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d0777f6a957e1a1575c17016512bf8dd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d0777f6a957e1a1575c17016512bf8dd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"812601aa751d6b915b766020eac0dada6a49021a","unresolved":true,"context_lines":[{"line_number":243,"context_line":"\t}"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"\tvar idxInsightsReq IndexInsightsRequest"},{"line_number":246,"context_line":"\terr \u003d json.Unmarshal(requestBody, \u0026idxInsightsReq)"},{"line_number":247,"context_line":"\tif err !\u003d nil {"},{"line_number":248,"context_line":"\t\trest.ShowErrorBody(w, nil, fmt.Sprintf(\"indexInsights,\"+"},{"line_number":249,"context_line":"\t\t\t\" error parsing request body, indexName: %s, err: %v\","}],"source_content_type":"text/x-go","patch_set":28,"id":"7bd7a9f4_964c0d57","line":246,"updated":"2025-11-10 15:46:40.000000000","message":"`UnmarshalJSON` to keep it consistent with jsoniter usage","commit_id":"353a681ff0201ad2e7266039f0b85973f7d53f6b"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7b9b16bab8d05cc378d34d8eb7a8f70090fef722","unresolved":false,"context_lines":[{"line_number":243,"context_line":"\t}"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"\tvar idxInsightsReq IndexInsightsRequest"},{"line_number":246,"context_line":"\terr \u003d json.Unmarshal(requestBody, \u0026idxInsightsReq)"},{"line_number":247,"context_line":"\tif err !\u003d nil {"},{"line_number":248,"context_line":"\t\trest.ShowErrorBody(w, nil, fmt.Sprintf(\"indexInsights,\"+"},{"line_number":249,"context_line":"\t\t\t\" error parsing request body, indexName: %s, err: %v\","}],"source_content_type":"text/x-go","patch_set":28,"id":"35efabcb_6eeaed32","line":246,"in_reply_to":"7bd7a9f4_964c0d57","updated":"2025-11-10 16:57:47.000000000","message":"Acknowledged","commit_id":"353a681ff0201ad2e7266039f0b85973f7d53f6b"},{"author":{"_account_id":1005103,"name":"Rahul Rampure","email":"rahul.rampure@couchbase.com","username":"CascadingRadium","avatars":[{"url":"https://www.gravatar.com/avatar/d0777f6a957e1a1575c17016512bf8dd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d0777f6a957e1a1575c17016512bf8dd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d0777f6a957e1a1575c17016512bf8dd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d0777f6a957e1a1575c17016512bf8dd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"812601aa751d6b915b766020eac0dada6a49021a","unresolved":true,"context_lines":[{"line_number":245,"context_line":"\tvar idxInsightsReq IndexInsightsRequest"},{"line_number":246,"context_line":"\terr \u003d json.Unmarshal(requestBody, \u0026idxInsightsReq)"},{"line_number":247,"context_line":"\tif err !\u003d nil {"},{"line_number":248,"context_line":"\t\trest.ShowErrorBody(w, nil, fmt.Sprintf(\"indexInsights,\"+"},{"line_number":249,"context_line":"\t\t\t\" error parsing request body, indexName: %s, err: %v\","},{"line_number":250,"context_line":"\t\t\tindexName, err), http.StatusBadRequest)"},{"line_number":251,"context_line":"\t\treturn"}],"source_content_type":"text/x-go","patch_set":28,"id":"783266ca_ecd3426e","line":248,"updated":"2025-11-10 15:46:40.000000000","message":"use `rest.ShowError`","commit_id":"353a681ff0201ad2e7266039f0b85973f7d53f6b"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7b9b16bab8d05cc378d34d8eb7a8f70090fef722","unresolved":false,"context_lines":[{"line_number":245,"context_line":"\tvar idxInsightsReq IndexInsightsRequest"},{"line_number":246,"context_line":"\terr \u003d json.Unmarshal(requestBody, \u0026idxInsightsReq)"},{"line_number":247,"context_line":"\tif err !\u003d nil {"},{"line_number":248,"context_line":"\t\trest.ShowErrorBody(w, nil, fmt.Sprintf(\"indexInsights,\"+"},{"line_number":249,"context_line":"\t\t\t\" error parsing request body, indexName: %s, err: %v\","},{"line_number":250,"context_line":"\t\t\tindexName, err), http.StatusBadRequest)"},{"line_number":251,"context_line":"\t\treturn"}],"source_content_type":"text/x-go","patch_set":28,"id":"91c54efe_f7c1221f","line":248,"in_reply_to":"783266ca_ecd3426e","updated":"2025-11-10 16:57:47.000000000","message":"Acknowledged","commit_id":"353a681ff0201ad2e7266039f0b85973f7d53f6b"},{"author":{"_account_id":1005103,"name":"Rahul Rampure","email":"rahul.rampure@couchbase.com","username":"CascadingRadium","avatars":[{"url":"https://www.gravatar.com/avatar/d0777f6a957e1a1575c17016512bf8dd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d0777f6a957e1a1575c17016512bf8dd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d0777f6a957e1a1575c17016512bf8dd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d0777f6a957e1a1575c17016512bf8dd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"812601aa751d6b915b766020eac0dada6a49021a","unresolved":true,"context_lines":[{"line_number":256,"context_line":"\t\treturn"},{"line_number":257,"context_line":"\t}"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"\tif idxInsightsReq.Insight !\u003d insightTermFrequencies \u0026\u0026"},{"line_number":260,"context_line":"\t\tidxInsightsReq.Insight !\u003d insightCentroidCardinalities {"},{"line_number":261,"context_line":"\t\trest.ShowError(w, req,"},{"line_number":262,"context_line":"\t\t\t\"indexInsights, supported insights: \u0027termFrequencies\u0027/\u0027centroidCardinalities\u0027\","},{"line_number":263,"context_line":"\t\t\thttp.StatusBadRequest)"},{"line_number":264,"context_line":"\t\treturn"},{"line_number":265,"context_line":"\t}"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"\trcAdder :\u003d addIndexClients"},{"line_number":268,"context_line":"\tif idxInsightsReq.LocalOnly {"}],"source_content_type":"text/x-go","patch_set":28,"id":"a961199f_ed283e47","line":265,"range":{"start_line":259,"start_character":0,"end_line":265,"end_character":2},"updated":"2025-11-10 15:46:40.000000000","message":"```\ntype InsightType string\n\nconst (\n\tInsightTermFrequencies       InsightType \u003d \"termFrequencies\"\n\tInsightCentroidCardinalities InsightType \u003d \"centroidCardinalities\"\n)\n\nvar supportedInsights \u003d map[InsightType]struct{}{\n\tInsightTermFrequencies:       {},\n\tInsightCentroidCardinalities: {},\n}\n\nfunc isSupportedInsight(v string) bool {\n\t_, ok :\u003d supportedInsights[InsightType(v)]\n\treturn ok\n}\n\nfunc supportedInsights() []string {\n        names :\u003d make([]string, 0, len(supportedInsights))\n\tfor k :\u003d range supportedInsights {\n\t\tnames \u003d append(names, string(k))\n\t}\n\tsort.Strings(names)\n\treturn names\n}\n\n...\n\nif !isSupportedInsight(idxInsightsReq.Insight) {\n        rest.ShowError(w, req,\n\tfmt.Sprintf(\"indexInsights, supported insights: %s\", strings.Join(supportedInsights(), \"/\")),\n\thttp.StatusBadRequest)\n}\n```","commit_id":"353a681ff0201ad2e7266039f0b85973f7d53f6b"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"1f73e934547ebe22e65c005d08123f262cadb68a","unresolved":false,"context_lines":[{"line_number":256,"context_line":"\t\treturn"},{"line_number":257,"context_line":"\t}"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"\tif idxInsightsReq.Insight !\u003d insightTermFrequencies \u0026\u0026"},{"line_number":260,"context_line":"\t\tidxInsightsReq.Insight !\u003d insightCentroidCardinalities {"},{"line_number":261,"context_line":"\t\trest.ShowError(w, req,"},{"line_number":262,"context_line":"\t\t\t\"indexInsights, supported insights: \u0027termFrequencies\u0027/\u0027centroidCardinalities\u0027\","},{"line_number":263,"context_line":"\t\t\thttp.StatusBadRequest)"},{"line_number":264,"context_line":"\t\treturn"},{"line_number":265,"context_line":"\t}"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"\trcAdder :\u003d addIndexClients"},{"line_number":268,"context_line":"\tif idxInsightsReq.LocalOnly {"}],"source_content_type":"text/x-go","patch_set":28,"id":"d584e395_74286234","line":265,"range":{"start_line":259,"start_character":0,"end_line":265,"end_character":2},"in_reply_to":"4494f7dc_7e295b2d","updated":"2025-11-10 17:51:08.000000000","message":"Done","commit_id":"353a681ff0201ad2e7266039f0b85973f7d53f6b"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"3edd3a42b257267080690746b83f5e68b0dffb60","unresolved":true,"context_lines":[{"line_number":256,"context_line":"\t\treturn"},{"line_number":257,"context_line":"\t}"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"\tif idxInsightsReq.Insight !\u003d insightTermFrequencies \u0026\u0026"},{"line_number":260,"context_line":"\t\tidxInsightsReq.Insight !\u003d insightCentroidCardinalities {"},{"line_number":261,"context_line":"\t\trest.ShowError(w, req,"},{"line_number":262,"context_line":"\t\t\t\"indexInsights, supported insights: \u0027termFrequencies\u0027/\u0027centroidCardinalities\u0027\","},{"line_number":263,"context_line":"\t\t\thttp.StatusBadRequest)"},{"line_number":264,"context_line":"\t\treturn"},{"line_number":265,"context_line":"\t}"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"\trcAdder :\u003d addIndexClients"},{"line_number":268,"context_line":"\tif idxInsightsReq.LocalOnly {"}],"source_content_type":"text/x-go","patch_set":28,"id":"4494f7dc_7e295b2d","line":265,"range":{"start_line":259,"start_character":0,"end_line":265,"end_character":2},"in_reply_to":"a961199f_ed283e47","updated":"2025-11-10 17:38:18.000000000","message":"Don\u0027t feel this would do any better than what\u0027s in place already.","commit_id":"353a681ff0201ad2e7266039f0b85973f7d53f6b"},{"author":{"_account_id":1005103,"name":"Rahul Rampure","email":"rahul.rampure@couchbase.com","username":"CascadingRadium","avatars":[{"url":"https://www.gravatar.com/avatar/d0777f6a957e1a1575c17016512bf8dd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d0777f6a957e1a1575c17016512bf8dd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d0777f6a957e1a1575c17016512bf8dd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d0777f6a957e1a1575c17016512bf8dd.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"812601aa751d6b915b766020eac0dada6a49021a","unresolved":true,"context_lines":[{"line_number":264,"context_line":"\t\treturn"},{"line_number":265,"context_line":"\t}"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"\trcAdder :\u003d addIndexClients"},{"line_number":268,"context_line":"\tif idxInsightsReq.LocalOnly {"},{"line_number":269,"context_line":"\t\t// no index clients in case of a \"local-only\" request"},{"line_number":270,"context_line":"\t\trcAdder \u003d nil"},{"line_number":271,"context_line":"\t}"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"\talias, _, _, err :\u003d bleveIndexAlias(h.mgr, indexName, \"\", false, nil, nil,"},{"line_number":274,"context_line":"\t\ttrue, nil, \"\", rcAdder)"}],"source_content_type":"text/x-go","patch_set":28,"id":"8f7f0eda_1bf715ca","line":271,"range":{"start_line":267,"start_character":0,"end_line":271,"end_character":2},"updated":"2025-11-10 15:46:40.000000000","message":"why not use gprc? addGrpcClients is equivalent\n```\nvar rcAdder addRemoteClients\n\nif !idxInsightsReq.LocalOnly {\n    rcAdder :\u003d addIndexClients\n} \n```","commit_id":"353a681ff0201ad2e7266039f0b85973f7d53f6b"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7b9b16bab8d05cc378d34d8eb7a8f70090fef722","unresolved":true,"context_lines":[{"line_number":264,"context_line":"\t\treturn"},{"line_number":265,"context_line":"\t}"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"\trcAdder :\u003d addIndexClients"},{"line_number":268,"context_line":"\tif idxInsightsReq.LocalOnly {"},{"line_number":269,"context_line":"\t\t// no index clients in case of a \"local-only\" request"},{"line_number":270,"context_line":"\t\trcAdder \u003d nil"},{"line_number":271,"context_line":"\t}"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"\talias, _, _, err :\u003d bleveIndexAlias(h.mgr, indexName, \"\", false, nil, nil,"},{"line_number":274,"context_line":"\t\ttrue, nil, \"\", rcAdder)"}],"source_content_type":"text/x-go","patch_set":28,"id":"e9033a30_d48b30fa","line":271,"range":{"start_line":267,"start_character":0,"end_line":271,"end_character":2},"in_reply_to":"8f7f0eda_1bf715ca","updated":"2025-11-10 16:57:47.000000000","message":"Requires changes to the protobuf, and there\u0027s no real requirement for streaming etc - so let\u0027s leave this be for now.","commit_id":"353a681ff0201ad2e7266039f0b85973f7d53f6b"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"1f73e934547ebe22e65c005d08123f262cadb68a","unresolved":false,"context_lines":[{"line_number":264,"context_line":"\t\treturn"},{"line_number":265,"context_line":"\t}"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"\trcAdder :\u003d addIndexClients"},{"line_number":268,"context_line":"\tif idxInsightsReq.LocalOnly {"},{"line_number":269,"context_line":"\t\t// no index clients in case of a \"local-only\" request"},{"line_number":270,"context_line":"\t\trcAdder \u003d nil"},{"line_number":271,"context_line":"\t}"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"\talias, _, _, err :\u003d bleveIndexAlias(h.mgr, indexName, \"\", false, nil, nil,"},{"line_number":274,"context_line":"\t\ttrue, nil, \"\", rcAdder)"}],"source_content_type":"text/x-go","patch_set":28,"id":"109a48c2_5b37fc6d","line":271,"range":{"start_line":267,"start_character":0,"end_line":271,"end_character":2},"in_reply_to":"e9033a30_d48b30fa","updated":"2025-11-10 17:51:08.000000000","message":"Done","commit_id":"353a681ff0201ad2e7266039f0b85973f7d53f6b"}]}