)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e24ef7072b9a7b07b62bbbd84b1c1f0ca7a81a9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fa8f998f_3e134838","updated":"2022-08-11 01:10:30.000000000","message":"Pending verification.","commit_id":"44b614a3eb1598696d879f45b492dba76b8f7316"}],"cbauth.go":[{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"419641da847c5b11c446355fbf328c0a47bc8805","unresolved":true,"context_lines":[{"line_number":292,"context_line":"\t\tEncryptData:        configs.EncryptionEnabled,"},{"line_number":293,"context_line":"\t\tDisableNonSSLPorts: configs.DisableNonSSLPorts,"},{"line_number":294,"context_line":"\t\tCertificates:       []tls.Certificate{configs.ClientCertificate},"},{"line_number":295,"context_line":"\t\tRootCAs:            FetchSecurityConfig(),"},{"line_number":296,"context_line":"\t}); err !\u003d nil {"},{"line_number":297,"context_line":"\t\tlog.Warnf(\"cbauth: Error updating go-couchbase/cbdatasource\u0027s\"+"},{"line_number":298,"context_line":"\t\t\t\" TLS data, err: %v\", err)"}],"source_content_type":"text/x-go","patch_set":13,"id":"3b0470dd_6edb19ea","line":295,"range":{"start_line":295,"start_character":0,"end_line":295,"end_character":44},"updated":"2022-08-11 17:54:25.000000000","message":"Seems like you are passing client cert as a root CA here, no?","commit_id":"4dabce4e9e213e9c13beafa3618fc32b66799f33"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"35ff6821b2a48d8c6f2189dde3f05fdac63745fe","unresolved":true,"context_lines":[{"line_number":292,"context_line":"\t\tEncryptData:        configs.EncryptionEnabled,"},{"line_number":293,"context_line":"\t\tDisableNonSSLPorts: configs.DisableNonSSLPorts,"},{"line_number":294,"context_line":"\t\tCertificates:       []tls.Certificate{configs.ClientCertificate},"},{"line_number":295,"context_line":"\t\tRootCAs:            FetchSecurityConfig(),"},{"line_number":296,"context_line":"\t}); err !\u003d nil {"},{"line_number":297,"context_line":"\t\tlog.Warnf(\"cbauth: Error updating go-couchbase/cbdatasource\u0027s\"+"},{"line_number":298,"context_line":"\t\t\t\" TLS data, err: %v\", err)"}],"source_content_type":"text/x-go","patch_set":13,"id":"92d95e56_e16cd847","line":295,"range":{"start_line":295,"start_character":0,"end_line":295,"end_character":44},"in_reply_to":"3b0470dd_6edb19ea","updated":"2022-08-11 18:03:53.000000000","message":"This code isn\u0027t really used anymore. It\u0027s the older SDK that requires a RootCAs. Think I can safely remove this parameter even.\n\nupdateSecurityConfig above^ in live 285 is the one in active use.","commit_id":"4dabce4e9e213e9c13beafa3618fc32b66799f33"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"6dfdde5338730ab4b9cd6868992d57b9c61dc4c3","unresolved":false,"context_lines":[{"line_number":292,"context_line":"\t\tEncryptData:        configs.EncryptionEnabled,"},{"line_number":293,"context_line":"\t\tDisableNonSSLPorts: configs.DisableNonSSLPorts,"},{"line_number":294,"context_line":"\t\tCertificates:       []tls.Certificate{configs.ClientCertificate},"},{"line_number":295,"context_line":"\t\tRootCAs:            FetchSecurityConfig(),"},{"line_number":296,"context_line":"\t}); err !\u003d nil {"},{"line_number":297,"context_line":"\t\tlog.Warnf(\"cbauth: Error updating go-couchbase/cbdatasource\u0027s\"+"},{"line_number":298,"context_line":"\t\t\t\" TLS data, err: %v\", err)"}],"source_content_type":"text/x-go","patch_set":13,"id":"28dd36a9_e4cc82ba","line":295,"range":{"start_line":295,"start_character":0,"end_line":295,"end_character":44},"in_reply_to":"92d95e56_e16cd847","updated":"2022-08-11 19:20:34.000000000","message":"ack.","commit_id":"4dabce4e9e213e9c13beafa3618fc32b66799f33"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"57a2c2a4f5476aefabe18777e0f2fccddd0dc7f0","unresolved":true,"context_lines":[{"line_number":217,"context_line":"\t\treturn err"},{"line_number":218,"context_line":"\t}"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"\tconfigs.Certificate \u003d cert"},{"line_number":221,"context_line":"\tconfigs.CertInBytes \u003d certInBytes"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"\treturn nil"},{"line_number":224,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":14,"id":"a6930b70_f01f5520","line":221,"range":{"start_line":220,"start_character":0,"end_line":221,"end_character":34},"updated":"2022-08-11 19:33:46.000000000","message":"What is the meaning of configs.Certificate and configs.CertInBytes?\n\nRe congigs.certificate: if it\u0027s server cert maybe it makes sense to call it ServerX509KeyPair or something like that?\n\nRe configs.CertInBytes: if it\u0027s CA certs, maybe it makes sense to call it CACertsInBytes or something like that?","commit_id":"985c9055e5ea65b9c197c2eb762e7cdb85aa328f"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"1ddde006855ed219648cf9f5513f8b89db26eb6c","unresolved":false,"context_lines":[{"line_number":217,"context_line":"\t\treturn err"},{"line_number":218,"context_line":"\t}"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"\tconfigs.Certificate \u003d cert"},{"line_number":221,"context_line":"\tconfigs.CertInBytes \u003d certInBytes"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"\treturn nil"},{"line_number":224,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":14,"id":"afe18744_463a0847","line":221,"range":{"start_line":220,"start_character":0,"end_line":221,"end_character":34},"in_reply_to":"a6930b70_f01f5520","updated":"2022-08-11 19:35:17.000000000","message":"Yea let me rename these.","commit_id":"985c9055e5ea65b9c197c2eb762e7cdb85aa328f"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"dae44301217feb98a49d87a8cb843440e5ebce5d","unresolved":true,"context_lines":[{"line_number":272,"context_line":"\t}"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"\tconfigs.ClientCertificate \u003d cert"},{"line_number":275,"context_line":"\tconfigs.ClientCertInBytes \u003d certInBytes"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"\treturn nil"},{"line_number":278,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":15,"id":"bf7b9e93_6f7ee3ab","line":275,"range":{"start_line":275,"start_character":0,"end_line":275,"end_character":40},"updated":"2022-08-11 19:38:21.000000000","message":"I don\u0027t see where you use configs.ClientCertInBytes. Do you really need it?","commit_id":"e2f8a3f8604d9e349d5abe734a1ffc29af2b6e08"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"23563a02ddd214bbb3ad4fc306177de2a48cb2c1","unresolved":false,"context_lines":[{"line_number":272,"context_line":"\t}"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"\tconfigs.ClientCertificate \u003d cert"},{"line_number":275,"context_line":"\tconfigs.ClientCertInBytes \u003d certInBytes"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"\treturn nil"},{"line_number":278,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":15,"id":"4c619ae0_01bca804","line":275,"range":{"start_line":275,"start_character":0,"end_line":275,"end_character":40},"in_reply_to":"bf7b9e93_6f7ee3ab","updated":"2022-08-11 19:45:06.000000000","message":"Perhaps not, good spot.","commit_id":"e2f8a3f8604d9e349d5abe734a1ffc29af2b6e08"}],"gocbcore_utils.go":[{"author":{"_account_id":1003912,"name":"Sreekanth Sivasankaran","email":"sreekanth.sivasankaran@couchbase.com","username":"sreekanth-cb","avatars":[{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1cfa3f82174305fc7b07623866e0a72a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ee7b062bb90f7a8820afe2d5639ccbe1606d4c4a","unresolved":true,"context_lines":[{"line_number":147,"context_line":"\t\tcaProvider \u003d FetchRootCAs"},{"line_number":148,"context_line":"\t} else {"},{"line_number":149,"context_line":"\t\tif RootCAsProvider !\u003d nil {"},{"line_number":150,"context_line":"\t\t\tcaProvider \u003d RootCAsProvider(bucketName, bucketUUID)"},{"line_number":151,"context_line":"\t\t}"},{"line_number":152,"context_line":"\t}"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-go","patch_set":17,"id":"0aef6ecf_16abfb5e","line":150,"updated":"2022-08-18 12:34:57.000000000","message":"Would this be applicable for on-premise as well?\nWhat about the default initialisation on the else part on left side when RootCAsProvider is nil?","commit_id":"3f8822612b7975e78a7d1097cf0b253efce3386b"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"50c1adab415d812a68ea0ca5d0029883c6ce56f0","unresolved":true,"context_lines":[{"line_number":147,"context_line":"\t\tcaProvider \u003d FetchRootCAs"},{"line_number":148,"context_line":"\t} else {"},{"line_number":149,"context_line":"\t\tif RootCAsProvider !\u003d nil {"},{"line_number":150,"context_line":"\t\t\tcaProvider \u003d RootCAsProvider(bucketName, bucketUUID)"},{"line_number":151,"context_line":"\t\t}"},{"line_number":152,"context_line":"\t}"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-go","patch_set":17,"id":"2d82a350_50badfe3","line":150,"in_reply_to":"0aef6ecf_16abfb5e","updated":"2022-08-18 13:05:34.000000000","message":"No just for for sync gateway at the moment.\nLeaving RootCAsProvider at nil is a way for them to not use TLS.","commit_id":"3f8822612b7975e78a7d1097cf0b253efce3386b"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"6b1720a27b2ee2df6e80c39362db71ea0c5af140","unresolved":false,"context_lines":[{"line_number":147,"context_line":"\t\tcaProvider \u003d FetchRootCAs"},{"line_number":148,"context_line":"\t} else {"},{"line_number":149,"context_line":"\t\tif RootCAsProvider !\u003d nil {"},{"line_number":150,"context_line":"\t\t\tcaProvider \u003d RootCAsProvider(bucketName, bucketUUID)"},{"line_number":151,"context_line":"\t\t}"},{"line_number":152,"context_line":"\t}"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-go","patch_set":17,"id":"3bd8b482_e414ad6c","line":150,"in_reply_to":"2d82a350_50badfe3","updated":"2022-08-18 16:50:07.000000000","message":"Resolving after conversation w/ sreekanth.","commit_id":"3f8822612b7975e78a7d1097cf0b253efce3386b"}]}