)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1004804,"name":"Thejas-bhat","email":"thejas.orkombu@couchbase.com","username":"Thejas-bhat","avatars":[{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"8a78061126d768499fc13dc1f36d68bdad9b4b16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ee3d813a_78bf64c3","updated":"2022-10-12 16:26:55.000000000","message":"Fair point, then the changes look good to me ","commit_id":"6ccb83452f90bba3db30a8cc41feedcdc4c49f58"}],"rest/rest_diag.go":[{"author":{"_account_id":1004804,"name":"Thejas-bhat","email":"thejas.orkombu@couchbase.com","username":"Thejas-bhat","avatars":[{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/287cbc76d9eb75d794779bc8ce9efb8b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4705ec32860e6911757bb7b1777e99e03ab63a59","unresolved":true,"context_lines":[{"line_number":48,"context_line":"}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"var extDiagHandlerMutex sync.RWMutex"},{"line_number":51,"context_line":"var extDiagHandlers \u003d []cbgt.DiagHandler{}"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"// RegisterDiagHandler accounts for external DiagHandlers that"},{"line_number":54,"context_line":"// an application can register with cbgt. The REST endpoint"}],"source_content_type":"text/x-go","patch_set":2,"id":"40e6d545_3fe636f6","line":51,"updated":"2022-10-12 06:56:40.000000000","message":"I\u0027m wondering if we can pass the handlers from the cbft layer using the options param thats passed to InitRestRouterEx, where we will register the handlers in the object created by NewDiagGetHandler. That way, I\u0027m thinking we can avoid global vars and the locks. Is this a valid one?","commit_id":"6ccb83452f90bba3db30a8cc41feedcdc4c49f58"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"52bcbb40381654c9a15287a72e6f12aac573a27e","unresolved":true,"context_lines":[{"line_number":48,"context_line":"}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"var extDiagHandlerMutex sync.RWMutex"},{"line_number":51,"context_line":"var extDiagHandlers \u003d []cbgt.DiagHandler{}"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"// RegisterDiagHandler accounts for external DiagHandlers that"},{"line_number":54,"context_line":"// an application can register with cbgt. The REST endpoint"}],"source_content_type":"text/x-go","patch_set":2,"id":"b8563531_cdd3471c","line":51,"in_reply_to":"343e6171_9011655d","updated":"2022-10-12 15:11:38.000000000","message":"Ah so you meant setting new options within NewRESTRouter, which is a good idea.\n\nUnfortunately, it seems we call NewRESTRouter/InitRESTRouterEx and initialize all the cbgt endpoints/handlers prior to registering the handler for /api/nsstats.\n\nTo support what you\u0027re suggesting - I\u0027m not seeing an easy way of doing it without major changes :/. Thoughts?","commit_id":"6ccb83452f90bba3db30a8cc41feedcdc4c49f58"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"51119acec63cdda72ce563746ca655f34fdc8d5c","unresolved":true,"context_lines":[{"line_number":48,"context_line":"}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"var extDiagHandlerMutex sync.RWMutex"},{"line_number":51,"context_line":"var extDiagHandlers \u003d []cbgt.DiagHandler{}"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"// RegisterDiagHandler accounts for external DiagHandlers that"},{"line_number":54,"context_line":"// an application can register with cbgt. The REST endpoint"}],"source_content_type":"text/x-go","patch_set":2,"id":"343e6171_9011655d","line":51,"in_reply_to":"40e6d545_3fe636f6","updated":"2022-10-12 14:30:11.000000000","message":"But isn\u0027t options of type - map[string]string or are you referring to something else?","commit_id":"6ccb83452f90bba3db30a8cc41feedcdc4c49f58"}]}