)]}'
{"cbmgr.py":[{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7aee6d893a03552b1f404a48f2272bf043c150ea","unresolved":false,"context_lines":[{"line_number":2741,"context_line":"        else:"},{"line_number":2742,"context_line":"            opts.authorization_enabled \u003d \u0027false\u0027"},{"line_number":2743,"context_line":""},{"line_number":2744,"context_line":"        if not opts.disable_cert_val:"},{"line_number":2745,"context_line":"            if opts.cacert_ldap is None:"},{"line_number":2746,"context_line":"                _exitIfErrors([\u0027--ldap-cacert is required when server certificate verification is active.\u0027])"},{"line_number":2747,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bdec108f_6ebc5b82","line":2744,"range":{"start_line":2744,"start_character":7,"end_line":2744,"end_character":37},"updated":"2019-06-26 18:13:04.000000000","message":"What if opts.disable_cert_val is set and opts.cacert_ldap is set? If I understand it right, you will pass both of them. Moreover cacert_ldap will be passed as filename which is weird. I would prefer one of the following behaviours for this case:\n1) we read the ldap_cert file anyway and let server decide what to do with disable_cert_val and cacert_ldap;\n2) return error kind of \"--ldap-cacert can\u0027t be used with \"--disable-cert-validation\"","commit_id":"19285f6fddffff79c9e94c8c38db1ed0f83c4d5d"},{"author":{"_account_id":1004370,"name":"Carlos Gonzalez","email":"carlos.gonzalez@couchbase.com","username":"cg14823","avatars":[{"url":"https://www.gravatar.com/avatar/ddd88d77822c24976ea3ac162e0d5436.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ddd88d77822c24976ea3ac162e0d5436.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ddd88d77822c24976ea3ac162e0d5436.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ddd88d77822c24976ea3ac162e0d5436.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"03d7486f94eb950b7cede0df2f758946b231b3c6","unresolved":false,"context_lines":[{"line_number":2741,"context_line":"        else:"},{"line_number":2742,"context_line":"            opts.authorization_enabled \u003d \u0027false\u0027"},{"line_number":2743,"context_line":""},{"line_number":2744,"context_line":"        if not opts.disable_cert_val:"},{"line_number":2745,"context_line":"            if opts.cacert_ldap is None:"},{"line_number":2746,"context_line":"                _exitIfErrors([\u0027--ldap-cacert is required when server certificate verification is active.\u0027])"},{"line_number":2747,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"22a72c1c_98562671","line":2744,"range":{"start_line":2744,"start_character":7,"end_line":2744,"end_character":37},"in_reply_to":"bdec108f_6ebc5b82","updated":"2019-06-27 08:13:32.000000000","message":"It would not pass both of them as in the rest.ldap_settings function it will only send the ca if disable_cert_val is false, nevertheless I think having the CLI throw an error when both --disable-cacert-validation and --ldap-cacert are provided is a good idea so I will implement behavour number 2.","commit_id":"19285f6fddffff79c9e94c8c38db1ed0f83c4d5d"}]}