)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1004460,"name":"James Lee","email":"james.lee@couchbase.com","username":"jamesl33","avatars":[{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ddb4ddb0de29019b3e21babce06c5863330ed919","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"649851bb_a8b2379d","updated":"2022-09-15 10:27:34.000000000","message":"Is this a breaking change?\n\nIn this case I\u0027m happy with it being a breaking change, just want to confirm so we know whether or not a 7.2.x couchbase-cli will be able to perform this operation for older cluster versions.\n\nDo we have any testing in-place which asserts we exhibit the new behavior, this might be covered by existing tests, just not 100% sure?","commit_id":"113fa08a84635d855503776b5c3ae4c0d96cb59a"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"d847fca8da43705dbe04ddc7f5b8635db8ae07d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"daa82598_bd2daa68","updated":"2022-09-14 17:21:53.000000000","message":"Please review.\nJust in case ns_server change is here https://review.couchbase.org/c/ns_server/+/179141","commit_id":"113fa08a84635d855503776b5c3ae4c0d96cb59a"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"74223d717744ce70deb98bd2d7ee23e15bcfd956","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d19c947b_74b757f1","in_reply_to":"649851bb_a8b2379d","updated":"2022-09-15 23:17:18.000000000","message":"Yes, it\u0027s a breaking change.\n7.2 couchbase-cli won\u0027t be able to pass master password to a 7.1 node.\nHypothetically we can add support for old versions if we need to. Let me know what you think.\n\nThere were some negative tests for master password. I also added two tests for positive scenario.","commit_id":"113fa08a84635d855503776b5c3ae4c0d96cb59a"},{"author":{"_account_id":1004460,"name":"James Lee","email":"james.lee@couchbase.com","username":"jamesl33","avatars":[{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"be5f0df0048daace0a82f704041057d8c5f06b69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"246190da_331d112b","in_reply_to":"d19c947b_74b757f1","updated":"2022-09-16 08:14:05.000000000","message":"\u003e Hypothetically we can add support for old versions if we need to. Let me know what you think.\n\nPersonally, I don\u0027t mind this being a breaking change. We can just use an older instance of couchbase-cli if we require that use-case. If anyone feels differently, please feel free to voice their opinion.\n\n\u003e I also added two tests for positive scenario.\n\nPerfect, thank you, much appreciated!","commit_id":"113fa08a84635d855503776b5c3ae4c0d96cb59a"}],"cbmgr.py":[{"author":{"_account_id":1004460,"name":"James Lee","email":"james.lee@couchbase.com","username":"jamesl33","avatars":[{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ddb4ddb0de29019b3e21babce06c5863330ed919","unresolved":true,"context_lines":[{"line_number":1692,"context_line":"                \" configuration\").rstrip()"},{"line_number":1693,"context_line":"            [afamilystr, portstr] \u003d familyport.split()"},{"line_number":1694,"context_line":"            port \u003d int(portstr)"},{"line_number":1695,"context_line":"            afamily \u003d None"},{"line_number":1696,"context_line":"            if afamilystr \u003d\u003d \"inet\":"},{"line_number":1697,"context_line":"                afamily \u003d socket.AF_INET"},{"line_number":1698,"context_line":"            elif afamilystr \u003d\u003d \"inet6\":"}],"source_content_type":"text/x-python","patch_set":3,"id":"81a43ba7_7bb700d0","line":1695,"range":{"start_line":1695,"start_character":12,"end_line":1695,"end_character":26},"updated":"2022-09-15 10:27:34.000000000","message":"Is it ever OK for this to be None?\n\nWould we be better doing something like below?\n\nafamily \u003d socket.AF_INET6 if afamilystr \u003d\u003d \"inet6\" else socket.AF_INET","commit_id":"113fa08a84635d855503776b5c3ae4c0d96cb59a"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"74223d717744ce70deb98bd2d7ee23e15bcfd956","unresolved":false,"context_lines":[{"line_number":1692,"context_line":"                \" configuration\").rstrip()"},{"line_number":1693,"context_line":"            [afamilystr, portstr] \u003d familyport.split()"},{"line_number":1694,"context_line":"            port \u003d int(portstr)"},{"line_number":1695,"context_line":"            afamily \u003d None"},{"line_number":1696,"context_line":"            if afamilystr \u003d\u003d \"inet\":"},{"line_number":1697,"context_line":"                afamily \u003d socket.AF_INET"},{"line_number":1698,"context_line":"            elif afamilystr \u003d\u003d \"inet6\":"}],"source_content_type":"text/x-python","patch_set":3,"id":"9162ecec_f8d23b06","line":1695,"range":{"start_line":1695,"start_character":12,"end_line":1695,"end_character":26},"in_reply_to":"81a43ba7_7bb700d0","updated":"2022-09-15 23:17:18.000000000","message":"done","commit_id":"113fa08a84635d855503776b5c3ae4c0d96cb59a"},{"author":{"_account_id":1004460,"name":"James Lee","email":"james.lee@couchbase.com","username":"jamesl33","avatars":[{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ddb4ddb0de29019b3e21babce06c5863330ed919","unresolved":true,"context_lines":[{"line_number":1710,"context_line":"        try:"},{"line_number":1711,"context_line":"            sock.settimeout(5)"},{"line_number":1712,"context_line":"            addr \u003d \"::1\" if afamily \u003d\u003d socket.AF_INET6 else \"127.0.0.1\""},{"line_number":1713,"context_line":"            sock.sendto(password.encode(\u0027utf-8\u0027), (addr, port))"},{"line_number":1714,"context_line":"            (result, _) \u003d sock.recvfrom(128)"},{"line_number":1715,"context_line":"        except socket.timeout:"},{"line_number":1716,"context_line":"            result \u003d b\u0027timeout\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"1c3ed6a1_08f71be0","line":1713,"range":{"start_line":1713,"start_character":17,"end_line":1713,"end_character":23},"updated":"2022-09-15 10:27:34.000000000","message":"This function returns the number of bytes written doesn\u0027t it?\n\nShould we be using `sendall` instead to ensure we write the whole payload?","commit_id":"113fa08a84635d855503776b5c3ae4c0d96cb59a"},{"author":{"_account_id":1004460,"name":"James Lee","email":"james.lee@couchbase.com","username":"jamesl33","avatars":[{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"be5f0df0048daace0a82f704041057d8c5f06b69","unresolved":false,"context_lines":[{"line_number":1710,"context_line":"        try:"},{"line_number":1711,"context_line":"            sock.settimeout(5)"},{"line_number":1712,"context_line":"            addr \u003d \"::1\" if afamily \u003d\u003d socket.AF_INET6 else \"127.0.0.1\""},{"line_number":1713,"context_line":"            sock.sendto(password.encode(\u0027utf-8\u0027), (addr, port))"},{"line_number":1714,"context_line":"            (result, _) \u003d sock.recvfrom(128)"},{"line_number":1715,"context_line":"        except socket.timeout:"},{"line_number":1716,"context_line":"            result \u003d b\u0027timeout\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"7912a217_6b925145","line":1713,"range":{"start_line":1713,"start_character":17,"end_line":1713,"end_character":23},"in_reply_to":"10261af6_755c2a90","updated":"2022-09-16 08:14:05.000000000","message":"Roger, as long as we\u0027re happy that it\u0027ll not send partial data, I\u0027m fine with it as is 👍","commit_id":"113fa08a84635d855503776b5c3ae4c0d96cb59a"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"74223d717744ce70deb98bd2d7ee23e15bcfd956","unresolved":false,"context_lines":[{"line_number":1710,"context_line":"        try:"},{"line_number":1711,"context_line":"            sock.settimeout(5)"},{"line_number":1712,"context_line":"            addr \u003d \"::1\" if afamily \u003d\u003d socket.AF_INET6 else \"127.0.0.1\""},{"line_number":1713,"context_line":"            sock.sendto(password.encode(\u0027utf-8\u0027), (addr, port))"},{"line_number":1714,"context_line":"            (result, _) \u003d sock.recvfrom(128)"},{"line_number":1715,"context_line":"        except socket.timeout:"},{"line_number":1716,"context_line":"            result \u003d b\u0027timeout\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"10261af6_755c2a90","line":1713,"range":{"start_line":1713,"start_character":17,"end_line":1713,"end_character":23},"in_reply_to":"1c3ed6a1_08f71be0","updated":"2022-09-15 23:17:18.000000000","message":"I think sendall expects a socket to be connected to remote addr while our socket is not connected (it\u0027s UDP).\nI don\u0027t really think it can send part of datagram over UDP to be honest.","commit_id":"113fa08a84635d855503776b5c3ae4c0d96cb59a"},{"author":{"_account_id":1004460,"name":"James Lee","email":"james.lee@couchbase.com","username":"jamesl33","avatars":[{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ddb4ddb0de29019b3e21babce06c5863330ed919","unresolved":true,"context_lines":[{"line_number":1712,"context_line":"            addr \u003d \"::1\" if afamily \u003d\u003d socket.AF_INET6 else \"127.0.0.1\""},{"line_number":1713,"context_line":"            sock.sendto(password.encode(\u0027utf-8\u0027), (addr, port))"},{"line_number":1714,"context_line":"            (result, _) \u003d sock.recvfrom(128)"},{"line_number":1715,"context_line":"        except socket.timeout:"},{"line_number":1716,"context_line":"            result \u003d b\u0027timeout\u0027"},{"line_number":1717,"context_line":"        finally:"},{"line_number":1718,"context_line":"            sock.close()"},{"line_number":1719,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"636a9e14_95c3a9e9","line":1716,"range":{"start_line":1715,"start_character":7,"end_line":1716,"end_character":31},"updated":"2022-09-15 10:27:34.000000000","message":"super nit: feels odd to catch this, to then handle it in the if/else blocks below (only reason I see is so the socket is closed in finally). IMO would be better to catch and handle here, rather than deferring to later.\n\n(feel free to ignore)","commit_id":"113fa08a84635d855503776b5c3ae4c0d96cb59a"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"74223d717744ce70deb98bd2d7ee23e15bcfd956","unresolved":false,"context_lines":[{"line_number":1712,"context_line":"            addr \u003d \"::1\" if afamily \u003d\u003d socket.AF_INET6 else \"127.0.0.1\""},{"line_number":1713,"context_line":"            sock.sendto(password.encode(\u0027utf-8\u0027), (addr, port))"},{"line_number":1714,"context_line":"            (result, _) \u003d sock.recvfrom(128)"},{"line_number":1715,"context_line":"        except socket.timeout:"},{"line_number":1716,"context_line":"            result \u003d b\u0027timeout\u0027"},{"line_number":1717,"context_line":"        finally:"},{"line_number":1718,"context_line":"            sock.close()"},{"line_number":1719,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5e6c9e46_a9590969","line":1716,"range":{"start_line":1715,"start_character":7,"end_line":1716,"end_character":31},"in_reply_to":"636a9e14_95c3a9e9","updated":"2022-09-15 23:17:18.000000000","message":"I would prefer to leave it as is. Thanks","commit_id":"113fa08a84635d855503776b5c3ae4c0d96cb59a"},{"author":{"_account_id":1004460,"name":"James Lee","email":"james.lee@couchbase.com","username":"jamesl33","avatars":[{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ddb4ddb0de29019b3e21babce06c5863330ed919","unresolved":true,"context_lines":[{"line_number":1726,"context_line":"            _exit_if_errors([\"Timeout\"])"},{"line_number":1727,"context_line":"        elif result \u003d\u003d b\u0027auth_failure\u0027:"},{"line_number":1728,"context_line":"            _exit_if_errors([\"Incorrect password. Node shuts down.\"])"},{"line_number":1729,"context_line":"        else:"},{"line_number":1730,"context_line":"            _exit_if_errors([f\u0027Unknown error: {result}\u0027])"},{"line_number":1731,"context_line":""},{"line_number":1732,"context_line":"    def run_process(self, name, args, extra_env\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"91463205_6bbfa33d","line":1729,"range":{"start_line":1729,"start_character":8,"end_line":1729,"end_character":12},"updated":"2022-09-15 10:27:34.000000000","message":"nit: don\u0027t need this else, could just de-indent the last case\n\n(feel free to ignore)","commit_id":"113fa08a84635d855503776b5c3ae4c0d96cb59a"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"74223d717744ce70deb98bd2d7ee23e15bcfd956","unresolved":false,"context_lines":[{"line_number":1726,"context_line":"            _exit_if_errors([\"Timeout\"])"},{"line_number":1727,"context_line":"        elif result \u003d\u003d b\u0027auth_failure\u0027:"},{"line_number":1728,"context_line":"            _exit_if_errors([\"Incorrect password. Node shuts down.\"])"},{"line_number":1729,"context_line":"        else:"},{"line_number":1730,"context_line":"            _exit_if_errors([f\u0027Unknown error: {result}\u0027])"},{"line_number":1731,"context_line":""},{"line_number":1732,"context_line":"    def run_process(self, name, args, extra_env\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"d21581aa_4b92debc","line":1729,"range":{"start_line":1729,"start_character":8,"end_line":1729,"end_character":12},"in_reply_to":"91463205_6bbfa33d","updated":"2022-09-15 23:17:18.000000000","message":"It will not work in the case when there is no errors then. I would prefer to leave it as is if you don\u0027t mind. Thanks","commit_id":"113fa08a84635d855503776b5c3ae4c0d96cb59a"},{"author":{"_account_id":1004460,"name":"James Lee","email":"james.lee@couchbase.com","username":"jamesl33","avatars":[{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"be5f0df0048daace0a82f704041057d8c5f06b69","unresolved":false,"context_lines":[{"line_number":1726,"context_line":"            _exit_if_errors([\"Timeout\"])"},{"line_number":1727,"context_line":"        elif result \u003d\u003d b\u0027auth_failure\u0027:"},{"line_number":1728,"context_line":"            _exit_if_errors([\"Incorrect password. Node shuts down.\"])"},{"line_number":1729,"context_line":"        else:"},{"line_number":1730,"context_line":"            _exit_if_errors([f\u0027Unknown error: {result}\u0027])"},{"line_number":1731,"context_line":""},{"line_number":1732,"context_line":"    def run_process(self, name, args, extra_env\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"f8cac363_fbab1f1a","line":1729,"range":{"start_line":1729,"start_character":8,"end_line":1729,"end_character":12},"in_reply_to":"d21581aa_4b92debc","updated":"2022-09-16 08:14:05.000000000","message":"Is there a no errors case, wouldn\u0027t that hit the first branch, otherwise wouldn\u0027t we have a case that doesn\u0027t print anything to stdout?\n\n\u003e I would prefer to leave it as is if you don\u0027t mind. Thanks\n\nAbsolutely fine by me 👍","commit_id":"113fa08a84635d855503776b5c3ae4c0d96cb59a"}]}