)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1004460,"name":"James Lee","email":"james.lee@couchbase.com","username":"jamesl33","avatars":[{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"30dd29243ef8155c81b639d23df8d146a61c7a0e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e2bcfcca_2adf4778","updated":"2022-10-26 13:24:12.000000000","message":"Change looks good to me.\n\nI wonder whether we could offload this validation to validation to ns_server to avoid being hit by changes like this in the future.","commit_id":"aa5f25fc0b834c82361658f6a3581bf8ee65272e"},{"author":{"_account_id":1004460,"name":"James Lee","email":"james.lee@couchbase.com","username":"jamesl33","avatars":[{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"8f7056c4c07f31a68305b40866f30275abd77d0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d06d7e0d_a4dabac7","updated":"2022-10-27 09:59:16.000000000","message":"Looks like we probably need to remove a failing test-case.","commit_id":"d10e07e5f3864522a09f0f73c4337e194504bdda"},{"author":{"_account_id":1004460,"name":"James Lee","email":"james.lee@couchbase.com","username":"jamesl33","avatars":[{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"a7644e716616acf3e4fe50332e15ad111d31e6f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"68918130_529ff0f9","in_reply_to":"7239d0ef_34be7f14","updated":"2022-10-27 12:01:15.000000000","message":"Roger, will create an MB for that. Thanks Peter 👍","commit_id":"d10e07e5f3864522a09f0f73c4337e194504bdda"},{"author":{"_account_id":1005031,"name":"Peter Searby","email":"peter.searby@couchbase.com","username":"Peter-Searby","avatars":[{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"6fee62c7afeee0f8200e1eac000aa0a850d902c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7239d0ef_34be7f14","in_reply_to":"a716ce88_2b4a017f","updated":"2022-10-27 11:20:23.000000000","message":"\u0027make test\u0027 doesn\u0027t work on my machine, seems to be an M1 problem","commit_id":"d10e07e5f3864522a09f0f73c4337e194504bdda"},{"author":{"_account_id":1004460,"name":"James Lee","email":"james.lee@couchbase.com","username":"jamesl33","avatars":[{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4a6410a8b7f03fd87f442c2646655b3f19db352c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a716ce88_2b4a017f","in_reply_to":"d06d7e0d_a4dabac7","updated":"2022-10-27 10:00:39.000000000","message":"https://github.com/couchbase/couchbase-cli/blob/d449f00d7f43f1c8eb69d90ef74ae1689edd3fb3/test/test_cli.py#L1356-L1357\n\nYou should be able to just remove that test.\n\nThe tests can be run locally using \u0027make test\u0027 providing you have \u0027pipenv\u0027 installed.","commit_id":"d10e07e5f3864522a09f0f73c4337e194504bdda"}],"cbmgr.py":[{"author":{"_account_id":1004460,"name":"James Lee","email":"james.lee@couchbase.com","username":"jamesl33","avatars":[{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"30dd29243ef8155c81b639d23df8d146a61c7a0e","unresolved":true,"context_lines":[{"line_number":3229,"context_line":"            default\u003dNone,"},{"line_number":3230,"context_line":"            help\u003d\"Set cluster encryption level, only used when cluster encryption enabled.\")"},{"line_number":3231,"context_line":"        group.add_argument(\u0027--tls-min-version\u0027, dest\u003d\u0027tls_min_version\u0027, metavar\u003d\u0027\u003ctlsv1|tlsv1.1|tlsv1.2|tlsv1.3\u003e\u0027,"},{"line_number":3232,"context_line":"                           choices\u003d[\u0027tlsv1\u0027, \u0027tlsv1.1\u0027, \u0027tlsv1.2\u0027, \u0027tlsv1.3\u0027], default\u003dNone, help\u003d\u0027Set the minimum TLS version\u0027)"},{"line_number":3233,"context_line":"        group.add_argument(\u0027--tls-honor-cipher-order\u0027, dest\u003d\u0027tls_honor_cipher_order\u0027, metavar\u003d\u0027\u003c1|0\u003e\u0027,"},{"line_number":3234,"context_line":"                           choices\u003d[\u00271\u0027, \u00270\u0027], help\u003d\u0027Specify or not the cipher order has to be followed.\u0027, default\u003dNone)"},{"line_number":3235,"context_line":"        group.add_argument(\u0027--cipher-suites\u0027, metavar\u003d\u0027\u003cciphers\u003e\u0027, default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"de55c6a9_5a30d4e7","line":3232,"range":{"start_line":3232,"start_character":27,"end_line":3232,"end_character":77},"updated":"2022-10-26 13:24:12.000000000","message":"What\u0027s the validation like in \u0027ns_server\u0027, will it return an informative error if the user supplies invalid input?","commit_id":"aa5f25fc0b834c82361658f6a3581bf8ee65272e"},{"author":{"_account_id":1004460,"name":"James Lee","email":"james.lee@couchbase.com","username":"jamesl33","avatars":[{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"8f7056c4c07f31a68305b40866f30275abd77d0a","unresolved":false,"context_lines":[{"line_number":3229,"context_line":"            default\u003dNone,"},{"line_number":3230,"context_line":"            help\u003d\"Set cluster encryption level, only used when cluster encryption enabled.\")"},{"line_number":3231,"context_line":"        group.add_argument(\u0027--tls-min-version\u0027, dest\u003d\u0027tls_min_version\u0027, metavar\u003d\u0027\u003ctlsv1|tlsv1.1|tlsv1.2|tlsv1.3\u003e\u0027,"},{"line_number":3232,"context_line":"                           choices\u003d[\u0027tlsv1\u0027, \u0027tlsv1.1\u0027, \u0027tlsv1.2\u0027, \u0027tlsv1.3\u0027], default\u003dNone, help\u003d\u0027Set the minimum TLS version\u0027)"},{"line_number":3233,"context_line":"        group.add_argument(\u0027--tls-honor-cipher-order\u0027, dest\u003d\u0027tls_honor_cipher_order\u0027, metavar\u003d\u0027\u003c1|0\u003e\u0027,"},{"line_number":3234,"context_line":"                           choices\u003d[\u00271\u0027, \u00270\u0027], help\u003d\u0027Specify or not the cipher order has to be followed.\u0027, default\u003dNone)"},{"line_number":3235,"context_line":"        group.add_argument(\u0027--cipher-suites\u0027, metavar\u003d\u0027\u003cciphers\u003e\u0027, default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"2dc1342c_69b490b8","line":3232,"range":{"start_line":3232,"start_character":27,"end_line":3232,"end_character":77},"in_reply_to":"720a625b_6fd04aab","updated":"2022-10-27 09:59:16.000000000","message":"Perfect, thanks Peter 👍","commit_id":"aa5f25fc0b834c82361658f6a3581bf8ee65272e"},{"author":{"_account_id":1004460,"name":"James Lee","email":"james.lee@couchbase.com","username":"jamesl33","avatars":[{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"5b16acec95e8e7e875d1b7f16e8c776e5c6f65c3","unresolved":false,"context_lines":[{"line_number":3229,"context_line":"            default\u003dNone,"},{"line_number":3230,"context_line":"            help\u003d\"Set cluster encryption level, only used when cluster encryption enabled.\")"},{"line_number":3231,"context_line":"        group.add_argument(\u0027--tls-min-version\u0027, dest\u003d\u0027tls_min_version\u0027, metavar\u003d\u0027\u003ctlsv1|tlsv1.1|tlsv1.2|tlsv1.3\u003e\u0027,"},{"line_number":3232,"context_line":"                           choices\u003d[\u0027tlsv1\u0027, \u0027tlsv1.1\u0027, \u0027tlsv1.2\u0027, \u0027tlsv1.3\u0027], default\u003dNone, help\u003d\u0027Set the minimum TLS version\u0027)"},{"line_number":3233,"context_line":"        group.add_argument(\u0027--tls-honor-cipher-order\u0027, dest\u003d\u0027tls_honor_cipher_order\u0027, metavar\u003d\u0027\u003c1|0\u003e\u0027,"},{"line_number":3234,"context_line":"                           choices\u003d[\u00271\u0027, \u00270\u0027], help\u003d\u0027Specify or not the cipher order has to be followed.\u0027, default\u003dNone)"},{"line_number":3235,"context_line":"        group.add_argument(\u0027--cipher-suites\u0027, metavar\u003d\u0027\u003cciphers\u003e\u0027, default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"d872ff9d_2db8cce1","line":3232,"range":{"start_line":3232,"start_character":27,"end_line":3232,"end_character":77},"in_reply_to":"834519b1_8bbef1b2","updated":"2022-10-26 15:26:42.000000000","message":"That looks pretty good to me, I think we should fall back to ns_server validation. We should remove the choices and just allow users to supply any string (and defer to ns_server validation).","commit_id":"aa5f25fc0b834c82361658f6a3581bf8ee65272e"},{"author":{"_account_id":1005031,"name":"Peter Searby","email":"peter.searby@couchbase.com","username":"Peter-Searby","avatars":[{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"92d6523d2b77b14840e51eafd2833ce9a08f3ad4","unresolved":false,"context_lines":[{"line_number":3229,"context_line":"            default\u003dNone,"},{"line_number":3230,"context_line":"            help\u003d\"Set cluster encryption level, only used when cluster encryption enabled.\")"},{"line_number":3231,"context_line":"        group.add_argument(\u0027--tls-min-version\u0027, dest\u003d\u0027tls_min_version\u0027, metavar\u003d\u0027\u003ctlsv1|tlsv1.1|tlsv1.2|tlsv1.3\u003e\u0027,"},{"line_number":3232,"context_line":"                           choices\u003d[\u0027tlsv1\u0027, \u0027tlsv1.1\u0027, \u0027tlsv1.2\u0027, \u0027tlsv1.3\u0027], default\u003dNone, help\u003d\u0027Set the minimum TLS version\u0027)"},{"line_number":3233,"context_line":"        group.add_argument(\u0027--tls-honor-cipher-order\u0027, dest\u003d\u0027tls_honor_cipher_order\u0027, metavar\u003d\u0027\u003c1|0\u003e\u0027,"},{"line_number":3234,"context_line":"                           choices\u003d[\u00271\u0027, \u00270\u0027], help\u003d\u0027Specify or not the cipher order has to be followed.\u0027, default\u003dNone)"},{"line_number":3235,"context_line":"        group.add_argument(\u0027--cipher-suites\u0027, metavar\u003d\u0027\u003cciphers\u003e\u0027, default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"720a625b_6fd04aab","line":3232,"range":{"start_line":3232,"start_character":27,"end_line":3232,"end_character":77},"in_reply_to":"d872ff9d_2db8cce1","updated":"2022-10-27 09:48:00.000000000","message":"I\u0027ve removed the metavar and choices args, so it now falls back to ns_server validation, giving:\n`ERROR: tlsMinVersion - Supported TLS versions are tlsv1, tlsv1.1, tlsv1.2, tlsv1.3`","commit_id":"aa5f25fc0b834c82361658f6a3581bf8ee65272e"},{"author":{"_account_id":1005031,"name":"Peter Searby","email":"peter.searby@couchbase.com","username":"Peter-Searby","avatars":[{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"94c7265c5ac3f7854d22cb4f70db7c2ef1c871ac","unresolved":false,"context_lines":[{"line_number":3229,"context_line":"            default\u003dNone,"},{"line_number":3230,"context_line":"            help\u003d\"Set cluster encryption level, only used when cluster encryption enabled.\")"},{"line_number":3231,"context_line":"        group.add_argument(\u0027--tls-min-version\u0027, dest\u003d\u0027tls_min_version\u0027, metavar\u003d\u0027\u003ctlsv1|tlsv1.1|tlsv1.2|tlsv1.3\u003e\u0027,"},{"line_number":3232,"context_line":"                           choices\u003d[\u0027tlsv1\u0027, \u0027tlsv1.1\u0027, \u0027tlsv1.2\u0027, \u0027tlsv1.3\u0027], default\u003dNone, help\u003d\u0027Set the minimum TLS version\u0027)"},{"line_number":3233,"context_line":"        group.add_argument(\u0027--tls-honor-cipher-order\u0027, dest\u003d\u0027tls_honor_cipher_order\u0027, metavar\u003d\u0027\u003c1|0\u003e\u0027,"},{"line_number":3234,"context_line":"                           choices\u003d[\u00271\u0027, \u00270\u0027], help\u003d\u0027Specify or not the cipher order has to be followed.\u0027, default\u003dNone)"},{"line_number":3235,"context_line":"        group.add_argument(\u0027--cipher-suites\u0027, metavar\u003d\u0027\u003cciphers\u003e\u0027, default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"834519b1_8bbef1b2","line":3232,"range":{"start_line":3232,"start_character":27,"end_line":3232,"end_character":77},"in_reply_to":"de55c6a9_5a30d4e7","updated":"2022-10-26 14:36:22.000000000","message":"An invalid input yields {\"errors\":[\"tlsMinVersion - Supported TLS versions are tlsv1, tlsv1.1, tlsv1.2, tlsv1.3\"]}\n\nSeems pretty informative to me.","commit_id":"aa5f25fc0b834c82361658f6a3581bf8ee65272e"}]}