)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1004460,"name":"James Lee","email":"james.lee@couchbase.com","username":"jamesl33","avatars":[{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"5512fa589de9e508d7e5a5e22535b405695aa344","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Maksimiljans Januska \u003cmaks.januska@couchbase.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-02-28 14:57:45 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"MB-55692 Add support for editing collections history field"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I601f493f46b858f7f316ed8d9353682205667a1f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"cf524736_c823117c","line":7,"range":{"start_line":7,"start_character":25,"end_line":7,"end_character":44},"updated":"2023-02-28 15:36:53.000000000","message":"Do we need to support this at the scope level as well?","commit_id":"c32ccf256a6d9f22c9ff19efa9eee74a034a709b"},{"author":{"_account_id":1004460,"name":"James Lee","email":"james.lee@couchbase.com","username":"jamesl33","avatars":[{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"70b3b1556e4d426bda2d0d001f5823b7b6f70003","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Maksimiljans Januska \u003cmaks.januska@couchbase.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-02-28 14:57:45 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"MB-55692 Add support for editing collections history field"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I601f493f46b858f7f316ed8d9353682205667a1f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"a893ae39_ea3daa89","line":7,"range":{"start_line":7,"start_character":25,"end_line":7,"end_character":44},"in_reply_to":"74327938_61181607","updated":"2023-02-28 15:44:17.000000000","message":"Perfect, thanks for checking.","commit_id":"c32ccf256a6d9f22c9ff19efa9eee74a034a709b"},{"author":{"_account_id":1004855,"name":"Maksimiljans Januska","email":"maks.januska@couchbase.com","username":"yonsken","avatars":[{"url":"https://www.gravatar.com/avatar/07220ab1da1bfeb73dd92237147f9882.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/07220ab1da1bfeb73dd92237147f9882.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/07220ab1da1bfeb73dd92237147f9882.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/07220ab1da1bfeb73dd92237147f9882.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"fe5d08c2bbdff96e08d95c01cded745df3d7e1ce","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Maksimiljans Januska \u003cmaks.januska@couchbase.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-02-28 14:57:45 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"MB-55692 Add support for editing collections history field"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I601f493f46b858f7f316ed8d9353682205667a1f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"74327938_61181607","line":7,"range":{"start_line":7,"start_character":25,"end_line":7,"end_character":44},"in_reply_to":"cf524736_c823117c","updated":"2023-02-28 15:42:45.000000000","message":"The \"history\" field is collection-level only:\n{\n    \"scopes\": [\n        {\n            \"collections\": [\n                {\n                    \"history\": false,\n                    \"maxTTL\": 0,\n                    \"name\": \"test_collection2\",\n                    \"uid\": \"9\"\n                },\n                {\n                    \"history\": false,\n                    \"maxTTL\": 0,\n                    \"name\": \"test_collection\",\n                    \"uid\": \"8\"\n                }\n            ],\n            \"name\": \"test_scope\",\n            \"uid\": \"8\"\n        },\n        {\n            \"collections\": [\n                {\n                    \"history\": false,\n                    \"maxTTL\": 0,\n                    \"name\": \"_default\",\n                    \"uid\": \"0\"\n                }\n            ],\n            \"name\": \"_default\",\n            \"uid\": \"0\"\n        }\n    ],\n    \"uid\": \"e\"\n}\n\nSo no need to add support for scopes, unless I am misunderstanding your question!","commit_id":"c32ccf256a6d9f22c9ff19efa9eee74a034a709b"}],"cbmgr.py":[{"author":{"_account_id":1004460,"name":"James Lee","email":"james.lee@couchbase.com","username":"jamesl33","avatars":[{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"acacbc70b019d987d9024cdf4360b2667fd00b4d","unresolved":true,"context_lines":[{"line_number":4755,"context_line":""},{"line_number":4756,"context_line":"        if opts.edit_collection is not None and opts.enable_history is None:"},{"line_number":4757,"context_line":"            _exit_if_errors([\"--enable-history-retention should be set with --edit-collection\"])"},{"line_number":4758,"context_line":"        if opts.edit_collection is not None and opts.max_ttl is not None:"},{"line_number":4759,"context_line":"            _exit_if_errors([\"--max-ttl cannot be set with --edit-collection\"])"},{"line_number":4760,"context_line":""},{"line_number":4761,"context_line":"        if opts.create_scope:"},{"line_number":4762,"context_line":"            self._create_scope(opts)"}],"source_content_type":"text/x-python","patch_set":6,"id":"c723de0e_b253d711","line":4759,"range":{"start_line":4758,"start_character":8,"end_line":4759,"end_character":79},"updated":"2023-02-28 11:55:12.000000000","message":"Are there any other parameters we should be ignoring/erroring out for here?\n\nI don\u0027t think we generally do a very good job of disallowing things that shouldn\u0027t be supplied in conjunction","commit_id":"09aa7103b8f781301638133233945e93a477f344"},{"author":{"_account_id":1004855,"name":"Maksimiljans Januska","email":"maks.januska@couchbase.com","username":"yonsken","avatars":[{"url":"https://www.gravatar.com/avatar/07220ab1da1bfeb73dd92237147f9882.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/07220ab1da1bfeb73dd92237147f9882.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/07220ab1da1bfeb73dd92237147f9882.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/07220ab1da1bfeb73dd92237147f9882.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b3cce4b83aaf576d05265362085d2ffc65d70e99","unresolved":true,"context_lines":[{"line_number":4755,"context_line":""},{"line_number":4756,"context_line":"        if opts.edit_collection is not None and opts.enable_history is None:"},{"line_number":4757,"context_line":"            _exit_if_errors([\"--enable-history-retention should be set with --edit-collection\"])"},{"line_number":4758,"context_line":"        if opts.edit_collection is not None and opts.max_ttl is not None:"},{"line_number":4759,"context_line":"            _exit_if_errors([\"--max-ttl cannot be set with --edit-collection\"])"},{"line_number":4760,"context_line":""},{"line_number":4761,"context_line":"        if opts.create_scope:"},{"line_number":4762,"context_line":"            self._create_scope(opts)"}],"source_content_type":"text/x-python","patch_set":6,"id":"d35199b1_62282e6d","line":4759,"range":{"start_line":4758,"start_character":8,"end_line":4759,"end_character":79},"in_reply_to":"c723de0e_b253d711","updated":"2023-02-28 12:09:11.000000000","message":"Nope, --enable-history-retention and --max-ttl are the only flags that don\u0027t correspond to sub-commands. These checks are sufficient (although not nice looking) as we make sure that only one sub-command flag is provided on line 4746.","commit_id":"09aa7103b8f781301638133233945e93a477f344"},{"author":{"_account_id":1004460,"name":"James Lee","email":"james.lee@couchbase.com","username":"jamesl33","avatars":[{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"d7509d525d9d1e56ee53cce419669dfa8217ea7f","unresolved":false,"context_lines":[{"line_number":4755,"context_line":""},{"line_number":4756,"context_line":"        if opts.edit_collection is not None and opts.enable_history is None:"},{"line_number":4757,"context_line":"            _exit_if_errors([\"--enable-history-retention should be set with --edit-collection\"])"},{"line_number":4758,"context_line":"        if opts.edit_collection is not None and opts.max_ttl is not None:"},{"line_number":4759,"context_line":"            _exit_if_errors([\"--max-ttl cannot be set with --edit-collection\"])"},{"line_number":4760,"context_line":""},{"line_number":4761,"context_line":"        if opts.create_scope:"},{"line_number":4762,"context_line":"            self._create_scope(opts)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7eb16dc4_fd2f622f","line":4759,"range":{"start_line":4758,"start_character":8,"end_line":4759,"end_character":79},"in_reply_to":"d35199b1_62282e6d","updated":"2023-02-28 13:27:25.000000000","message":"Ack","commit_id":"09aa7103b8f781301638133233945e93a477f344"}],"cluster_manager.py":[{"author":{"_account_id":1004460,"name":"James Lee","email":"james.lee@couchbase.com","username":"jamesl33","avatars":[{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"acacbc70b019d987d9024cdf4360b2667fd00b4d","unresolved":true,"context_lines":[{"line_number":2233,"context_line":""},{"line_number":2234,"context_line":"        return self._post_form_encoded(url, params)"},{"line_number":2235,"context_line":""},{"line_number":2236,"context_line":"    def edit_collection(self, bucket, scope, collection, enable_history):"},{"line_number":2237,"context_line":"        url \u003d f\u0027{self.hostname}/pools/default/buckets/{urllib.parse.quote_plus(bucket)}/scopes/\u0027 \\"},{"line_number":2238,"context_line":"            f\u0027{urllib.parse.quote_plus(scope)}/collections/{urllib.parse.quote_plus(collection)}\u0027"},{"line_number":2239,"context_line":"        params \u003d {}"},{"line_number":2240,"context_line":"        if enable_history:"},{"line_number":2241,"context_line":"            params[\"history\"] \u003d one_zero_boolean_to_string(enable_history)"},{"line_number":2242,"context_line":""},{"line_number":2243,"context_line":"        return self._patch_form_encoded(url, params)"},{"line_number":2244,"context_line":""},{"line_number":2245,"context_line":"    def drop_collection(self, bucket, scope, collection):"},{"line_number":2246,"context_line":"        url \u003d f\u0027{self.hostname}/pools/default/buckets/{urllib.parse.quote_plus(bucket)}/scopes/\u0027 \\"}],"source_content_type":"text/x-python","patch_set":6,"id":"1834dafb_3a45d3f9","line":2243,"range":{"start_line":2236,"start_character":4,"end_line":2243,"end_character":52},"updated":"2023-02-28 11:55:12.000000000","message":"What happens if nothing is changed, will this error out?","commit_id":"09aa7103b8f781301638133233945e93a477f344"},{"author":{"_account_id":1004855,"name":"Maksimiljans Januska","email":"maks.januska@couchbase.com","username":"yonsken","avatars":[{"url":"https://www.gravatar.com/avatar/07220ab1da1bfeb73dd92237147f9882.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/07220ab1da1bfeb73dd92237147f9882.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/07220ab1da1bfeb73dd92237147f9882.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/07220ab1da1bfeb73dd92237147f9882.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b3cce4b83aaf576d05265362085d2ffc65d70e99","unresolved":true,"context_lines":[{"line_number":2233,"context_line":""},{"line_number":2234,"context_line":"        return self._post_form_encoded(url, params)"},{"line_number":2235,"context_line":""},{"line_number":2236,"context_line":"    def edit_collection(self, bucket, scope, collection, enable_history):"},{"line_number":2237,"context_line":"        url \u003d f\u0027{self.hostname}/pools/default/buckets/{urllib.parse.quote_plus(bucket)}/scopes/\u0027 \\"},{"line_number":2238,"context_line":"            f\u0027{urllib.parse.quote_plus(scope)}/collections/{urllib.parse.quote_plus(collection)}\u0027"},{"line_number":2239,"context_line":"        params \u003d {}"},{"line_number":2240,"context_line":"        if enable_history:"},{"line_number":2241,"context_line":"            params[\"history\"] \u003d one_zero_boolean_to_string(enable_history)"},{"line_number":2242,"context_line":""},{"line_number":2243,"context_line":"        return self._patch_form_encoded(url, params)"},{"line_number":2244,"context_line":""},{"line_number":2245,"context_line":"    def drop_collection(self, bucket, scope, collection):"},{"line_number":2246,"context_line":"        url \u003d f\u0027{self.hostname}/pools/default/buckets/{urllib.parse.quote_plus(bucket)}/scopes/\u0027 \\"}],"source_content_type":"text/x-python","patch_set":6,"id":"89415a9d_9910f549","line":2243,"range":{"start_line":2236,"start_character":4,"end_line":2243,"end_character":52},"in_reply_to":"1834dafb_3a45d3f9","updated":"2023-02-28 12:09:11.000000000","message":"Nope, it will be a 200 code (I think) no-op.","commit_id":"09aa7103b8f781301638133233945e93a477f344"},{"author":{"_account_id":1004855,"name":"Maksimiljans Januska","email":"maks.januska@couchbase.com","username":"yonsken","avatars":[{"url":"https://www.gravatar.com/avatar/07220ab1da1bfeb73dd92237147f9882.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/07220ab1da1bfeb73dd92237147f9882.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/07220ab1da1bfeb73dd92237147f9882.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/07220ab1da1bfeb73dd92237147f9882.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"2edab658af6316ecb3a21b9a3e22cf4927883a5e","unresolved":false,"context_lines":[{"line_number":2233,"context_line":""},{"line_number":2234,"context_line":"        return self._post_form_encoded(url, params)"},{"line_number":2235,"context_line":""},{"line_number":2236,"context_line":"    def edit_collection(self, bucket, scope, collection, enable_history):"},{"line_number":2237,"context_line":"        url \u003d f\u0027{self.hostname}/pools/default/buckets/{urllib.parse.quote_plus(bucket)}/scopes/\u0027 \\"},{"line_number":2238,"context_line":"            f\u0027{urllib.parse.quote_plus(scope)}/collections/{urllib.parse.quote_plus(collection)}\u0027"},{"line_number":2239,"context_line":"        params \u003d {}"},{"line_number":2240,"context_line":"        if enable_history:"},{"line_number":2241,"context_line":"            params[\"history\"] \u003d one_zero_boolean_to_string(enable_history)"},{"line_number":2242,"context_line":""},{"line_number":2243,"context_line":"        return self._patch_form_encoded(url, params)"},{"line_number":2244,"context_line":""},{"line_number":2245,"context_line":"    def drop_collection(self, bucket, scope, collection):"},{"line_number":2246,"context_line":"        url \u003d f\u0027{self.hostname}/pools/default/buckets/{urllib.parse.quote_plus(bucket)}/scopes/\u0027 \\"}],"source_content_type":"text/x-python","patch_set":6,"id":"4cc85735_68415df7","line":2243,"range":{"start_line":2236,"start_character":4,"end_line":2243,"end_character":52},"in_reply_to":"733ce8cf_6e59f7cf","updated":"2023-02-28 14:58:30.000000000","message":"Done, idempotent as expected.","commit_id":"09aa7103b8f781301638133233945e93a477f344"},{"author":{"_account_id":1004460,"name":"James Lee","email":"james.lee@couchbase.com","username":"jamesl33","avatars":[{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"d7509d525d9d1e56ee53cce419669dfa8217ea7f","unresolved":true,"context_lines":[{"line_number":2233,"context_line":""},{"line_number":2234,"context_line":"        return self._post_form_encoded(url, params)"},{"line_number":2235,"context_line":""},{"line_number":2236,"context_line":"    def edit_collection(self, bucket, scope, collection, enable_history):"},{"line_number":2237,"context_line":"        url \u003d f\u0027{self.hostname}/pools/default/buckets/{urllib.parse.quote_plus(bucket)}/scopes/\u0027 \\"},{"line_number":2238,"context_line":"            f\u0027{urllib.parse.quote_plus(scope)}/collections/{urllib.parse.quote_plus(collection)}\u0027"},{"line_number":2239,"context_line":"        params \u003d {}"},{"line_number":2240,"context_line":"        if enable_history:"},{"line_number":2241,"context_line":"            params[\"history\"] \u003d one_zero_boolean_to_string(enable_history)"},{"line_number":2242,"context_line":""},{"line_number":2243,"context_line":"        return self._patch_form_encoded(url, params)"},{"line_number":2244,"context_line":""},{"line_number":2245,"context_line":"    def drop_collection(self, bucket, scope, collection):"},{"line_number":2246,"context_line":"        url \u003d f\u0027{self.hostname}/pools/default/buckets/{urllib.parse.quote_plus(bucket)}/scopes/\u0027 \\"}],"source_content_type":"text/x-python","patch_set":6,"id":"733ce8cf_6e59f7cf","line":2243,"range":{"start_line":2236,"start_character":4,"end_line":2243,"end_character":52},"in_reply_to":"89415a9d_9910f549","updated":"2023-02-28 13:27:25.000000000","message":"Please could you confirm the endpoint is idempotent before you merge.","commit_id":"09aa7103b8f781301638133233945e93a477f344"}],"test/test_cli.py":[{"author":{"_account_id":1004460,"name":"James Lee","email":"james.lee@couchbase.com","username":"jamesl33","avatars":[{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"d7509d525d9d1e56ee53cce419669dfa8217ea7f","unresolved":true,"context_lines":[{"line_number":2744,"context_line":"        self.rest_parameter_match(expected_params)"},{"line_number":2745,"context_line":""},{"line_number":2746,"context_line":"    def test_edit_collection(self):"},{"line_number":2747,"context_line":"        self.no_error_run(self.command + [\u0027--edit-collection\u0027, \u0027scope_1.collection_1\u0027, \u0027--enable-history-retention\u0027,"},{"line_number":2748,"context_line":"                                          \u00271\u0027], self.server_args)"},{"line_number":2749,"context_line":"        self.assertIn(\u0027PATCH:/pools/default/buckets/name/scopes/scope_1/collections/collection_1\u0027, self.server.trace)"},{"line_number":2750,"context_line":"        expected_params \u003d [\u0027history\u003dtrue\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"44980808_58da9570","line":2747,"updated":"2023-02-28 13:27:25.000000000","message":"Could we add tests for the flag validation as well","commit_id":"09aa7103b8f781301638133233945e93a477f344"},{"author":{"_account_id":1004855,"name":"Maksimiljans Januska","email":"maks.januska@couchbase.com","username":"yonsken","avatars":[{"url":"https://www.gravatar.com/avatar/07220ab1da1bfeb73dd92237147f9882.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/07220ab1da1bfeb73dd92237147f9882.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/07220ab1da1bfeb73dd92237147f9882.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/07220ab1da1bfeb73dd92237147f9882.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"2edab658af6316ecb3a21b9a3e22cf4927883a5e","unresolved":false,"context_lines":[{"line_number":2744,"context_line":"        self.rest_parameter_match(expected_params)"},{"line_number":2745,"context_line":""},{"line_number":2746,"context_line":"    def test_edit_collection(self):"},{"line_number":2747,"context_line":"        self.no_error_run(self.command + [\u0027--edit-collection\u0027, \u0027scope_1.collection_1\u0027, \u0027--enable-history-retention\u0027,"},{"line_number":2748,"context_line":"                                          \u00271\u0027], self.server_args)"},{"line_number":2749,"context_line":"        self.assertIn(\u0027PATCH:/pools/default/buckets/name/scopes/scope_1/collections/collection_1\u0027, self.server.trace)"},{"line_number":2750,"context_line":"        expected_params \u003d [\u0027history\u003dtrue\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"e5641b53_044e5604","line":2747,"in_reply_to":"44980808_58da9570","updated":"2023-02-28 14:58:30.000000000","message":"Done, added tests for all flag checks for completeness.","commit_id":"09aa7103b8f781301638133233945e93a477f344"}]}