)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1004879,"name":"Matt Hall","email":"matthew@quickbeam.me.uk","username":"mattyhall","avatars":[{"url":"https://www.gravatar.com/avatar/53d1d84f1bfdafc6399d56cba3efbe08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/53d1d84f1bfdafc6399d56cba3efbe08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/53d1d84f1bfdafc6399d56cba3efbe08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/53d1d84f1bfdafc6399d56cba3efbe08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b4bc965fb43541756e1dc3ec620d66e744195333","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e8680f8a_41fe9d6a","updated":"2023-03-27 10:32:03.000000000","message":"Change looks safe - could we write a unit test? ","commit_id":"bdc9290bca2495927c91c6130f0d203e8b4b417b"},{"author":{"_account_id":1004855,"name":"Maksimiljans Januska","email":"maks.januska@couchbase.com","username":"yonsken","avatars":[{"url":"https://www.gravatar.com/avatar/07220ab1da1bfeb73dd92237147f9882.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/07220ab1da1bfeb73dd92237147f9882.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/07220ab1da1bfeb73dd92237147f9882.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/07220ab1da1bfeb73dd92237147f9882.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ec3cd6b33f1a2c617cc38789b7d1b1ecb9989ccb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e0979903_96df36c8","in_reply_to":"c2796508_610a437d","updated":"2023-03-29 10:54:35.000000000","message":"Done","commit_id":"bdc9290bca2495927c91c6130f0d203e8b4b417b"},{"author":{"_account_id":1004460,"name":"James Lee","email":"james.lee@couchbase.com","username":"jamesl33","avatars":[{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"1a94bc706aa734ec48c087367c4d850e3921529a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c2796508_610a437d","in_reply_to":"e8680f8a_41fe9d6a","updated":"2023-03-28 10:52:45.000000000","message":"+1","commit_id":"bdc9290bca2495927c91c6130f0d203e8b4b417b"},{"author":{"_account_id":1004855,"name":"Maksimiljans Januska","email":"maks.januska@couchbase.com","username":"yonsken","avatars":[{"url":"https://www.gravatar.com/avatar/07220ab1da1bfeb73dd92237147f9882.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/07220ab1da1bfeb73dd92237147f9882.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/07220ab1da1bfeb73dd92237147f9882.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/07220ab1da1bfeb73dd92237147f9882.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"d467d8fa978d41a0c274d39225757a2819c5a4b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9ef63094_d6f4b372","updated":"2023-03-29 12:49:13.000000000","message":"check approval","commit_id":"804c37d37280e996686d9775b3e8aa84341ec2a5"}],"test/test_cli.py":[{"author":{"_account_id":1004460,"name":"James Lee","email":"james.lee@couchbase.com","username":"jamesl33","avatars":[{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52d2998b3f81f6ca2acd4a81886a9a35.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"dcf481368c0e2d87fb2f5528ed9c410e23709542","unresolved":true,"context_lines":[{"line_number":1236,"context_line":"        self.system_exit_run(self.command + self.cmd_args + self.EE_args, self.server_args)"},{"line_number":1237,"context_line":"        self.assertIn(\u0027can only be configured on enterprise edition\u0027, self.str_output)"},{"line_number":1238,"context_line":""},{"line_number":1239,"context_line":"    def test_setting_disk_issues_without_disk_period(self):"},{"line_number":1240,"context_line":"        self.EE_args \u003d [\u0027--enable-failover-on-data-disk-issues\u0027, \u00271\u0027]"},{"line_number":1241,"context_line":"        self.system_exit_run(self.command + self.cmd_args + self.EE_args, self.server_args)"},{"line_number":1242,"context_line":"        self.assertIn(\u0027--failover-data-disk-period must be set when auto-failover on Data Service disk is enabled\u0027, self.str_output)"},{"line_number":1243,"context_line":""},{"line_number":1244,"context_line":"    def test_setting_disk_issues_with_disk_period(self):"},{"line_number":1245,"context_line":"        self.EE_args \u003d [\u0027--enable-failover-on-data-disk-issues\u0027, \u00271\u0027, \u0027--failover-data-disk-period\u0027, \u002720\u0027]"},{"line_number":1246,"context_line":"        self.no_error_run(self.command + self.cmd_args + self.EE_args, self.server_args)"},{"line_number":1247,"context_line":"        expected_params \u003d [\u0027enabled\u003dtrue\u0027, \u0027timeout\u003d10\u0027, \u0027failoverOnDataDiskIssues%5Benabled%5D\u003dtrue\u0027,"},{"line_number":1248,"context_line":"                           \u0027failoverOnDataDiskIssues%5BtimePeriod%5D\u003d20\u0027]"},{"line_number":1249,"context_line":"        self.assertIn(\u0027POST:/settings/autoFailover\u0027, self.server.trace)"},{"line_number":1250,"context_line":"        self.rest_parameter_match(expected_params)"},{"line_number":1251,"context_line":""},{"line_number":1252,"context_line":""},{"line_number":1253,"context_line":"class TestSettingAutoreporovision(CommandTest):"}],"source_content_type":"text/x-python","patch_set":3,"id":"c77aaa7a_100bdb9f","line":1250,"range":{"start_line":1239,"start_character":0,"end_line":1250,"end_character":50},"updated":"2023-03-29 10:56:47.000000000","message":"Don\u0027t think we\u0027re testing the case from the MB here are we?\n\n\u003e Setting --enable-failover-on-data-disk-issues to 0 requires --failover-data-disk-period to be set as well\n\nWouldn\u0027t we need a test case which asserts than when setting to zero, it doesn\u0027t incorrectly request a period as well?","commit_id":"2922a719e5a77680f42e3be23b737a578eac2c7b"},{"author":{"_account_id":1004855,"name":"Maksimiljans Januska","email":"maks.januska@couchbase.com","username":"yonsken","avatars":[{"url":"https://www.gravatar.com/avatar/07220ab1da1bfeb73dd92237147f9882.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/07220ab1da1bfeb73dd92237147f9882.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/07220ab1da1bfeb73dd92237147f9882.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/07220ab1da1bfeb73dd92237147f9882.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"2b55e52ef38d76583a1e3c211096bea1bd294657","unresolved":false,"context_lines":[{"line_number":1236,"context_line":"        self.system_exit_run(self.command + self.cmd_args + self.EE_args, self.server_args)"},{"line_number":1237,"context_line":"        self.assertIn(\u0027can only be configured on enterprise edition\u0027, self.str_output)"},{"line_number":1238,"context_line":""},{"line_number":1239,"context_line":"    def test_setting_disk_issues_without_disk_period(self):"},{"line_number":1240,"context_line":"        self.EE_args \u003d [\u0027--enable-failover-on-data-disk-issues\u0027, \u00271\u0027]"},{"line_number":1241,"context_line":"        self.system_exit_run(self.command + self.cmd_args + self.EE_args, self.server_args)"},{"line_number":1242,"context_line":"        self.assertIn(\u0027--failover-data-disk-period must be set when auto-failover on Data Service disk is enabled\u0027, self.str_output)"},{"line_number":1243,"context_line":""},{"line_number":1244,"context_line":"    def test_setting_disk_issues_with_disk_period(self):"},{"line_number":1245,"context_line":"        self.EE_args \u003d [\u0027--enable-failover-on-data-disk-issues\u0027, \u00271\u0027, \u0027--failover-data-disk-period\u0027, \u002720\u0027]"},{"line_number":1246,"context_line":"        self.no_error_run(self.command + self.cmd_args + self.EE_args, self.server_args)"},{"line_number":1247,"context_line":"        expected_params \u003d [\u0027enabled\u003dtrue\u0027, \u0027timeout\u003d10\u0027, \u0027failoverOnDataDiskIssues%5Benabled%5D\u003dtrue\u0027,"},{"line_number":1248,"context_line":"                           \u0027failoverOnDataDiskIssues%5BtimePeriod%5D\u003d20\u0027]"},{"line_number":1249,"context_line":"        self.assertIn(\u0027POST:/settings/autoFailover\u0027, self.server.trace)"},{"line_number":1250,"context_line":"        self.rest_parameter_match(expected_params)"},{"line_number":1251,"context_line":""},{"line_number":1252,"context_line":""},{"line_number":1253,"context_line":"class TestSettingAutoreporovision(CommandTest):"}],"source_content_type":"text/x-python","patch_set":3,"id":"23d002cc_ead20e7a","line":1250,"range":{"start_line":1239,"start_character":0,"end_line":1250,"end_character":50},"in_reply_to":"c77aaa7a_100bdb9f","updated":"2023-03-29 11:12:14.000000000","message":"Done, great spot, that\u0027s what you get for copy-pasting without thinking 😞","commit_id":"2922a719e5a77680f42e3be23b737a578eac2c7b"}]}