)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1005187,"name":"Nour Elmenyawi","email":"nour.elmenyawi@couchbase.com","username":"nourelmenyawi","avatars":[{"url":"https://www.gravatar.com/avatar/b52e9109b362cb5b2e9728fdb9f91345.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/b52e9109b362cb5b2e9728fdb9f91345.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/b52e9109b362cb5b2e9728fdb9f91345.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/b52e9109b362cb5b2e9728fdb9f91345.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"0f08fdbda25b331b268c92740dd18a19caeae293","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"83341284_afaa4960","updated":"2024-02-02 09:44:16.000000000","message":"reverify","commit_id":"d401b5ec3aced67cd93ab74e486d4255449ffc33"},{"author":{"_account_id":1004879,"name":"Matt Hall","email":"matthew@quickbeam.me.uk","username":"mattyhall","avatars":[{"url":"https://www.gravatar.com/avatar/53d1d84f1bfdafc6399d56cba3efbe08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/53d1d84f1bfdafc6399d56cba3efbe08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/53d1d84f1bfdafc6399d56cba3efbe08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/53d1d84f1bfdafc6399d56cba3efbe08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"43e7ea816c5740130ed087cc0753e71b440b3ac5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"83e559bc_0521ec48","updated":"2024-02-02 12:09:16.000000000","message":"Could you target the neo branch please? You\u0027ll want to move the change through the UI.","commit_id":"9af6c99809872085fa3a77a1b7cd1d24ef679326"},{"author":{"_account_id":1005039,"name":"Safian Ali","email":"safian.ali@couchbase.com","username":"safianalicb","avatars":[{"url":"https://www.gravatar.com/avatar/fd5ddc39eab136fd76ae4419d1a94039.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd5ddc39eab136fd76ae4419d1a94039.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd5ddc39eab136fd76ae4419d1a94039.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd5ddc39eab136fd76ae4419d1a94039.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"203472ed7806ce1fc6768a959602e84f7739d275","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"97c1172a_7d5775bd","updated":"2024-02-02 10:50:47.000000000","message":"LGTM code wise, but I thought the issue here was that the decorator version check doesn\u0027t work for uninitialised nodes and that\u0027s where the \"unknown pool\" error was coming from?","commit_id":"9af6c99809872085fa3a77a1b7cd1d24ef679326"},{"author":{"_account_id":1005187,"name":"Nour Elmenyawi","email":"nour.elmenyawi@couchbase.com","username":"nourelmenyawi","avatars":[{"url":"https://www.gravatar.com/avatar/b52e9109b362cb5b2e9728fdb9f91345.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/b52e9109b362cb5b2e9728fdb9f91345.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/b52e9109b362cb5b2e9728fdb9f91345.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/b52e9109b362cb5b2e9728fdb9f91345.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"457756f1be7c4c2fe2e386b96142461d05e29973","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5739dc4e_e7ee2e3c","in_reply_to":"83e559bc_0521ec48","updated":"2024-02-02 12:17:35.000000000","message":"Done","commit_id":"9af6c99809872085fa3a77a1b7cd1d24ef679326"},{"author":{"_account_id":1005187,"name":"Nour Elmenyawi","email":"nour.elmenyawi@couchbase.com","username":"nourelmenyawi","avatars":[{"url":"https://www.gravatar.com/avatar/b52e9109b362cb5b2e9728fdb9f91345.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/b52e9109b362cb5b2e9728fdb9f91345.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/b52e9109b362cb5b2e9728fdb9f91345.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/b52e9109b362cb5b2e9728fdb9f91345.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"8f453066f86d45299f7e0e3c25b827b724e25472","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a061b575_e51a1d2b","in_reply_to":"97c1172a_7d5775bd","updated":"2024-02-02 11:03:10.000000000","message":"It wasn\u0027t the decorator that was failing with unknown pool, it was this line:\n```\nmin_version, errors \u003d self.rest.min_version()\n        _exit_if_errors(errors)\n```\nThe decorator version check is works fine.","commit_id":"9af6c99809872085fa3a77a1b7cd1d24ef679326"},{"author":{"_account_id":1005039,"name":"Safian Ali","email":"safian.ali@couchbase.com","username":"safianalicb","avatars":[{"url":"https://www.gravatar.com/avatar/fd5ddc39eab136fd76ae4419d1a94039.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd5ddc39eab136fd76ae4419d1a94039.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd5ddc39eab136fd76ae4419d1a94039.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd5ddc39eab136fd76ae4419d1a94039.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4bfd0e2df22ecb9467442559c5e237d45f032ef7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cc866afb_a9fe676f","in_reply_to":"a061b575_e51a1d2b","updated":"2024-02-02 11:06:28.000000000","message":"Done","commit_id":"9af6c99809872085fa3a77a1b7cd1d24ef679326"},{"author":{"_account_id":1005187,"name":"Nour Elmenyawi","email":"nour.elmenyawi@couchbase.com","username":"nourelmenyawi","avatars":[{"url":"https://www.gravatar.com/avatar/b52e9109b362cb5b2e9728fdb9f91345.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/b52e9109b362cb5b2e9728fdb9f91345.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/b52e9109b362cb5b2e9728fdb9f91345.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/b52e9109b362cb5b2e9728fdb9f91345.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"8cb707663c819cad4512e5b86d597deae89b6f8e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"8e28d2e7_a9b1f908","updated":"2024-02-02 15:47:09.000000000","message":"reverify","commit_id":"25bfca78069e826734d27e30e13ff582270df3df"}],"cbmgr.py":[{"author":{"_account_id":1004879,"name":"Matt Hall","email":"matthew@quickbeam.me.uk","username":"mattyhall","avatars":[{"url":"https://www.gravatar.com/avatar/53d1d84f1bfdafc6399d56cba3efbe08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/53d1d84f1bfdafc6399d56cba3efbe08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/53d1d84f1bfdafc6399d56cba3efbe08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/53d1d84f1bfdafc6399d56cba3efbe08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"43e7ea816c5740130ed087cc0753e71b440b3ac5","unresolved":true,"context_lines":[{"line_number":3277,"context_line":""},{"line_number":3278,"context_line":"    @rest_initialiser(version_check\u003dTrue, enterprise_check\u003dFalse)"},{"line_number":3279,"context_line":"    def execute(self, opts):"},{"line_number":3280,"context_line":"        if not self.enterprise:"},{"line_number":3281,"context_line":"            _exit_if_errors([\"Modifying notifications settings is an Enterprise Edition only feature\"])"},{"line_number":3282,"context_line":""},{"line_number":3283,"context_line":"        enabled \u003d None"}],"source_content_type":"text/x-python","patch_set":4,"id":"44762a30_6dbc3e9f","line":3280,"updated":"2024-02-02 12:09:16.000000000","message":"Sorry - I think I\u0027ve caused some confusion on slack. We in general do still want to do a version check here as it\u0027s an EE feature _only after 7.2.3_.\n\nI think we should try to do self.rest.min_version and if it fails due to not being setup then we should try to get the version of just this node. There should be an API to do that, but you might need to hunt for it. If there isn\u0027t then I think it is fine to just assume the version is \u003e\u003d 7.2.3 and check whether it\u0027s EE.","commit_id":"9af6c99809872085fa3a77a1b7cd1d24ef679326"},{"author":{"_account_id":1005187,"name":"Nour Elmenyawi","email":"nour.elmenyawi@couchbase.com","username":"nourelmenyawi","avatars":[{"url":"https://www.gravatar.com/avatar/b52e9109b362cb5b2e9728fdb9f91345.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/b52e9109b362cb5b2e9728fdb9f91345.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/b52e9109b362cb5b2e9728fdb9f91345.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/b52e9109b362cb5b2e9728fdb9f91345.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"70ee505cd0fbbc1ef76c7e2f50a9da897f1dedef","unresolved":false,"context_lines":[{"line_number":3277,"context_line":""},{"line_number":3278,"context_line":"    @rest_initialiser(version_check\u003dTrue, enterprise_check\u003dFalse)"},{"line_number":3279,"context_line":"    def execute(self, opts):"},{"line_number":3280,"context_line":"        if not self.enterprise:"},{"line_number":3281,"context_line":"            _exit_if_errors([\"Modifying notifications settings is an Enterprise Edition only feature\"])"},{"line_number":3282,"context_line":""},{"line_number":3283,"context_line":"        enabled \u003d None"}],"source_content_type":"text/x-python","patch_set":4,"id":"39d9e5e1_fb0493e6","line":3280,"in_reply_to":"1c3bc69c_a2cf41bc","updated":"2024-02-02 12:18:29.000000000","message":"Done","commit_id":"9af6c99809872085fa3a77a1b7cd1d24ef679326"},{"author":{"_account_id":1005187,"name":"Nour Elmenyawi","email":"nour.elmenyawi@couchbase.com","username":"nourelmenyawi","avatars":[{"url":"https://www.gravatar.com/avatar/b52e9109b362cb5b2e9728fdb9f91345.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/b52e9109b362cb5b2e9728fdb9f91345.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/b52e9109b362cb5b2e9728fdb9f91345.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/b52e9109b362cb5b2e9728fdb9f91345.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"457756f1be7c4c2fe2e386b96142461d05e29973","unresolved":true,"context_lines":[{"line_number":3277,"context_line":""},{"line_number":3278,"context_line":"    @rest_initialiser(version_check\u003dTrue, enterprise_check\u003dFalse)"},{"line_number":3279,"context_line":"    def execute(self, opts):"},{"line_number":3280,"context_line":"        if not self.enterprise:"},{"line_number":3281,"context_line":"            _exit_if_errors([\"Modifying notifications settings is an Enterprise Edition only feature\"])"},{"line_number":3282,"context_line":""},{"line_number":3283,"context_line":"        enabled \u003d None"}],"source_content_type":"text/x-python","patch_set":4,"id":"1c3bc69c_a2cf41bc","line":3280,"in_reply_to":"44762a30_6dbc3e9f","updated":"2024-02-02 12:17:35.000000000","message":"Ah you\u0027re right. I have changed it now to use `node_version()` instead of `min_version()` and that provides us with the correct version even if the cluster is not initialised.","commit_id":"9af6c99809872085fa3a77a1b7cd1d24ef679326"},{"author":{"_account_id":1004879,"name":"Matt Hall","email":"matthew@quickbeam.me.uk","username":"mattyhall","avatars":[{"url":"https://www.gravatar.com/avatar/53d1d84f1bfdafc6399d56cba3efbe08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/53d1d84f1bfdafc6399d56cba3efbe08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/53d1d84f1bfdafc6399d56cba3efbe08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/53d1d84f1bfdafc6399d56cba3efbe08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b0df67564ecaf163e70a7dbb79df39036517596e","unresolved":true,"context_lines":[{"line_number":3172,"context_line":""},{"line_number":3173,"context_line":"    @rest_initialiser(version_check\u003dTrue, enterprise_check\u003dFalse)"},{"line_number":3174,"context_line":"    def execute(self, opts):"},{"line_number":3175,"context_line":"        min_version, errors \u003d self.rest.node_version()"},{"line_number":3176,"context_line":"        _exit_if_errors(errors)"},{"line_number":3177,"context_line":""},{"line_number":3178,"context_line":"        if not self.enterprise and min_version \u003e\u003d \"7.2.3\":"}],"source_content_type":"text/x-python","patch_set":9,"id":"d26b56c4_63e68f65","line":3175,"updated":"2024-02-05 14:53:05.000000000","message":"I still think we should at least try the cluster version and then fallback to the node version if it fails, rather than just the latter.","commit_id":"c252bd944b2716299d6fd9d3b21f9f1da647a2ac"},{"author":{"_account_id":1005187,"name":"Nour Elmenyawi","email":"nour.elmenyawi@couchbase.com","username":"nourelmenyawi","avatars":[{"url":"https://www.gravatar.com/avatar/b52e9109b362cb5b2e9728fdb9f91345.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/b52e9109b362cb5b2e9728fdb9f91345.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/b52e9109b362cb5b2e9728fdb9f91345.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/b52e9109b362cb5b2e9728fdb9f91345.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c3e362ec11029a8dd5f98161040c9c9b27dd5216","unresolved":false,"context_lines":[{"line_number":3172,"context_line":""},{"line_number":3173,"context_line":"    @rest_initialiser(version_check\u003dTrue, enterprise_check\u003dFalse)"},{"line_number":3174,"context_line":"    def execute(self, opts):"},{"line_number":3175,"context_line":"        min_version, errors \u003d self.rest.node_version()"},{"line_number":3176,"context_line":"        _exit_if_errors(errors)"},{"line_number":3177,"context_line":""},{"line_number":3178,"context_line":"        if not self.enterprise and min_version \u003e\u003d \"7.2.3\":"}],"source_content_type":"text/x-python","patch_set":9,"id":"4b0b431b_088acdf5","line":3175,"in_reply_to":"d26b56c4_63e68f65","updated":"2024-02-05 16:01:53.000000000","message":"Done","commit_id":"c252bd944b2716299d6fd9d3b21f9f1da647a2ac"}]}