)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1005039,"name":"Safian Ali","email":"safian.ali@couchbase.com","username":"safianalicb","avatars":[{"url":"https://www.gravatar.com/avatar/fd5ddc39eab136fd76ae4419d1a94039.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd5ddc39eab136fd76ae4419d1a94039.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd5ddc39eab136fd76ae4419d1a94039.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd5ddc39eab136fd76ae4419d1a94039.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"5ded3ebbcff14cdc82672984140930db8813d7dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cd84164f_9a891f26","updated":"2025-02-24 13:25:23.000000000","message":"Please create tests","commit_id":"27ef862dcd0fcaf77f53880166cc57ed538a6af7"},{"author":{"_account_id":1003738,"name":"Michael Blow","email":"michael.blow@couchbase.com","username":"mblow","avatars":[{"url":"https://www.gravatar.com/avatar/73916dd7925a872906a78b2b79b7780b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/73916dd7925a872906a78b2b79b7780b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/73916dd7925a872906a78b2b79b7780b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/73916dd7925a872906a78b2b79b7780b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"43fc19d1193588c84ef0ae7cff7b8f31b190eaab","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4ac11d20_333268a0","in_reply_to":"cd84164f_9a891f26","updated":"2025-02-24 17:05:02.000000000","message":"Will do.","commit_id":"27ef862dcd0fcaf77f53880166cc57ed538a6af7"}],"cbmgr.py":[{"author":{"_account_id":1004879,"name":"Matt Hall","email":"matthew@quickbeam.me.uk","username":"mattyhall","avatars":[{"url":"https://www.gravatar.com/avatar/53d1d84f1bfdafc6399d56cba3efbe08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/53d1d84f1bfdafc6399d56cba3efbe08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/53d1d84f1bfdafc6399d56cba3efbe08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/53d1d84f1bfdafc6399d56cba3efbe08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"fc1862fb3f00671fb0e540bca9b49026a4e7d230","unresolved":true,"context_lines":[{"line_number":934,"context_line":"        _exit_if_errors(errors)"},{"line_number":935,"context_line":""},{"line_number":936,"context_line":"        versionCheck \u003d compare_versions(min_version, \"7.2.3\")"},{"line_number":937,"context_line":"        if not self.columnar and versionCheck \u003d\u003d -1:"},{"line_number":938,"context_line":"            _exit_if_errors([\"--cluster-init can only be used against \u003e\u003d 7.2.3 clusters\"])"},{"line_number":939,"context_line":""},{"line_number":940,"context_line":"        if not self.enterprise and opts.notifications \u003d\u003d \"0\":"}],"source_content_type":"text/x-python","patch_set":3,"id":"08e8f4aa_7b4e2c45","line":937,"updated":"2025-02-24 13:21:57.000000000","message":"I am not sure I understand why some of the version checks have `and not columnar` added to them. Taking this as an example I am not sure what checking columnar does here - unless columnar is not keeping the server version?","commit_id":"27ef862dcd0fcaf77f53880166cc57ed538a6af7"},{"author":{"_account_id":1003738,"name":"Michael Blow","email":"michael.blow@couchbase.com","username":"mblow","avatars":[{"url":"https://www.gravatar.com/avatar/73916dd7925a872906a78b2b79b7780b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/73916dd7925a872906a78b2b79b7780b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/73916dd7925a872906a78b2b79b7780b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/73916dd7925a872906a78b2b79b7780b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"43fc19d1193588c84ef0ae7cff7b8f31b190eaab","unresolved":true,"context_lines":[{"line_number":934,"context_line":"        _exit_if_errors(errors)"},{"line_number":935,"context_line":""},{"line_number":936,"context_line":"        versionCheck \u003d compare_versions(min_version, \"7.2.3\")"},{"line_number":937,"context_line":"        if not self.columnar and versionCheck \u003d\u003d -1:"},{"line_number":938,"context_line":"            _exit_if_errors([\"--cluster-init can only be used against \u003e\u003d 7.2.3 clusters\"])"},{"line_number":939,"context_line":""},{"line_number":940,"context_line":"        if not self.enterprise and opts.notifications \u003d\u003d \"0\":"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f13ecf1_c739571d","line":937,"in_reply_to":"08e8f4aa_7b4e2c45","updated":"2025-02-24 17:05:02.000000000","message":"When columnar, the version numbers are completely independent from CB version numbers. e.g. for the upcoming columnar self-managed (on-prem) release, the version number is 1.2.0. This check for example is failing here, since 1.2.0 \u003c 7.2.3.\n\nAs the server version that Columnar is based on is known at build time, we should be able to add another field to pools to indicate the underlying server version build, perhaps we can go that route for these checks eventually: when columnar (or when the server version is defined), take that instead of `implementationVersion`...","commit_id":"27ef862dcd0fcaf77f53880166cc57ed538a6af7"},{"author":{"_account_id":1004879,"name":"Matt Hall","email":"matthew@quickbeam.me.uk","username":"mattyhall","avatars":[{"url":"https://www.gravatar.com/avatar/53d1d84f1bfdafc6399d56cba3efbe08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/53d1d84f1bfdafc6399d56cba3efbe08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/53d1d84f1bfdafc6399d56cba3efbe08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/53d1d84f1bfdafc6399d56cba3efbe08.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"47787f0bab4c52013ffc0d66bf05ecfa791dd071","unresolved":false,"context_lines":[{"line_number":934,"context_line":"        _exit_if_errors(errors)"},{"line_number":935,"context_line":""},{"line_number":936,"context_line":"        versionCheck \u003d compare_versions(min_version, \"7.2.3\")"},{"line_number":937,"context_line":"        if not self.columnar and versionCheck \u003d\u003d -1:"},{"line_number":938,"context_line":"            _exit_if_errors([\"--cluster-init can only be used against \u003e\u003d 7.2.3 clusters\"])"},{"line_number":939,"context_line":""},{"line_number":940,"context_line":"        if not self.enterprise and opts.notifications \u003d\u003d \"0\":"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf5b5549_41d4812e","line":937,"in_reply_to":"9f13ecf1_c739571d","updated":"2025-02-24 17:42:29.000000000","message":"Acknowledged","commit_id":"27ef862dcd0fcaf77f53880166cc57ed538a6af7"}],"cluster_manager.py":[{"author":{"_account_id":1005039,"name":"Safian Ali","email":"safian.ali@couchbase.com","username":"safianalicb","avatars":[{"url":"https://www.gravatar.com/avatar/fd5ddc39eab136fd76ae4419d1a94039.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd5ddc39eab136fd76ae4419d1a94039.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd5ddc39eab136fd76ae4419d1a94039.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd5ddc39eab136fd76ae4419d1a94039.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"5ded3ebbcff14cdc82672984140930db8813d7dd","unresolved":true,"context_lines":[{"line_number":261,"context_line":"        data, errors \u003d self.pools()"},{"line_number":262,"context_line":"        if errors:"},{"line_number":263,"context_line":"            return None, None, errors"},{"line_number":264,"context_line":"        # use data[\"isColumnar\"] once MB-65393 is completed"},{"line_number":265,"context_line":"        return data[\"isEnterprise\"], data[\"implementationVersion\"].endswith(\"-columnar\"), None"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    def get_hostnames_for_service(self, service_name):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7cca4972_198c764a","line":264,"range":{"start_line":264,"start_character":10,"end_line":264,"end_character":59},"updated":"2025-02-24 13:25:23.000000000","message":"Please can you raise a tools ticket for this and link it to MB-65393","commit_id":"27ef862dcd0fcaf77f53880166cc57ed538a6af7"},{"author":{"_account_id":1003738,"name":"Michael Blow","email":"michael.blow@couchbase.com","username":"mblow","avatars":[{"url":"https://www.gravatar.com/avatar/73916dd7925a872906a78b2b79b7780b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/73916dd7925a872906a78b2b79b7780b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/73916dd7925a872906a78b2b79b7780b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/73916dd7925a872906a78b2b79b7780b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"43fc19d1193588c84ef0ae7cff7b8f31b190eaab","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        data, errors \u003d self.pools()"},{"line_number":262,"context_line":"        if errors:"},{"line_number":263,"context_line":"            return None, None, errors"},{"line_number":264,"context_line":"        # use data[\"isColumnar\"] once MB-65393 is completed"},{"line_number":265,"context_line":"        return data[\"isEnterprise\"], data[\"implementationVersion\"].endswith(\"-columnar\"), None"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    def get_hostnames_for_service(self, service_name):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7fbccbc9_b8eb5aae","line":264,"range":{"start_line":264,"start_character":10,"end_line":264,"end_character":59},"in_reply_to":"7cca4972_198c764a","updated":"2025-02-24 17:05:02.000000000","message":"Acknowledged","commit_id":"27ef862dcd0fcaf77f53880166cc57ed538a6af7"}]}