)]}'
{"src/Couchbase/Core/IO/Connections/DataFlow/DataFlowConnectionPool.cs":[{"author":{"_account_id":1000530,"name":"Jeffry Morris","email":"jeffrymorris@gmail.com","username":"jmorris","avatars":[{"url":"https://www.gravatar.com/avatar/d0b8b4cd259ea37fb99be261e6a720b0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d0b8b4cd259ea37fb99be261e6a720b0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d0b8b4cd259ea37fb99be261e6a720b0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d0b8b4cd259ea37fb99be261e6a720b0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"51f0506c72ac6907db9ffdb83feccfd1cedc2da7","unresolved":true,"context_lines":[{"line_number":133,"context_line":"                        if (!_sendQueue.Post(operation))"},{"line_number":134,"context_line":"                        {"},{"line_number":135,"context_line":"                            throw new SendQueueFullException();"},{"line_number":136,"context_line":"                        }"},{"line_number":137,"context_line":"                    }"},{"line_number":138,"context_line":"                }"},{"line_number":139,"context_line":"            }, cancellationToken);"}],"source_content_type":"text/x-csharp","patch_set":3,"id":"962f9d80_22943c33","line":136,"updated":"2020-12-09 18:52:57.000000000","message":"I would think we would want consistency here: throw vs task.SetException(..)","commit_id":"137843603db865faf4a7040e7bba2937a83e36eb"},{"author":{"_account_id":1004555,"name":"Richard Ponton","email":"richard.ponton@couchbase.com","username":"RiPont","avatars":[{"url":"https://www.gravatar.com/avatar/fd2121b54ddf4a68170b9f607ddb68de.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd2121b54ddf4a68170b9f607ddb68de.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd2121b54ddf4a68170b9f607ddb68de.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd2121b54ddf4a68170b9f607ddb68de.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"a04c884f57f9e8e3e3e8caca913ebc44ab31ffcf","unresolved":true,"context_lines":[{"line_number":358,"context_line":"                            // Since the exception on the task is ignored, we\u0027re also eating the exception"},{"line_number":359,"context_line":"                                if (!_sendQueue.Post(request))"},{"line_number":360,"context_line":"                                {"},{"line_number":361,"context_line":"                                    request.TrySetException(new SendQueueFullException());"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"                                }"},{"line_number":364,"context_line":"                            }"}],"source_content_type":"text/x-csharp","patch_set":3,"id":"9a55eb2b_a47c45ef","line":361,"updated":"2020-12-09 18:51:52.000000000","message":"what if this returns false?\n\nAlso, will this exception actually have a stack trace, or do you need to throw it first?","commit_id":"137843603db865faf4a7040e7bba2937a83e36eb"},{"author":{"_account_id":1003698,"name":"Brant Burnett","email":"bburnett@centeredgesoftware.com","username":"brantburnett","avatars":[{"url":"https://www.gravatar.com/avatar/12aa2d70cf0b92feeceb6dd7f81dd059.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/12aa2d70cf0b92feeceb6dd7f81dd059.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/12aa2d70cf0b92feeceb6dd7f81dd059.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/12aa2d70cf0b92feeceb6dd7f81dd059.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"0413b3c5e0eabcaad7a55b6599c30bb68bcb77d1","unresolved":true,"context_lines":[{"line_number":356,"context_line":"                                // Requeue the request for a different connection"},{"line_number":357,"context_line":"                                // Note: always requeues even if cleanup fails"},{"line_number":358,"context_line":"                                // Since the exception on the task is ignored, we\u0027re also eating the exception"},{"line_number":359,"context_line":"                                if (!_sendQueue.Post(request)) request.TrySetException(new SendQueueFullException());"},{"line_number":360,"context_line":"                            }"},{"line_number":361,"context_line":"                        }"},{"line_number":362,"context_line":"                    }"}],"source_content_type":"text/x-csharp","patch_set":4,"id":"c2c71df9_46956c99","line":359,"updated":"2020-12-09 19:36:27.000000000","message":"In my opinion, this should be throwing the exception rather than calling TrySetException, and letting the catch block below call TrySetException. If you never throw the exception, it will be lacking details like StackTrace.","commit_id":"6e20c47da18fec79581f0b2ede42f01d22f54d14"}]}