)]}'
{"id":"couchbase-net-client~142023","triplet_id":"couchbase-net-client~master~I43dff50f0417eafafc4f551bcb157e4c12e3c4d5","project":"couchbase-net-client","branch":"master","hashtags":[],"change_id":"I43dff50f0417eafafc4f551bcb157e4c12e3c4d5","subject":"NCBC-2754: Use Span\u003cT\u003e to build key in VBucketKeyMapper","status":"MERGED","created":"2020-12-12 21:07:38.000000000","updated":"2020-12-14 19:56:50.000000000","submitted":"2020-12-14 19:56:50.000000000","submitter":{"_account_id":1000530,"name":"Jeffry Morris","email":"jeffrymorris@gmail.com","username":"jmorris","avatars":[{"url":"https://www.gravatar.com/avatar/d0b8b4cd259ea37fb99be261e6a720b0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d0b8b4cd259ea37fb99be261e6a720b0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d0b8b4cd259ea37fb99be261e6a720b0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d0b8b4cd259ea37fb99be261e6a720b0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"total_comment_count":2,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"142023-1607975810483-5f9c5476","meta_rev_id":"a1dc6ac94736f29149bb0413683b77448dbd97fa","_number":142023,"virtual_id_number":142023,"owner":{"_account_id":1003698,"name":"Brant Burnett","email":"bburnett@centeredgesoftware.com","username":"brantburnett","avatars":[{"url":"https://www.gravatar.com/avatar/12aa2d70cf0b92feeceb6dd7f81dd059.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/12aa2d70cf0b92feeceb6dd7f81dd059.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/12aa2d70cf0b92feeceb6dd7f81dd059.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/12aa2d70cf0b92feeceb6dd7f81dd059.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000530,"name":"Jeffry Morris","email":"jeffrymorris@gmail.com","username":"jmorris","avatars":[{"url":"https://www.gravatar.com/avatar/d0b8b4cd259ea37fb99be261e6a720b0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d0b8b4cd259ea37fb99be261e6a720b0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d0b8b4cd259ea37fb99be261e6a720b0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d0b8b4cd259ea37fb99be261e6a720b0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2020-12-14 19:56:50.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},{"value":0,"_account_id":1004555,"name":"Richard Ponton","email":"richard.ponton@couchbase.com","username":"RiPont","avatars":[{"url":"https://www.gravatar.com/avatar/fd2121b54ddf4a68170b9f607ddb68de.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd2121b54ddf4a68170b9f607ddb68de.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd2121b54ddf4a68170b9f607ddb68de.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd2121b54ddf4a68170b9f607ddb68de.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1004555,"name":"Richard Ponton","email":"richard.ponton@couchbase.com","username":"RiPont","avatars":[{"url":"https://www.gravatar.com/avatar/fd2121b54ddf4a68170b9f607ddb68de.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd2121b54ddf4a68170b9f607ddb68de.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd2121b54ddf4a68170b9f607ddb68de.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd2121b54ddf4a68170b9f607ddb68de.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"all":[{"value":0,"_account_id":1000530,"name":"Jeffry Morris","email":"jeffrymorris@gmail.com","username":"jmorris","avatars":[{"url":"https://www.gravatar.com/avatar/d0b8b4cd259ea37fb99be261e6a720b0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d0b8b4cd259ea37fb99be261e6a720b0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d0b8b4cd259ea37fb99be261e6a720b0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d0b8b4cd259ea37fb99be261e6a720b0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2020-12-14 19:56:50.000000000","_account_id":1004555,"name":"Richard Ponton","email":"richard.ponton@couchbase.com","username":"RiPont","avatars":[{"url":"https://www.gravatar.com/avatar/fd2121b54ddf4a68170b9f607ddb68de.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd2121b54ddf4a68170b9f607ddb68de.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd2121b54ddf4a68170b9f607ddb68de.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd2121b54ddf4a68170b9f607ddb68de.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-2":"Do not submit","-1":"I would prefer that you didn\u0027t submit this"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Well-Formed":{"all":[{"value":0,"_account_id":1000530,"name":"Jeffry Morris","email":"jeffrymorris@gmail.com","username":"jmorris","avatars":[{"url":"https://www.gravatar.com/avatar/d0b8b4cd259ea37fb99be261e6a720b0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d0b8b4cd259ea37fb99be261e6a720b0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d0b8b4cd259ea37fb99be261e6a720b0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d0b8b4cd259ea37fb99be261e6a720b0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},{"value":0,"_account_id":1004555,"name":"Richard Ponton","email":"richard.ponton@couchbase.com","username":"RiPont","avatars":[{"url":"https://www.gravatar.com/avatar/fd2121b54ddf4a68170b9f607ddb68de.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd2121b54ddf4a68170b9f607ddb68de.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd2121b54ddf4a68170b9f607ddb68de.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd2121b54ddf4a68170b9f607ddb68de.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Commit is not well-formed"," 0":"Well-formedness not checked","+1":"Commit is well-formed"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},{"_account_id":1000530,"name":"Jeffry Morris","email":"jeffrymorris@gmail.com","username":"jmorris","avatars":[{"url":"https://www.gravatar.com/avatar/d0b8b4cd259ea37fb99be261e6a720b0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d0b8b4cd259ea37fb99be261e6a720b0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d0b8b4cd259ea37fb99be261e6a720b0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d0b8b4cd259ea37fb99be261e6a720b0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1004555,"name":"Richard Ponton","email":"richard.ponton@couchbase.com","username":"RiPont","avatars":[{"url":"https://www.gravatar.com/avatar/fd2121b54ddf4a68170b9f607ddb68de.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd2121b54ddf4a68170b9f607ddb68de.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd2121b54ddf4a68170b9f607ddb68de.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd2121b54ddf4a68170b9f607ddb68de.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-12-12 21:07:49.000000000","updated_by":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2020-12-12 21:11:12.000000000","updated_by":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-12-12 21:18:01.000000000","updated_by":{"_account_id":1003698,"name":"Brant Burnett","email":"bburnett@centeredgesoftware.com","username":"brantburnett","avatars":[{"url":"https://www.gravatar.com/avatar/12aa2d70cf0b92feeceb6dd7f81dd059.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/12aa2d70cf0b92feeceb6dd7f81dd059.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/12aa2d70cf0b92feeceb6dd7f81dd059.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/12aa2d70cf0b92feeceb6dd7f81dd059.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":1004555,"name":"Richard Ponton","email":"richard.ponton@couchbase.com","username":"RiPont","avatars":[{"url":"https://www.gravatar.com/avatar/fd2121b54ddf4a68170b9f607ddb68de.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd2121b54ddf4a68170b9f607ddb68de.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd2121b54ddf4a68170b9f607ddb68de.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd2121b54ddf4a68170b9f607ddb68de.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2020-12-12 21:18:01.000000000","updated_by":{"_account_id":1003698,"name":"Brant Burnett","email":"bburnett@centeredgesoftware.com","username":"brantburnett","avatars":[{"url":"https://www.gravatar.com/avatar/12aa2d70cf0b92feeceb6dd7f81dd059.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/12aa2d70cf0b92feeceb6dd7f81dd059.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/12aa2d70cf0b92feeceb6dd7f81dd059.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/12aa2d70cf0b92feeceb6dd7f81dd059.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":1000530,"name":"Jeffry Morris","email":"jeffrymorris@gmail.com","username":"jmorris","avatars":[{"url":"https://www.gravatar.com/avatar/d0b8b4cd259ea37fb99be261e6a720b0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d0b8b4cd259ea37fb99be261e6a720b0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d0b8b4cd259ea37fb99be261e6a720b0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d0b8b4cd259ea37fb99be261e6a720b0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"}],"messages":[{"id":"fe936e8c68c9cdf33864b29a65d50b8e25501255","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1003698,"name":"Brant Burnett","email":"bburnett@centeredgesoftware.com","username":"brantburnett","avatars":[{"url":"https://www.gravatar.com/avatar/12aa2d70cf0b92feeceb6dd7f81dd059.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/12aa2d70cf0b92feeceb6dd7f81dd059.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/12aa2d70cf0b92feeceb6dd7f81dd059.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/12aa2d70cf0b92feeceb6dd7f81dd059.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-12-12 21:07:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f4e505ed8214768895e55ed230a37544d79bd7d3","author":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2020-12-12 21:07:49.000000000","message":"Patch Set 1:\n\nBuild Started http://sdk.jenkins.couchbase.com/job/dotnet/job/sdk/job/couchbase-net-client-cv-trigger/2135/","accounts_in_message":[],"_revision_number":1},{"id":"74e2da387057c581c7e07227b7e4b6c6c115eca7","author":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2020-12-12 21:11:12.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttp://sdk.jenkins.couchbase.com/job/dotnet/job/sdk/job/couchbase-net-client-cv-trigger/2135/ : success","accounts_in_message":[],"_revision_number":1},{"id":"ef83c160a9bf422dd0e11e13b9bfd30512536e41","author":{"_account_id":1004555,"name":"Richard Ponton","email":"richard.ponton@couchbase.com","username":"RiPont","avatars":[{"url":"https://www.gravatar.com/avatar/fd2121b54ddf4a68170b9f607ddb68de.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd2121b54ddf4a68170b9f607ddb68de.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd2121b54ddf4a68170b9f607ddb68de.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd2121b54ddf4a68170b9f607ddb68de.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-12-14 16:38:26.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"d2043e2f85d0dfcad8b5497fcaf2255f314a1606","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1003698,"name":"Brant Burnett","email":"bburnett@centeredgesoftware.com","username":"brantburnett","avatars":[{"url":"https://www.gravatar.com/avatar/12aa2d70cf0b92feeceb6dd7f81dd059.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/12aa2d70cf0b92feeceb6dd7f81dd059.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/12aa2d70cf0b92feeceb6dd7f81dd059.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/12aa2d70cf0b92feeceb6dd7f81dd059.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-12-14 17:49:26.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"8002aa82617e777785dff9e87857ee0f4e2efdd6","author":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2020-12-14 17:49:36.000000000","message":"Patch Set 2:\n\nBuild Started http://sdk.jenkins.couchbase.com/job/dotnet/job/sdk/job/couchbase-net-client-cv-trigger/2138/","accounts_in_message":[],"_revision_number":2},{"id":"750e6aeb72ba58716d8aa97b1b418859b5dcbae0","author":{"_account_id":1003698,"name":"Brant Burnett","email":"bburnett@centeredgesoftware.com","username":"brantburnett","avatars":[{"url":"https://www.gravatar.com/avatar/12aa2d70cf0b92feeceb6dd7f81dd059.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/12aa2d70cf0b92feeceb6dd7f81dd059.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/12aa2d70cf0b92feeceb6dd7f81dd059.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/12aa2d70cf0b92feeceb6dd7f81dd059.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-12-14 17:51:00.000000000","message":"Patch Set 2:\n\n(1 comment)\n\n\u003e Patch Set 1: Code-Review+1\n\u003e \n\u003e (1 comment)\n\nResponse inline","accounts_in_message":[],"_revision_number":2},{"id":"ffe716efc81400e21e6539d498bcc779372342e1","author":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2020-12-14 17:53:10.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttp://sdk.jenkins.couchbase.com/job/dotnet/job/sdk/job/couchbase-net-client-cv-trigger/2138/ : success","accounts_in_message":[],"_revision_number":2},{"id":"4760679980a9ce74f94699f7c4d86a3cb30a2fe3","author":{"_account_id":1004555,"name":"Richard Ponton","email":"richard.ponton@couchbase.com","username":"RiPont","avatars":[{"url":"https://www.gravatar.com/avatar/fd2121b54ddf4a68170b9f607ddb68de.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd2121b54ddf4a68170b9f607ddb68de.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd2121b54ddf4a68170b9f607ddb68de.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd2121b54ddf4a68170b9f607ddb68de.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-12-14 18:17:47.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"a1dc6ac94736f29149bb0413683b77448dbd97fa","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000530,"name":"Jeffry Morris","email":"jeffrymorris@gmail.com","username":"jmorris","avatars":[{"url":"https://www.gravatar.com/avatar/d0b8b4cd259ea37fb99be261e6a720b0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d0b8b4cd259ea37fb99be261e6a720b0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d0b8b4cd259ea37fb99be261e6a720b0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d0b8b4cd259ea37fb99be261e6a720b0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-12-14 19:56:50.000000000","message":"Change has been successfully cherry-picked as c520a70e8b7b26be8713b8b2883b43c1867f8d02 by Jeffry Morris","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"c520a70e8b7b26be8713b8b2883b43c1867f8d02","revisions":{"18126818b61471f9f1d02e431a5eb4c16019eda6":{"kind":"REWORK","_number":1,"created":"2020-12-12 21:07:38.000000000","uploader":{"_account_id":1003698,"name":"Brant Burnett","email":"bburnett@centeredgesoftware.com","username":"brantburnett","avatars":[{"url":"https://www.gravatar.com/avatar/12aa2d70cf0b92feeceb6dd7f81dd059.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/12aa2d70cf0b92feeceb6dd7f81dd059.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/12aa2d70cf0b92feeceb6dd7f81dd059.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/12aa2d70cf0b92feeceb6dd7f81dd059.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/23/142023/1","fetch":{"anonymous http":{"url":"https://review.couchbase.org/couchbase-net-client","ref":"refs/changes/23/142023/1","commands":{"Branch":"git fetch https://review.couchbase.org/couchbase-net-client refs/changes/23/142023/1 \u0026\u0026 git checkout -b change-142023 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/couchbase-net-client refs/changes/23/142023/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/couchbase-net-client refs/changes/23/142023/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/couchbase-net-client refs/changes/23/142023/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/couchbase-net-client refs/changes/23/142023/1","Reset To":"git fetch https://review.couchbase.org/couchbase-net-client refs/changes/23/142023/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d6a5df056a8fb3eee576244463745650b1f0d9c2","subject":"NCBC-2752: Improve ToTtl performance"}],"author":{"name":"Brant Burnett","email":"bburnett@centeredgesoftware.com","date":"2020-12-12 21:07:33.000000000","tz":-300},"committer":{"name":"Brant Burnett","email":"bburnett@centeredgesoftware.com","date":"2020-12-12 21:07:33.000000000","tz":-300},"subject":"NCBC-2754: Use Span\u003cT\u003e to build key in VBucketKeyMapper","message":"NCBC-2754: Use Span\u003cT\u003e to build key in VBucketKeyMapper\n\nMotivation\n----------\nImprove the performance of VBucketKeyMapper.GetIndex on modern .NET\nruntimes.\n\nModifications\n-------------\nStack allocate a Span\u003cT\u003e to hold the key and encode directly to this\nspan when using a target runtime that supports the required encoding\noverload.\n\nUse SkipLocalsInitAttribute and C# 9 to avoid the cost of zero-filling\nthe span since the portion we care about will be immediately filled\nby Encoding.UTF8.GetBytes. Note: Without this feature, short keys\n(i.e. 10 bytes) actually take a performance hit.\n\nResults\n-------\nGetIndex has improved performance and is completely free of heap\nallocations on .NET Core 2.1 and later.\n\nBenchmarkDotNet\u003dv0.12.1, OS\u003dWindows 10.0.19042\nIntel Core i7-9750H CPU 2.60GHz, 1 CPU, 12 logical and 6 physical cores\n.NET Core SDK\u003d5.0.101\n  [Host]     : .NET Core 3.1.10 (CoreCLR 4.700.20.51601, CoreFX 4.700.20.51901), X64 RyuJIT\n  DefaultJob : .NET Core 3.1.10 (CoreCLR 4.700.20.51601, CoreFX 4.700.20.51901), X64 RyuJIT\n\n|     Method | KeySize |     Mean |    Error |   StdDev | Ratio | Rank |  Gen 0 | Gen 1 | Gen 2 | Allocated |\n|----------- |-------- |---------:|---------:|---------:|------:|-----:|-------:|------:|------:|----------:|\n|    Current |      10 | 40.18 ns | 0.124 ns | 0.104 ns |  1.00 |    2 | 0.0063 |     - |     - |      40 B |\n| StackAlloc |      10 | 32.89 ns | 0.324 ns | 0.270 ns |  0.82 |    1 |      - |     - |     - |         - |\n|            |         |          |          |          |       |      |        |       |       |           |\n|    Current |      40 | 59.57 ns | 0.270 ns | 0.252 ns |  1.00 |    2 | 0.0101 |     - |     - |      64 B |\n| StackAlloc |      40 | 48.25 ns | 0.296 ns | 0.262 ns |  0.81 |    1 |      - |     - |     - |         - |\n|            |         |          |          |          |       |      |        |       |       |           |\n|    Current |     100 | 94.18 ns | 0.480 ns | 0.449 ns |  1.00 |    2 | 0.0204 |     - |     - |     128 B |\n| StackAlloc |     100 | 81.23 ns | 0.326 ns | 0.305 ns |  0.86 |    1 |      - |     - |     - |         - |\n\nChange-Id: I43dff50f0417eafafc4f551bcb157e4c12e3c4d5\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"d6a5df056a8fb3eee576244463745650b1f0d9c2","is_merged_in_target_branch":true,"change_id":"I6bf4f88cb00cee8d92cb67625e065972b7c4b755","change_number":142019,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"},"00f2b0d9f41bbeaf1f65863aff396c8d947f6d87":{"kind":"REWORK","_number":2,"created":"2020-12-14 17:49:26.000000000","uploader":{"_account_id":1003698,"name":"Brant Burnett","email":"bburnett@centeredgesoftware.com","username":"brantburnett","avatars":[{"url":"https://www.gravatar.com/avatar/12aa2d70cf0b92feeceb6dd7f81dd059.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/12aa2d70cf0b92feeceb6dd7f81dd059.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/12aa2d70cf0b92feeceb6dd7f81dd059.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/12aa2d70cf0b92feeceb6dd7f81dd059.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/23/142023/2","fetch":{"anonymous http":{"url":"https://review.couchbase.org/couchbase-net-client","ref":"refs/changes/23/142023/2","commands":{"Branch":"git fetch https://review.couchbase.org/couchbase-net-client refs/changes/23/142023/2 \u0026\u0026 git checkout -b change-142023 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/couchbase-net-client refs/changes/23/142023/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/couchbase-net-client refs/changes/23/142023/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/couchbase-net-client refs/changes/23/142023/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/couchbase-net-client refs/changes/23/142023/2","Reset To":"git fetch https://review.couchbase.org/couchbase-net-client refs/changes/23/142023/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d6a5df056a8fb3eee576244463745650b1f0d9c2","subject":"NCBC-2752: Improve ToTtl performance"}],"author":{"name":"Brant Burnett","email":"bburnett@centeredgesoftware.com","date":"2020-12-12 21:07:33.000000000","tz":-300},"committer":{"name":"Brant Burnett","email":"bburnett@centeredgesoftware.com","date":"2020-12-14 17:49:18.000000000","tz":-300},"subject":"NCBC-2754: Use Span\u003cT\u003e to build key in VBucketKeyMapper","message":"NCBC-2754: Use Span\u003cT\u003e to build key in VBucketKeyMapper\n\nMotivation\n----------\nImprove the performance of VBucketKeyMapper.GetIndex on modern .NET\nruntimes.\n\nModifications\n-------------\nStack allocate a Span\u003cT\u003e to hold the key and encode directly to this\nspan when using a target runtime that supports the required encoding\noverload.\n\nUse SkipLocalsInitAttribute and C# 9 to avoid the cost of zero-filling\nthe span since the portion we care about will be immediately filled\nby Encoding.UTF8.GetBytes. Note: Without this feature, short keys\n(i.e. 10 bytes) actually take a performance hit.\n\nResults\n-------\nGetIndex has improved performance and is completely free of heap\nallocations on .NET Core 2.1 and later.\n\nBenchmarkDotNet\u003dv0.12.1, OS\u003dWindows 10.0.19042\nIntel Core i7-9750H CPU 2.60GHz, 1 CPU, 12 logical and 6 physical cores\n.NET Core SDK\u003d5.0.101\n  [Host]     : .NET Core 3.1.10 (CoreCLR 4.700.20.51601, CoreFX 4.700.20.51901), X64 RyuJIT\n  DefaultJob : .NET Core 3.1.10 (CoreCLR 4.700.20.51601, CoreFX 4.700.20.51901), X64 RyuJIT\n\n|     Method | KeySize |     Mean |    Error |   StdDev | Ratio | Rank |  Gen 0 | Gen 1 | Gen 2 | Allocated |\n|----------- |-------- |---------:|---------:|---------:|------:|-----:|-------:|------:|------:|----------:|\n|    Current |      10 | 40.18 ns | 0.124 ns | 0.104 ns |  1.00 |    2 | 0.0063 |     - |     - |      40 B |\n| StackAlloc |      10 | 32.89 ns | 0.324 ns | 0.270 ns |  0.82 |    1 |      - |     - |     - |         - |\n|            |         |          |          |          |       |      |        |       |       |           |\n|    Current |      40 | 59.57 ns | 0.270 ns | 0.252 ns |  1.00 |    2 | 0.0101 |     - |     - |      64 B |\n| StackAlloc |      40 | 48.25 ns | 0.296 ns | 0.262 ns |  0.81 |    1 |      - |     - |     - |         - |\n|            |         |          |          |          |       |      |        |       |       |           |\n|    Current |     100 | 94.18 ns | 0.480 ns | 0.449 ns |  1.00 |    2 | 0.0204 |     - |     - |     128 B |\n| StackAlloc |     100 | 81.23 ns | 0.326 ns | 0.305 ns |  0.86 |    1 |      - |     - |     - |         - |\n\nChange-Id: I43dff50f0417eafafc4f551bcb157e4c12e3c4d5\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"d6a5df056a8fb3eee576244463745650b1f0d9c2","is_merged_in_target_branch":true,"change_id":"I6bf4f88cb00cee8d92cb67625e065972b7c4b755","change_number":142019,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"},"c520a70e8b7b26be8713b8b2883b43c1867f8d02":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2020-12-14 19:56:50.000000000","uploader":{"_account_id":1000530,"name":"Jeffry Morris","email":"jeffrymorris@gmail.com","username":"jmorris","avatars":[{"url":"https://www.gravatar.com/avatar/d0b8b4cd259ea37fb99be261e6a720b0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d0b8b4cd259ea37fb99be261e6a720b0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d0b8b4cd259ea37fb99be261e6a720b0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d0b8b4cd259ea37fb99be261e6a720b0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/23/142023/3","fetch":{"anonymous http":{"url":"https://review.couchbase.org/couchbase-net-client","ref":"refs/changes/23/142023/3","commands":{"Branch":"git fetch https://review.couchbase.org/couchbase-net-client refs/changes/23/142023/3 \u0026\u0026 git checkout -b change-142023 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/couchbase-net-client refs/changes/23/142023/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/couchbase-net-client refs/changes/23/142023/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/couchbase-net-client refs/changes/23/142023/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/couchbase-net-client refs/changes/23/142023/3","Reset To":"git fetch https://review.couchbase.org/couchbase-net-client refs/changes/23/142023/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d6a5df056a8fb3eee576244463745650b1f0d9c2","subject":"NCBC-2752: Improve ToTtl performance"}],"author":{"name":"Brant Burnett","email":"bburnett@centeredgesoftware.com","date":"2020-12-12 21:07:33.000000000","tz":-300},"committer":{"name":"Jeffry Morris","email":"jeffrymorris@gmail.com","date":"2020-12-14 19:56:50.000000000","tz":0},"subject":"NCBC-2754: Use Span\u003cT\u003e to build key in VBucketKeyMapper","message":"NCBC-2754: Use Span\u003cT\u003e to build key in VBucketKeyMapper\n\nMotivation\n----------\nImprove the performance of VBucketKeyMapper.GetIndex on modern .NET\nruntimes.\n\nModifications\n-------------\nStack allocate a Span\u003cT\u003e to hold the key and encode directly to this\nspan when using a target runtime that supports the required encoding\noverload.\n\nUse SkipLocalsInitAttribute and C# 9 to avoid the cost of zero-filling\nthe span since the portion we care about will be immediately filled\nby Encoding.UTF8.GetBytes. Note: Without this feature, short keys\n(i.e. 10 bytes) actually take a performance hit.\n\nResults\n-------\nGetIndex has improved performance and is completely free of heap\nallocations on .NET Core 2.1 and later.\n\nBenchmarkDotNet\u003dv0.12.1, OS\u003dWindows 10.0.19042\nIntel Core i7-9750H CPU 2.60GHz, 1 CPU, 12 logical and 6 physical cores\n.NET Core SDK\u003d5.0.101\n  [Host]     : .NET Core 3.1.10 (CoreCLR 4.700.20.51601, CoreFX 4.700.20.51901), X64 RyuJIT\n  DefaultJob : .NET Core 3.1.10 (CoreCLR 4.700.20.51601, CoreFX 4.700.20.51901), X64 RyuJIT\n\n|     Method | KeySize |     Mean |    Error |   StdDev | Ratio | Rank |  Gen 0 | Gen 1 | Gen 2 | Allocated |\n|----------- |-------- |---------:|---------:|---------:|------:|-----:|-------:|------:|------:|----------:|\n|    Current |      10 | 40.18 ns | 0.124 ns | 0.104 ns |  1.00 |    2 | 0.0063 |     - |     - |      40 B |\n| StackAlloc |      10 | 32.89 ns | 0.324 ns | 0.270 ns |  0.82 |    1 |      - |     - |     - |         - |\n|            |         |          |          |          |       |      |        |       |       |           |\n|    Current |      40 | 59.57 ns | 0.270 ns | 0.252 ns |  1.00 |    2 | 0.0101 |     - |     - |      64 B |\n| StackAlloc |      40 | 48.25 ns | 0.296 ns | 0.262 ns |  0.81 |    1 |      - |     - |     - |         - |\n|            |         |          |          |          |       |      |        |       |       |           |\n|    Current |     100 | 94.18 ns | 0.480 ns | 0.449 ns |  1.00 |    2 | 0.0204 |     - |     - |     128 B |\n| StackAlloc |     100 | 81.23 ns | 0.326 ns | 0.305 ns |  0.86 |    1 |      - |     - |     - |         - |\n\nChange-Id: I43dff50f0417eafafc4f551bcb157e4c12e3c4d5\nReviewed-on: http://review.couchbase.org/c/couchbase-net-client/+/142023\nTested-by: Build Bot \u003cbuild@couchbase.com\u003e\nReviewed-by: \u003crichard.ponton@couchbase.com\u003e\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"d6a5df056a8fb3eee576244463745650b1f0d9c2","is_merged_in_target_branch":true,"change_id":"I6bf4f88cb00cee8d92cb67625e065972b7c4b755","change_number":142019,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1004555,"name":"Richard Ponton","email":"richard.ponton@couchbase.com","username":"RiPont","avatars":[{"url":"https://www.gravatar.com/avatar/fd2121b54ddf4a68170b9f607ddb68de.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd2121b54ddf4a68170b9f607ddb68de.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd2121b54ddf4a68170b9f607ddb68de.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd2121b54ddf4a68170b9f607ddb68de.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}},{"label":"Well-Formed","status":"MAY"}]},{"status":"CLOSED"}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Custom-Rule","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Custom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["Custom-Rule"],"failing_atoms":[]}}]}
