)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1004568,"name":"Jared Casey","email":"jared.casey@couchbase.com","username":"thejcfactor","avatars":[{"url":"https://www.gravatar.com/avatar/20ac69da8a1fb4cc11bdd1c880389132.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/20ac69da8a1fb4cc11bdd1c880389132.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/20ac69da8a1fb4cc11bdd1c880389132.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/20ac69da8a1fb4cc11bdd1c880389132.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"698ba21f44a90e543fd9e5d7c7f3c040124c03fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4a85ec78_ec478740","updated":"2025-01-10 02:38:02.000000000","message":"Looks good so far, just some small comments.  I do think all the test fixtures added that use `EnvironmentFeatures.check_if_feature_supported` will need to pass in the patch version of the server.\n\nAlso, TBD on how we will merge this change, so I will probably hold off on the +2 until that path is more clear.","commit_id":"f26b9b5c883a5e60343b94842d127485fb5fedd7"}],"acouchbase/tests/subdoc_t.py":[{"author":{"_account_id":1004568,"name":"Jared Casey","email":"jared.casey@couchbase.com","username":"thejcfactor","avatars":[{"url":"https://www.gravatar.com/avatar/20ac69da8a1fb4cc11bdd1c880389132.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/20ac69da8a1fb4cc11bdd1c880389132.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/20ac69da8a1fb4cc11bdd1c880389132.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/20ac69da8a1fb4cc11bdd1c880389132.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"698ba21f44a90e543fd9e5d7c7f3c040124c03fa","unresolved":true,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    @pytest.fixture(scope\u003d\u0027class\u0027)"},{"line_number":141,"context_line":"    def check_server_groups_supported(self, cb_env):"},{"line_number":142,"context_line":"        EnvironmentFeatures.check_if_feature_supported(\u0027server_groups\u0027,"},{"line_number":143,"context_line":"                                                       cb_env.server_version_short,"},{"line_number":144,"context_line":"                                                       cb_env.mock_server_type)"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"d268aadc_753d00f4","line":142,"updated":"2025-01-10 02:38:02.000000000","message":"I think we need to add `cb_env.server_version_patch` to the `check_if_feature_supported` call since this feature was added in a patch version.\n\nSame will apply to other fixtures.","commit_id":"f26b9b5c883a5e60343b94842d127485fb5fedd7"},{"author":{"_account_id":1005035,"name":"Dimitris Christodoulou","email":"dimitris.christodoulou@couchbase.com","username":"DemetrisChr","avatars":[{"url":"https://www.gravatar.com/avatar/4291f7baa025a5558b77019a9c264ab2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4291f7baa025a5558b77019a9c264ab2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4291f7baa025a5558b77019a9c264ab2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4291f7baa025a5558b77019a9c264ab2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"73d49eebf5a8aa67effbec3b83f93c9e243bab5b","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    @pytest.fixture(scope\u003d\u0027class\u0027)"},{"line_number":141,"context_line":"    def check_server_groups_supported(self, cb_env):"},{"line_number":142,"context_line":"        EnvironmentFeatures.check_if_feature_supported(\u0027server_groups\u0027,"},{"line_number":143,"context_line":"                                                       cb_env.server_version_short,"},{"line_number":144,"context_line":"                                                       cb_env.mock_server_type)"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f933410_8469f87e","line":142,"in_reply_to":"d268aadc_753d00f4","updated":"2025-01-10 12:20:23.000000000","message":"Done","commit_id":"f26b9b5c883a5e60343b94842d127485fb5fedd7"}],"couchbase/replica_reads.py":[{"author":{"_account_id":1004568,"name":"Jared Casey","email":"jared.casey@couchbase.com","username":"thejcfactor","avatars":[{"url":"https://www.gravatar.com/avatar/20ac69da8a1fb4cc11bdd1c880389132.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/20ac69da8a1fb4cc11bdd1c880389132.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/20ac69da8a1fb4cc11bdd1c880389132.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/20ac69da8a1fb4cc11bdd1c880389132.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"698ba21f44a90e543fd9e5d7c7f3c040124c03fa","unresolved":true,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"class ReadPreference(IntEnum):"},{"line_number":5,"context_line":"    NO_PREFERENCE \u003d 0"},{"line_number":6,"context_line":"    SELECTED_SERVER_GROUP \u003d 1"}],"source_content_type":"text/x-python","patch_set":5,"id":"d0927344_86bbc692","line":6,"updated":"2025-01-10 02:38:02.000000000","message":"Should we have `SELECTED_SERVER_GROUP_OR_ALL_AVAILABLE` as well?  Looks like Graham has asked about it in the RFC PR (so TBD apparently).  It is in FIT and the C++ client.","commit_id":"f26b9b5c883a5e60343b94842d127485fb5fedd7"},{"author":{"_account_id":1005035,"name":"Dimitris Christodoulou","email":"dimitris.christodoulou@couchbase.com","username":"DemetrisChr","avatars":[{"url":"https://www.gravatar.com/avatar/4291f7baa025a5558b77019a9c264ab2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4291f7baa025a5558b77019a9c264ab2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4291f7baa025a5558b77019a9c264ab2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4291f7baa025a5558b77019a9c264ab2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7dc771585139de7689e2de5209a04adfba4bcc4f","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"class ReadPreference(IntEnum):"},{"line_number":5,"context_line":"    NO_PREFERENCE \u003d 0"},{"line_number":6,"context_line":"    SELECTED_SERVER_GROUP \u003d 1"}],"source_content_type":"text/x-python","patch_set":5,"id":"30831464_8c61df8f","line":6,"in_reply_to":"d0927344_86bbc692","updated":"2025-01-10 11:02:50.000000000","message":"Mentions of it were removed from most parts of the RFC, though there is still a reference to it. So from this I understood that the intention is that don\u0027t want to include it at this stage. In FIT it\u0027s behind a separate cap. Still, it would be good to get clarity on the RFC, so I\u0027ll revisit this if necessary.","commit_id":"f26b9b5c883a5e60343b94842d127485fb5fedd7"}]}