)]}'
{"couchbase/__init__.py":[{"author":{"_account_id":1005035,"name":"Dimitris Christodoulou","email":"dimitris.christodoulou@couchbase.com","username":"DemetrisChr","avatars":[{"url":"https://www.gravatar.com/avatar/4291f7baa025a5558b77019a9c264ab2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4291f7baa025a5558b77019a9c264ab2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4291f7baa025a5558b77019a9c264ab2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4291f7baa025a5558b77019a9c264ab2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"accbfc23196135fb4ef9555cb6783df1aacd4c89","unresolved":true,"context_lines":[{"line_number":146,"context_line":"    if log_level:"},{"line_number":147,"context_line":"        log_file \u003d os.getenv(\u0027PYCBC_LOG_FILE\u0027, None)"},{"line_number":148,"context_line":"        if log_file:"},{"line_number":149,"context_line":"            enable_console_logging \u003d 0 if os.getenv(\u0027PYCBC_ENABLE_CONSOLE\u0027, None) is None else 1"},{"line_number":150,"context_line":"            _PYCBC_LOGGER.create_logger(level\u003dlog_level.lower(),"},{"line_number":151,"context_line":"                                        filename\u003dlog_file,"},{"line_number":152,"context_line":"                                        enable_console\u003denable_console_logging)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5952fd68_4693b9e2","line":149,"updated":"2025-04-16 16:46:06.000000000","message":"If someone sets `PYCBC_ENABLE_CONSOLE\u003dFalse` or something similar, that gets interpreted as `enable_console_logging \u003d 1`.\n\nWould it be a good idea to have something more similar to our build-related environment variables where we recognize a range of truthy values (yes/true/y/on/1) and treat other values as false?","commit_id":"713973b4e503dd79e9fe3f27e238506ccf5f423c"},{"author":{"_account_id":1005035,"name":"Dimitris Christodoulou","email":"dimitris.christodoulou@couchbase.com","username":"DemetrisChr","avatars":[{"url":"https://www.gravatar.com/avatar/4291f7baa025a5558b77019a9c264ab2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4291f7baa025a5558b77019a9c264ab2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4291f7baa025a5558b77019a9c264ab2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4291f7baa025a5558b77019a9c264ab2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"0502d62f5e45b3a2783ffba42b80bdaf043e2f1d","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    if log_level:"},{"line_number":147,"context_line":"        log_file \u003d os.getenv(\u0027PYCBC_LOG_FILE\u0027, None)"},{"line_number":148,"context_line":"        if log_file:"},{"line_number":149,"context_line":"            enable_console_logging \u003d 0 if os.getenv(\u0027PYCBC_ENABLE_CONSOLE\u0027, None) is None else 1"},{"line_number":150,"context_line":"            _PYCBC_LOGGER.create_logger(level\u003dlog_level.lower(),"},{"line_number":151,"context_line":"                                        filename\u003dlog_file,"},{"line_number":152,"context_line":"                                        enable_console\u003denable_console_logging)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ebcd9727_2a71f679","line":149,"in_reply_to":"3dac31fd_e5696fce","updated":"2025-04-17 08:25:34.000000000","message":"That sounds reasonable","commit_id":"713973b4e503dd79e9fe3f27e238506ccf5f423c"},{"author":{"_account_id":1004568,"name":"Jared Casey","email":"jared.casey@couchbase.com","username":"thejcfactor","avatars":[{"url":"https://www.gravatar.com/avatar/20ac69da8a1fb4cc11bdd1c880389132.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/20ac69da8a1fb4cc11bdd1c880389132.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/20ac69da8a1fb4cc11bdd1c880389132.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/20ac69da8a1fb4cc11bdd1c880389132.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"fb7651663fb133fb0b97a0801c38038858eb9df3","unresolved":true,"context_lines":[{"line_number":146,"context_line":"    if log_level:"},{"line_number":147,"context_line":"        log_file \u003d os.getenv(\u0027PYCBC_LOG_FILE\u0027, None)"},{"line_number":148,"context_line":"        if log_file:"},{"line_number":149,"context_line":"            enable_console_logging \u003d 0 if os.getenv(\u0027PYCBC_ENABLE_CONSOLE\u0027, None) is None else 1"},{"line_number":150,"context_line":"            _PYCBC_LOGGER.create_logger(level\u003dlog_level.lower(),"},{"line_number":151,"context_line":"                                        filename\u003dlog_file,"},{"line_number":152,"context_line":"                                        enable_console\u003denable_console_logging)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3dac31fd_e5696fce","line":149,"in_reply_to":"5952fd68_4693b9e2","updated":"2025-04-17 01:45:59.000000000","message":"I had exactly that initially (checking for `[\u0027true\u0027, \u00271\u0027, \u0027y\u0027, \u0027yes\u0027, \u0027on\u0027]`).  But then I got to thinking that since `PYCBC_ENABLE_CONSOLE` is a flag and the _only_ reason to use it would be to have both file logging and console logging I cannot see the usecase for checking if it is true/false. If one wants file logging and doesn\u0027t want console logging there is no reason to bother with `PYCBC_ENABLE_CONSOLE`.","commit_id":"713973b4e503dd79e9fe3f27e238506ccf5f423c"}]}