)]}'
{"id":"ep-engine~13181","triplet_id":"ep-engine~master~Ibbbe618184d6e3004cd6ed8b261fd33ad6d9e39c","project":"ep-engine","branch":"master","hashtags":[],"change_id":"Ibbbe618184d6e3004cd6ed8b261fd33ad6d9e39c","subject":"cbrestore multithreading fix.","status":"ABANDONED","created":"2012-02-13 02:51:35.000000000","updated":"2014-03-11 22:58:32.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"911d10da2e4ba5938e0c748cff7407c077f52ce3","_number":13181,"virtual_id_number":13181,"owner":{"_account_id":1000000,"name":"Dustin Sallings","email":"dustin@spy.net","username":"dustin","avatars":[{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Verified":{"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"values":{"-2":"Do not submit","-1":"I would prefer that you didn\u0027t submit this"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Well-Formed":{"values":{"-1":"Commit is not well-formed"," 0":"Well-formedness not checked","+1":"Commit is well-formed"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{},"pending_reviewers":{},"reviewer_updates":[],"messages":[{"id":"3b8b58583275af0735637b25c630ad14c26d4c33","author":{"_account_id":1000000,"name":"Dustin Sallings","email":"dustin@spy.net","username":"dustin","avatars":[{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2012-02-13 02:53:07.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"18171063dc3b47c95216702b74f7c0a931e22a8e","author":{"_account_id":1000000,"name":"Dustin Sallings","email":"dustin@spy.net","username":"dustin","avatars":[{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2012-02-13 02:56:05.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n(1 inline comment)\n\nI think this mostly looks right, but the abs() thing confuses me a bit.  It seems like it might cover up a bug or something.","accounts_in_message":[],"_revision_number":2},{"id":"f7d1076c93f4a45ed6fba85bc8f778a6a67a271e","author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2012-09-25 21:06:05.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t submit this\n\nDustin,\n\ncbrestore is no longer used in ep-engine. Please abandon this change.","accounts_in_message":[],"_revision_number":2},{"id":"911d10da2e4ba5938e0c748cff7407c077f52ce3","author":{"_account_id":1000097,"name":"Chiyoung Seo","email":"chiyoung@northscale.com","username":"chiyoung","avatars":[{"url":"https://www.gravatar.com/avatar/ec517f4126dd292151b452ce4d1edf31.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ec517f4126dd292151b452ce4d1edf31.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ec517f4126dd292151b452ce4d1edf31.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ec517f4126dd292151b452ce4d1edf31.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2014-03-11 22:58:32.000000000","message":"Abandoned\n\nAbandon it as the cbresotre is managed separately.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"00505655780243009d37ec8abccd8ab5934e8f9a","revisions":{"cb4f5019a4affacc17e343f9817854f922ba0200":{"kind":"REWORK","_number":1,"created":"2012-02-13 02:51:35.000000000","uploader":{"_account_id":1000000,"name":"Dustin Sallings","email":"dustin@spy.net","username":"dustin","avatars":[{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/81/13181/1","fetch":{"anonymous http":{"url":"https://review.couchbase.org/ep-engine","ref":"refs/changes/81/13181/1","commands":{"Branch":"git fetch https://review.couchbase.org/ep-engine refs/changes/81/13181/1 \u0026\u0026 git checkout -b change-13181 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/ep-engine refs/changes/81/13181/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/ep-engine refs/changes/81/13181/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/ep-engine refs/changes/81/13181/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/ep-engine refs/changes/81/13181/1","Reset To":"git fetch https://review.couchbase.org/ep-engine refs/changes/81/13181/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3954566883e1b5a1e9c97412f104dd431c5d1a4f","subject":"Merge branch \u0027branch-17\u0027"}],"author":{"name":"traqy","email":"btraquena@gmail.com","date":"2012-02-03 05:16:42.000000000","tz":480},"committer":{"name":"Dustin Sallings","email":"dustin@spy.net","date":"2012-02-13 02:51:07.000000000","tz":-480},"subject":"cbrestore multithreading fix.","message":"cbrestore multithreading fix.\n\nThe current code base does not actually propagate the value assigned\nto opts.threads (-t). Even the DEFAULT_THREADS is also not\npropagated. The script \"cbrestore\" always create one thread instance\nfor worker function. As a result, it can restore only upto 700\nitems/sec.\n\nThis bug fix is tested in our production platform and we\u0027ve managed to\nrestore db files at 3.5k to 5k items/sec on each node running\ncbrestore process to all nodes in parallel. For nine node-cluster, we\nwere able to restore at 30k to 36k items/sec. At 100 million items, we\nwere able to restore it within an hour.\n\nopts.threads is not properly propagated to worker threads instantiation.\n\nPreviously, there\u0027s only one thread worker will be instantiated even\nif the DEFAULT_THREADS is 4.\n\nChange-Id: Ibbbe618184d6e3004cd6ed8b261fd33ad6d9e39c\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"3954566883e1b5a1e9c97412f104dd431c5d1a4f","is_merged_in_target_branch":true,"change_id":"Ic1500f1d075274beeb5c37b882a35ac85059dafe","change_number":13074,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"},"00505655780243009d37ec8abccd8ab5934e8f9a":{"kind":"REWORK","_number":2,"created":"2012-02-13 02:53:07.000000000","uploader":{"_account_id":1000000,"name":"Dustin Sallings","email":"dustin@spy.net","username":"dustin","avatars":[{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/81/13181/2","fetch":{"anonymous http":{"url":"https://review.couchbase.org/ep-engine","ref":"refs/changes/81/13181/2","commands":{"Branch":"git fetch https://review.couchbase.org/ep-engine refs/changes/81/13181/2 \u0026\u0026 git checkout -b change-13181 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/ep-engine refs/changes/81/13181/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/ep-engine refs/changes/81/13181/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/ep-engine refs/changes/81/13181/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/ep-engine refs/changes/81/13181/2","Reset To":"git fetch https://review.couchbase.org/ep-engine refs/changes/81/13181/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3954566883e1b5a1e9c97412f104dd431c5d1a4f","subject":"Merge branch \u0027branch-17\u0027"}],"author":{"name":"traqy","email":"btraquena@gmail.com","date":"2012-02-03 05:16:42.000000000","tz":480},"committer":{"name":"Dustin Sallings","email":"dustin@spy.net","date":"2012-02-13 02:52:56.000000000","tz":-480},"subject":"cbrestore multithreading fix.","message":"cbrestore multithreading fix.\n\nThe current code base does not actually propagate the value assigned\nto opts.threads (-t). Even the DEFAULT_THREADS is also not\npropagated. The script \"cbrestore\" always create one thread instance\nfor worker function. As a result, it can restore only upto 700\nitems/sec.\n\nThis bug fix is tested in our production platform and we\u0027ve managed to\nrestore db files at 3.5k to 5k items/sec on each node running\ncbrestore process to all nodes in parallel. For nine node-cluster, we\nwere able to restore at 30k to 36k items/sec. At 100 million items, we\nwere able to restore it within an hour.\n\nopts.threads is not properly propagated to worker threads instantiation.\n\nPreviously, there\u0027s only one thread worker will be instantiated even\nif the DEFAULT_THREADS is 4.\n\nChange-Id: Ibbbe618184d6e3004cd6ed8b261fd33ad6d9e39c\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"3954566883e1b5a1e9c97412f104dd431c5d1a4f","is_merged_in_target_branch":true,"change_id":"Ic1500f1d075274beeb5c37b882a35ac85059dafe","change_number":13074,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}