)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000489,"name":"Sundar Sridharan","email":"sundar@couchbase.com","username":"sundar","avatars":[{"url":"https://www.gravatar.com/avatar/c4b296426c3566f9fc7c5d6a7276df15.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c4b296426c3566f9fc7c5d6a7276df15.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c4b296426c3566f9fc7c5d6a7276df15.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c4b296426c3566f9fc7c5d6a7276df15.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"de0124575ea82f76c74fec429d98fb00c713ea4f","unresolved":false,"context_lines":[{"line_number":19,"context_line":"\t#6 wait_for_stat_change(engine_interface*, engine_interface_v1*, char const*, int, char const*) /repos/couchbase/server/source/ep-engine/tests/ep_test_apis.cc:846 (ep_testsuite.so+0x0000000838d6)"},{"line_number":20,"context_line":"\t#7 test_setup /repos/couchbase/server/source/ep-engine/tests/ep_testsuite.cc:178 (ep_testsuite.so+0x00000001ee69)"},{"line_number":21,"context_line":"\t#8 execute_test /repos/couchbase/server/source/memcached/programs/engine_testapp/engine_testapp.c:1050 (exe+0x000000005970)"},{"line_number":22,"context_line":"\t#9 main /repos/couchbase/server/source/memcached/programs/engine_testapp/engine_testapp.c:1313 (exe+0x000000006606)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"      Previous write of size 8 at 0x7fec86e44de0 by thread T7:"},{"line_number":25,"context_line":"\t#0 gmtime ??:0 (libtsan.so.0+0x000000025135)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"cc62b0bf_3a335df4","line":22,"updated":"2014-11-17 19:03:38.000000000","message":"Thanks Dave, If possible can you please shorten the commit messages limiting the lines to 80 characters.\nYou can copy paste the stack trace into gerrit comment if you like, since the commit message carries the link to gerrit.\nthanks","commit_id":"d0d69fca1ad18252d48b3b1f5b1f438bb973e723"},{"author":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"221a2cf3d0a40b9c2e77b90917166760db404079","unresolved":false,"context_lines":[{"line_number":19,"context_line":"\t#6 wait_for_stat_change(engine_interface*, engine_interface_v1*, char const*, int, char const*) /repos/couchbase/server/source/ep-engine/tests/ep_test_apis.cc:846 (ep_testsuite.so+0x0000000838d6)"},{"line_number":20,"context_line":"\t#7 test_setup /repos/couchbase/server/source/ep-engine/tests/ep_testsuite.cc:178 (ep_testsuite.so+0x00000001ee69)"},{"line_number":21,"context_line":"\t#8 execute_test /repos/couchbase/server/source/memcached/programs/engine_testapp/engine_testapp.c:1050 (exe+0x000000005970)"},{"line_number":22,"context_line":"\t#9 main /repos/couchbase/server/source/memcached/programs/engine_testapp/engine_testapp.c:1313 (exe+0x000000006606)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"      Previous write of size 8 at 0x7fec86e44de0 by thread T7:"},{"line_number":25,"context_line":"\t#0 gmtime ??:0 (libtsan.so.0+0x000000025135)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"cc62b0bf_1a75b956","line":22,"in_reply_to":"cc62b0bf_3a335df4","updated":"2014-11-17 21:35:32.000000000","message":"Hi Sundar,\n\nIn general I agree to keep human-written commit messages wrapped at ~78 chars, but in this instance wrapping the tool\u0027s output essentially makes it harder to follow, not easier.\n\nNote there\u0027s plenty of precedent for this approach - e.g. Linux kernel git messages: \n\nhttps://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id\u003d242bcd5ba1dcea802c0ad03344f626a727212399\n\nhttps://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id\u003db3ecba096729f521312d1863ad22530695527aed\n\nRegarding using a gerrit comment - while gerrit is our current review system it isn\u0027t guaranteed to be forever, and hence I believe it\u0027s better to keep the information on the \"why\" behind this patch with the commit message, then it will always be associated with the code.","commit_id":"d0d69fca1ad18252d48b3b1f5b1f438bb973e723"}]}