)]}'
{"src/atomic.h":[{"author":{"_account_id":1001546,"name":"Jim Walker","email":"jim@couchbase.com","username":"jim","avatars":[{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"8d9dae02d1bd98dd49ea63be4d8f3ba0a8a486cf","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    void store(const T \u0026newValue, memory_order sync \u003d memory_order_acq_rel) {"},{"line_number":83,"context_line":"        (void) sync;"},{"line_number":84,"context_line":"        ep_sync_lock_test_and_set(\u0026value, newValue);"},{"line_number":85,"context_line":"    }"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"c028ba83_94e1ece8","line":84,"updated":"2015-06-15 20:45:56.000000000","message":"I have one concern that ep_sync_lock_test_and_set only has a implementation using int for newValue. This could cause issues when T is a smaller size. That seem valid?","commit_id":"60316bb4608f56bd3533efe42896f8e31dffe9cd"},{"author":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"0855691ad029d084696fe0d827433154085d4227","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    void store(const T \u0026newValue, memory_order sync \u003d memory_order_acq_rel) {"},{"line_number":83,"context_line":"        (void) sync;"},{"line_number":84,"context_line":"        ep_sync_lock_test_and_set(\u0026value, newValue);"},{"line_number":85,"context_line":"    }"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"c028ba83_7445607d","line":84,"in_reply_to":"c028ba83_94e1ece8","updated":"2015-06-16 07:59:23.000000000","message":"While it\u0027s true the lib atomic header only declares a variant for int, we actually use gcc_atomics.h for CentOS6 (and probably other Linuxes). I\u0027ve added a test to this patch to confirm it does work correctly.","commit_id":"60316bb4608f56bd3533efe42896f8e31dffe9cd"}]}