)]}'
{"src/flusher.cc":[{"author":{"_account_id":1000489,"name":"Sundar Sridharan","email":"sundar@couchbase.com","username":"sundar","avatars":[{"url":"https://www.gravatar.com/avatar/c4b296426c3566f9fc7c5d6a7276df15.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c4b296426c3566f9fc7c5d6a7276df15.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c4b296426c3566f9fc7c5d6a7276df15.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c4b296426c3566f9fc7c5d6a7276df15.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"12a39caf1a9bcb1d34428eff6103e298f3a3e85a","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        LOG(EXTENSION_LOG_WARNING, \"Double start in flusher task id %llu: %s\","},{"line_number":145,"context_line":"                taskId.load(), stateName());"},{"line_number":146,"context_line":"        return;"},{"line_number":147,"context_line":"    }"},{"line_number":148,"context_line":"    schedule_UNLOCKED();"},{"line_number":149,"context_line":"}"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-c","patch_set":1,"id":"c0d8ba6d_3dadfbd4","line":147,"updated":"2015-07-15 19:24:35.000000000","message":"we might need something like } else { taskId \u003d \u003ca non-zero value\u003e; to ensure that schedule_UNLOCKED(); runs correctly.\nthanks","commit_id":"793c1670f1da17837fbae3e7245df55a8c94b323"},{"author":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b0e8fce141254137910181139d23558055d8965e","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        LOG(EXTENSION_LOG_WARNING, \"Double start in flusher task id %llu: %s\","},{"line_number":145,"context_line":"                taskId.load(), stateName());"},{"line_number":146,"context_line":"        return;"},{"line_number":147,"context_line":"    }"},{"line_number":148,"context_line":"    schedule_UNLOCKED();"},{"line_number":149,"context_line":"}"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-c","patch_set":1,"id":"c0d8ba6d_283ed792","line":147,"in_reply_to":"c0d8ba6d_0839dbe0","updated":"2015-07-16 10:29:48.000000000","message":"I went with restoring the mutex and using that to serialize access to start(). \n\nThe issue with CAS is that there isn\u0027t another \"temporary\" value to set taskId to other than zero; i.e. ideally we\u0027d CAS from 0 (uninitialised) to XXX (starting), then call schedule_UNLOCKED(), which would change from XXX to the real task ID.","commit_id":"793c1670f1da17837fbae3e7245df55a8c94b323"},{"author":{"_account_id":1000489,"name":"Sundar Sridharan","email":"sundar@couchbase.com","username":"sundar","avatars":[{"url":"https://www.gravatar.com/avatar/c4b296426c3566f9fc7c5d6a7276df15.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c4b296426c3566f9fc7c5d6a7276df15.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c4b296426c3566f9fc7c5d6a7276df15.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c4b296426c3566f9fc7c5d6a7276df15.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c2df4aa09a777318b73fe2c89cb181d9977a11f1","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        LOG(EXTENSION_LOG_WARNING, \"Double start in flusher task id %llu: %s\","},{"line_number":145,"context_line":"                taskId.load(), stateName());"},{"line_number":146,"context_line":"        return;"},{"line_number":147,"context_line":"    }"},{"line_number":148,"context_line":"    schedule_UNLOCKED();"},{"line_number":149,"context_line":"}"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-c","patch_set":1,"id":"c0d8ba6d_fd753394","line":147,"in_reply_to":"c0d8ba6d_3dadfbd4","updated":"2015-07-15 19:28:43.000000000","message":"or rather a cas() operation to ensure that schedule_UNLOCKED() gets called only once right?","commit_id":"793c1670f1da17837fbae3e7245df55a8c94b323"},{"author":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"cf07b81cb83a11329bd4ced2314795c2cbd3b7e0","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        LOG(EXTENSION_LOG_WARNING, \"Double start in flusher task id %llu: %s\","},{"line_number":145,"context_line":"                taskId.load(), stateName());"},{"line_number":146,"context_line":"        return;"},{"line_number":147,"context_line":"    }"},{"line_number":148,"context_line":"    schedule_UNLOCKED();"},{"line_number":149,"context_line":"}"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-c","patch_set":1,"id":"c0d8ba6d_0839dbe0","line":147,"in_reply_to":"c0d8ba6d_fd753394","updated":"2015-07-16 09:39:39.000000000","message":"Good spot. I\u0027ll change to a CAS.","commit_id":"793c1670f1da17837fbae3e7245df55a8c94b323"}]}