)]}'
{"src/dcp/stream.cc":[{"author":{"_account_id":1001546,"name":"Jim Walker","email":"jim@couchbase.com","username":"jim","avatars":[{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"1cb770d1cd890768ed7b8c2a0fdd8d887ce1830a","unresolved":false,"context_lines":[{"line_number":361,"context_line":"            itemsReady \u003d true;"},{"line_number":362,"context_line":"            lh.unlock();"},{"line_number":363,"context_line":"            if (transitionVbucket) {"},{"line_number":364,"context_line":"                engine-\u003egetEpStore()-\u003esetVBucketState(vb_, vbucket_state_dead,"},{"line_number":365,"context_line":"                                                      false, false);"},{"line_number":366,"context_line":"            }"},{"line_number":367,"context_line":"            producer-\u003enotifyStreamReady(vb_, true);"}],"source_content_type":"text/x-c","patch_set":7,"id":"fdee4902_509f8ca3","line":364,"updated":"2015-11-23 12:14:08.000000000","message":"we can\u0027t be holding the stream lock whilst then going for setVbucketState (vbucket state write lock) as there\u0027s a lock ordering inversion risk. Upcoming DCP performance changes maybe able to tidy this up further as itemsReady becomes atomic","commit_id":"b8e9c942aee5b227ac0f8d90c74852d29f53d03d"}],"src/ep.cc":[{"author":{"_account_id":1000097,"name":"Chiyoung Seo","email":"chiyoung@northscale.com","username":"chiyoung","avatars":[{"url":"https://www.gravatar.com/avatar/ec517f4126dd292151b452ce4d1edf31.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ec517f4126dd292151b452ce4d1edf31.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ec517f4126dd292151b452ce4d1edf31.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ec517f4126dd292151b452ce4d1edf31.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"cd0bdbb8e42ce0e979e76e533466c3902eb67660","unresolved":false,"context_lines":[{"line_number":2169,"context_line":"{"},{"line_number":2170,"context_line":"    (void) cookie;"},{"line_number":2171,"context_line":"    RCPtr\u003cVBucket\u003e vb \u003d getVBucket(vbucket);"},{"line_number":2172,"context_line":"    if (!vb || vb-\u003egetState() \u003d\u003d vbucket_state_dead ||"},{"line_number":2173,"context_line":"        vb-\u003egetState() \u003d\u003d vbucket_state_replica) {"},{"line_number":2174,"context_line":"        ++stats.numNotMyVBuckets;"},{"line_number":2175,"context_line":"        return ENGINE_NOT_MY_VBUCKET;"}],"source_content_type":"text/x-c","patch_set":7,"id":"fdee4902_108fc420","side":"PARENT","line":2172,"updated":"2015-11-23 18:47:18.000000000","message":"Same as above comment","commit_id":"6421dec75af97191c8e331536e70af6be60fa5b3"},{"author":{"_account_id":1001547,"name":"Dan Owen","email":"owend@couchbase.com","username":"owend","avatars":[{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"0802a4a663efd7214649a8ca88e429d3ad85141f","unresolved":false,"context_lines":[{"line_number":1939,"context_line":"                                if (v-\u003eisTempInitialItem() ||"},{"line_number":1940,"context_line":"                                    (!v-\u003eisResident() \u0026\u0026 !v-\u003eisDeleted())) {"},{"line_number":1941,"context_line":"                                    restore \u003d true;"},{"line_number":1942,"context_line":"                                }"},{"line_number":1943,"context_line":"                            }"},{"line_number":1944,"context_line":"                            break;"},{"line_number":1945,"context_line":"                        default:"}],"source_content_type":"text/x-c","patch_set":7,"id":"fdee4902_90adf490","line":1942,"updated":"2015-11-23 17:40:31.000000000","message":"Can\u0027t it be....\n\n if (v \u0026\u0026 (v-\u003eisTempInitialItem() || (!v-\u003eisResident() \u0026\u0026 !v-\u003eisDeleted())))","commit_id":"b8e9c942aee5b227ac0f8d90c74852d29f53d03d"},{"author":{"_account_id":1000097,"name":"Chiyoung Seo","email":"chiyoung@northscale.com","username":"chiyoung","avatars":[{"url":"https://www.gravatar.com/avatar/ec517f4126dd292151b452ce4d1edf31.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ec517f4126dd292151b452ce4d1edf31.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ec517f4126dd292151b452ce4d1edf31.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ec517f4126dd292151b452ce4d1edf31.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"cd0bdbb8e42ce0e979e76e533466c3902eb67660","unresolved":false,"context_lines":[{"line_number":2068,"context_line":"    }"},{"line_number":2069,"context_line":""},{"line_number":2070,"context_line":"    int bucket_num(0);"},{"line_number":2071,"context_line":"    ReaderLockHolder rlh(vb-\u003egetStateLock());"},{"line_number":2072,"context_line":"    LockHolder lh \u003d vb-\u003eht.getLockedBucket(key, \u0026bucket_num);"},{"line_number":2073,"context_line":"    StoredValue *v \u003d fetchValidValue(vb, key, bucket_num, true,"},{"line_number":2074,"context_line":"                                     trackReference);"}],"source_content_type":"text/x-c","patch_set":7,"id":"fdee4902_3092c84c","line":2071,"updated":"2015-11-23 18:47:18.000000000","message":"Shouldn\u0027t we move this to the line 2058, so that we can check a vbucket state while a state lock is grabbed? Please correct me if I\u0027m wrong.","commit_id":"b8e9c942aee5b227ac0f8d90c74852d29f53d03d"},{"author":{"_account_id":1000097,"name":"Chiyoung Seo","email":"chiyoung@northscale.com","username":"chiyoung","avatars":[{"url":"https://www.gravatar.com/avatar/ec517f4126dd292151b452ce4d1edf31.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ec517f4126dd292151b452ce4d1edf31.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ec517f4126dd292151b452ce4d1edf31.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ec517f4126dd292151b452ce4d1edf31.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"cd0bdbb8e42ce0e979e76e533466c3902eb67660","unresolved":false,"context_lines":[{"line_number":2382,"context_line":"        }"},{"line_number":2383,"context_line":"    }"},{"line_number":2384,"context_line":""},{"line_number":2385,"context_line":"    ReaderLockHolder rlh(vb-\u003egetStateLock());"},{"line_number":2386,"context_line":"    int bucket_num(0);"},{"line_number":2387,"context_line":"    LockHolder lh \u003d vb-\u003eht.getLockedBucket(key, \u0026bucket_num);"},{"line_number":2388,"context_line":"    StoredValue *v \u003d fetchValidValue(vb, key, bucket_num, true);"}],"source_content_type":"text/x-c","patch_set":7,"id":"fdee4902_f07c4031","line":2385,"updated":"2015-11-23 18:47:18.000000000","message":"Same as above comment","commit_id":"b8e9c942aee5b227ac0f8d90c74852d29f53d03d"}]}