)]}'
{"src/connmap.cc":[{"author":{"_account_id":1000097,"name":"Chiyoung Seo","email":"chiyoung@northscale.com","username":"chiyoung","avatars":[{"url":"https://www.gravatar.com/avatar/ec517f4126dd292151b452ce4d1edf31.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ec517f4126dd292151b452ce4d1edf31.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ec517f4126dd292151b452ce4d1edf31.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ec517f4126dd292151b452ce4d1edf31.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"394e6431639c61bcc39442d7df32252bd7ac15e7","unresolved":false,"context_lines":[{"line_number":753,"context_line":"    LockHolder lh(connsLock);"},{"line_number":754,"context_line":"    for (ii \u003d all.begin(); ii !\u003d all.end(); ++ii) {"},{"line_number":755,"context_line":"        toRelease.push_back(*ii);"},{"line_number":756,"context_line":"    }"},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"    all.clear();"},{"line_number":759,"context_line":"    map_.clear();"}],"source_content_type":"text/x-c","patch_set":3,"id":"fd3c8952_c9f8a903","line":756,"updated":"2016-01-14 03:20:35.000000000","message":"You can simply create the cloned vector or list by passing all.begin() and all.end() to the constructor.","commit_id":"67eb00e9f57e3fb2c7994d8e05425387c120a970"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"69250d7b4f2b2d06bebd055699f1a3d99c96cf75","unresolved":false,"context_lines":[{"line_number":753,"context_line":"    LockHolder lh(connsLock);"},{"line_number":754,"context_line":"    for (ii \u003d all.begin(); ii !\u003d all.end(); ++ii) {"},{"line_number":755,"context_line":"        toRelease.push_back(*ii);"},{"line_number":756,"context_line":"    }"},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"    all.clear();"},{"line_number":759,"context_line":"    map_.clear();"}],"source_content_type":"text/x-c","patch_set":3,"id":"fd3c8952_a90c4548","line":756,"in_reply_to":"fd3c8952_c9f8a903","updated":"2016-01-14 03:26:38.000000000","message":"Done","commit_id":"67eb00e9f57e3fb2c7994d8e05425387c120a970"},{"author":{"_account_id":1000097,"name":"Chiyoung Seo","email":"chiyoung@northscale.com","username":"chiyoung","avatars":[{"url":"https://www.gravatar.com/avatar/ec517f4126dd292151b452ce4d1edf31.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ec517f4126dd292151b452ce4d1edf31.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ec517f4126dd292151b452ce4d1edf31.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ec517f4126dd292151b452ce4d1edf31.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"394e6431639c61bcc39442d7df32252bd7ac15e7","unresolved":false,"context_lines":[{"line_number":761,"context_line":"    lh.unlock();"},{"line_number":762,"context_line":""},{"line_number":763,"context_line":"    LockHolder rlh(releaseLock);"},{"line_number":764,"context_line":"    for (ii \u003d toRelease.begin(); ii !\u003d toRelease.end(); ++ii) {"},{"line_number":765,"context_line":"        LOG(EXTENSION_LOG_NOTICE, \"Clean up \\\"%s\\\"\", (*ii)-\u003egetName().c_str());"},{"line_number":766,"context_line":"        (*ii)-\u003ereleaseReference();"},{"line_number":767,"context_line":"        TapProducer *tp \u003d dynamic_cast\u003cTapProducer*\u003e((*ii).get());"}],"source_content_type":"text/x-c","patch_set":3,"id":"fd3c8952_69fe3dee","line":764,"updated":"2016-01-14 03:20:35.000000000","message":"for (auto ...) to leverage C++ 11 support?","commit_id":"67eb00e9f57e3fb2c7994d8e05425387c120a970"},{"author":{"_account_id":1000338,"name":"Abhi Dangeti","email":"abhinav@couchbase.com","username":"abhinavdangeti","avatars":[{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9007099855b1bf7d96e9c1a10bc9542e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"69250d7b4f2b2d06bebd055699f1a3d99c96cf75","unresolved":false,"context_lines":[{"line_number":761,"context_line":"    lh.unlock();"},{"line_number":762,"context_line":""},{"line_number":763,"context_line":"    LockHolder rlh(releaseLock);"},{"line_number":764,"context_line":"    for (ii \u003d toRelease.begin(); ii !\u003d toRelease.end(); ++ii) {"},{"line_number":765,"context_line":"        LOG(EXTENSION_LOG_NOTICE, \"Clean up \\\"%s\\\"\", (*ii)-\u003egetName().c_str());"},{"line_number":766,"context_line":"        (*ii)-\u003ereleaseReference();"},{"line_number":767,"context_line":"        TapProducer *tp \u003d dynamic_cast\u003cTapProducer*\u003e((*ii).get());"}],"source_content_type":"text/x-c","patch_set":3,"id":"fd3c8952_c9118963","line":764,"in_reply_to":"fd3c8952_69fe3dee","updated":"2016-01-14 03:26:38.000000000","message":"Done","commit_id":"67eb00e9f57e3fb2c7994d8e05425387c120a970"},{"author":{"_account_id":1000097,"name":"Chiyoung Seo","email":"chiyoung@northscale.com","username":"chiyoung","avatars":[{"url":"https://www.gravatar.com/avatar/ec517f4126dd292151b452ce4d1edf31.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ec517f4126dd292151b452ce4d1edf31.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ec517f4126dd292151b452ce4d1edf31.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ec517f4126dd292151b452ce4d1edf31.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"394e6431639c61bcc39442d7df32252bd7ac15e7","unresolved":false,"context_lines":[{"line_number":1026,"context_line":"    LockHolder lh(connsLock);"},{"line_number":1027,"context_line":"    for (ii \u003d all.begin(); ii !\u003d all.end(); ++ii) {"},{"line_number":1028,"context_line":"        toRelease.push_back(*ii);"},{"line_number":1029,"context_line":"    }"},{"line_number":1030,"context_line":""},{"line_number":1031,"context_line":"    closeAllStreams_UNLOCKED();"},{"line_number":1032,"context_line":"    cancelAllTasks_UNLOCKED();"}],"source_content_type":"text/x-c","patch_set":3,"id":"fd3c8952_4905791e","line":1029,"updated":"2016-01-14 03:20:35.000000000","message":"Same comment as above","commit_id":"67eb00e9f57e3fb2c7994d8e05425387c120a970"},{"author":{"_account_id":1000097,"name":"Chiyoung Seo","email":"chiyoung@northscale.com","username":"chiyoung","avatars":[{"url":"https://www.gravatar.com/avatar/ec517f4126dd292151b452ce4d1edf31.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ec517f4126dd292151b452ce4d1edf31.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ec517f4126dd292151b452ce4d1edf31.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ec517f4126dd292151b452ce4d1edf31.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"6883d4c9791eff8fb20e3da29d5da3641ce9f199","unresolved":false,"context_lines":[{"line_number":749,"context_line":""},{"line_number":750,"context_line":""},{"line_number":751,"context_line":"    LockHolder lh(connsLock);"},{"line_number":752,"context_line":"    std::list\u003cconnection_t\u003e toRelease(all.begin(), all.end());"},{"line_number":753,"context_line":""},{"line_number":754,"context_line":"    all.clear();"},{"line_number":755,"context_line":"    map_.clear();"}],"source_content_type":"text/x-c","patch_set":4,"id":"fd3c8952_e937adeb","line":752,"updated":"2016-01-14 03:30:44.000000000","message":"Please use the vector as the size of the source container is known.","commit_id":"c894b61b8125eaded6eac46e75d774ea3bcd0662"},{"author":{"_account_id":1000097,"name":"Chiyoung Seo","email":"chiyoung@northscale.com","username":"chiyoung","avatars":[{"url":"https://www.gravatar.com/avatar/ec517f4126dd292151b452ce4d1edf31.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ec517f4126dd292151b452ce4d1edf31.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ec517f4126dd292151b452ce4d1edf31.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ec517f4126dd292151b452ce4d1edf31.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"6883d4c9791eff8fb20e3da29d5da3641ce9f199","unresolved":false,"context_lines":[{"line_number":1018,"context_line":""},{"line_number":1019,"context_line":""},{"line_number":1020,"context_line":"    LockHolder lh(connsLock);"},{"line_number":1021,"context_line":"    std::list\u003cconnection_t\u003e toRelease(all.begin(), all.end());"},{"line_number":1022,"context_line":""},{"line_number":1023,"context_line":"    closeAllStreams_UNLOCKED();"},{"line_number":1024,"context_line":"    cancelAllTasks_UNLOCKED();"}],"source_content_type":"text/x-c","patch_set":4,"id":"fd3c8952_093d31ca","line":1021,"updated":"2016-01-14 03:30:44.000000000","message":"Ditto","commit_id":"c894b61b8125eaded6eac46e75d774ea3bcd0662"},{"author":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f72ef6737d3b6c62139c0745a9316cad1f392030","unresolved":false,"context_lines":[{"line_number":749,"context_line":""},{"line_number":750,"context_line":""},{"line_number":751,"context_line":"    LockHolder lh(connsLock);"},{"line_number":752,"context_line":"    std::vector\u003cconnection_t\u003e toRelease(all.begin(), all.end());"},{"line_number":753,"context_line":""},{"line_number":754,"context_line":"    all.clear();"},{"line_number":755,"context_line":"    map_.clear();"}],"source_content_type":"text/x-c","patch_set":7,"id":"fd3c8952_4960193c","line":752,"updated":"2016-01-14 09:27:52.000000000","message":"Note: An alternative implementation (which I think would be faster) would be to create an empty std::list, use std::swap (under lock) to swap all with the empty list, and then iterate across and release all the items.\n\nThis would save copying the whole list.","commit_id":"b34baa6274ffa1365133d731889e3ccd0bfab2d7"},{"author":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"10627edb535ab94b47bb5eed91ff01d2c6eaf4ab","unresolved":false,"context_lines":[{"line_number":754,"context_line":"    all.clear();"},{"line_number":755,"context_line":"    map_.clear();"},{"line_number":756,"context_line":""},{"line_number":757,"context_line":"    lh.unlock();"},{"line_number":758,"context_line":""},{"line_number":759,"context_line":"    LockHolder rlh(releaseLock);"},{"line_number":760,"context_line":"    for (auto \u0026ii : toRelease) {"}],"source_content_type":"text/x-c","patch_set":7,"id":"fd3c8952_a96e8532","line":757,"updated":"2016-01-14 09:26:02.000000000","message":"Nit: In general I find creating scopes for locks (and then letting RAII do it\u0027s thing) clearer and more explicit that a lock is only valid for a specific scope.","commit_id":"b34baa6274ffa1365133d731889e3ccd0bfab2d7"}]}