)]}'
{"src/dcp/producer.h":[{"author":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"218b83821249e00541e02e7fe0cc4cbc5132c253","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    BackfillManager* getBackfillManager() {"},{"line_number":111,"context_line":"        return backfillMgr.get();"},{"line_number":112,"context_line":"    }"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    bool isExtMetaDataEnabled () {"},{"line_number":115,"context_line":"        return enableExtMetaData;"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"fd3c8952_4987b9c8","line":112,"updated":"2016-01-14 09:23:57.000000000","message":"Be careful with this - as soon as you decay to a raw pointer you loose the \"smartness\" - i.e. if someone calls getBackfillMgr on Producer, and then the Producer is deleted, then the raw pointer is now invalid. \n\nI haven\u0027t looked at who calls this method, but you may find it safer to change the return type to backfill_manager_t if there\u0027s any potential lifetime issues.","commit_id":"c2060c6b2834b0a5e22f7163595729dd0bf011f9"},{"author":{"_account_id":1000097,"name":"Chiyoung Seo","email":"chiyoung@northscale.com","username":"chiyoung","avatars":[{"url":"https://www.gravatar.com/avatar/ec517f4126dd292151b452ce4d1edf31.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ec517f4126dd292151b452ce4d1edf31.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ec517f4126dd292151b452ce4d1edf31.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ec517f4126dd292151b452ce4d1edf31.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"83664064120d1b672d73612c7f1f663691da6b3e","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    BackfillManager* getBackfillManager() {"},{"line_number":111,"context_line":"        return backfillMgr.get();"},{"line_number":112,"context_line":"    }"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    bool isExtMetaDataEnabled () {"},{"line_number":115,"context_line":"        return enableExtMetaData;"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"fd3c8952_740db0f0","line":112,"in_reply_to":"fd3c8952_4987b9c8","updated":"2016-01-14 15:20:21.000000000","message":"I agree with it. I\u0027d have this function return backfill_manager_t to make it safer.","commit_id":"c2060c6b2834b0a5e22f7163595729dd0bf011f9"}]}