)]}'
{"parts/xmem_nozzle.go":[{"author":{"_account_id":1002062,"name":"Yu Sui","email":"ysui68@gmail.com","username":"ysui6888","avatars":[{"url":"https://www.gravatar.com/avatar/29df8236b840728528345ea82cca246f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/29df8236b840728528345ea82cca246f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/29df8236b840728528345ea82cca246f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/29df8236b840728528345ea82cca246f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"1812b1b0729f0ed7fce76d3fa85d4d47da6b2aab","unresolved":false,"context_lines":[{"line_number":173,"context_line":"func (buf *requestBuffer) initialize() error {"},{"line_number":174,"context_line":"\tfor i :\u003d 0; i \u003c int(buf.size); i++ {"},{"line_number":175,"context_line":"\t\t// initialize all slots to empty requests"},{"line_number":176,"context_line":"\t\tbuf.slots[i] \u003d newBufferedMCRequest()"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"\t\t//initialize the empty_slots_pos"},{"line_number":179,"context_line":"\t\tbuf.empty_slots_pos \u003c- uint16(i)"}],"source_content_type":"text/x-go","patch_set":2,"id":"dbd8ad6d_82ea4adb","line":176,"updated":"2015-05-28 04:10:25.000000000","message":"after the change, each slot will always contain a buffered request, which is re-used across mc requests. this not only makes it unnecessary to lock the slots array, but also helps reduce memory footprint.","commit_id":"729668339abd54b5b300fde733bdb7a52cdeb2ba"},{"author":{"_account_id":1001513,"name":"Xiaomei Zhang","email":"xiaomei@couchbase.com","username":"xiaomeizhang","avatars":[{"url":"https://www.gravatar.com/avatar/9d64230ee2846ee57109fae9a412fd4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9d64230ee2846ee57109fae9a412fd4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9d64230ee2846ee57109fae9a412fd4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9d64230ee2846ee57109fae9a412fd4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"5a92e5e99866d446667637d6edf660b83492e762","unresolved":false,"context_lines":[{"line_number":329,"context_line":""},{"line_number":330,"context_line":"\treq.reservation \u003d reservation_num"},{"line_number":331,"context_line":"\tnow :\u003d time.Now()"},{"line_number":332,"context_line":"\treq.sent_time \u003d \u0026now"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"\treturn nil, uint16(index), reservation_num"},{"line_number":335,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":2,"id":"dbd8ad6d_5d2687c9","line":332,"updated":"2015-05-28 17:44:22.000000000","message":"sent_time should not be set when calling reserveSlot","commit_id":"729668339abd54b5b300fde733bdb7a52cdeb2ba"},{"author":{"_account_id":1002062,"name":"Yu Sui","email":"ysui68@gmail.com","username":"ysui6888","avatars":[{"url":"https://www.gravatar.com/avatar/29df8236b840728528345ea82cca246f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/29df8236b840728528345ea82cca246f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/29df8236b840728528345ea82cca246f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/29df8236b840728528345ea82cca246f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c65a91ff4d2fdf0c16ce9eea726303fb43ad8bd7","unresolved":false,"context_lines":[{"line_number":329,"context_line":""},{"line_number":330,"context_line":"\treq.reservation \u003d reservation_num"},{"line_number":331,"context_line":"\tnow :\u003d time.Now()"},{"line_number":332,"context_line":"\treq.sent_time \u003d \u0026now"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"\treturn nil, uint16(index), reservation_num"},{"line_number":335,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":2,"id":"dbd8ad6d_5d99e7b7","line":332,"in_reply_to":"dbd8ad6d_5d2687c9","updated":"2015-05-28 18:43:49.000000000","message":"this is what the current code is doing. where should it be done, then? enSlot?","commit_id":"729668339abd54b5b300fde733bdb7a52cdeb2ba"},{"author":{"_account_id":1001513,"name":"Xiaomei Zhang","email":"xiaomei@couchbase.com","username":"xiaomeizhang","avatars":[{"url":"https://www.gravatar.com/avatar/9d64230ee2846ee57109fae9a412fd4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9d64230ee2846ee57109fae9a412fd4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9d64230ee2846ee57109fae9a412fd4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9d64230ee2846ee57109fae9a412fd4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"fa77ec2a242f82003c921ab02cf12d3c87ff9f85","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"type bufferedMCRequest struct {"},{"line_number":92,"context_line":"\treq          *base.WrappedMCRequest"},{"line_number":93,"context_line":"\tsent_time    *time.Time"},{"line_number":94,"context_line":"\tnum_of_retry int"},{"line_number":95,"context_line":"\terr          error"},{"line_number":96,"context_line":"\ttimedout     bool"}],"source_content_type":"text/x-go","patch_set":3,"id":"dbd8ad6d_e8f20f96","line":93,"updated":"2015-05-29 17:28:37.000000000","message":"Does this need to ptr?","commit_id":"9a41b13c6524968138d9916bfe591dbc9763b15f"},{"author":{"_account_id":1002062,"name":"Yu Sui","email":"ysui68@gmail.com","username":"ysui6888","avatars":[{"url":"https://www.gravatar.com/avatar/29df8236b840728528345ea82cca246f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/29df8236b840728528345ea82cca246f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/29df8236b840728528345ea82cca246f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/29df8236b840728528345ea82cca246f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"6ffee35ce71a163b284b74c757027829f88e63d3","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"type bufferedMCRequest struct {"},{"line_number":92,"context_line":"\treq          *base.WrappedMCRequest"},{"line_number":93,"context_line":"\tsent_time    *time.Time"},{"line_number":94,"context_line":"\tnum_of_retry int"},{"line_number":95,"context_line":"\terr          error"},{"line_number":96,"context_line":"\ttimedout     bool"}],"source_content_type":"text/x-go","patch_set":3,"id":"dba0ad0a_8e3cfb41","line":93,"in_reply_to":"dbd8ad6d_e8f20f96","updated":"2015-06-01 17:06:48.000000000","message":"when the right value of sent_time is not known, it is cheaper to set it to nil than an empty time object","commit_id":"9a41b13c6524968138d9916bfe591dbc9763b15f"}]}