)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1003828,"name":"James H","email":"james.harrison@couchbase.com","username":"jameseh96","avatars":[{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"28271c3aba7ab4c80a026663c4cad02d11d567f9","unresolved":true,"context_lines":[{"line_number":15,"context_line":"- Rename getBuckets to getTaskables to better reflect the current,"},{"line_number":16,"context_line":"  more generic form."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- Adjust some tests to not rely on implmementation details of"},{"line_number":19,"context_line":"  CB3ExecutorPool."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Ia01595b9bf4c2b6c494f0b32615052b495afc8d9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"52d329f3_11fec502","line":18,"range":{"start_line":18,"start_character":35,"end_line":18,"end_character":50},"updated":"2020-08-06 12:11:09.000000000","message":"nit implementation","commit_id":"43e29a5b014d91069c96c5fe0bd9b02267eb467a"}],"engines/ep/src/executorpool.h":[{"author":{"_account_id":1003828,"name":"James H","email":"james.harrison@couchbase.com","username":"jameseh96","avatars":[{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"28271c3aba7ab4c80a026663c4cad02d11d567f9","unresolved":true,"context_lines":[{"line_number":115,"context_line":"                                                   bool force) \u003d 0;"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    /// @returns the number of registered Taskables."},{"line_number":118,"context_line":"    virtual size_t getNumTaskables() \u003d 0;"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    /***************** Task Scheduling **************************************/"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"b71ed876_2e13b657","line":118,"range":{"start_line":118,"start_character":4,"end_line":118,"end_character":41},"updated":"2020-08-06 12:11:09.000000000","message":"Could this be const? Or is the new pool impl likely to have a non-const impl?","commit_id":"43e29a5b014d91069c96c5fe0bd9b02267eb467a"}],"engines/ep/tests/module_tests/executorpool_test.cc":[{"author":{"_account_id":1003828,"name":"James H","email":"james.harrison@couchbase.com","username":"jameseh96","avatars":[{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"28271c3aba7ab4c80a026663c4cad02d11d567f9","unresolved":true,"context_lines":[{"line_number":330,"context_line":"    // it\u0027s run() method), insert and schedule a \"sentinal\" task. Once that"},{"line_number":331,"context_line":"    // task has started running we know our main task must have completed"},{"line_number":332,"context_line":"    // all execution."},{"line_number":333,"context_line":"    bool sentinalExecuted \u003d false;"},{"line_number":334,"context_line":"    ExTask sentinalTask \u003d std::make_shared\u003cLambdaTask\u003e("},{"line_number":335,"context_line":"            this-\u003etaskable, TaskId::ItemPager, 0, true, [\u0026] {"},{"line_number":336,"context_line":"                std::unique_lock\u003cstd::mutex\u003e guard(cv);"}],"source_content_type":"text/x-c","patch_set":2,"id":"8b0a7a28_e2c93a95","line":333,"range":{"start_line":333,"start_character":15,"end_line":333,"end_character":16},"updated":"2020-08-06 12:11:09.000000000","message":"tiny nit sentinel (not worth a CV run for a letter, but if you happen to do another patchset :shrug:)","commit_id":"43e29a5b014d91069c96c5fe0bd9b02267eb467a"}]}