)]}'
{"id":"kv_engine~137548","triplet_id":"kv_engine~master~I7f7448627d20c753add8c92eaf1186fb350aaab0","project":"kv_engine","branch":"master","hashtags":[],"change_id":"I7f7448627d20c753add8c92eaf1186fb350aaab0","subject":"MB-41510: Fix TSAN failure due to lock order inversion","status":"MERGED","created":"2020-10-06 11:30:53.000000000","updated":"2020-10-07 17:20:02.000000000","submitted":"2020-10-07 13:36:52.000000000","submitter":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"total_comment_count":28,"unresolved_comment_count":2,"has_review_started":true,"submission_id":"137548-1602077812580-99c988ba","meta_rev_id":"9399152864597a8352f18a67b4c010e0fc954eca","_number":137548,"virtual_id_number":137548,"owner":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":1003828,"name":"James H","email":"james.harrison@couchbase.com","username":"jameseh96","avatars":[{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2020-10-07 13:36:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"all":[{"value":0,"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2020-10-07 13:36:52.000000000","_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":1003828,"name":"James H","email":"james.harrison@couchbase.com","username":"jameseh96","avatars":[{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]}],"values":{"-2":"Do not submit","-1":"I would prefer that you didn\u0027t submit this"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Well-Formed":{"all":[{"value":0,"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":1003828,"name":"James H","email":"james.harrison@couchbase.com","username":"jameseh96","avatars":[{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]}],"values":{"-1":"Commit is not well-formed"," 0":"Well-formedness not checked","+1":"Commit is well-formed"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":1000002,"name":"Trond Norbye","display_name":"Trond","email":"trond.norbye@couchbase.com","username":"trond","avatars":[{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1004341,"name":"Ben Huddleston","email":"ben.huddleston@couchbase.com","username":"BenHuddleston","avatars":[{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1001547,"name":"Dan Owen","email":"owend@couchbase.com","username":"owend","avatars":[{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1004059,"name":"Paolo Cocchi","email":"paolo.cocchi@couchbase.com","username":"paolococchi","avatars":[{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1001546,"name":"Jim Walker","email":"jim@couchbase.com","username":"jim","avatars":[{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1002319,"name":"Dave Finlay","email":"dave.finlay@couchbase.com","username":"dave-finlay","avatars":[{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"Trond Norbye","display_name":"Trond","email":"trond.norbye@couchbase.com","username":"trond","avatars":[{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1001546,"name":"Jim Walker","email":"jim@couchbase.com","username":"jim","avatars":[{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1001547,"name":"Dan Owen","email":"owend@couchbase.com","username":"owend","avatars":[{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1002319,"name":"Dave Finlay","email":"dave.finlay@couchbase.com","username":"dave-finlay","avatars":[{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1003828,"name":"James H","email":"james.harrison@couchbase.com","username":"jameseh96","avatars":[{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1004059,"name":"Paolo Cocchi","email":"paolo.cocchi@couchbase.com","username":"paolococchi","avatars":[{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1004341,"name":"Ben Huddleston","email":"ben.huddleston@couchbase.com","username":"BenHuddleston","avatars":[{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-10-06 11:32:02.000000000","updated_by":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":1002319,"name":"Dave Finlay","email":"dave.finlay@couchbase.com","username":"dave-finlay","avatars":[{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2020-10-06 11:32:02.000000000","updated_by":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":1001546,"name":"Jim Walker","email":"jim@couchbase.com","username":"jim","avatars":[{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2020-10-06 11:32:02.000000000","updated_by":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":1004059,"name":"Paolo Cocchi","email":"paolo.cocchi@couchbase.com","username":"paolococchi","avatars":[{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2020-10-06 11:32:02.000000000","updated_by":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":1001547,"name":"Dan Owen","email":"owend@couchbase.com","username":"owend","avatars":[{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2020-10-06 11:32:02.000000000","updated_by":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":1003828,"name":"James H","email":"james.harrison@couchbase.com","username":"jameseh96","avatars":[{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2020-10-06 11:32:02.000000000","updated_by":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":1004341,"name":"Ben Huddleston","email":"ben.huddleston@couchbase.com","username":"BenHuddleston","avatars":[{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2020-10-06 11:32:02.000000000","updated_by":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2020-10-06 11:32:02.000000000","updated_by":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":1000002,"name":"Trond Norbye","display_name":"Trond","email":"trond.norbye@couchbase.com","username":"trond","avatars":[{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2020-10-06 11:51:00.000000000","updated_by":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"398b035d1127367c6c366bcbf990d6a718ef245e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-06 11:30:53.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d3f0caabe56c68a4682bceca104f5a1d225bd6b4","author":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-06 11:40:05.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"050a36c86985a88a875e93b9c2f2370505699adf","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2020-10-06 11:51:00.000000000","message":"Patch Set 1: Verified-1\n\nBuild Unstable \n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_analyzer-master/26700/ : UNSTABLE\n\nClang Analyser identified one or more potential bugs - see \u003ca href\u003d\"clangScanBuildBugs\"\u003eclangScanBuildBugs\u003c/a\u003e ( http://cv.jenkins.couchbase.com/job/kv_engine-clang_analyzer-master/26700/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_format_9/3430/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_tidy/4903/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-windows-master/30892/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux/job/master/6320/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.macos/job/master/5279/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux-CE/job/master/6202/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.threadsanitizer/job/master/6435/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/14094/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"2f8626cb7487f55fde47eb61e2977770a3e7e975","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-06 12:44:18.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"c37cda0116296695ffc4ce7a660cbaac20a45cfe","author":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-06 12:44:27.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"5d3f95c8cbb118c4d6d39308f1d354789c97bde2","author":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-06 12:47:07.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"e9d7264854120a840cb1b291e475557f634b3373","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-06 13:35:07.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"35f0e55ff9c9e3efa92ab891bae88a31a3d8f25c","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2020-10-06 13:35:10.000000000","message":"Patch Set 2: Verified-1\n\nBuild Failed \n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-windows-master/30895/ : ABORTED\n\nBuild which was aborted due to a newer patch set being uploaded for the given review. ( http://cv.jenkins.couchbase.com/job/kv_engine-windows-master/30895/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/14096/ : FAILURE\n\nNo problems were identified. If you know why this problem occurred, please add a suitable Cause for it. ( http://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/14096/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_analyzer-master/26702/ : UNSTABLE\n\nClang Analyser identified one or more potential bugs - see \u003ca href\u003d\"clangScanBuildBugs\"\u003eclangScanBuildBugs\u003c/a\u003e ( http://cv.jenkins.couchbase.com/job/kv_engine-clang_analyzer-master/26702/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_format_9/3432/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_tidy/4905/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.macos/job/master/5281/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux/job/master/6322/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.threadsanitizer/job/master/6437/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux-CE/job/master/6204/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"f9ec646afe19caebe3ea4325f0cea4de507a0f2c","author":{"_account_id":1003828,"name":"James H","email":"james.harrison@couchbase.com","username":"jameseh96","avatars":[{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-06 13:50:13.000000000","message":"Patch Set 3: Code-Review-1\n\n(3 comments)","accounts_in_message":[],"_revision_number":3},{"id":"ec4d0030b2c19a4300966ef759521bb48ffe47db","author":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-06 14:10:41.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"964bff44e8c3be4e526386c154a792e53611acaf","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-06 14:25:46.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"ac10753ef40507c9a288fd5273ab80e756554537","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2020-10-06 14:25:49.000000000","message":"Patch Set 3: Verified-1\n\nBuild Failed \n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.threadsanitizer/job/master/6438/ : ABORTED\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-windows-master/30896/ : FAILURE\n\nFailure of GoogleTest \"PersistentAndEphemeral/ConnectionTest.test_maybesendnoop_send_noop/2\":\n\n\u003cpre\u003e\n[ RUN      ] PersistentAndEphemeral/ConnectionTest.test_maybesendnoop_send_noop/2\nunknown file: error: C++ exception with description \"cb::io::rmrf: stat of ep_engine_ep_unit_tests.db/test.989301 failed: The system cannot find the file specified.\" thrown in TearDown().\n[  FAILED  ] PersistentAndEphemeral/ConnectionTest.test_maybesendnoop_send_noop/2, where GetParam() \u003d (\"persistent\", \"value_only\") (17 ms)\nPersistentAndEphemeral/ConnectionTest.test_maybesendnoop_send_noop/2\n\u003c/pre\u003e\n ( http://cv.jenkins.couchbase.com/job/kv_engine-windows-master/30896/ )\n\nFailure of a CTest test 177/391 Test #164: ep-engine_ep_unit_tests.PersistentAndEphemeral/ConnectionTest ................................................................. ( http://cv.jenkins.couchbase.com/job/kv_engine-windows-master/30896/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_analyzer-master/26703/ : UNSTABLE\n\nClang Analyser identified one or more potential bugs - see \u003ca href\u003d\"clangScanBuildBugs\"\u003eclangScanBuildBugs\u003c/a\u003e ( http://cv.jenkins.couchbase.com/job/kv_engine-clang_analyzer-master/26703/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_format_9/3433/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_tidy/4906/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.macos/job/master/5282/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux/job/master/6323/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux-CE/job/master/6205/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/14097/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"f3e69736f7f2e5eab3e098a94638226831108859","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-06 14:47:48.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"b7e0ec583e38944a372b835a3d191bc14cd8793a","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2020-10-06 14:47:51.000000000","message":"Patch Set 4: Verified-1\n\nBuild Unstable \n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-windows-master/30902/ : ABORTED\n\nBuild which was aborted due to a newer patch set being uploaded for the given review. ( http://cv.jenkins.couchbase.com/job/kv_engine-windows-master/30902/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux-CE/job/master/6208/ : ABORTED\n\nBuild which was aborted due to a newer patch set being uploaded for the given review. ( http://cv.jenkins.couchbase.com/job/kv_engine.linux-CE/job/master/6208/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux/job/master/6325/ : ABORTED\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.threadsanitizer/job/master/6440/ : ABORTED\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/14099/ : ABORTED\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_analyzer-master/26705/ : UNSTABLE\n\nClang Analyser identified one or more potential bugs - see \u003ca href\u003d\"clangScanBuildBugs\"\u003eclangScanBuildBugs\u003c/a\u003e ( http://cv.jenkins.couchbase.com/job/kv_engine-clang_analyzer-master/26705/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_format_9/3435/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_tidy/4908/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.macos/job/master/5284/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"2beab3613deeffe0b33d6bb975c58b71c40549ec","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-06 15:11:21.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"3363558d327e8be833f0652fd795d51e48fc18fa","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2020-10-06 15:11:30.000000000","message":"Patch Set 5: Verified-1\n\nBuild Failed \n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux/job/master/6327/ : ABORTED\n\nBuild which was aborted due to a newer patch set being uploaded for the given review. ( http://cv.jenkins.couchbase.com/job/kv_engine.linux/job/master/6327/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/14101/ : ABORTED\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_format_9/3437/ : FAILURE\n\n\u003cp\u003eclang-format suggested the following changes:\n\n\u003cpre\u003e\ncat \u003c\u003c\"EOF\" | patch -p1\ndiff --git a/utilities/hdrhistogram.cc b/utilities/hdrhistogram.cc\nindex ee5fbe9..346f4c6 100644\n--- a/utilities/hdrhistogram.cc\n+++ b/utilities/hdrhistogram.cc\n@@ -62,8 +62,7 @@ HdrHistogram\u0026amp; HdrHistogram::operator+\u003d(const HdrHistogram\u0026amp; other) {\n      * as this-\u0026gt;histogram is not. Furthermore, we only need to write to the ptr\n      * of this-\u0026gt;histogram.\n      */\n-    auto lockPair \u003d\n-            folly::acquireLockedPair(this-\u0026gt;histogram, other.histogram);\n+    auto lockPair \u003d folly::acquireLockedPair(this-\u0026gt;histogram, other.histogram);\n     auto\u0026amp; thisLock \u003d lockPair.first;\n     auto\u0026amp; otherLock \u003d lockPair.second;\n     if (otherLock-\u0026gt;get()-\u0026gt;total_count \u0026gt; 0) {\n\nEOF\n\u003c/pre\u003e ( http://cv.jenkins.couchbase.com/job/kv_engine-clang_format_9/3437/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_tidy/4910/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_analyzer-master/26707/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-windows-master/30903/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.macos/job/master/5286/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux-CE/job/master/6210/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.threadsanitizer/job/master/6442/ : SUCCESS","accounts_in_message":[],"_revision_number":5},{"id":"a624e006846076e1dfd7a74cb2d308a1e18b0017","author":{"_account_id":1003828,"name":"James H","email":"james.harrison@couchbase.com","username":"jameseh96","avatars":[{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-06 15:35:51.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"16c70916f46e31fbe31c5dd0f0cc22fdff868e93","author":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-06 15:49:17.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"ba3d9483e2e8e94c67a1a35b46fe827b540a5831","author":{"_account_id":1003828,"name":"James H","email":"james.harrison@couchbase.com","username":"jameseh96","avatars":[{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-06 15:52:55.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"1c795cbdafb9b37719f8b4e839fa892daaa958a4","author":{"_account_id":1003828,"name":"James H","email":"james.harrison@couchbase.com","username":"jameseh96","avatars":[{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-06 15:54:58.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"88666a1d35d5af0cb9767ebc80c7e601cbf6d5ea","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-06 16:16:45.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"106dfd0bc4a756c979d74163bf24440509d1babe","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2020-10-06 16:16:49.000000000","message":"Patch Set 6: Verified-1\n\nBuild Failed \n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-windows-master/30904/ : ABORTED\n\nBuild which was aborted due to a newer patch set being uploaded for the given review. ( http://cv.jenkins.couchbase.com/job/kv_engine-windows-master/30904/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_format_9/3438/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_tidy/4911/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_analyzer-master/26708/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.macos/job/master/5287/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux-CE/job/master/6211/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux/job/master/6329/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.threadsanitizer/job/master/6443/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/14103/ : SUCCESS","accounts_in_message":[],"_revision_number":6},{"id":"36f1f16b0108c275a60390ca7ed2f54ecfaa7e1e","author":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-06 16:18:59.000000000","message":"Patch Set 7:\n\n(1 comment)","accounts_in_message":[],"_revision_number":7},{"id":"d4393f97602fb73983f4f835687db777564f7c98","author":{"_account_id":1003828,"name":"James H","email":"james.harrison@couchbase.com","username":"jameseh96","avatars":[{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-06 16:23:52.000000000","message":"Patch Set 7: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":7},{"id":"ade4232e226d3581914f3e7c3a4a7ab20fa38646","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-06 16:28:41.000000000","message":"Uploaded patch set 8.","accounts_in_message":[],"_revision_number":8},{"id":"c928e295446b74d0687d13df633247007bdf53ea","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2020-10-06 16:28:47.000000000","message":"Patch Set 7: Verified-1\n\nBuild Failed \n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_analyzer-master/26710/ : ABORTED\n\nNo problems were identified. If you know why this problem occurred, please add a suitable Cause for it. ( http://cv.jenkins.couchbase.com/job/kv_engine-clang_analyzer-master/26710/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-windows-master/30907/ : ABORTED\n\nBuild which was aborted due to a newer patch set being uploaded for the given review. ( http://cv.jenkins.couchbase.com/job/kv_engine-windows-master/30907/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux-CE/job/master/6213/ : ABORTED\n\nBuild which was aborted due to a newer patch set being uploaded for the given review. ( http://cv.jenkins.couchbase.com/job/kv_engine.linux-CE/job/master/6213/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/14105/ : ABORTED\n\nBuild which was aborted due to a newer patch set being uploaded for the given review. ( http://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/14105/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux/job/master/6332/ : ABORTED\n\nBuild which was aborted due to a newer patch set being uploaded for the given review. ( http://cv.jenkins.couchbase.com/job/kv_engine.linux/job/master/6332/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.macos/job/master/5289/ : ABORTED\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.threadsanitizer/job/master/6445/ : ABORTED\n\nBuild which was aborted due to a newer patch set being uploaded for the given review. ( http://cv.jenkins.couchbase.com/job/kv_engine.threadsanitizer/job/master/6445/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_format_9/3440/ : SUCCESS","accounts_in_message":[],"_revision_number":7},{"id":"32a37e8e286279d79506cceb0f95fa11e5693fdc","author":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-06 16:28:48.000000000","message":"Patch Set 8:\n\n(1 comment)","accounts_in_message":[],"_revision_number":8},{"id":"3b14dc72a1a8ef6b06fffe20d9a9961756fa8d81","author":{"_account_id":1003828,"name":"James H","email":"james.harrison@couchbase.com","username":"jameseh96","avatars":[{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-06 16:35:20.000000000","message":"Patch Set 8: Code-Review+1","accounts_in_message":[],"_revision_number":8},{"id":"f944e1d2b9a9a0ab514909bddc2985b52d75dfc7","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2020-10-06 17:21:56.000000000","message":"Patch Set 8: Verified+1\n\nBuild Successful \n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_format_9/3441/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_tidy/4913/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_analyzer-master/26711/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-windows-master/30909/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/14106/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.threadsanitizer/job/master/6446/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.macos/job/master/5290/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux/job/master/6333/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux-CE/job/master/6214/ : SUCCESS","accounts_in_message":[],"_revision_number":8},{"id":"9ab5e49a76d884087240c886c31f6e66aa77f979","author":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-07 09:00:50.000000000","message":"Patch Set 8: Code-Review-1\n\n(4 comments)\n\n-1 for the comment about shared and exclusive - I don\u0027t follow how that is the case.","accounts_in_message":[],"_revision_number":8},{"id":"1b3aff1192712f312fd0fcc9abcab4d222971003","author":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-07 09:10:28.000000000","message":"Patch Set 8:\n\n(1 comment)","accounts_in_message":[],"_revision_number":8},{"id":"9a7df81cb4b2147a70019fc6c5c27f07d1aba153","author":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-07 09:18:44.000000000","message":"Patch Set 8:\n\n(1 comment)","accounts_in_message":[],"_revision_number":8},{"id":"f85035f7c48db7d032cda398e1cdeb6bf5d17000","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-07 10:01:47.000000000","message":"Uploaded patch set 9.","accounts_in_message":[],"_revision_number":9},{"id":"6845962516ce720a69702b915a9598b986b319f1","author":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-07 10:02:31.000000000","message":"Patch Set 9:\n\n(4 comments)","accounts_in_message":[],"_revision_number":9},{"id":"68040915662626cb5693d5e841d66da1d97a1646","author":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-07 10:09:27.000000000","message":"Patch Set 9:\n\n(1 comment)","accounts_in_message":[],"_revision_number":9},{"id":"fd3ffa66fc48005f75f271ee6ac4d3bf622e37f7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-07 10:24:47.000000000","message":"Uploaded patch set 10.","accounts_in_message":[],"_revision_number":10},{"id":"8f80ddf88a85c0f72c0c02bcec65e6379aef7ed6","author":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-07 10:24:56.000000000","message":"Patch Set 10:\n\n(1 comment)","accounts_in_message":[],"_revision_number":10},{"id":"5d0b23962ef897f7401f35aa9ce9f0fba47ea3ae","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2020-10-07 10:24:57.000000000","message":"Patch Set 9: Verified-1\n\nBuild Failed \n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_analyzer-master/26729/ : ABORTED\n\nBuild which was aborted due to a newer patch set being uploaded for the given review. ( http://cv.jenkins.couchbase.com/job/kv_engine-clang_analyzer-master/26729/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux-CE/job/master/6234/ : ABORTED\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/14127/ : ABORTED\n\nBuild which was aborted due to a newer patch set being uploaded for the given review. ( http://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/14127/ )\n\nFailure of a CTest test [2020-10-07T10:24:50.549Z]  17/391 Test #260: ep_testsuite_checkpoint.value_eviction.magma ................................................................Child terminated ( http://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/14127/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-windows-master/30938/ : FAILURE\n\nNo problems were identified. If you know why this problem occurred, please add a suitable Cause for it. ( http://cv.jenkins.couchbase.com/job/kv_engine-windows-master/30938/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux/job/master/6351/ : FAILURE\n\nFailure of an engine_testapp test:\n\n\u003cpre\u003e\nRunning [0055/0099]: test chk manager rollback...Exceeded maximum wait time of 60000000us waiting for stat \"ep_queue_size\" to be 0 (last value:20) - aborting.\n\u003c/pre\u003e\n ( http://cv.jenkins.couchbase.com/job/kv_engine.linux/job/master/6351/ )\n\nFailure of a CTest test [2020-10-07T10:15:20.453Z] 408/408 Test #257: ep_testsuite_dcp.value_eviction.comp_passive ................................................................Child aborted ( http://cv.jenkins.couchbase.com/job/kv_engine.linux/job/master/6351/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_format_9/3459/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_tidy/4931/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.macos/job/master/5308/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.threadsanitizer/job/master/6464/ : SUCCESS","accounts_in_message":[],"_revision_number":9},{"id":"e35eb69da2c89fa7d8a309936a083048882c7553","author":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-07 10:25:49.000000000","message":"Patch Set 10: Code-Review+2","accounts_in_message":[],"_revision_number":10},{"id":"66a2c9048c0afd1ffba522f8e0e7f8dfbc8bff7d","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2020-10-07 11:41:08.000000000","message":"Patch Set 10: Verified-1\n\nBuild Failed \n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-windows-master/30945/ : FAILURE\n\nNo problems were identified. If you know why this problem occurred, please add a suitable Cause for it. ( http://cv.jenkins.couchbase.com/job/kv_engine-windows-master/30945/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_format_9/3465/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_tidy/4937/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_analyzer-master/26735/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux/job/master/6357/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.threadsanitizer/job/master/6470/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.macos/job/master/5314/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/14134/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux-CE/job/master/6240/ : SUCCESS","accounts_in_message":[],"_revision_number":10},{"id":"7329aa426367bdd9d3fc31eab3f2116d5797f8ea","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2020-10-07 11:43:57.000000000","message":"Patch Set 10:\n\nBuild Failed \n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-windows-master/30953/ : FAILURE\n\nNo problems were identified. If you know why this problem occurred, please add a suitable Cause for it. ( http://cv.jenkins.couchbase.com/job/kv_engine-windows-master/30953/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_format_9/3465/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_tidy/4937/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_analyzer-master/26735/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux/job/master/6357/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.threadsanitizer/job/master/6470/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.macos/job/master/5314/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/14134/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux-CE/job/master/6240/ : SUCCESS","accounts_in_message":[],"_revision_number":10},{"id":"d2121f989aa2f1c43276bfbf984266064c750f5f","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2020-10-07 11:44:30.000000000","message":"Patch Set 10:\n\nBuild Failed \n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-windows-master/30954/ : FAILURE\n\nNo problems were identified. If you know why this problem occurred, please add a suitable Cause for it. ( http://cv.jenkins.couchbase.com/job/kv_engine-windows-master/30954/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_format_9/3465/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_tidy/4937/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_analyzer-master/26735/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux/job/master/6357/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.threadsanitizer/job/master/6470/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.macos/job/master/5314/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/14134/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux-CE/job/master/6240/ : SUCCESS","accounts_in_message":[],"_revision_number":10},{"id":"139b927745c6ee0424040c663abde662b7aa128d","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2020-10-07 11:55:40.000000000","message":"Patch Set 10:\n\nBuild Failed \n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-windows-master/30957/ : FAILURE\n\nNo problems were identified. If you know why this problem occurred, please add a suitable Cause for it. ( http://cv.jenkins.couchbase.com/job/kv_engine-windows-master/30957/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_format_9/3465/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_tidy/4937/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_analyzer-master/26735/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux/job/master/6357/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.threadsanitizer/job/master/6470/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.macos/job/master/5314/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/14134/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux-CE/job/master/6240/ : SUCCESS","accounts_in_message":[],"_revision_number":10},{"id":"6e5aaf2c11b80e8273f6fa9b11579d162a31ab28","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2020-10-07 11:59:34.000000000","message":"Patch Set 10:\n\nBuild Failed \n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-windows-master/30958/ : FAILURE\n\nNo problems were identified. If you know why this problem occurred, please add a suitable Cause for it. ( http://cv.jenkins.couchbase.com/job/kv_engine-windows-master/30958/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_format_9/3465/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_tidy/4937/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_analyzer-master/26735/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux/job/master/6357/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.threadsanitizer/job/master/6470/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.macos/job/master/5314/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/14134/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux-CE/job/master/6240/ : SUCCESS","accounts_in_message":[],"_revision_number":10},{"id":"7cb7ab2d05d055537e1f4f22be600344436d4c4c","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2020-10-07 13:11:03.000000000","message":"Patch Set 10:\n\nBuild Failed \n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-windows-master/30959/ : ABORTED\n\nNo problems were identified. If you know why this problem occurred, please add a suitable Cause for it. ( http://cv.jenkins.couchbase.com/job/kv_engine-windows-master/30959/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_format_9/3465/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_tidy/4937/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_analyzer-master/26735/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux/job/master/6357/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.threadsanitizer/job/master/6470/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.macos/job/master/5314/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/14134/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux-CE/job/master/6240/ : SUCCESS","accounts_in_message":[],"_revision_number":10},{"id":"86abf506020cde9e240103bfe727967e72632c9e","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2020-10-07 13:26:57.000000000","message":"Patch Set 10: Verified+1\n\nBuild Successful \n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_format_9/3465/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_tidy/4937/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_analyzer-master/26735/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux/job/master/6357/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.threadsanitizer/job/master/6470/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.macos/job/master/5314/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/14134/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux-CE/job/master/6240/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-windows-master/30971/ : SUCCESS","accounts_in_message":[],"_revision_number":10},{"id":"07c0c2a3588afeb48b8184e23db239703c75f08b","tag":"autogenerated:gerrit:merged","author":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-07 13:36:52.000000000","message":"Change has been successfully cherry-picked as fb7e114fddc3fa9a86a53f36770c991bd1b79c4b by Richard de Mellow","accounts_in_message":[],"_revision_number":11},{"id":"15a071f3a9c022f4d362f0cc65e3f9a0b29ae771","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2020-10-07 14:38:22.000000000","message":"Patch Set 11:\n\nBuild Started http://cv.jenkins.couchbase.com/job/kv_engine-master-post-commit/5189/ (1/2)","accounts_in_message":[],"_revision_number":11},{"id":"9399152864597a8352f18a67b4c010e0fc954eca","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2020-10-07 17:20:02.000000000","message":"Patch Set 11:\n\nBuild Successful \n\nhttp://cv.jenkins.couchbase.com/job/kv-engine-master-perf/3861/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-master-post-commit/5189/ : SUCCESS\u0027","accounts_in_message":[],"_revision_number":11}],"current_revision_number":11,"current_revision":"fb7e114fddc3fa9a86a53f36770c991bd1b79c4b","revisions":{"0647f7fddbd2dbd745f149246b5c66698378c784":{"kind":"REWORK","_number":1,"created":"2020-10-06 11:30:53.000000000","uploader":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/48/137548/1","fetch":{"anonymous http":{"url":"https://review.couchbase.org/kv_engine","ref":"refs/changes/48/137548/1","commands":{"Branch":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/1 \u0026\u0026 git checkout -b change-137548 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/kv_engine refs/changes/48/137548/1","Reset To":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"45ff1ec9b2c6e20eb67156d868e9f610ad107ff5","subject":"MB-41719: Move ProducerNegotiatesIncludeDeletedUserXattrs to ST suite"}],"author":{"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","date":"2020-10-06 11:15:24.000000000","tz":60},"committer":{"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","date":"2020-10-06 11:30:31.000000000","tz":60},"subject":"MB-41510: Fix TSAN failure due to lock order inversion","message":"MB-41510: Fix TSAN failure due to lock order inversion\n\nFix a TSAN failure due to a lock order inversion observed on the\nmad-hatter TSAN cv machine. This was due to a potential deadlock while\nacquiring locks on this and other histogram in\nHdrHistogram::operator+\u003d(). To fix this use folly::acquireLocked() to\nsafely take write lock and read lock on this-\u003ehistogram and\nother.histogram respectively. This patch also refactors some methods so\nmake them unlocked version so that whey can be used while we hold locks\nin HdrHistogram::operator+\u003d().\n\nTSAN failure:\nWARNING: ThreadSanitizer: lock-order-inversion (potential deadlock) (pid\u003d11208)\nCycle in lock order graph: M296533874179548048 (0x000000000000) \u003d\u003e M174936684240544688 (0x000000000000) \u003d\u003e M296533874179548048\n\nMutex M174936684240544688 acquired here while holding mutex M296533874179548048 in main thread:\n#0 AnnotateRWLockAcquired \u003cnull\u003e (libtsan.so.0+0x00000005b63d)\n#1 folly::detail::annotate_rwlock_acquired_impl(void const volatile*, folly::annotate_rwlock_level, char const*, int) /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/synchronization/SanitizeThread.cpp:99 (ep-engine_ep_unit_tests+0x00000139555e)\n#2 annotate_rwlock_acquired tlm/deps/folly.exploded/include/folly/synchronization/SanitizeThread.h:111 (ep-engine_ep_unit_tests+0x000001362a06)\n#3 folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e::annotateAcquired(folly::annotate_rwlock_level) tlm/deps/folly.exploded/include/folly/SharedMutex.h:726 (ep-engine_ep_unit_tests+0x000001362a06)\n#4 folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e::lock_shared() tlm/deps/folly.exploded/include/folly/SharedMutex.h:400 (ep-engine_ep_unit_tests+0x000001362a06)\n#5 folly::detail::LockTraitsImpl\u003cfolly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e, (folly::detail::MutexLevel)1, false\u003e::lock_shared(folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e\u0026) tlm/deps/folly.exploded/include/folly/LockTraits.h:157 (ep-engine_ep_unit_tests+0x000001362a06)\n#6 std::integral_constant\u003cbool, true\u003e folly::LockPolicyShared::lock\u003cfolly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e(folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e\u0026) tlm/deps/folly.exploded/include/folly/LockTraits.h:499 (ep-engine_ep_unit_tests+0x000001362a06)\n#7 folly::LockedPtrBase\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e, folly::LockPolicyShared\u003e::LockedPtrBase(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const*) tlm/deps/folly.exploded/include/folly/Synchronized.h:1089 (ep-engine_ep_unit_tests+0x000001362a06)\n#8 folly::LockedPtr\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const, folly::LockPolicyShared\u003e::LockedPtr(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const*) tlm/deps/folly.exploded/include/folly/Synchronized.h:1394 (ep-engine_ep_unit_tests+0x000001360063)\n#9 folly::SynchronizedBase\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e, (folly::detail::MutexLevel)1\u003e::rlock() tlm/deps/folly.exploded/include/folly/Synchronized.h:140 (ep-engine_ep_unit_tests+0x000001360063)\n#10 HdrHistogram::operator+\u003d(HdrHistogram const\u0026) ../kv_engine/utilities/hdrhistogram.cc:83 (ep-engine_ep_unit_tests+0x000001360063)\n#11 HdrHistogramTest_aggregationTest_Test::TestBody() ../kv_engine/engines/ep/tests/module_tests/hdrhistogram_test.cc:317 (ep-engine_ep_unit_tests+0x00000106945c)\n#12 void testing::internal::HandleSehExceptionsInMethodIfSupported\u003ctesting::Test, void\u003e(testing::Test*, void (testing::Test::*)(), char const*) ../googletest/googletest/src/gtest.cc:2402 (ep-engine_ep_unit_tests+0x0000013276cb)\n#13 void testing::internal::HandleExceptionsInMethodIfSupported\u003ctesting::Test, void\u003e(testing::Test*, void (testing::Test::*)(), char const*) ../googletest/googletest/src/gtest.cc:2438 (ep-engine_ep_unit_tests+0x00000132e814)\n#14 testing::Test::Run() ../googletest/googletest/src/gtest.cc:2474 (ep-engine_ep_unit_tests+0x00000131d649)\n#15 testing::TestInfo::Run() ../googletest/googletest/src/gtest.cc:2656 (ep-engine_ep_unit_tests+0x00000131d91d)\n#16 testing::TestCase::Run() ../googletest/googletest/src/gtest.cc:2774 (ep-engine_ep_unit_tests+0x00000131dac5)\n#17 testing::internal::UnitTestImpl::RunAllTests() ../googletest/googletest/src/gtest.cc:4649 (ep-engine_ep_unit_tests+0x00000131fe3e)\n#18 bool testing::internal::HandleSehExceptionsInMethodIfSupported\u003ctesting::internal::UnitTestImpl, bool\u003e(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) ../googletest/googletest/src/gtest.cc:2402 (ep-engine_ep_unit_tests+0x000001327972)\n#19 bool testing::internal::HandleExceptionsInMethodIfSupported\u003ctesting::internal::UnitTestImpl, bool\u003e(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) ../googletest/googletest/src/gtest.cc:2438 (ep-engine_ep_unit_tests+0x00000132edc8)\n#20 testing::UnitTest::Run() ../googletest/googletest/src/gtest.cc:4257 (ep-engine_ep_unit_tests+0x00000131d741)\n#21 RUN_ALL_TESTS() ../googletest/googletest/include/gtest/gtest.h:2237 (ep-engine_ep_unit_tests+0x000000d30e6a)\n#22 main ../kv_engine/engines/ep/tests/module_tests/ep_unit_tests_main.cc:144 (ep-engine_ep_unit_tests+0x000000d30e6a)\n\nChange-Id: I7f7448627d20c753add8c92eaf1186fb350aaab0\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"45ff1ec9b2c6e20eb67156d868e9f610ad107ff5","is_merged_in_target_branch":true,"change_id":"I6ea27d955e27f4d032bca2895503c4c90fff8f06","change_number":137169,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/master"},"aef055b5b7fd6df2076bd6d441e9204fa596f2dd":{"kind":"REWORK","_number":2,"created":"2020-10-06 12:44:18.000000000","uploader":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/48/137548/2","fetch":{"anonymous http":{"url":"https://review.couchbase.org/kv_engine","ref":"refs/changes/48/137548/2","commands":{"Branch":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/2 \u0026\u0026 git checkout -b change-137548 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/kv_engine refs/changes/48/137548/2","Reset To":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"643773a60560b0235fd786a0bb311b27215ed15b","subject":"MB-41719: Move AckCorrectPassiveStream to ST suite"}],"author":{"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","date":"2020-10-06 11:15:24.000000000","tz":60},"committer":{"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","date":"2020-10-06 12:32:31.000000000","tz":60},"subject":"MB-41510: Fix TSAN failure due to lock order inversion","message":"MB-41510: Fix TSAN failure due to lock order inversion\n\nFix a TSAN failure due to a lock order inversion observed on the\nmad-hatter TSAN cv machine. This was due to a potential deadlock while\nacquiring locks on this and other histogram in\nHdrHistogram::operator+\u003d(). To fix this use folly::acquireLocked() to\nsafely take write lock and read lock on this-\u003ehistogram and\nother.histogram respectively.\n\nTSAN failure:\n    WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock) (pid\u003d11208)\n    Cycle in lock order graph: M296533874179548048 (0x000000000000) \u003d\u003e M174936684240544688 (0x000000000000) \u003d\u003e M296533874179548048\n\n    Mutex M174936684240544688 acquired here while holding mutex M296533874179548048 in main thread:\n    #0 AnnotateRWLockAcquired \u003cnull\u003e (libtsan.so.0+0x00000005b63d)\n    #1 folly::detail::annotate_rwlock_acquired_impl(void const volatile*, folly::annotate_rwlock_level, char const*, int) /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/synchronization/SanitizeThread.cpp:99 (ep-engine_ep_unit_tests+0x00000139555e)\n    #2 annotate_rwlock_acquired tlm/deps/folly.exploded/include/folly/synchronization/SanitizeThread.h:111 (ep-engine_ep_unit_tests+0x000001362a06)\n    #3 folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e::annotateAcquired(folly::annotate_rwlock_level) tlm/deps/folly.exploded/include/folly/SharedMutex.h:726 (ep-engine_ep_unit_tests+0x000001362a06)\n    #4 folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e::lock_shared() tlm/deps/folly.exploded/include/folly/SharedMutex.h:400 (ep-engine_ep_unit_tests+0x000001362a06)\n    #5 folly::detail::LockTraitsImpl\u003cfolly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e, (folly::detail::MutexLevel)1, false\u003e::lock_shared(folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e\u0026) tlm/deps/folly.exploded/include/folly/LockTraits.h:157 (ep-engine_ep_unit_tests+0x000001362a06)\n    #6 std::integral_constant\u003cbool, true\u003e folly::LockPolicyShared::lock\u003cfolly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e(folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e\u0026) tlm/deps/folly.exploded/include/folly/LockTraits.h:499 (ep-engine_ep_unit_tests+0x000001362a06)\n    #7 folly::LockedPtrBase\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e, folly::LockPolicyShared\u003e::LockedPtrBase(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const*) tlm/deps/folly.exploded/include/folly/Synchronized.h:1089 (ep-engine_ep_unit_tests+0x000001362a06)\n    #8 folly::LockedPtr\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const, folly::LockPolicyShared\u003e::LockedPtr(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const*) tlm/deps/folly.exploded/include/folly/Synchronized.h:1394 (ep-engine_ep_unit_tests+0x000001360063)\n    #9 folly::SynchronizedBase\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e, (folly::detail::MutexLevel)1\u003e::rlock() tlm/deps/folly.exploded/include/folly/Synchronized.h:140 (ep-engine_ep_unit_tests+0x000001360063)\n    #10 HdrHistogram::operator+\u003d(HdrHistogram const\u0026) ../kv_engine/utilities/hdrhistogram.cc:83 (ep-engine_ep_unit_tests+0x000001360063)\n    #11 HdrHistogramTest_aggregationTest_Test::TestBody() ../kv_engine/engines/ep/tests/module_tests/hdrhistogram_test.cc:317 (ep-engine_ep_unit_tests+0x00000106945c)\n    #12 void testing::internal::HandleSehExceptionsInMethodIfSupported\u003ctesting::Test, void\u003e(testing::Test*, void (testing::Test::*)(), char const*) ../googletest/googletest/src/gtest.cc:2402 (ep-engine_ep_unit_tests+0x0000013276cb)\n    #13 void testing::internal::HandleExceptionsInMethodIfSupported\u003ctesting::Test, void\u003e(testing::Test*, void (testing::Test::*)(), char const*) ../googletest/googletest/src/gtest.cc:2438 (ep-engine_ep_unit_tests+0x00000132e814)\n    #14 testing::Test::Run() ../googletest/googletest/src/gtest.cc:2474 (ep-engine_ep_unit_tests+0x00000131d649)\n    #15 testing::TestInfo::Run() ../googletest/googletest/src/gtest.cc:2656 (ep-engine_ep_unit_tests+0x00000131d91d)\n    #16 testing::TestCase::Run() ../googletest/googletest/src/gtest.cc:2774 (ep-engine_ep_unit_tests+0x00000131dac5)\n    #17 testing::internal::UnitTestImpl::RunAllTests() ../googletest/googletest/src/gtest.cc:4649 (ep-engine_ep_unit_tests+0x00000131fe3e)\n    #18 bool testing::internal::HandleSehExceptionsInMethodIfSupported\u003ctesting::internal::UnitTestImpl, bool\u003e(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) ../googletest/googletest/src/gtest.cc:2402 (ep-engine_ep_unit_tests+0x000001327972)\n    #19 bool testing::internal::HandleExceptionsInMethodIfSupported\u003ctesting::internal::UnitTestImpl, bool\u003e(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) ../googletest/googletest/src/gtest.cc:2438 (ep-engine_ep_unit_tests+0x00000132edc8)\n    #20 testing::UnitTest::Run() ../googletest/googletest/src/gtest.cc:4257 (ep-engine_ep_unit_tests+0x00000131d741)\n    #21 RUN_ALL_TESTS() ../googletest/googletest/include/gtest/gtest.h:2237 (ep-engine_ep_unit_tests+0x000000d30e6a)\n    #22 main ../kv_engine/engines/ep/tests/module_tests/ep_unit_tests_main.cc:144 (ep-engine_ep_unit_tests+0x000000d30e6a)\n\nChange-Id: I7f7448627d20c753add8c92eaf1186fb350aaab0\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"643773a60560b0235fd786a0bb311b27215ed15b","is_merged_in_target_branch":true,"change_id":"I5e50e617dadcd2e2a7f329470ada43c4598b659d","change_number":137281,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/master"},"c3e3fd734e1a7d0479948d4a7d9aedcb595a1a0a":{"kind":"REWORK","_number":3,"created":"2020-10-06 13:35:07.000000000","uploader":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/48/137548/3","fetch":{"anonymous http":{"url":"https://review.couchbase.org/kv_engine","ref":"refs/changes/48/137548/3","commands":{"Branch":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/3 \u0026\u0026 git checkout -b change-137548 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/kv_engine refs/changes/48/137548/3","Reset To":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"643773a60560b0235fd786a0bb311b27215ed15b","subject":"MB-41719: Move AckCorrectPassiveStream to ST suite"}],"author":{"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","date":"2020-10-06 11:15:24.000000000","tz":60},"committer":{"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","date":"2020-10-06 13:34:49.000000000","tz":60},"subject":"MB-41510: Fix TSAN failure due to lock order inversion","message":"MB-41510: Fix TSAN failure due to lock order inversion\n\nFix a TSAN failure due to a lock order inversion observed on the\nmad-hatter TSAN cv machine. This was due to a potential deadlock while\nacquiring locks on this and other histogram in\nHdrHistogram::operator+\u003d(). To fix this use folly::acquireLocked() to\nsafely take write lock and read lock on this-\u003ehistogram and\nother.histogram respectively. We also remove the nullptr for\nthis-\u003ehistogram as we don\u0027t guard any other access to the histograms\npointer, in case cb_calloc() fails.  \n\nTSAN failure:\n    WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock) (pid\u003d11208)\n    Cycle in lock order graph: M296533874179548048 (0x000000000000) \u003d\u003e M174936684240544688 (0x000000000000) \u003d\u003e M296533874179548048\n\n    Mutex M174936684240544688 acquired here while holding mutex M296533874179548048 in main thread:\n    #0 AnnotateRWLockAcquired \u003cnull\u003e (libtsan.so.0+0x00000005b63d)\n    #1 folly::detail::annotate_rwlock_acquired_impl(void const volatile*, folly::annotate_rwlock_level, char const*, int) /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/synchronization/SanitizeThread.cpp:99 (ep-engine_ep_unit_tests+0x00000139555e)\n    #2 annotate_rwlock_acquired tlm/deps/folly.exploded/include/folly/synchronization/SanitizeThread.h:111 (ep-engine_ep_unit_tests+0x000001362a06)\n    #3 folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e::annotateAcquired(folly::annotate_rwlock_level) tlm/deps/folly.exploded/include/folly/SharedMutex.h:726 (ep-engine_ep_unit_tests+0x000001362a06)\n    #4 folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e::lock_shared() tlm/deps/folly.exploded/include/folly/SharedMutex.h:400 (ep-engine_ep_unit_tests+0x000001362a06)\n    #5 folly::detail::LockTraitsImpl\u003cfolly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e, (folly::detail::MutexLevel)1, false\u003e::lock_shared(folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e\u0026) tlm/deps/folly.exploded/include/folly/LockTraits.h:157 (ep-engine_ep_unit_tests+0x000001362a06)\n    #6 std::integral_constant\u003cbool, true\u003e folly::LockPolicyShared::lock\u003cfolly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e(folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e\u0026) tlm/deps/folly.exploded/include/folly/LockTraits.h:499 (ep-engine_ep_unit_tests+0x000001362a06)\n    #7 folly::LockedPtrBase\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e, folly::LockPolicyShared\u003e::LockedPtrBase(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const*) tlm/deps/folly.exploded/include/folly/Synchronized.h:1089 (ep-engine_ep_unit_tests+0x000001362a06)\n    #8 folly::LockedPtr\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const, folly::LockPolicyShared\u003e::LockedPtr(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const*) tlm/deps/folly.exploded/include/folly/Synchronized.h:1394 (ep-engine_ep_unit_tests+0x000001360063)\n    #9 folly::SynchronizedBase\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e, (folly::detail::MutexLevel)1\u003e::rlock() tlm/deps/folly.exploded/include/folly/Synchronized.h:140 (ep-engine_ep_unit_tests+0x000001360063)\n    #10 HdrHistogram::operator+\u003d(HdrHistogram const\u0026) ../kv_engine/utilities/hdrhistogram.cc:83 (ep-engine_ep_unit_tests+0x000001360063)\n    #11 HdrHistogramTest_aggregationTest_Test::TestBody() ../kv_engine/engines/ep/tests/module_tests/hdrhistogram_test.cc:317 (ep-engine_ep_unit_tests+0x00000106945c)\n    #12 void testing::internal::HandleSehExceptionsInMethodIfSupported\u003ctesting::Test, void\u003e(testing::Test*, void (testing::Test::*)(), char const*) ../googletest/googletest/src/gtest.cc:2402 (ep-engine_ep_unit_tests+0x0000013276cb)\n    #13 void testing::internal::HandleExceptionsInMethodIfSupported\u003ctesting::Test, void\u003e(testing::Test*, void (testing::Test::*)(), char const*) ../googletest/googletest/src/gtest.cc:2438 (ep-engine_ep_unit_tests+0x00000132e814)\n    #14 testing::Test::Run() ../googletest/googletest/src/gtest.cc:2474 (ep-engine_ep_unit_tests+0x00000131d649)\n    #15 testing::TestInfo::Run() ../googletest/googletest/src/gtest.cc:2656 (ep-engine_ep_unit_tests+0x00000131d91d)\n    #16 testing::TestCase::Run() ../googletest/googletest/src/gtest.cc:2774 (ep-engine_ep_unit_tests+0x00000131dac5)\n    #17 testing::internal::UnitTestImpl::RunAllTests() ../googletest/googletest/src/gtest.cc:4649 (ep-engine_ep_unit_tests+0x00000131fe3e)\n    #18 bool testing::internal::HandleSehExceptionsInMethodIfSupported\u003ctesting::internal::UnitTestImpl, bool\u003e(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) ../googletest/googletest/src/gtest.cc:2402 (ep-engine_ep_unit_tests+0x000001327972)\n    #19 bool testing::internal::HandleExceptionsInMethodIfSupported\u003ctesting::internal::UnitTestImpl, bool\u003e(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) ../googletest/googletest/src/gtest.cc:2438 (ep-engine_ep_unit_tests+0x00000132edc8)\n    #20 testing::UnitTest::Run() ../googletest/googletest/src/gtest.cc:4257 (ep-engine_ep_unit_tests+0x00000131d741)\n    #21 RUN_ALL_TESTS() ../googletest/googletest/include/gtest/gtest.h:2237 (ep-engine_ep_unit_tests+0x000000d30e6a)\n    #22 main ../kv_engine/engines/ep/tests/module_tests/ep_unit_tests_main.cc:144 (ep-engine_ep_unit_tests+0x000000d30e6a)\n\nChange-Id: I7f7448627d20c753add8c92eaf1186fb350aaab0\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"643773a60560b0235fd786a0bb311b27215ed15b","is_merged_in_target_branch":true,"change_id":"I5e50e617dadcd2e2a7f329470ada43c4598b659d","change_number":137281,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/master"},"b54aea7692b2708bff65571a2e5eb96ef587a2a5":{"kind":"REWORK","_number":4,"created":"2020-10-06 14:25:46.000000000","uploader":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/48/137548/4","fetch":{"anonymous http":{"url":"https://review.couchbase.org/kv_engine","ref":"refs/changes/48/137548/4","commands":{"Branch":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/4 \u0026\u0026 git checkout -b change-137548 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/kv_engine refs/changes/48/137548/4","Reset To":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"643773a60560b0235fd786a0bb311b27215ed15b","subject":"MB-41719: Move AckCorrectPassiveStream to ST suite"}],"author":{"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","date":"2020-10-06 11:15:24.000000000","tz":60},"committer":{"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","date":"2020-10-06 14:25:33.000000000","tz":60},"subject":"MB-41510: Fix TSAN failure due to lock order inversion","message":"MB-41510: Fix TSAN failure due to lock order inversion\n\nFix a TSAN failure due to a lock order inversion observed on the\nmad-hatter TSAN cv machine. This was due to a potential deadlock while\nacquiring locks on this and other histogram in\nHdrHistogram::operator+\u003d(). To fix this use folly::acquireLocked() to\nsafely take write lock and read lock on this-\u003ehistogram and\nother.histogram respectively. We also remove the nullptr for\nthis-\u003ehistogram as we don\u0027t guard any other access to the histograms\npointer, in case cb_calloc() fails.\n\nTSAN failure:\n    WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock) (pid\u003d11208)\n    Cycle in lock order graph: M296533874179548048 (0x000000000000) \u003d\u003e M174936684240544688 (0x000000000000) \u003d\u003e M296533874179548048\n\n    Mutex M174936684240544688 acquired here while holding mutex M296533874179548048 in main thread:\n    #0 AnnotateRWLockAcquired \u003cnull\u003e (libtsan.so.0+0x00000005b63d)\n    #1 folly::detail::annotate_rwlock_acquired_impl(void const volatile*, folly::annotate_rwlock_level, char const*, int) /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/synchronization/SanitizeThread.cpp:99 (ep-engine_ep_unit_tests+0x00000139555e)\n    #2 annotate_rwlock_acquired tlm/deps/folly.exploded/include/folly/synchronization/SanitizeThread.h:111 (ep-engine_ep_unit_tests+0x000001362a06)\n    #3 folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e::annotateAcquired(folly::annotate_rwlock_level) tlm/deps/folly.exploded/include/folly/SharedMutex.h:726 (ep-engine_ep_unit_tests+0x000001362a06)\n    #4 folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e::lock_shared() tlm/deps/folly.exploded/include/folly/SharedMutex.h:400 (ep-engine_ep_unit_tests+0x000001362a06)\n    #5 folly::detail::LockTraitsImpl\u003cfolly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e, (folly::detail::MutexLevel)1, false\u003e::lock_shared(folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e\u0026) tlm/deps/folly.exploded/include/folly/LockTraits.h:157 (ep-engine_ep_unit_tests+0x000001362a06)\n    #6 std::integral_constant\u003cbool, true\u003e folly::LockPolicyShared::lock\u003cfolly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e(folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e\u0026) tlm/deps/folly.exploded/include/folly/LockTraits.h:499 (ep-engine_ep_unit_tests+0x000001362a06)\n    #7 folly::LockedPtrBase\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e, folly::LockPolicyShared\u003e::LockedPtrBase(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const*) tlm/deps/folly.exploded/include/folly/Synchronized.h:1089 (ep-engine_ep_unit_tests+0x000001362a06)\n    #8 folly::LockedPtr\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const, folly::LockPolicyShared\u003e::LockedPtr(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const*) tlm/deps/folly.exploded/include/folly/Synchronized.h:1394 (ep-engine_ep_unit_tests+0x000001360063)\n    #9 folly::SynchronizedBase\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e, (folly::detail::MutexLevel)1\u003e::rlock() tlm/deps/folly.exploded/include/folly/Synchronized.h:140 (ep-engine_ep_unit_tests+0x000001360063)\n    #10 HdrHistogram::operator+\u003d(HdrHistogram const\u0026) ../kv_engine/utilities/hdrhistogram.cc:83 (ep-engine_ep_unit_tests+0x000001360063)\n    #11 HdrHistogramTest_aggregationTest_Test::TestBody() ../kv_engine/engines/ep/tests/module_tests/hdrhistogram_test.cc:317 (ep-engine_ep_unit_tests+0x00000106945c)\n    #12 void testing::internal::HandleSehExceptionsInMethodIfSupported\u003ctesting::Test, void\u003e(testing::Test*, void (testing::Test::*)(), char const*) ../googletest/googletest/src/gtest.cc:2402 (ep-engine_ep_unit_tests+0x0000013276cb)\n    #13 void testing::internal::HandleExceptionsInMethodIfSupported\u003ctesting::Test, void\u003e(testing::Test*, void (testing::Test::*)(), char const*) ../googletest/googletest/src/gtest.cc:2438 (ep-engine_ep_unit_tests+0x00000132e814)\n    #14 testing::Test::Run() ../googletest/googletest/src/gtest.cc:2474 (ep-engine_ep_unit_tests+0x00000131d649)\n    #15 testing::TestInfo::Run() ../googletest/googletest/src/gtest.cc:2656 (ep-engine_ep_unit_tests+0x00000131d91d)\n    #16 testing::TestCase::Run() ../googletest/googletest/src/gtest.cc:2774 (ep-engine_ep_unit_tests+0x00000131dac5)\n    #17 testing::internal::UnitTestImpl::RunAllTests() ../googletest/googletest/src/gtest.cc:4649 (ep-engine_ep_unit_tests+0x00000131fe3e)\n    #18 bool testing::internal::HandleSehExceptionsInMethodIfSupported\u003ctesting::internal::UnitTestImpl, bool\u003e(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) ../googletest/googletest/src/gtest.cc:2402 (ep-engine_ep_unit_tests+0x000001327972)\n    #19 bool testing::internal::HandleExceptionsInMethodIfSupported\u003ctesting::internal::UnitTestImpl, bool\u003e(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) ../googletest/googletest/src/gtest.cc:2438 (ep-engine_ep_unit_tests+0x00000132edc8)\n    #20 testing::UnitTest::Run() ../googletest/googletest/src/gtest.cc:4257 (ep-engine_ep_unit_tests+0x00000131d741)\n    #21 RUN_ALL_TESTS() ../googletest/googletest/include/gtest/gtest.h:2237 (ep-engine_ep_unit_tests+0x000000d30e6a)\n    #22 main ../kv_engine/engines/ep/tests/module_tests/ep_unit_tests_main.cc:144 (ep-engine_ep_unit_tests+0x000000d30e6a)\n\nChange-Id: I7f7448627d20c753add8c92eaf1186fb350aaab0\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"643773a60560b0235fd786a0bb311b27215ed15b","is_merged_in_target_branch":true,"change_id":"I5e50e617dadcd2e2a7f329470ada43c4598b659d","change_number":137281,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/master"},"7fe20d9efd3139df9b49ada6248ec3d7efbeeb35":{"kind":"REWORK","_number":5,"created":"2020-10-06 14:47:48.000000000","uploader":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/48/137548/5","fetch":{"anonymous http":{"url":"https://review.couchbase.org/kv_engine","ref":"refs/changes/48/137548/5","commands":{"Branch":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/5 \u0026\u0026 git checkout -b change-137548 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/kv_engine refs/changes/48/137548/5","Reset To":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"643773a60560b0235fd786a0bb311b27215ed15b","subject":"MB-41719: Move AckCorrectPassiveStream to ST suite"}],"author":{"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","date":"2020-10-06 11:15:24.000000000","tz":60},"committer":{"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","date":"2020-10-06 14:45:29.000000000","tz":60},"subject":"MB-41510: Fix TSAN failure due to lock order inversion","message":"MB-41510: Fix TSAN failure due to lock order inversion\n\nFix a TSAN failure due to a lock order inversion observed on the\nmad-hatter TSAN cv machine. This was due to a potential deadlock while\nacquiring locks on this and other histogram in\nHdrHistogram::operator+\u003d(). To fix this use folly::acquireLocked() to\nsafely take write lock and read lock on this-\u003ehistogram and\nother.histogram respectively. We also remove the nullptr for\nthis-\u003ehistogram as we don\u0027t guard any other access to the histograms\npointer, in case cb_calloc() fails.\n\nTSAN failure:\n    WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock) (pid\u003d11208)\n    Cycle in lock order graph: M296533874179548048 (0x000000000000) \u003d\u003e M174936684240544688 (0x000000000000) \u003d\u003e M296533874179548048\n\n    Mutex M174936684240544688 acquired here while holding mutex M296533874179548048 in main thread:\n    #0 AnnotateRWLockAcquired \u003cnull\u003e (libtsan.so.0+0x00000005b63d)\n    #1 folly::detail::annotate_rwlock_acquired_impl(void const volatile*, folly::annotate_rwlock_level, char const*, int) /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/synchronization/SanitizeThread.cpp:99 (ep-engine_ep_unit_tests+0x00000139555e)\n    #2 annotate_rwlock_acquired tlm/deps/folly.exploded/include/folly/synchronization/SanitizeThread.h:111 (ep-engine_ep_unit_tests+0x000001362a06)\n    #3 folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e::annotateAcquired(folly::annotate_rwlock_level) tlm/deps/folly.exploded/include/folly/SharedMutex.h:726 (ep-engine_ep_unit_tests+0x000001362a06)\n    #4 folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e::lock_shared() tlm/deps/folly.exploded/include/folly/SharedMutex.h:400 (ep-engine_ep_unit_tests+0x000001362a06)\n    #5 folly::detail::LockTraitsImpl\u003cfolly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e, (folly::detail::MutexLevel)1, false\u003e::lock_shared(folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e\u0026) tlm/deps/folly.exploded/include/folly/LockTraits.h:157 (ep-engine_ep_unit_tests+0x000001362a06)\n    #6 std::integral_constant\u003cbool, true\u003e folly::LockPolicyShared::lock\u003cfolly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e(folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e\u0026) tlm/deps/folly.exploded/include/folly/LockTraits.h:499 (ep-engine_ep_unit_tests+0x000001362a06)\n    #7 folly::LockedPtrBase\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e, folly::LockPolicyShared\u003e::LockedPtrBase(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const*) tlm/deps/folly.exploded/include/folly/Synchronized.h:1089 (ep-engine_ep_unit_tests+0x000001362a06)\n    #8 folly::LockedPtr\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const, folly::LockPolicyShared\u003e::LockedPtr(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const*) tlm/deps/folly.exploded/include/folly/Synchronized.h:1394 (ep-engine_ep_unit_tests+0x000001360063)\n    #9 folly::SynchronizedBase\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e, (folly::detail::MutexLevel)1\u003e::rlock() tlm/deps/folly.exploded/include/folly/Synchronized.h:140 (ep-engine_ep_unit_tests+0x000001360063)\n    #10 HdrHistogram::operator+\u003d(HdrHistogram const\u0026) ../kv_engine/utilities/hdrhistogram.cc:83 (ep-engine_ep_unit_tests+0x000001360063)\n    #11 HdrHistogramTest_aggregationTest_Test::TestBody() ../kv_engine/engines/ep/tests/module_tests/hdrhistogram_test.cc:317 (ep-engine_ep_unit_tests+0x00000106945c)\n    #12 void testing::internal::HandleSehExceptionsInMethodIfSupported\u003ctesting::Test, void\u003e(testing::Test*, void (testing::Test::*)(), char const*) ../googletest/googletest/src/gtest.cc:2402 (ep-engine_ep_unit_tests+0x0000013276cb)\n    #13 void testing::internal::HandleExceptionsInMethodIfSupported\u003ctesting::Test, void\u003e(testing::Test*, void (testing::Test::*)(), char const*) ../googletest/googletest/src/gtest.cc:2438 (ep-engine_ep_unit_tests+0x00000132e814)\n    #14 testing::Test::Run() ../googletest/googletest/src/gtest.cc:2474 (ep-engine_ep_unit_tests+0x00000131d649)\n    #15 testing::TestInfo::Run() ../googletest/googletest/src/gtest.cc:2656 (ep-engine_ep_unit_tests+0x00000131d91d)\n    #16 testing::TestCase::Run() ../googletest/googletest/src/gtest.cc:2774 (ep-engine_ep_unit_tests+0x00000131dac5)\n    #17 testing::internal::UnitTestImpl::RunAllTests() ../googletest/googletest/src/gtest.cc:4649 (ep-engine_ep_unit_tests+0x00000131fe3e)\n    #18 bool testing::internal::HandleSehExceptionsInMethodIfSupported\u003ctesting::internal::UnitTestImpl, bool\u003e(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) ../googletest/googletest/src/gtest.cc:2402 (ep-engine_ep_unit_tests+0x000001327972)\n    #19 bool testing::internal::HandleExceptionsInMethodIfSupported\u003ctesting::internal::UnitTestImpl, bool\u003e(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) ../googletest/googletest/src/gtest.cc:2438 (ep-engine_ep_unit_tests+0x00000132edc8)\n    #20 testing::UnitTest::Run() ../googletest/googletest/src/gtest.cc:4257 (ep-engine_ep_unit_tests+0x00000131d741)\n    #21 RUN_ALL_TESTS() ../googletest/googletest/include/gtest/gtest.h:2237 (ep-engine_ep_unit_tests+0x000000d30e6a)\n    #22 main ../kv_engine/engines/ep/tests/module_tests/ep_unit_tests_main.cc:144 (ep-engine_ep_unit_tests+0x000000d30e6a)\n\nChange-Id: I7f7448627d20c753add8c92eaf1186fb350aaab0\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"643773a60560b0235fd786a0bb311b27215ed15b","is_merged_in_target_branch":true,"change_id":"I5e50e617dadcd2e2a7f329470ada43c4598b659d","change_number":137281,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/master"},"226656a3b2b641ae24ca445aeb30586128e1ac6a":{"kind":"REWORK","_number":6,"created":"2020-10-06 15:11:21.000000000","uploader":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/48/137548/6","fetch":{"anonymous http":{"url":"https://review.couchbase.org/kv_engine","ref":"refs/changes/48/137548/6","commands":{"Branch":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/6 \u0026\u0026 git checkout -b change-137548 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/kv_engine refs/changes/48/137548/6","Reset To":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"643773a60560b0235fd786a0bb311b27215ed15b","subject":"MB-41719: Move AckCorrectPassiveStream to ST suite"}],"author":{"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","date":"2020-10-06 11:15:24.000000000","tz":60},"committer":{"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","date":"2020-10-06 15:11:02.000000000","tz":60},"subject":"MB-41510: Fix TSAN failure due to lock order inversion","message":"MB-41510: Fix TSAN failure due to lock order inversion\n\nFix a TSAN failure due to a lock order inversion observed on the\nmad-hatter TSAN cv machine. This was due to a potential deadlock while\nacquiring locks on this and other histogram in\nHdrHistogram::operator+\u003d(). To fix this use folly::acquireLocked() to\nsafely take write lock and read lock on this-\u003ehistogram and\nother.histogram respectively. We also remove the nullptr for\nthis-\u003ehistogram as we don\u0027t guard any other access to the histograms\npointer, in case cb_calloc() fails.\n\nTSAN failure:\n    WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock) (pid\u003d11208)\n    Cycle in lock order graph: M296533874179548048 (0x000000000000) \u003d\u003e M174936684240544688 (0x000000000000) \u003d\u003e M296533874179548048\n\n    Mutex M174936684240544688 acquired here while holding mutex M296533874179548048 in main thread:\n    #0 AnnotateRWLockAcquired \u003cnull\u003e (libtsan.so.0+0x00000005b63d)\n    #1 folly::detail::annotate_rwlock_acquired_impl(void const volatile*, folly::annotate_rwlock_level, char const*, int) /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/synchronization/SanitizeThread.cpp:99 (ep-engine_ep_unit_tests+0x00000139555e)\n    #2 annotate_rwlock_acquired tlm/deps/folly.exploded/include/folly/synchronization/SanitizeThread.h:111 (ep-engine_ep_unit_tests+0x000001362a06)\n    #3 folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e::annotateAcquired(folly::annotate_rwlock_level) tlm/deps/folly.exploded/include/folly/SharedMutex.h:726 (ep-engine_ep_unit_tests+0x000001362a06)\n    #4 folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e::lock_shared() tlm/deps/folly.exploded/include/folly/SharedMutex.h:400 (ep-engine_ep_unit_tests+0x000001362a06)\n    #5 folly::detail::LockTraitsImpl\u003cfolly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e, (folly::detail::MutexLevel)1, false\u003e::lock_shared(folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e\u0026) tlm/deps/folly.exploded/include/folly/LockTraits.h:157 (ep-engine_ep_unit_tests+0x000001362a06)\n    #6 std::integral_constant\u003cbool, true\u003e folly::LockPolicyShared::lock\u003cfolly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e(folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e\u0026) tlm/deps/folly.exploded/include/folly/LockTraits.h:499 (ep-engine_ep_unit_tests+0x000001362a06)\n    #7 folly::LockedPtrBase\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e, folly::LockPolicyShared\u003e::LockedPtrBase(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const*) tlm/deps/folly.exploded/include/folly/Synchronized.h:1089 (ep-engine_ep_unit_tests+0x000001362a06)\n    #8 folly::LockedPtr\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const, folly::LockPolicyShared\u003e::LockedPtr(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const*) tlm/deps/folly.exploded/include/folly/Synchronized.h:1394 (ep-engine_ep_unit_tests+0x000001360063)\n    #9 folly::SynchronizedBase\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e, (folly::detail::MutexLevel)1\u003e::rlock() tlm/deps/folly.exploded/include/folly/Synchronized.h:140 (ep-engine_ep_unit_tests+0x000001360063)\n    #10 HdrHistogram::operator+\u003d(HdrHistogram const\u0026) ../kv_engine/utilities/hdrhistogram.cc:83 (ep-engine_ep_unit_tests+0x000001360063)\n    #11 HdrHistogramTest_aggregationTest_Test::TestBody() ../kv_engine/engines/ep/tests/module_tests/hdrhistogram_test.cc:317 (ep-engine_ep_unit_tests+0x00000106945c)\n    #12 void testing::internal::HandleSehExceptionsInMethodIfSupported\u003ctesting::Test, void\u003e(testing::Test*, void (testing::Test::*)(), char const*) ../googletest/googletest/src/gtest.cc:2402 (ep-engine_ep_unit_tests+0x0000013276cb)\n    #13 void testing::internal::HandleExceptionsInMethodIfSupported\u003ctesting::Test, void\u003e(testing::Test*, void (testing::Test::*)(), char const*) ../googletest/googletest/src/gtest.cc:2438 (ep-engine_ep_unit_tests+0x00000132e814)\n    #14 testing::Test::Run() ../googletest/googletest/src/gtest.cc:2474 (ep-engine_ep_unit_tests+0x00000131d649)\n    #15 testing::TestInfo::Run() ../googletest/googletest/src/gtest.cc:2656 (ep-engine_ep_unit_tests+0x00000131d91d)\n    #16 testing::TestCase::Run() ../googletest/googletest/src/gtest.cc:2774 (ep-engine_ep_unit_tests+0x00000131dac5)\n    #17 testing::internal::UnitTestImpl::RunAllTests() ../googletest/googletest/src/gtest.cc:4649 (ep-engine_ep_unit_tests+0x00000131fe3e)\n    #18 bool testing::internal::HandleSehExceptionsInMethodIfSupported\u003ctesting::internal::UnitTestImpl, bool\u003e(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) ../googletest/googletest/src/gtest.cc:2402 (ep-engine_ep_unit_tests+0x000001327972)\n    #19 bool testing::internal::HandleExceptionsInMethodIfSupported\u003ctesting::internal::UnitTestImpl, bool\u003e(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) ../googletest/googletest/src/gtest.cc:2438 (ep-engine_ep_unit_tests+0x00000132edc8)\n    #20 testing::UnitTest::Run() ../googletest/googletest/src/gtest.cc:4257 (ep-engine_ep_unit_tests+0x00000131d741)\n    #21 RUN_ALL_TESTS() ../googletest/googletest/include/gtest/gtest.h:2237 (ep-engine_ep_unit_tests+0x000000d30e6a)\n    #22 main ../kv_engine/engines/ep/tests/module_tests/ep_unit_tests_main.cc:144 (ep-engine_ep_unit_tests+0x000000d30e6a)\n\nChange-Id: I7f7448627d20c753add8c92eaf1186fb350aaab0\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"643773a60560b0235fd786a0bb311b27215ed15b","is_merged_in_target_branch":true,"change_id":"I5e50e617dadcd2e2a7f329470ada43c4598b659d","change_number":137281,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/master"},"c60f6aa8867e74d5688b6b445ac28dd103f1566e":{"kind":"REWORK","_number":7,"created":"2020-10-06 16:16:45.000000000","uploader":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/48/137548/7","fetch":{"anonymous http":{"url":"https://review.couchbase.org/kv_engine","ref":"refs/changes/48/137548/7","commands":{"Branch":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/7 \u0026\u0026 git checkout -b change-137548 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/kv_engine refs/changes/48/137548/7","Reset To":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/7 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f133e7103cee2a070f5fc7b61853751e49839428","subject":"MB-41719: Move processConsumerMutationsNearThreshold to ST test suite"}],"author":{"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","date":"2020-10-06 11:15:24.000000000","tz":60},"committer":{"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","date":"2020-10-06 16:15:54.000000000","tz":60},"subject":"MB-41510: Fix TSAN failure due to lock order inversion","message":"MB-41510: Fix TSAN failure due to lock order inversion\n\nFix a TSAN failure due to a lock order inversion observed on the\nmad-hatter TSAN cv machine. This was due to a potential deadlock while\nacquiring locks on this and other histogram in\nHdrHistogram::operator+\u003d(). To fix this use folly::acquireLocked() to\nsafely take write lock and read lock on this-\u003ehistogram and\nother.histogram respectively. We also remove the nullptr for\nthis-\u003ehistogram as we don\u0027t guard any other access to the histograms\npointer, in case cb_calloc() fails.\n\nTSAN failure:\n    WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock) (pid\u003d11208)\n    Cycle in lock order graph: M296533874179548048 (0x000000000000) \u003d\u003e M174936684240544688 (0x000000000000) \u003d\u003e M296533874179548048\n\n    Mutex M174936684240544688 acquired here while holding mutex M296533874179548048 in main thread:\n    #0 AnnotateRWLockAcquired \u003cnull\u003e (libtsan.so.0+0x00000005b63d)\n    #1 folly::detail::annotate_rwlock_acquired_impl(void const volatile*, folly::annotate_rwlock_level, char const*, int) /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/synchronization/SanitizeThread.cpp:99 (ep-engine_ep_unit_tests+0x00000139555e)\n    #2 annotate_rwlock_acquired tlm/deps/folly.exploded/include/folly/synchronization/SanitizeThread.h:111 (ep-engine_ep_unit_tests+0x000001362a06)\n    #3 folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e::annotateAcquired(folly::annotate_rwlock_level) tlm/deps/folly.exploded/include/folly/SharedMutex.h:726 (ep-engine_ep_unit_tests+0x000001362a06)\n    #4 folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e::lock_shared() tlm/deps/folly.exploded/include/folly/SharedMutex.h:400 (ep-engine_ep_unit_tests+0x000001362a06)\n    #5 folly::detail::LockTraitsImpl\u003cfolly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e, (folly::detail::MutexLevel)1, false\u003e::lock_shared(folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e\u0026) tlm/deps/folly.exploded/include/folly/LockTraits.h:157 (ep-engine_ep_unit_tests+0x000001362a06)\n    #6 std::integral_constant\u003cbool, true\u003e folly::LockPolicyShared::lock\u003cfolly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e(folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e\u0026) tlm/deps/folly.exploded/include/folly/LockTraits.h:499 (ep-engine_ep_unit_tests+0x000001362a06)\n    #7 folly::LockedPtrBase\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e, folly::LockPolicyShared\u003e::LockedPtrBase(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const*) tlm/deps/folly.exploded/include/folly/Synchronized.h:1089 (ep-engine_ep_unit_tests+0x000001362a06)\n    #8 folly::LockedPtr\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const, folly::LockPolicyShared\u003e::LockedPtr(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const*) tlm/deps/folly.exploded/include/folly/Synchronized.h:1394 (ep-engine_ep_unit_tests+0x000001360063)\n    #9 folly::SynchronizedBase\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e, (folly::detail::MutexLevel)1\u003e::rlock() tlm/deps/folly.exploded/include/folly/Synchronized.h:140 (ep-engine_ep_unit_tests+0x000001360063)\n    #10 HdrHistogram::operator+\u003d(HdrHistogram const\u0026) ../kv_engine/utilities/hdrhistogram.cc:83 (ep-engine_ep_unit_tests+0x000001360063)\n    #11 HdrHistogramTest_aggregationTest_Test::TestBody() ../kv_engine/engines/ep/tests/module_tests/hdrhistogram_test.cc:317 (ep-engine_ep_unit_tests+0x00000106945c)\n    #12 void testing::internal::HandleSehExceptionsInMethodIfSupported\u003ctesting::Test, void\u003e(testing::Test*, void (testing::Test::*)(), char const*) ../googletest/googletest/src/gtest.cc:2402 (ep-engine_ep_unit_tests+0x0000013276cb)\n    #13 void testing::internal::HandleExceptionsInMethodIfSupported\u003ctesting::Test, void\u003e(testing::Test*, void (testing::Test::*)(), char const*) ../googletest/googletest/src/gtest.cc:2438 (ep-engine_ep_unit_tests+0x00000132e814)\n    #14 testing::Test::Run() ../googletest/googletest/src/gtest.cc:2474 (ep-engine_ep_unit_tests+0x00000131d649)\n    #15 testing::TestInfo::Run() ../googletest/googletest/src/gtest.cc:2656 (ep-engine_ep_unit_tests+0x00000131d91d)\n    #16 testing::TestCase::Run() ../googletest/googletest/src/gtest.cc:2774 (ep-engine_ep_unit_tests+0x00000131dac5)\n    #17 testing::internal::UnitTestImpl::RunAllTests() ../googletest/googletest/src/gtest.cc:4649 (ep-engine_ep_unit_tests+0x00000131fe3e)\n    #18 bool testing::internal::HandleSehExceptionsInMethodIfSupported\u003ctesting::internal::UnitTestImpl, bool\u003e(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) ../googletest/googletest/src/gtest.cc:2402 (ep-engine_ep_unit_tests+0x000001327972)\n    #19 bool testing::internal::HandleExceptionsInMethodIfSupported\u003ctesting::internal::UnitTestImpl, bool\u003e(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) ../googletest/googletest/src/gtest.cc:2438 (ep-engine_ep_unit_tests+0x00000132edc8)\n    #20 testing::UnitTest::Run() ../googletest/googletest/src/gtest.cc:4257 (ep-engine_ep_unit_tests+0x00000131d741)\n    #21 RUN_ALL_TESTS() ../googletest/googletest/include/gtest/gtest.h:2237 (ep-engine_ep_unit_tests+0x000000d30e6a)\n    #22 main ../kv_engine/engines/ep/tests/module_tests/ep_unit_tests_main.cc:144 (ep-engine_ep_unit_tests+0x000000d30e6a)\n\nChange-Id: I7f7448627d20c753add8c92eaf1186fb350aaab0\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"f133e7103cee2a070f5fc7b61853751e49839428","is_merged_in_target_branch":true,"change_id":"I8b51b0eb9d7a779a652f8c73ee3ce3b5410e9f30","change_number":137170,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/master"},"61b49aa4277ed7ccdfcd94dc33293fd8da3bfd0c":{"kind":"REWORK","_number":8,"created":"2020-10-06 16:28:41.000000000","uploader":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/48/137548/8","fetch":{"anonymous http":{"url":"https://review.couchbase.org/kv_engine","ref":"refs/changes/48/137548/8","commands":{"Branch":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/8 \u0026\u0026 git checkout -b change-137548 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/kv_engine refs/changes/48/137548/8","Reset To":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/8 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f133e7103cee2a070f5fc7b61853751e49839428","subject":"MB-41719: Move processConsumerMutationsNearThreshold to ST test suite"}],"author":{"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","date":"2020-10-06 11:15:24.000000000","tz":60},"committer":{"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","date":"2020-10-06 16:28:23.000000000","tz":60},"subject":"MB-41510: Fix TSAN failure due to lock order inversion","message":"MB-41510: Fix TSAN failure due to lock order inversion\n\nFix a TSAN failure due to a lock order inversion observed on the\nmad-hatter TSAN cv machine. This was due to a potential deadlock while\nacquiring locks on this and other histogram in\nHdrHistogram::operator+\u003d(). To fix this use folly::acquireLocked() to\nsafely take write lock and read lock on this-\u003ehistogram and\nother.histogram respectively. We also remove the nullptr for\nthis-\u003ehistogram as we don\u0027t guard any other access to the histograms\npointer, in case cb_calloc() fails.\n\nTSAN failure:\n    WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock) (pid\u003d11208)\n    Cycle in lock order graph: M296533874179548048 (0x000000000000) \u003d\u003e M174936684240544688 (0x000000000000) \u003d\u003e M296533874179548048\n\n    Mutex M174936684240544688 acquired here while holding mutex M296533874179548048 in main thread:\n    #0 AnnotateRWLockAcquired \u003cnull\u003e (libtsan.so.0+0x00000005b63d)\n    #1 folly::detail::annotate_rwlock_acquired_impl(void const volatile*, folly::annotate_rwlock_level, char const*, int) /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/synchronization/SanitizeThread.cpp:99 (ep-engine_ep_unit_tests+0x00000139555e)\n    #2 annotate_rwlock_acquired tlm/deps/folly.exploded/include/folly/synchronization/SanitizeThread.h:111 (ep-engine_ep_unit_tests+0x000001362a06)\n    #3 folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e::annotateAcquired(folly::annotate_rwlock_level) tlm/deps/folly.exploded/include/folly/SharedMutex.h:726 (ep-engine_ep_unit_tests+0x000001362a06)\n    #4 folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e::lock_shared() tlm/deps/folly.exploded/include/folly/SharedMutex.h:400 (ep-engine_ep_unit_tests+0x000001362a06)\n    #5 folly::detail::LockTraitsImpl\u003cfolly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e, (folly::detail::MutexLevel)1, false\u003e::lock_shared(folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e\u0026) tlm/deps/folly.exploded/include/folly/LockTraits.h:157 (ep-engine_ep_unit_tests+0x000001362a06)\n    #6 std::integral_constant\u003cbool, true\u003e folly::LockPolicyShared::lock\u003cfolly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e(folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e\u0026) tlm/deps/folly.exploded/include/folly/LockTraits.h:499 (ep-engine_ep_unit_tests+0x000001362a06)\n    #7 folly::LockedPtrBase\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e, folly::LockPolicyShared\u003e::LockedPtrBase(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const*) tlm/deps/folly.exploded/include/folly/Synchronized.h:1089 (ep-engine_ep_unit_tests+0x000001362a06)\n    #8 folly::LockedPtr\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const, folly::LockPolicyShared\u003e::LockedPtr(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const*) tlm/deps/folly.exploded/include/folly/Synchronized.h:1394 (ep-engine_ep_unit_tests+0x000001360063)\n    #9 folly::SynchronizedBase\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e, (folly::detail::MutexLevel)1\u003e::rlock() tlm/deps/folly.exploded/include/folly/Synchronized.h:140 (ep-engine_ep_unit_tests+0x000001360063)\n    #10 HdrHistogram::operator+\u003d(HdrHistogram const\u0026) ../kv_engine/utilities/hdrhistogram.cc:83 (ep-engine_ep_unit_tests+0x000001360063)\n    #11 HdrHistogramTest_aggregationTest_Test::TestBody() ../kv_engine/engines/ep/tests/module_tests/hdrhistogram_test.cc:317 (ep-engine_ep_unit_tests+0x00000106945c)\n    #12 void testing::internal::HandleSehExceptionsInMethodIfSupported\u003ctesting::Test, void\u003e(testing::Test*, void (testing::Test::*)(), char const*) ../googletest/googletest/src/gtest.cc:2402 (ep-engine_ep_unit_tests+0x0000013276cb)\n    #13 void testing::internal::HandleExceptionsInMethodIfSupported\u003ctesting::Test, void\u003e(testing::Test*, void (testing::Test::*)(), char const*) ../googletest/googletest/src/gtest.cc:2438 (ep-engine_ep_unit_tests+0x00000132e814)\n    #14 testing::Test::Run() ../googletest/googletest/src/gtest.cc:2474 (ep-engine_ep_unit_tests+0x00000131d649)\n    #15 testing::TestInfo::Run() ../googletest/googletest/src/gtest.cc:2656 (ep-engine_ep_unit_tests+0x00000131d91d)\n    #16 testing::TestCase::Run() ../googletest/googletest/src/gtest.cc:2774 (ep-engine_ep_unit_tests+0x00000131dac5)\n    #17 testing::internal::UnitTestImpl::RunAllTests() ../googletest/googletest/src/gtest.cc:4649 (ep-engine_ep_unit_tests+0x00000131fe3e)\n    #18 bool testing::internal::HandleSehExceptionsInMethodIfSupported\u003ctesting::internal::UnitTestImpl, bool\u003e(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) ../googletest/googletest/src/gtest.cc:2402 (ep-engine_ep_unit_tests+0x000001327972)\n    #19 bool testing::internal::HandleExceptionsInMethodIfSupported\u003ctesting::internal::UnitTestImpl, bool\u003e(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) ../googletest/googletest/src/gtest.cc:2438 (ep-engine_ep_unit_tests+0x00000132edc8)\n    #20 testing::UnitTest::Run() ../googletest/googletest/src/gtest.cc:4257 (ep-engine_ep_unit_tests+0x00000131d741)\n    #21 RUN_ALL_TESTS() ../googletest/googletest/include/gtest/gtest.h:2237 (ep-engine_ep_unit_tests+0x000000d30e6a)\n    #22 main ../kv_engine/engines/ep/tests/module_tests/ep_unit_tests_main.cc:144 (ep-engine_ep_unit_tests+0x000000d30e6a)\n\nChange-Id: I7f7448627d20c753add8c92eaf1186fb350aaab0\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"f133e7103cee2a070f5fc7b61853751e49839428","is_merged_in_target_branch":true,"change_id":"I8b51b0eb9d7a779a652f8c73ee3ce3b5410e9f30","change_number":137170,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/master"},"54ad0eac2af0b40e9d94055254c587ef1dc1d14a":{"kind":"REWORK","_number":9,"created":"2020-10-07 10:01:47.000000000","uploader":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/48/137548/9","fetch":{"anonymous http":{"url":"https://review.couchbase.org/kv_engine","ref":"refs/changes/48/137548/9","commands":{"Branch":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/9 \u0026\u0026 git checkout -b change-137548 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/kv_engine refs/changes/48/137548/9","Reset To":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/9 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3b525cb99251f4086d08080c06f70645da33c032","subject":"MB-41719: Make test_producer_no_stream_end_on_client_close_stream ST"}],"author":{"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","date":"2020-10-06 11:15:24.000000000","tz":60},"committer":{"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","date":"2020-10-07 09:59:41.000000000","tz":60},"subject":"MB-41510: Fix TSAN failure due to lock order inversion","message":"MB-41510: Fix TSAN failure due to lock order inversion\n\nFix a TSAN failure due to a lock order inversion observed on the\nmad-hatter TSAN cv machine. This was due to a potential deadlock while\nacquiring locks on this and other histogram in\nHdrHistogram::operator+\u003d(). To fix this use folly::acquireLocked() to\nsafely take write lock and read lock on this-\u003ehistogram and\nother.histogram respectively. We also remove the nullptr for\nthis-\u003ehistogram as we don\u0027t guard any other access to the histograms\npointer, in case cb_calloc() fails.\n\nTSAN failure:\n    WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock) (pid\u003d11208)\n    Cycle in lock order graph: M296533874179548048 (0x000000000000) \u003d\u003e M174936684240544688 (0x000000000000) \u003d\u003e M296533874179548048\n\n    Mutex M174936684240544688 acquired here while holding mutex M296533874179548048 in main thread:\n    #0 AnnotateRWLockAcquired \u003cnull\u003e (libtsan.so.0+0x00000005b63d)\n    #1 folly::detail::annotate_rwlock_acquired_impl(void const volatile*, folly::annotate_rwlock_level, char const*, int) /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/synchronization/SanitizeThread.cpp:99 (ep-engine_ep_unit_tests+0x00000139555e)\n    #2 annotate_rwlock_acquired tlm/deps/folly.exploded/include/folly/synchronization/SanitizeThread.h:111 (ep-engine_ep_unit_tests+0x000001362a06)\n    #3 folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e::annotateAcquired(folly::annotate_rwlock_level) tlm/deps/folly.exploded/include/folly/SharedMutex.h:726 (ep-engine_ep_unit_tests+0x000001362a06)\n    #4 folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e::lock_shared() tlm/deps/folly.exploded/include/folly/SharedMutex.h:400 (ep-engine_ep_unit_tests+0x000001362a06)\n    #5 folly::detail::LockTraitsImpl\u003cfolly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e, (folly::detail::MutexLevel)1, false\u003e::lock_shared(folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e\u0026) tlm/deps/folly.exploded/include/folly/LockTraits.h:157 (ep-engine_ep_unit_tests+0x000001362a06)\n    #6 std::integral_constant\u003cbool, true\u003e folly::LockPolicyShared::lock\u003cfolly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e(folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e\u0026) tlm/deps/folly.exploded/include/folly/LockTraits.h:499 (ep-engine_ep_unit_tests+0x000001362a06)\n    #7 folly::LockedPtrBase\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e, folly::LockPolicyShared\u003e::LockedPtrBase(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const*) tlm/deps/folly.exploded/include/folly/Synchronized.h:1089 (ep-engine_ep_unit_tests+0x000001362a06)\n    #8 folly::LockedPtr\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const, folly::LockPolicyShared\u003e::LockedPtr(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const*) tlm/deps/folly.exploded/include/folly/Synchronized.h:1394 (ep-engine_ep_unit_tests+0x000001360063)\n    #9 folly::SynchronizedBase\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e, (folly::detail::MutexLevel)1\u003e::rlock() tlm/deps/folly.exploded/include/folly/Synchronized.h:140 (ep-engine_ep_unit_tests+0x000001360063)\n    #10 HdrHistogram::operator+\u003d(HdrHistogram const\u0026) ../kv_engine/utilities/hdrhistogram.cc:83 (ep-engine_ep_unit_tests+0x000001360063)\n    #11 HdrHistogramTest_aggregationTest_Test::TestBody() ../kv_engine/engines/ep/tests/module_tests/hdrhistogram_test.cc:317 (ep-engine_ep_unit_tests+0x00000106945c)\n    #12 void testing::internal::HandleSehExceptionsInMethodIfSupported\u003ctesting::Test, void\u003e(testing::Test*, void (testing::Test::*)(), char const*) ../googletest/googletest/src/gtest.cc:2402 (ep-engine_ep_unit_tests+0x0000013276cb)\n    #13 void testing::internal::HandleExceptionsInMethodIfSupported\u003ctesting::Test, void\u003e(testing::Test*, void (testing::Test::*)(), char const*) ../googletest/googletest/src/gtest.cc:2438 (ep-engine_ep_unit_tests+0x00000132e814)\n    #14 testing::Test::Run() ../googletest/googletest/src/gtest.cc:2474 (ep-engine_ep_unit_tests+0x00000131d649)\n    #15 testing::TestInfo::Run() ../googletest/googletest/src/gtest.cc:2656 (ep-engine_ep_unit_tests+0x00000131d91d)\n    #16 testing::TestCase::Run() ../googletest/googletest/src/gtest.cc:2774 (ep-engine_ep_unit_tests+0x00000131dac5)\n    #17 testing::internal::UnitTestImpl::RunAllTests() ../googletest/googletest/src/gtest.cc:4649 (ep-engine_ep_unit_tests+0x00000131fe3e)\n    #18 bool testing::internal::HandleSehExceptionsInMethodIfSupported\u003ctesting::internal::UnitTestImpl, bool\u003e(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) ../googletest/googletest/src/gtest.cc:2402 (ep-engine_ep_unit_tests+0x000001327972)\n    #19 bool testing::internal::HandleExceptionsInMethodIfSupported\u003ctesting::internal::UnitTestImpl, bool\u003e(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) ../googletest/googletest/src/gtest.cc:2438 (ep-engine_ep_unit_tests+0x00000132edc8)\n    #20 testing::UnitTest::Run() ../googletest/googletest/src/gtest.cc:4257 (ep-engine_ep_unit_tests+0x00000131d741)\n    #21 RUN_ALL_TESTS() ../googletest/googletest/include/gtest/gtest.h:2237 (ep-engine_ep_unit_tests+0x000000d30e6a)\n    #22 main ../kv_engine/engines/ep/tests/module_tests/ep_unit_tests_main.cc:144 (ep-engine_ep_unit_tests+0x000000d30e6a)\n\nChange-Id: I7f7448627d20c753add8c92eaf1186fb350aaab0\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"3b525cb99251f4086d08080c06f70645da33c032","is_merged_in_target_branch":true,"change_id":"Iabfc0efdc576a354a017f89c2d90a1466d549b44","change_number":137424,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"},"ef66cf6772e0cf03d528b13ab155c74db6000d3e":{"kind":"REWORK","_number":10,"created":"2020-10-07 10:24:47.000000000","uploader":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/48/137548/10","fetch":{"anonymous http":{"url":"https://review.couchbase.org/kv_engine","ref":"refs/changes/48/137548/10","commands":{"Branch":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/10 \u0026\u0026 git checkout -b change-137548 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/10 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/10 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/10 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/kv_engine refs/changes/48/137548/10","Reset To":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/10 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3b525cb99251f4086d08080c06f70645da33c032","subject":"MB-41719: Make test_producer_no_stream_end_on_client_close_stream ST"}],"author":{"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","date":"2020-10-06 11:15:24.000000000","tz":60},"committer":{"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","date":"2020-10-07 10:24:23.000000000","tz":60},"subject":"MB-41510: Fix TSAN failure due to lock order inversion","message":"MB-41510: Fix TSAN failure due to lock order inversion\n\nFix a TSAN failure due to a lock order inversion observed on the\nmad-hatter TSAN cv machine. This was due to a potential deadlock while\nacquiring locks on this and other histogram in\nHdrHistogram::operator+\u003d(). To fix this use folly::acquireLocked() to\nsafely take write lock and read lock on this-\u003ehistogram and\nother.histogram respectively. We also remove the nullptr for\nthis-\u003ehistogram as we don\u0027t guard any other access to the histograms\npointer, in case cb_calloc() fails.\n\nTSAN failure:\n    WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock) (pid\u003d11208)\n    Cycle in lock order graph: M296533874179548048 (0x000000000000) \u003d\u003e M174936684240544688 (0x000000000000) \u003d\u003e M296533874179548048\n\n    Mutex M174936684240544688 acquired here while holding mutex M296533874179548048 in main thread:\n    #0 AnnotateRWLockAcquired \u003cnull\u003e (libtsan.so.0+0x00000005b63d)\n    #1 folly::detail::annotate_rwlock_acquired_impl(void const volatile*, folly::annotate_rwlock_level, char const*, int) /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/synchronization/SanitizeThread.cpp:99 (ep-engine_ep_unit_tests+0x00000139555e)\n    #2 annotate_rwlock_acquired tlm/deps/folly.exploded/include/folly/synchronization/SanitizeThread.h:111 (ep-engine_ep_unit_tests+0x000001362a06)\n    #3 folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e::annotateAcquired(folly::annotate_rwlock_level) tlm/deps/folly.exploded/include/folly/SharedMutex.h:726 (ep-engine_ep_unit_tests+0x000001362a06)\n    #4 folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e::lock_shared() tlm/deps/folly.exploded/include/folly/SharedMutex.h:400 (ep-engine_ep_unit_tests+0x000001362a06)\n    #5 folly::detail::LockTraitsImpl\u003cfolly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e, (folly::detail::MutexLevel)1, false\u003e::lock_shared(folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e\u0026) tlm/deps/folly.exploded/include/folly/LockTraits.h:157 (ep-engine_ep_unit_tests+0x000001362a06)\n    #6 std::integral_constant\u003cbool, true\u003e folly::LockPolicyShared::lock\u003cfolly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e(folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e\u0026) tlm/deps/folly.exploded/include/folly/LockTraits.h:499 (ep-engine_ep_unit_tests+0x000001362a06)\n    #7 folly::LockedPtrBase\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e, folly::LockPolicyShared\u003e::LockedPtrBase(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const*) tlm/deps/folly.exploded/include/folly/Synchronized.h:1089 (ep-engine_ep_unit_tests+0x000001362a06)\n    #8 folly::LockedPtr\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const, folly::LockPolicyShared\u003e::LockedPtr(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const*) tlm/deps/folly.exploded/include/folly/Synchronized.h:1394 (ep-engine_ep_unit_tests+0x000001360063)\n    #9 folly::SynchronizedBase\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e, (folly::detail::MutexLevel)1\u003e::rlock() tlm/deps/folly.exploded/include/folly/Synchronized.h:140 (ep-engine_ep_unit_tests+0x000001360063)\n    #10 HdrHistogram::operator+\u003d(HdrHistogram const\u0026) ../kv_engine/utilities/hdrhistogram.cc:83 (ep-engine_ep_unit_tests+0x000001360063)\n    #11 HdrHistogramTest_aggregationTest_Test::TestBody() ../kv_engine/engines/ep/tests/module_tests/hdrhistogram_test.cc:317 (ep-engine_ep_unit_tests+0x00000106945c)\n    #12 void testing::internal::HandleSehExceptionsInMethodIfSupported\u003ctesting::Test, void\u003e(testing::Test*, void (testing::Test::*)(), char const*) ../googletest/googletest/src/gtest.cc:2402 (ep-engine_ep_unit_tests+0x0000013276cb)\n    #13 void testing::internal::HandleExceptionsInMethodIfSupported\u003ctesting::Test, void\u003e(testing::Test*, void (testing::Test::*)(), char const*) ../googletest/googletest/src/gtest.cc:2438 (ep-engine_ep_unit_tests+0x00000132e814)\n    #14 testing::Test::Run() ../googletest/googletest/src/gtest.cc:2474 (ep-engine_ep_unit_tests+0x00000131d649)\n    #15 testing::TestInfo::Run() ../googletest/googletest/src/gtest.cc:2656 (ep-engine_ep_unit_tests+0x00000131d91d)\n    #16 testing::TestCase::Run() ../googletest/googletest/src/gtest.cc:2774 (ep-engine_ep_unit_tests+0x00000131dac5)\n    #17 testing::internal::UnitTestImpl::RunAllTests() ../googletest/googletest/src/gtest.cc:4649 (ep-engine_ep_unit_tests+0x00000131fe3e)\n    #18 bool testing::internal::HandleSehExceptionsInMethodIfSupported\u003ctesting::internal::UnitTestImpl, bool\u003e(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) ../googletest/googletest/src/gtest.cc:2402 (ep-engine_ep_unit_tests+0x000001327972)\n    #19 bool testing::internal::HandleExceptionsInMethodIfSupported\u003ctesting::internal::UnitTestImpl, bool\u003e(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) ../googletest/googletest/src/gtest.cc:2438 (ep-engine_ep_unit_tests+0x00000132edc8)\n    #20 testing::UnitTest::Run() ../googletest/googletest/src/gtest.cc:4257 (ep-engine_ep_unit_tests+0x00000131d741)\n    #21 RUN_ALL_TESTS() ../googletest/googletest/include/gtest/gtest.h:2237 (ep-engine_ep_unit_tests+0x000000d30e6a)\n    #22 main ../kv_engine/engines/ep/tests/module_tests/ep_unit_tests_main.cc:144 (ep-engine_ep_unit_tests+0x000000d30e6a)\n\nChange-Id: I7f7448627d20c753add8c92eaf1186fb350aaab0\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"3b525cb99251f4086d08080c06f70645da33c032","is_merged_in_target_branch":true,"change_id":"Iabfc0efdc576a354a017f89c2d90a1466d549b44","change_number":137424,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"},"fb7e114fddc3fa9a86a53f36770c991bd1b79c4b":{"kind":"REWORK","_number":11,"created":"2020-10-07 13:36:52.000000000","uploader":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/48/137548/11","fetch":{"anonymous http":{"url":"https://review.couchbase.org/kv_engine","ref":"refs/changes/48/137548/11","commands":{"Branch":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/11 \u0026\u0026 git checkout -b change-137548 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/11 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/11 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/11 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/kv_engine refs/changes/48/137548/11","Reset To":"git fetch https://review.couchbase.org/kv_engine refs/changes/48/137548/11 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a075036eb3a7d28411d6fff0e335e3d75548e45c","subject":"MB-41658: Expand error message when non-dirty item found during persistence"}],"author":{"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","date":"2020-10-06 11:15:24.000000000","tz":60},"committer":{"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","date":"2020-10-07 13:36:52.000000000","tz":0},"subject":"MB-41510: Fix TSAN failure due to lock order inversion","message":"MB-41510: Fix TSAN failure due to lock order inversion\n\nFix a TSAN failure due to a lock order inversion observed on the\nmad-hatter TSAN cv machine. This was due to a potential deadlock while\nacquiring locks on this and other histogram in\nHdrHistogram::operator+\u003d(). To fix this use folly::acquireLocked() to\nsafely take write lock and read lock on this-\u003ehistogram and\nother.histogram respectively. We also remove the nullptr for\nthis-\u003ehistogram as we don\u0027t guard any other access to the histograms\npointer, in case cb_calloc() fails.\n\nTSAN failure:\n    WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock) (pid\u003d11208)\n    Cycle in lock order graph: M296533874179548048 (0x000000000000) \u003d\u003e M174936684240544688 (0x000000000000) \u003d\u003e M296533874179548048\n\n    Mutex M174936684240544688 acquired here while holding mutex M296533874179548048 in main thread:\n    #0 AnnotateRWLockAcquired \u003cnull\u003e (libtsan.so.0+0x00000005b63d)\n    #1 folly::detail::annotate_rwlock_acquired_impl(void const volatile*, folly::annotate_rwlock_level, char const*, int) /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/synchronization/SanitizeThread.cpp:99 (ep-engine_ep_unit_tests+0x00000139555e)\n    #2 annotate_rwlock_acquired tlm/deps/folly.exploded/include/folly/synchronization/SanitizeThread.h:111 (ep-engine_ep_unit_tests+0x000001362a06)\n    #3 folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e::annotateAcquired(folly::annotate_rwlock_level) tlm/deps/folly.exploded/include/folly/SharedMutex.h:726 (ep-engine_ep_unit_tests+0x000001362a06)\n    #4 folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e::lock_shared() tlm/deps/folly.exploded/include/folly/SharedMutex.h:400 (ep-engine_ep_unit_tests+0x000001362a06)\n    #5 folly::detail::LockTraitsImpl\u003cfolly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e, (folly::detail::MutexLevel)1, false\u003e::lock_shared(folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e\u0026) tlm/deps/folly.exploded/include/folly/LockTraits.h:157 (ep-engine_ep_unit_tests+0x000001362a06)\n    #6 std::integral_constant\u003cbool, true\u003e folly::LockPolicyShared::lock\u003cfolly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e(folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e\u0026) tlm/deps/folly.exploded/include/folly/LockTraits.h:499 (ep-engine_ep_unit_tests+0x000001362a06)\n    #7 folly::LockedPtrBase\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e, folly::LockPolicyShared\u003e::LockedPtrBase(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const*) tlm/deps/folly.exploded/include/folly/Synchronized.h:1089 (ep-engine_ep_unit_tests+0x000001362a06)\n    #8 folly::LockedPtr\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const, folly::LockPolicyShared\u003e::LockedPtr(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const*) tlm/deps/folly.exploded/include/folly/Synchronized.h:1394 (ep-engine_ep_unit_tests+0x000001360063)\n    #9 folly::SynchronizedBase\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e, (folly::detail::MutexLevel)1\u003e::rlock() tlm/deps/folly.exploded/include/folly/Synchronized.h:140 (ep-engine_ep_unit_tests+0x000001360063)\n    #10 HdrHistogram::operator+\u003d(HdrHistogram const\u0026) ../kv_engine/utilities/hdrhistogram.cc:83 (ep-engine_ep_unit_tests+0x000001360063)\n    #11 HdrHistogramTest_aggregationTest_Test::TestBody() ../kv_engine/engines/ep/tests/module_tests/hdrhistogram_test.cc:317 (ep-engine_ep_unit_tests+0x00000106945c)\n    #12 void testing::internal::HandleSehExceptionsInMethodIfSupported\u003ctesting::Test, void\u003e(testing::Test*, void (testing::Test::*)(), char const*) ../googletest/googletest/src/gtest.cc:2402 (ep-engine_ep_unit_tests+0x0000013276cb)\n    #13 void testing::internal::HandleExceptionsInMethodIfSupported\u003ctesting::Test, void\u003e(testing::Test*, void (testing::Test::*)(), char const*) ../googletest/googletest/src/gtest.cc:2438 (ep-engine_ep_unit_tests+0x00000132e814)\n    #14 testing::Test::Run() ../googletest/googletest/src/gtest.cc:2474 (ep-engine_ep_unit_tests+0x00000131d649)\n    #15 testing::TestInfo::Run() ../googletest/googletest/src/gtest.cc:2656 (ep-engine_ep_unit_tests+0x00000131d91d)\n    #16 testing::TestCase::Run() ../googletest/googletest/src/gtest.cc:2774 (ep-engine_ep_unit_tests+0x00000131dac5)\n    #17 testing::internal::UnitTestImpl::RunAllTests() ../googletest/googletest/src/gtest.cc:4649 (ep-engine_ep_unit_tests+0x00000131fe3e)\n    #18 bool testing::internal::HandleSehExceptionsInMethodIfSupported\u003ctesting::internal::UnitTestImpl, bool\u003e(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) ../googletest/googletest/src/gtest.cc:2402 (ep-engine_ep_unit_tests+0x000001327972)\n    #19 bool testing::internal::HandleExceptionsInMethodIfSupported\u003ctesting::internal::UnitTestImpl, bool\u003e(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) ../googletest/googletest/src/gtest.cc:2438 (ep-engine_ep_unit_tests+0x00000132edc8)\n    #20 testing::UnitTest::Run() ../googletest/googletest/src/gtest.cc:4257 (ep-engine_ep_unit_tests+0x00000131d741)\n    #21 RUN_ALL_TESTS() ../googletest/googletest/include/gtest/gtest.h:2237 (ep-engine_ep_unit_tests+0x000000d30e6a)\n    #22 main ../kv_engine/engines/ep/tests/module_tests/ep_unit_tests_main.cc:144 (ep-engine_ep_unit_tests+0x000000d30e6a)\n\nChange-Id: I7f7448627d20c753add8c92eaf1186fb350aaab0\nReviewed-on: http://review.couchbase.org/c/kv_engine/+/137548\nReviewed-by: Dave Rigby \u003cdaver@couchbase.com\u003e\nTested-by: Build Bot \u003cbuild@couchbase.com\u003e\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"a075036eb3a7d28411d6fff0e335e3d75548e45c","is_merged_in_target_branch":true,"change_id":"Ifa581ef552a12c652cf9756a591e19cce3c18a73","change_number":137355,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}},{"label":"Well-Formed","status":"MAY"}]},{"status":"CLOSED"}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Custom-Rule","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Custom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["Custom-Rule"],"failing_atoms":[]}}]}