)]}'
{"engines/ep/tests/module_tests/hdrhistogram_test.cc":[{"author":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"8756b0b360ac8cc88ebb4726348484e52e47ae19","unresolved":true,"context_lines":[{"line_number":317,"context_line":"    // Do aggregation"},{"line_number":318,"context_line":"    histogramOne +\u003d histogramTwo;"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"    std::array\u003cstd::optional\u003cstd::pair\u003cuint64_t, uint64_t\u003e\u003e, numberOfValues\u003e"},{"line_number":321,"context_line":"            histoOneValues;"},{"line_number":322,"context_line":"    { // iterOne read lock scope"},{"line_number":323,"context_line":"        auto iterOne \u003d"}],"source_content_type":"text/x-c","patch_set":1,"id":"d0e2e35c_aba10a0f","line":320,"updated":"2020-10-08 11:17:45.000000000","message":"Not sure you want the array to be of optionals - surely every element you record should be present?","commit_id":"90d3895382aaead22e04e6de0c387f0a2b483e2e"},{"author":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"8756b0b360ac8cc88ebb4726348484e52e47ae19","unresolved":true,"context_lines":[{"line_number":325,"context_line":"        for (int i \u003d 0; i \u003c numberOfValues; i++) {"},{"line_number":326,"context_line":"            histoOneValues[i] \u003d iterOne.getNextValueAndCount();"},{"line_number":327,"context_line":"        }"},{"line_number":328,"context_line":"    }"},{"line_number":329,"context_line":"    { // iterTwo read lock scope"},{"line_number":330,"context_line":"        auto iterTwo \u003d"},{"line_number":331,"context_line":"                histogramTwo.makeLinearIterator(/* valueUnitsPerBucket */ 1);"}],"source_content_type":"text/x-c","patch_set":1,"id":"40ad5938_e00bae2b","line":328,"updated":"2020-10-08 11:17:45.000000000","message":"Given you do the same thing at line 364, suggest creating a helper function which returns a vector of values from a histogram via a linear iterator.","commit_id":"90d3895382aaead22e04e6de0c387f0a2b483e2e"},{"author":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"8756b0b360ac8cc88ebb4726348484e52e47ae19","unresolved":true,"context_lines":[{"line_number":328,"context_line":"    }"},{"line_number":329,"context_line":"    { // iterTwo read lock scope"},{"line_number":330,"context_line":"        auto iterTwo \u003d"},{"line_number":331,"context_line":"                histogramTwo.makeLinearIterator(/* valueUnitsPerBucket */ 1);"},{"line_number":332,"context_line":"        uint64_t valueCount \u003d 0;"},{"line_number":333,"context_line":"        for (int i \u003d 0; i \u003c numberOfValues; i++) {"},{"line_number":334,"context_line":"            auto resultTwo \u003d iterTwo.getNextValueAndCount();"}],"source_content_type":"text/x-c","patch_set":1,"id":"29ef0b0d_6021cafd","line":331,"updated":"2020-10-08 11:17:45.000000000","message":"SImilary here, you could re-use the same helper function for histogram2, then just perform a simple comparison on the two std::vectors.","commit_id":"90d3895382aaead22e04e6de0c387f0a2b483e2e"},{"author":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c41b435738e26e1625877b022f78980170aab886","unresolved":true,"context_lines":[{"line_number":87,"context_line":"    }"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    uint64_t valueCount \u003d 0;"},{"line_number":90,"context_line":"    auto values \u003d getValuesOnePerBucket(histogram);"},{"line_number":91,"context_line":"    for (auto\u0026 result : values) {"},{"line_number":92,"context_line":"        EXPECT_EQ(valueCount++, result.first);"},{"line_number":93,"context_line":"    }"}],"source_content_type":"text/x-c","patch_set":2,"id":"3ab0c110_04543fb6","line":90,"updated":"2020-10-08 12:51:06.000000000","message":"Probably should check `values.size()` is as expected.","commit_id":"7bdc5b330aa4bcb610d9dfeab1cc74645c76d948"},{"author":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"1fcead0da620021d0b2e3c1f44d0200524a763b4","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    }"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    uint64_t valueCount \u003d 0;"},{"line_number":90,"context_line":"    auto values \u003d getValuesOnePerBucket(histogram);"},{"line_number":91,"context_line":"    for (auto\u0026 result : values) {"},{"line_number":92,"context_line":"        EXPECT_EQ(valueCount++, result.first);"},{"line_number":93,"context_line":"    }"}],"source_content_type":"text/x-c","patch_set":2,"id":"811338b4_0ec2ca3b","line":90,"in_reply_to":"3ab0c110_04543fb6","updated":"2020-10-08 13:16:26.000000000","message":"Done","commit_id":"7bdc5b330aa4bcb610d9dfeab1cc74645c76d948"},{"author":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c41b435738e26e1625877b022f78980170aab886","unresolved":true,"context_lines":[{"line_number":366,"context_line":"    EXPECT_EQ(histoTwoValues, histoOneValues);"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    // Check the totals of each histogram"},{"line_number":369,"context_line":"    EXPECT_EQ(numberOfValues, histogramOne.getValueCount());"},{"line_number":370,"context_line":"    EXPECT_EQ(numberOfValues, histogramTwo.getValueCount());"},{"line_number":371,"context_line":"}"},{"line_number":372,"context_line":""}],"source_content_type":"text/x-c","patch_set":2,"id":"04f33b6e_62a08f88","line":369,"updated":"2020-10-08 12:51:06.000000000","message":"These checks are arguably redundant given you already check the counts of the extracted vector above.","commit_id":"7bdc5b330aa4bcb610d9dfeab1cc74645c76d948"},{"author":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"1fcead0da620021d0b2e3c1f44d0200524a763b4","unresolved":true,"context_lines":[{"line_number":366,"context_line":"    EXPECT_EQ(histoTwoValues, histoOneValues);"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    // Check the totals of each histogram"},{"line_number":369,"context_line":"    EXPECT_EQ(numberOfValues, histogramOne.getValueCount());"},{"line_number":370,"context_line":"    EXPECT_EQ(numberOfValues, histogramTwo.getValueCount());"},{"line_number":371,"context_line":"}"},{"line_number":372,"context_line":""}],"source_content_type":"text/x-c","patch_set":2,"id":"ad79c064_2fcf7077","line":369,"in_reply_to":"04f33b6e_62a08f88","updated":"2020-10-08 13:16:26.000000000","message":"This isn\u0027t really redundant as their checking two different things (though the end effect might be the same). getValueCount() tracks how many counts have been added, where as histoOneValues.size() tells us how many buckets where returned with a width of 1.","commit_id":"7bdc5b330aa4bcb610d9dfeab1cc74645c76d948"},{"author":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"60efbbfb8d8787221e1d06beb24d58340c632f27","unresolved":false,"context_lines":[{"line_number":366,"context_line":"    EXPECT_EQ(histoTwoValues, histoOneValues);"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    // Check the totals of each histogram"},{"line_number":369,"context_line":"    EXPECT_EQ(numberOfValues, histogramOne.getValueCount());"},{"line_number":370,"context_line":"    EXPECT_EQ(numberOfValues, histogramTwo.getValueCount());"},{"line_number":371,"context_line":"}"},{"line_number":372,"context_line":""}],"source_content_type":"text/x-c","patch_set":2,"id":"2c85ee23_9597ee25","line":369,"in_reply_to":"ad79c064_2fcf7077","updated":"2020-10-08 13:36:13.000000000","message":"Ack","commit_id":"7bdc5b330aa4bcb610d9dfeab1cc74645c76d948"}]}