)]}'
{"id":"kv_engine~137745","triplet_id":"kv_engine~master~I7c3e9369065e5344333c410602267835f9bcc7e1","project":"kv_engine","branch":"master","hashtags":[],"change_id":"I7c3e9369065e5344333c410602267835f9bcc7e1","subject":"MB-41510: Fix TSAN failure due to lock order inversion","status":"MERGED","created":"2020-10-08 10:57:29.000000000","updated":"2020-10-08 16:24:57.000000000","submitted":"2020-10-08 15:06:46.000000000","submitter":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"total_comment_count":8,"unresolved_comment_count":3,"has_review_started":true,"submission_id":"137745-1602169606321-b5f02a79","meta_rev_id":"13d38d3f89966c8cd3dc93d3103da869fb72d505","_number":137745,"virtual_id_number":137745,"owner":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2020-10-08 15:06:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"all":[{"value":0,"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2020-10-08 15:06:46.000000000","_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]}],"values":{"-2":"Do not submit","-1":"I would prefer that you didn\u0027t submit this"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Well-Formed":{"all":[{"value":0,"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]}],"values":{"-1":"Commit is not well-formed"," 0":"Well-formedness not checked","+1":"Commit is well-formed"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":1000002,"name":"Trond Norbye","display_name":"Trond","email":"trond.norbye@couchbase.com","username":"trond","avatars":[{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1004341,"name":"Ben Huddleston","email":"ben.huddleston@couchbase.com","username":"BenHuddleston","avatars":[{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1003828,"name":"James H","email":"james.harrison@couchbase.com","username":"jameseh96","avatars":[{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1001547,"name":"Dan Owen","email":"owend@couchbase.com","username":"owend","avatars":[{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1004059,"name":"Paolo Cocchi","email":"paolo.cocchi@couchbase.com","username":"paolococchi","avatars":[{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1001546,"name":"Jim Walker","email":"jim@couchbase.com","username":"jim","avatars":[{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1002319,"name":"Dave Finlay","email":"dave.finlay@couchbase.com","username":"dave-finlay","avatars":[{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"Trond Norbye","display_name":"Trond","email":"trond.norbye@couchbase.com","username":"trond","avatars":[{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1001546,"name":"Jim Walker","email":"jim@couchbase.com","username":"jim","avatars":[{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1001547,"name":"Dan Owen","email":"owend@couchbase.com","username":"owend","avatars":[{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1002319,"name":"Dave Finlay","email":"dave.finlay@couchbase.com","username":"dave-finlay","avatars":[{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1003828,"name":"James H","email":"james.harrison@couchbase.com","username":"jameseh96","avatars":[{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1004059,"name":"Paolo Cocchi","email":"paolo.cocchi@couchbase.com","username":"paolococchi","avatars":[{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1004341,"name":"Ben Huddleston","email":"ben.huddleston@couchbase.com","username":"BenHuddleston","avatars":[{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-10-08 10:57:51.000000000","updated_by":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":1002319,"name":"Dave Finlay","email":"dave.finlay@couchbase.com","username":"dave-finlay","avatars":[{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2020-10-08 10:57:51.000000000","updated_by":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":1001546,"name":"Jim Walker","email":"jim@couchbase.com","username":"jim","avatars":[{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2020-10-08 10:57:51.000000000","updated_by":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":1004059,"name":"Paolo Cocchi","email":"paolo.cocchi@couchbase.com","username":"paolococchi","avatars":[{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2020-10-08 10:57:51.000000000","updated_by":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":1001547,"name":"Dan Owen","email":"owend@couchbase.com","username":"owend","avatars":[{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2020-10-08 10:57:51.000000000","updated_by":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":1003828,"name":"James H","email":"james.harrison@couchbase.com","username":"jameseh96","avatars":[{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2020-10-08 10:57:51.000000000","updated_by":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":1004341,"name":"Ben Huddleston","email":"ben.huddleston@couchbase.com","username":"BenHuddleston","avatars":[{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2020-10-08 10:57:51.000000000","updated_by":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2020-10-08 10:57:51.000000000","updated_by":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":1000002,"name":"Trond Norbye","display_name":"Trond","email":"trond.norbye@couchbase.com","username":"trond","avatars":[{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2020-10-08 11:47:47.000000000","updated_by":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"fa16475828cfa4bddb0697f1b0fad274b02e7d50","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-08 10:57:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"106178b103da5979104db4368a4ccf876e74aa05","author":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-08 11:06:38.000000000","message":"Patch Set 1: Code-Review-1\n\nThis isn\u0027t actually an issue on master IIRC (you only saw it on mad-hatter with GCC-7.3) ?","accounts_in_message":[],"_revision_number":1},{"id":"4c4a11b0833a1fac3eab95d0eb59fe4af9b45157","author":{"_account_id":1001546,"name":"Jim Walker","email":"jim@couchbase.com","username":"jim","avatars":[{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-08 11:12:22.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1: Code-Review-1\n\u003e \n\u003e This isn\u0027t actually an issue on master IIRC (you only saw it on mad-hatter with GCC-7.3) ?\n\nseen on master now - e.g. http://cv.jenkins.couchbase.com/job/kv_engine.threadsanitizer/job/master/6484/consoleFull#61701595461882284-c5b1-40af-8076-4f8cb2d12fb1","accounts_in_message":[],"_revision_number":1},{"id":"91717969f4a596680324d1ccb69140443dbfeff2","author":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-08 11:13:57.000000000","message":"Patch Set 1: -Code-Review\n\n\u003e Patch Set 1:\n\u003e \n\u003e \u003e Patch Set 1: Code-Review-1\n\u003e \u003e \n\u003e \u003e This isn\u0027t actually an issue on master IIRC (you only saw it on mad-hatter with GCC-7.3) ?\n\u003e \n\u003e seen on master now - e.g. http://cv.jenkins.couchbase.com/job/kv_engine.threadsanitizer/job/master/6484/consoleFull#61701595461882284-c5b1-40af-8076-4f8cb2d12fb1\n\nAh ok.","accounts_in_message":[],"_revision_number":1},{"id":"8756b0b360ac8cc88ebb4726348484e52e47ae19","author":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-08 11:17:45.000000000","message":"Patch Set 1: Code-Review-1\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"3c810f2464a535cd7c221f078dcbf03b22166078","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2020-10-08 11:47:47.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-windows-master/31002/ : FAILURE\n\nLink error: fatal error LNK1168: cannot open phosphor\\phosphor.dll for writing ( http://cv.jenkins.couchbase.com/job/kv_engine-windows-master/31002/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux-CE/job/master/6268/ : FAILURE\n\nFailure of an engine_testapp test:\n\n\u003cpre\u003e\nRunning [0043/0099]: test dcp stream takeover...../kv_engine/engines/ep/tests/ep_testsuite_dcp.cc:639 Test failed: `\" (Expected `2\", got `3\" - Unexpected number of snapshot markers)\n[2020-10-08T11:15:13.918Z] (6043 ms) FAIL\n\u003c/pre\u003e\n ( http://cv.jenkins.couchbase.com/job/kv_engine.linux-CE/job/master/6268/ )\n\nFailure of a CTest test [2020-10-08T11:15:13.917Z]   1/397 Test #255: ep_testsuite_dcp.full_eviction.comp_active ..................................................................Child aborted ( http://cv.jenkins.couchbase.com/job/kv_engine.linux-CE/job/master/6268/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/14167/ : FAILURE\n\nFailure of GoogleTest \"AllBackends/DurabilityEPBucketTest.PersistPrepareDelete/persistentRocksdb_value_only\":\n\n\u003cpre\u003e\n[ RUN      ] AllBackends/DurabilityEPBucketTest.PersistPrepareDelete/persistentRocksdb_value_only\n[2020-10-08T11:33:21.630Z] ../kv_engine/engines/ep/tests/module_tests/evp_store_durability_test.cc:474: Failure\n[2020-10-08T11:33:21.630Z] Expected equality of these values:\n[2020-10-08T11:33:21.630Z]   1\n[2020-10-08T11:33:21.630Z]   ckptList.size()\n[2020-10-08T11:33:21.630Z]     Which is: 2\n[2020-10-08T11:33:21.630Z] [  FAILED  ] AllBackends/DurabilityEPBucketTest.PersistPrepareDelete/persistentRocksdb_value_only, where GetParam() \u003d (\"persistentRocksdb\", \"value_only\") (11411 ms)\nAllBackends/DurabilityEPBucketTest.PersistPrepareDelete/persistentRocksdb_value_only\n\u003c/pre\u003e\n ( http://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/14167/ )\n\nTimeout of a CTest test [2020-10-08T11:34:15.646Z]  26/393 Test #199: ep-engine_ep_unit_tests.FullOrValue/DurabilityWarmupTest ....................................................} ( http://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/14167/ )\n\nFailure of a CTest test [2020-10-08T11:33:21.630Z]  17/393 Test #181: ep-engine_ep_unit_tests.AllBackends/DurabilityEPBucketTest .................................................. ( http://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/14167/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_format_9/3491/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_tidy/4963/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_analyzer-master/26761/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.macos/job/master/5343/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.threadsanitizer/job/master/6499/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux/job/master/6387/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"6e644fac40a26c3da0e69c74ff6a0434038643ad","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-08 12:44:47.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"c41b435738e26e1625877b022f78980170aab886","author":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-08 12:51:06.000000000","message":"Patch Set 2: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"1fcead0da620021d0b2e3c1f44d0200524a763b4","author":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-08 13:16:26.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"34fbd10760c391f56446afefea72864ae981670a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-08 13:16:44.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"caeb0a543658d835439d9cef283b6e7672c79ab0","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2020-10-08 13:16:48.000000000","message":"Patch Set 2: Verified-1\n\nBuild Failed \n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.threadsanitizer/job/master/6505/ : ABORTED\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.macos/job/master/5346/ : FAILURE\n\nFailure of a CTest test [2020-10-08T12:53:27.644Z] 187/407 Test #344: memcached_testapp.default.TransportProtocols/TouchTest ......................................................Child aborted ( http://cv.jenkins.couchbase.com/job/kv_engine.macos/job/master/5346/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_format_9/3494/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_tidy/4966/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_analyzer-master/26764/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux-CE/job/master/6271/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux/job/master/6390/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/14170/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-windows-master/31006/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"b389f0244fb5189c9dbc301550a0bc78841d4256","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-08 13:34:42.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"db25d8c48a027fd4a6e1cee37a8a9a9a0149a8af","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2020-10-08 13:34:58.000000000","message":"Patch Set 3: Verified-1\n\nBuild Failed \n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-windows-master/31009/ : ABORTED\n\nBuild which was aborted due to a newer patch set being uploaded for the given review. ( http://cv.jenkins.couchbase.com/job/kv_engine-windows-master/31009/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.threadsanitizer/job/master/6507/ : ABORTED\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.macos/job/master/5348/ : FAILURE\n\nFailure of GoogleTest \"HdrHistogramTest.addValueParallel\":\n\n\u003cpre\u003e\n[ RUN      ] HdrHistogramTest.addValueParallel\n[2020-10-08T13:27:56.685Z] ../kv_engine/engines/ep/tests/module_tests/hdrhistogram_test.cc:298: Failure\n[2020-10-08T13:27:56.685Z] Expected equality of these values:\n[2020-10-08T13:27:56.685Z]   numOfAddIterations\n[2020-10-08T13:27:56.685Z]     Which is: 5000\n[2020-10-08T13:27:56.685Z]   values.size()\n[2020-10-08T13:27:56.685Z]     Which is: 2\n[2020-10-08T13:27:56.685Z] [  FAILED  ] HdrHistogramTest.addValueParallel (5 ms)\nHdrHistogramTest.addValueParallel\n\u003c/pre\u003e\n ( http://cv.jenkins.couchbase.com/job/kv_engine.macos/job/master/5348/ )\n\nFailure of a CTest test [2020-10-08T13:27:56.685Z] 198/407 Test  #86: ep-engine_ep_unit_tests.HdrHistogramTest .................................................................... ( http://cv.jenkins.couchbase.com/job/kv_engine.macos/job/master/5348/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux/job/master/6392/ : FAILURE\n\nFailure of GoogleTest \"HdrHistogramTest.addValueParallel\":\n\n\u003cpre\u003e\n[ RUN      ] HdrHistogramTest.addValueParallel\n[2020-10-08T13:24:50.319Z] ../kv_engine/engines/ep/tests/module_tests/hdrhistogram_test.cc:298: Failure\n[2020-10-08T13:24:50.319Z] Expected equality of these values:\n[2020-10-08T13:24:50.319Z]   numOfAddIterations\n[2020-10-08T13:24:50.319Z]     Which is: 5000\n[2020-10-08T13:24:50.319Z]   values.size()\n[2020-10-08T13:24:50.319Z]     Which is: 2\n[2020-10-08T13:24:50.319Z] [  FAILED  ] HdrHistogramTest.addValueParallel (2 ms)\nHdrHistogramTest.addValueParallel\n\u003c/pre\u003e\n ( http://cv.jenkins.couchbase.com/job/kv_engine.linux/job/master/6392/ )\n\nFailure of a CTest test [2020-10-08T13:24:50.319Z] 250/410 Test  #89: ep-engine_ep_unit_tests.HdrHistogramTest .................................................................... ( http://cv.jenkins.couchbase.com/job/kv_engine.linux/job/master/6392/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux-CE/job/master/6273/ : FAILURE\n\nFailure of GoogleTest \"HdrHistogramTest.addValueParallel\":\n\n\u003cpre\u003e\n[ RUN      ] HdrHistogramTest.addValueParallel\n[2020-10-08T13:26:34.970Z] ../kv_engine/engines/ep/tests/module_tests/hdrhistogram_test.cc:298: Failure\n[2020-10-08T13:26:34.970Z] Expected equality of these values:\n[2020-10-08T13:26:34.970Z]   numOfAddIterations\n[2020-10-08T13:26:34.970Z]     Which is: 5000\n[2020-10-08T13:26:34.970Z]   values.size()\n[2020-10-08T13:26:34.970Z]     Which is: 2\n[2020-10-08T13:26:34.970Z] [  FAILED  ] HdrHistogramTest.addValueParallel (17 ms)\nHdrHistogramTest.addValueParallel\n\u003c/pre\u003e\n ( http://cv.jenkins.couchbase.com/job/kv_engine.linux-CE/job/master/6273/ )\n\nFailure of a CTest test [2020-10-08T13:26:34.970Z] 245/397 Test  #89: ep-engine_ep_unit_tests.HdrHistogramTest .................................................................... ( http://cv.jenkins.couchbase.com/job/kv_engine.linux-CE/job/master/6273/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/14173/ : FAILURE\n\nFailure of GoogleTest \"HdrHistogramTest.addValueParallel\":\n\n\u003cpre\u003e\n[ RUN      ] HdrHistogramTest.addValueParallel\n[2020-10-08T13:33:35.275Z] ../kv_engine/engines/ep/tests/module_tests/hdrhistogram_test.cc:298: Failure\n[2020-10-08T13:33:35.275Z] Expected equality of these values:\n[2020-10-08T13:33:35.275Z]   numOfAddIterations\n[2020-10-08T13:33:35.275Z]     Which is: 5000\n[2020-10-08T13:33:35.275Z]   values.size()\n[2020-10-08T13:33:35.275Z]     Which is: 2\n[2020-10-08T13:33:35.275Z] [  FAILED  ] HdrHistogramTest.addValueParallel (9 ms)\nHdrHistogramTest.addValueParallel\n\u003c/pre\u003e\n ( http://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/14173/ )\n\nUndefined Sanitizer: log...../kv_engine/engines/ep/src/vb_count_visitor.h:97:42: runtime error: 1.84467e+21 is outside the range of representable values of type \"unsigned long\" ( http://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/14173/ )\n\nFailure of a CTest test [2020-10-08T13:31:14.240Z]   8/393 Test #246: ep_testsuite_dcp.value_eviction.comp_passive ................................................................Child aborted ( http://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/14173/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_format_9/3496/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_tidy/4968/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_analyzer-master/26766/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"60efbbfb8d8787221e1d06beb24d58340c632f27","author":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-08 13:36:13.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"5604302dd2d053b03119dba9f154f946810cbc6b","author":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-08 13:36:45.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"2855ccb368c3aca0cbd88e426d6d2373cc87fb56","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2020-10-08 14:14:55.000000000","message":"Patch Set 4: Verified-1\n\nBuild Failed \n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.threadsanitizer/job/master/6510/ : ABORTED\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/14175/ : FAILURE\n\nFailure of an engine_testapp test:\n\n\u003cpre\u003e\nRunning [0000/0007]: checkpoint: create a new checkpoint...../kv_engine/engines/ep/tests/ep_testsuite_checkpoint.cc:41 Test failed: `\" (Expected `1\", got `2\" - Last closed checkpoint Id for VB 0 should still be 1 after storing 50 items)\n[2020-10-08T14:12:59.282Z] (31114 ms) FAIL\n\u003c/pre\u003e\n ( http://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/14175/ )\n\nFailure of GoogleTest \"AllBackends/DurabilityEPBucketTest.PersistPrepareWrite/persistentRocksdb_full_eviction\":\n\n\u003cpre\u003e\n[ RUN      ] AllBackends/DurabilityEPBucketTest.PersistPrepareWrite/persistentRocksdb_full_eviction\n[2020-10-08T14:09:26.926Z] ../kv_engine/engines/ep/tests/module_tests/evp_store_durability_test.cc:474: Failure\n[2020-10-08T14:09:26.926Z] Expected equality of these values:\n[2020-10-08T14:09:26.926Z]   1\n[2020-10-08T14:09:26.926Z]   ckptList.size()\n[2020-10-08T14:09:26.926Z]     Which is: 2\n[2020-10-08T14:09:26.926Z] [  FAILED  ] AllBackends/DurabilityEPBucketTest.PersistPrepareWrite/persistentRocksdb_full_eviction, where GetParam() \u003d (\"persistentRocksdb\", \"full_eviction\") (11554 ms)\nAllBackends/DurabilityEPBucketTest.PersistPrepareWrite/persistentRocksdb_full_eviction\n\u003c/pre\u003e\n ( http://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/14175/ )\n\nTimeout of a CTest test [2020-10-08T14:10:25.587Z]  25/393 Test #199: ep-engine_ep_unit_tests.FullOrValue/DurabilityWarmupTest ....................................................} ( http://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/14175/ )\n\nFailure of a CTest test [2020-10-08T14:09:26.926Z]  14/393 Test #181: ep-engine_ep_unit_tests.AllBackends/DurabilityEPBucketTest .................................................. ( http://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/14175/ )\n\nAddressSanitizer issue: 105 byte(s) leaked in 6 allocation(s). ( http://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/14175/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_format_9/3498/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_tidy/4970/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_analyzer-master/26768/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-windows-master/31012/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.macos/job/master/5350/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux-CE/job/master/6275/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux/job/master/6394/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"66f749427495018d5652d95b2e474650b52594bf","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2020-10-08 15:06:22.000000000","message":"Patch Set 4: Verified+1\n\nBuild Successful \n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_format_9/3498/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_tidy/4970/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_analyzer-master/26768/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-windows-master/31012/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.macos/job/master/5350/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/14179/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux-CE/job/master/6275/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux/job/master/6394/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.threadsanitizer/job/master/6515/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"e665284c3fdd2a635fe0ac8ce093b102debb3888","tag":"autogenerated:gerrit:merged","author":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2020-10-08 15:06:46.000000000","message":"Change has been successfully cherry-picked as 8ee8c85e89592fcfd54d6ae4a1dad06910047c26 by Richard de Mellow","accounts_in_message":[],"_revision_number":5},{"id":"e20c48401219f6edebb356f761e7e78a182bd128","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2020-10-08 15:06:57.000000000","message":"Patch Set 5:\n\nBuild Started http://cv.jenkins.couchbase.com/job/kv_engine-master-post-commit/5202/ (1/2)","accounts_in_message":[],"_revision_number":5},{"id":"13d38d3f89966c8cd3dc93d3103da869fb72d505","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2020-10-08 16:24:57.000000000","message":"Patch Set 5:\n\nBuild Successful \n\nhttp://cv.jenkins.couchbase.com/job/kv-engine-master-perf/3869/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-master-post-commit/5202/ : SUCCESS\u0027","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"8ee8c85e89592fcfd54d6ae4a1dad06910047c26","revisions":{"90d3895382aaead22e04e6de0c387f0a2b483e2e":{"kind":"REWORK","_number":1,"created":"2020-10-08 10:57:29.000000000","uploader":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/45/137745/1","fetch":{"anonymous http":{"url":"https://review.couchbase.org/kv_engine","ref":"refs/changes/45/137745/1","commands":{"Branch":"git fetch https://review.couchbase.org/kv_engine refs/changes/45/137745/1 \u0026\u0026 git checkout -b change-137745 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/kv_engine refs/changes/45/137745/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/kv_engine refs/changes/45/137745/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/kv_engine refs/changes/45/137745/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/kv_engine refs/changes/45/137745/1","Reset To":"git fetch https://review.couchbase.org/kv_engine refs/changes/45/137745/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4a5d9f4699d02eee908ea47694428491db677f30","subject":"Revert \"MB-41321: 2/4 Clean-up if collection exists in old and new drop containers\""}],"author":{"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","date":"2020-10-08 10:48:19.000000000","tz":60},"committer":{"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","date":"2020-10-08 10:56:46.000000000","tz":60},"subject":"MB-41510: Fix TSAN failure due to lock order inversion","message":"MB-41510: Fix TSAN failure due to lock order inversion\n\nFix TSAN failures in module_tests/hdrhistogram_test.cc, due to \ntheoretical deadlock that could occur when using two iterators that hold\nread locks on different HdrHistograms (this isn\u0027t the case now bug could\nbe if the code was modified). To avoid this WARNING, ensure in our\nHdrHistogramTests that we never hold multiple HdrHistogram::Iterators in\nthe same scope.\n\nExample TSAN Failure:\n  WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock) (pid\u003d16448)\n  Cycle in lock order graph: M732257135894671160 (0x000000000000) \u003d\u003e M730849761011117904 (0x000000000000) \u003d\u003e M732257135894671160\n\n  Mutex M730849761011117904 acquired here while holding mutex M732257135894671160 in main thread:\n    #0 AnnotateRWLockAcquired \u003cnull\u003e (ep-engine_ep_unit_tests+0x64007b)\n    #1 folly::detail::annotate_rwlock_acquired_impl(void const volatile*, folly::annotate_rwlock_level, char const*, int) /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/synchronization/SanitizeThread.cpp:99 (ep-engine_ep_unit_tests+0x162f6be)\n    #2 annotate_rwlock_acquired /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/synchronization/SanitizeThread.h:111 (ep-engine_ep_unit_tests+0x15a9881)\n    #3 folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e::annotateAcquired(folly::annotate_rwlock_level) /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/SharedMutex.h:740 (ep-engine_ep_unit_tests+0x15a9881)\n    #4 folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e::lock() /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/SharedMutex.h:372 (ep-engine_ep_unit_tests+0x15a9881)\n    #5 folly::detail::LockTraitsImpl\u003cfolly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e, (folly::detail::MutexLevel)0, false\u003e::lock(folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e\u0026) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/LockTraits.h:124:11 (ep-engine_ep_unit_tests+0x717b75)\n    #6 std::integral_constant\u003cbool, true\u003e folly::LockPolicyExclusive::lock\u003cfolly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e(folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e\u0026) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/LockTraits.h:479:5 (ep-engine_ep_unit_tests+0x717b45)\n    #7 folly::LockedPtrBase\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e, folly::LockPolicyExclusive\u003e::LockedPtrBase(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/Synchronized.h:1097:10 (ep-engine_ep_unit_tests+0x158cb02)\n    #8 folly::LockedPtr\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e, folly::LockPolicyExclusive\u003e::LockedPtr(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/Synchronized.h:1402:50 (ep-engine_ep_unit_tests+0x158caae)\n    #9 folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e::contextualLock() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/Synchronized.h:653:12 (ep-engine_ep_unit_tests+0x158ceae)\n    #10 std::tuple\u003cstd::conditional\u003cstd::is_const\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e \u003e::value, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e::ConstLockedPtr, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e::LockedPtr\u003e::type, std::conditional\u003cstd::is_const\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const\u003e::value, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const::ConstLockedPtr, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const::LockedPtr\u003e::type\u003e folly::acquireLocked\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const\u003e(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e\u0026, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const\u0026) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/Synchronized.h:1741:18 (ep-engine_ep_unit_tests+0x158ccda)\n    #11 std::pair\u003cstd::conditional\u003cstd::is_const\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e \u003e::value, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e::ConstLockedPtr, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e::LockedPtr\u003e::type, std::conditional\u003cstd::is_const\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const\u003e::value, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const::ConstLockedPtr, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const::LockedPtr\u003e::type\u003e folly::acquireLockedPair\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const\u003e(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e\u0026, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const\u0026) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/Synchronized.h:1753:21 (ep-engine_ep_unit_tests+0x158bbf9)\n    #12 HdrHistogram::operator+\u003d(HdrHistogram const\u0026) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../kv_engine/utilities/hdrhistogram.cc:67:21 (ep-engine_ep_unit_tests+0x158a3bf)\n    #13 HdrHistogramTest_aggregationTest_Test::TestBody() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../kv_engine/engines/ep/tests/module_tests/hdrhistogram_test.cc:317:18 (ep-engine_ep_unit_tests+0x13479b1)\n    #14 void testing::internal::HandleSehExceptionsInMethodIfSupported\u003ctesting::Test, void\u003e(testing::Test*, void (testing::Test::*)(), char const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2433:10 (ep-engine_ep_unit_tests+0x1567683)\n    #15 void testing::internal::HandleExceptionsInMethodIfSupported\u003ctesting::Test, void\u003e(testing::Test*, void (testing::Test::*)(), char const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2469:14 (ep-engine_ep_unit_tests+0x1553012)\n    #16 testing::Test::Run() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2508:5 (ep-engine_ep_unit_tests+0x153b87c)\n    #17 testing::TestInfo::Run() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2684:11 (ep-engine_ep_unit_tests+0x153c26a)\n    #18 testing::TestSuite::Run() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2816:28 (ep-engine_ep_unit_tests+0x153c841)\n    #19 testing::internal::UnitTestImpl::RunAllTests() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:5338:44 (ep-engine_ep_unit_tests+0x1545a21)\n    #20 bool testing::internal::HandleSehExceptionsInMethodIfSupported\u003ctesting::internal::UnitTestImpl, bool\u003e(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2433:10 (ep-engine_ep_unit_tests+0x156aa43)\n    #21 bool testing::internal::HandleExceptionsInMethodIfSupported\u003ctesting::internal::UnitTestImpl, bool\u003e(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2469:14 (ep-engine_ep_unit_tests+0x15551e2)\n    #22 testing::UnitTest::Run() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:4925:10 (ep-engine_ep_unit_tests+0x15455d7)\n    #23 RUN_ALL_TESTS() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/include/gtest/gtest.h:2473:46 (ep-engine_ep_unit_tests+0x1079927)\n    #24 main /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../kv_engine/engines/ep/tests/module_tests/ep_unit_tests_main.cc:175:16 (ep-engine_ep_unit_tests+0x107978e)\n\n    Hint: use TSAN_OPTIONS\u003dsecond_deadlock_stack\u003d1 to get more informative warning message\n\n  Mutex M732257135894671160 acquired here while holding mutex M730849761011117904 in main thread:\n    #0 AnnotateRWLockAcquired \u003cnull\u003e (ep-engine_ep_unit_tests+0x64007b)\n    #1 folly::detail::annotate_rwlock_acquired_impl(void const volatile*, folly::annotate_rwlock_level, char const*, int) /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/synchronization/SanitizeThread.cpp:99 (ep-engine_ep_unit_tests+0x162f6be)\n    #2 annotate_rwlock_acquired /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/synchronization/SanitizeThread.h:111 (ep-engine_ep_unit_tests+0x15ad433)\n    #3 folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e::annotateAcquired(folly::annotate_rwlock_level) /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/SharedMutex.h:740 (ep-engine_ep_unit_tests+0x15ad433)\n    #4 folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e::lock_shared() /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/SharedMutex.h:414 (ep-engine_ep_unit_tests+0x15ad433)\n    #5 folly::detail::LockTraitsImpl\u003cfolly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e, (folly::detail::MutexLevel)1, false\u003e::lock_shared(folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e\u0026) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/LockTraits.h:157:11 (ep-engine_ep_unit_tests+0x703215)\n    #6 std::integral_constant\u003cbool, true\u003e folly::LockPolicyShared::lock\u003cfolly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e(folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e\u0026) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/LockTraits.h:499:5 (ep-engine_ep_unit_tests+0x7031c5)\n    #7 folly::LockedPtrBase\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e, folly::LockPolicyShared\u003e::LockedPtrBase(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/Synchronized.h:1097:10 (ep-engine_ep_unit_tests+0x915242)\n    #8 folly::LockedPtr\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const, folly::LockPolicyShared\u003e::LockedPtr(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/Synchronized.h:1402:50 (ep-engine_ep_unit_tests+0x9151ee)\n    #9 folly::SynchronizedBase\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e, (folly::detail::MutexLevel)1\u003e::rlock() const /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/Synchronized.h:144:12 (ep-engine_ep_unit_tests+0x91502e)\n    #10 HdrHistogram::Iterator::Iterator(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const\u0026, HdrHistogram::Iterator::IterMode) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../kv_engine/utilities/hdrhistogram.h:89:66 (ep-engine_ep_unit_tests+0x158be71)\n    #11 HdrHistogram::makeLinearIterator(long) const /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../kv_engine/utilities/hdrhistogram.cc:162:28 (ep-engine_ep_unit_tests+0x158aafb)\n    #12 HdrHistogramTest_aggregationTest_Test::TestBody() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../kv_engine/engines/ep/tests/module_tests/hdrhistogram_test.cc:322:26 (ep-engine_ep_unit_tests+0x13479e2)\n    #13 void testing::internal::HandleSehExceptionsInMethodIfSupported\u003ctesting::Test, void\u003e(testing::Test*, void (testing::Test::*)(), char const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2433:10 (ep-engine_ep_unit_tests+0x1567683)\n    #14 void testing::internal::HandleExceptionsInMethodIfSupported\u003ctesting::Test, void\u003e(testing::Test*, void (testing::Test::*)(), char const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2469:14 (ep-engine_ep_unit_tests+0x1553012)\n    #15 testing::Test::Run() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2508:5 (ep-engine_ep_unit_tests+0x153b87c)\n    #16 testing::TestInfo::Run() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2684:11 (ep-engine_ep_unit_tests+0x153c26a)\n    #17 testing::TestSuite::Run() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2816:28 (ep-engine_ep_unit_tests+0x153c841)\n    #18 testing::internal::UnitTestImpl::RunAllTests() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:5338:44 (ep-engine_ep_unit_tests+0x1545a21)\n    #19 bool testing::internal::HandleSehExceptionsInMethodIfSupported\u003ctesting::internal::UnitTestImpl, bool\u003e(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2433:10 (ep-engine_ep_unit_tests+0x156aa43)\n    #20 bool testing::internal::HandleExceptionsInMethodIfSupported\u003ctesting::internal::UnitTestImpl, bool\u003e(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2469:14 (ep-engine_ep_unit_tests+0x15551e2)\n    #21 testing::UnitTest::Run() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:4925:10 (ep-engine_ep_unit_tests+0x15455d7)\n    #22 RUN_ALL_TESTS() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/include/gtest/gtest.h:2473:46 (ep-engine_ep_unit_tests+0x1079927)\n    #23 main /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../kv_engine/engines/ep/tests/module_tests/ep_unit_tests_main.cc:175:16 (ep-engine_ep_unit_tests+0x107978e)\n\nChange-Id: I7c3e9369065e5344333c410602267835f9bcc7e1\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"4a5d9f4699d02eee908ea47694428491db677f30","is_merged_in_target_branch":true,"change_id":"Ib709a997cee0e64ff3f66eacf4e778b26b8e0cd4","change_number":137630,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"},"7bdc5b330aa4bcb610d9dfeab1cc74645c76d948":{"kind":"REWORK","_number":2,"created":"2020-10-08 12:44:47.000000000","uploader":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/45/137745/2","fetch":{"anonymous http":{"url":"https://review.couchbase.org/kv_engine","ref":"refs/changes/45/137745/2","commands":{"Branch":"git fetch https://review.couchbase.org/kv_engine refs/changes/45/137745/2 \u0026\u0026 git checkout -b change-137745 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/kv_engine refs/changes/45/137745/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/kv_engine refs/changes/45/137745/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/kv_engine refs/changes/45/137745/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/kv_engine refs/changes/45/137745/2","Reset To":"git fetch https://review.couchbase.org/kv_engine refs/changes/45/137745/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4a5d9f4699d02eee908ea47694428491db677f30","subject":"Revert \"MB-41321: 2/4 Clean-up if collection exists in old and new drop containers\""}],"author":{"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","date":"2020-10-08 10:48:19.000000000","tz":60},"committer":{"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","date":"2020-10-08 12:37:08.000000000","tz":60},"subject":"MB-41510: Fix TSAN failure due to lock order inversion","message":"MB-41510: Fix TSAN failure due to lock order inversion\n\nFix TSAN failures in module_tests/hdrhistogram_test.cc, due to\ntheoretical deadlock that could occur when using two iterators that hold\nread locks on different HdrHistograms (this isn\u0027t the case now bug could\nbe if the code was modified). To avoid this WARNING, ensure in our\nHdrHistogramTests that we never hold multiple HdrHistogram::Iterators in\nthe same scope.\n\nExample TSAN Failure:\n  WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock) (pid\u003d16448)\n  Cycle in lock order graph: M732257135894671160 (0x000000000000) \u003d\u003e M730849761011117904 (0x000000000000) \u003d\u003e M732257135894671160\n\n  Mutex M730849761011117904 acquired here while holding mutex M732257135894671160 in main thread:\n    #0 AnnotateRWLockAcquired \u003cnull\u003e (ep-engine_ep_unit_tests+0x64007b)\n    #1 folly::detail::annotate_rwlock_acquired_impl(void const volatile*, folly::annotate_rwlock_level, char const*, int) /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/synchronization/SanitizeThread.cpp:99 (ep-engine_ep_unit_tests+0x162f6be)\n    #2 annotate_rwlock_acquired /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/synchronization/SanitizeThread.h:111 (ep-engine_ep_unit_tests+0x15a9881)\n    #3 folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e::annotateAcquired(folly::annotate_rwlock_level) /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/SharedMutex.h:740 (ep-engine_ep_unit_tests+0x15a9881)\n    #4 folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e::lock() /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/SharedMutex.h:372 (ep-engine_ep_unit_tests+0x15a9881)\n    #5 folly::detail::LockTraitsImpl\u003cfolly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e, (folly::detail::MutexLevel)0, false\u003e::lock(folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e\u0026) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/LockTraits.h:124:11 (ep-engine_ep_unit_tests+0x717b75)\n    #6 std::integral_constant\u003cbool, true\u003e folly::LockPolicyExclusive::lock\u003cfolly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e(folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e\u0026) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/LockTraits.h:479:5 (ep-engine_ep_unit_tests+0x717b45)\n    #7 folly::LockedPtrBase\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e, folly::LockPolicyExclusive\u003e::LockedPtrBase(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/Synchronized.h:1097:10 (ep-engine_ep_unit_tests+0x158cb02)\n    #8 folly::LockedPtr\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e, folly::LockPolicyExclusive\u003e::LockedPtr(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/Synchronized.h:1402:50 (ep-engine_ep_unit_tests+0x158caae)\n    #9 folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e::contextualLock() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/Synchronized.h:653:12 (ep-engine_ep_unit_tests+0x158ceae)\n    #10 std::tuple\u003cstd::conditional\u003cstd::is_const\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e \u003e::value, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e::ConstLockedPtr, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e::LockedPtr\u003e::type, std::conditional\u003cstd::is_const\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const\u003e::value, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const::ConstLockedPtr, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const::LockedPtr\u003e::type\u003e folly::acquireLocked\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const\u003e(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e\u0026, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const\u0026) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/Synchronized.h:1741:18 (ep-engine_ep_unit_tests+0x158ccda)\n    #11 std::pair\u003cstd::conditional\u003cstd::is_const\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e \u003e::value, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e::ConstLockedPtr, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e::LockedPtr\u003e::type, std::conditional\u003cstd::is_const\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const\u003e::value, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const::ConstLockedPtr, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const::LockedPtr\u003e::type\u003e folly::acquireLockedPair\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const\u003e(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e\u0026, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const\u0026) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/Synchronized.h:1753:21 (ep-engine_ep_unit_tests+0x158bbf9)\n    #12 HdrHistogram::operator+\u003d(HdrHistogram const\u0026) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../kv_engine/utilities/hdrhistogram.cc:67:21 (ep-engine_ep_unit_tests+0x158a3bf)\n    #13 HdrHistogramTest_aggregationTest_Test::TestBody() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../kv_engine/engines/ep/tests/module_tests/hdrhistogram_test.cc:317:18 (ep-engine_ep_unit_tests+0x13479b1)\n    #14 void testing::internal::HandleSehExceptionsInMethodIfSupported\u003ctesting::Test, void\u003e(testing::Test*, void (testing::Test::*)(), char const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2433:10 (ep-engine_ep_unit_tests+0x1567683)\n    #15 void testing::internal::HandleExceptionsInMethodIfSupported\u003ctesting::Test, void\u003e(testing::Test*, void (testing::Test::*)(), char const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2469:14 (ep-engine_ep_unit_tests+0x1553012)\n    #16 testing::Test::Run() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2508:5 (ep-engine_ep_unit_tests+0x153b87c)\n    #17 testing::TestInfo::Run() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2684:11 (ep-engine_ep_unit_tests+0x153c26a)\n    #18 testing::TestSuite::Run() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2816:28 (ep-engine_ep_unit_tests+0x153c841)\n    #19 testing::internal::UnitTestImpl::RunAllTests() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:5338:44 (ep-engine_ep_unit_tests+0x1545a21)\n    #20 bool testing::internal::HandleSehExceptionsInMethodIfSupported\u003ctesting::internal::UnitTestImpl, bool\u003e(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2433:10 (ep-engine_ep_unit_tests+0x156aa43)\n    #21 bool testing::internal::HandleExceptionsInMethodIfSupported\u003ctesting::internal::UnitTestImpl, bool\u003e(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2469:14 (ep-engine_ep_unit_tests+0x15551e2)\n    #22 testing::UnitTest::Run() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:4925:10 (ep-engine_ep_unit_tests+0x15455d7)\n    #23 RUN_ALL_TESTS() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/include/gtest/gtest.h:2473:46 (ep-engine_ep_unit_tests+0x1079927)\n    #24 main /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../kv_engine/engines/ep/tests/module_tests/ep_unit_tests_main.cc:175:16 (ep-engine_ep_unit_tests+0x107978e)\n\n    Hint: use TSAN_OPTIONS\u003dsecond_deadlock_stack\u003d1 to get more informative warning message\n\n  Mutex M732257135894671160 acquired here while holding mutex M730849761011117904 in main thread:\n    #0 AnnotateRWLockAcquired \u003cnull\u003e (ep-engine_ep_unit_tests+0x64007b)\n    #1 folly::detail::annotate_rwlock_acquired_impl(void const volatile*, folly::annotate_rwlock_level, char const*, int) /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/synchronization/SanitizeThread.cpp:99 (ep-engine_ep_unit_tests+0x162f6be)\n    #2 annotate_rwlock_acquired /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/synchronization/SanitizeThread.h:111 (ep-engine_ep_unit_tests+0x15ad433)\n    #3 folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e::annotateAcquired(folly::annotate_rwlock_level) /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/SharedMutex.h:740 (ep-engine_ep_unit_tests+0x15ad433)\n    #4 folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e::lock_shared() /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/SharedMutex.h:414 (ep-engine_ep_unit_tests+0x15ad433)\n    #5 folly::detail::LockTraitsImpl\u003cfolly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e, (folly::detail::MutexLevel)1, false\u003e::lock_shared(folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e\u0026) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/LockTraits.h:157:11 (ep-engine_ep_unit_tests+0x703215)\n    #6 std::integral_constant\u003cbool, true\u003e folly::LockPolicyShared::lock\u003cfolly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e(folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e\u0026) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/LockTraits.h:499:5 (ep-engine_ep_unit_tests+0x7031c5)\n    #7 folly::LockedPtrBase\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e, folly::LockPolicyShared\u003e::LockedPtrBase(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/Synchronized.h:1097:10 (ep-engine_ep_unit_tests+0x915242)\n    #8 folly::LockedPtr\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const, folly::LockPolicyShared\u003e::LockedPtr(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/Synchronized.h:1402:50 (ep-engine_ep_unit_tests+0x9151ee)\n    #9 folly::SynchronizedBase\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e, (folly::detail::MutexLevel)1\u003e::rlock() const /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/Synchronized.h:144:12 (ep-engine_ep_unit_tests+0x91502e)\n    #10 HdrHistogram::Iterator::Iterator(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const\u0026, HdrHistogram::Iterator::IterMode) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../kv_engine/utilities/hdrhistogram.h:89:66 (ep-engine_ep_unit_tests+0x158be71)\n    #11 HdrHistogram::makeLinearIterator(long) const /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../kv_engine/utilities/hdrhistogram.cc:162:28 (ep-engine_ep_unit_tests+0x158aafb)\n    #12 HdrHistogramTest_aggregationTest_Test::TestBody() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../kv_engine/engines/ep/tests/module_tests/hdrhistogram_test.cc:322:26 (ep-engine_ep_unit_tests+0x13479e2)\n    #13 void testing::internal::HandleSehExceptionsInMethodIfSupported\u003ctesting::Test, void\u003e(testing::Test*, void (testing::Test::*)(), char const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2433:10 (ep-engine_ep_unit_tests+0x1567683)\n    #14 void testing::internal::HandleExceptionsInMethodIfSupported\u003ctesting::Test, void\u003e(testing::Test*, void (testing::Test::*)(), char const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2469:14 (ep-engine_ep_unit_tests+0x1553012)\n    #15 testing::Test::Run() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2508:5 (ep-engine_ep_unit_tests+0x153b87c)\n    #16 testing::TestInfo::Run() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2684:11 (ep-engine_ep_unit_tests+0x153c26a)\n    #17 testing::TestSuite::Run() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2816:28 (ep-engine_ep_unit_tests+0x153c841)\n    #18 testing::internal::UnitTestImpl::RunAllTests() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:5338:44 (ep-engine_ep_unit_tests+0x1545a21)\n    #19 bool testing::internal::HandleSehExceptionsInMethodIfSupported\u003ctesting::internal::UnitTestImpl, bool\u003e(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2433:10 (ep-engine_ep_unit_tests+0x156aa43)\n    #20 bool testing::internal::HandleExceptionsInMethodIfSupported\u003ctesting::internal::UnitTestImpl, bool\u003e(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2469:14 (ep-engine_ep_unit_tests+0x15551e2)\n    #21 testing::UnitTest::Run() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:4925:10 (ep-engine_ep_unit_tests+0x15455d7)\n    #22 RUN_ALL_TESTS() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/include/gtest/gtest.h:2473:46 (ep-engine_ep_unit_tests+0x1079927)\n    #23 main /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../kv_engine/engines/ep/tests/module_tests/ep_unit_tests_main.cc:175:16 (ep-engine_ep_unit_tests+0x107978e)\n\nChange-Id: I7c3e9369065e5344333c410602267835f9bcc7e1\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"4a5d9f4699d02eee908ea47694428491db677f30","is_merged_in_target_branch":true,"change_id":"Ib709a997cee0e64ff3f66eacf4e778b26b8e0cd4","change_number":137630,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"},"441bb2e1780a9b35f01be776edcca4d45c926aeb":{"kind":"REWORK","_number":3,"created":"2020-10-08 13:16:44.000000000","uploader":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/45/137745/3","fetch":{"anonymous http":{"url":"https://review.couchbase.org/kv_engine","ref":"refs/changes/45/137745/3","commands":{"Branch":"git fetch https://review.couchbase.org/kv_engine refs/changes/45/137745/3 \u0026\u0026 git checkout -b change-137745 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/kv_engine refs/changes/45/137745/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/kv_engine refs/changes/45/137745/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/kv_engine refs/changes/45/137745/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/kv_engine refs/changes/45/137745/3","Reset To":"git fetch https://review.couchbase.org/kv_engine refs/changes/45/137745/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4a5d9f4699d02eee908ea47694428491db677f30","subject":"Revert \"MB-41321: 2/4 Clean-up if collection exists in old and new drop containers\""}],"author":{"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","date":"2020-10-08 10:48:19.000000000","tz":60},"committer":{"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","date":"2020-10-08 12:54:56.000000000","tz":60},"subject":"MB-41510: Fix TSAN failure due to lock order inversion","message":"MB-41510: Fix TSAN failure due to lock order inversion\n\nFix TSAN failures in module_tests/hdrhistogram_test.cc, due to\ntheoretical deadlock that could occur when using two iterators that hold\nread locks on different HdrHistograms (this isn\u0027t the case now bug could\nbe if the code was modified). To avoid this WARNING, ensure in our\nHdrHistogramTests that we never hold multiple HdrHistogram::Iterators in\nthe same scope.\n\nExample TSAN Failure:\n  WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock) (pid\u003d16448)\n  Cycle in lock order graph: M732257135894671160 (0x000000000000) \u003d\u003e M730849761011117904 (0x000000000000) \u003d\u003e M732257135894671160\n\n  Mutex M730849761011117904 acquired here while holding mutex M732257135894671160 in main thread:\n    #0 AnnotateRWLockAcquired \u003cnull\u003e (ep-engine_ep_unit_tests+0x64007b)\n    #1 folly::detail::annotate_rwlock_acquired_impl(void const volatile*, folly::annotate_rwlock_level, char const*, int) /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/synchronization/SanitizeThread.cpp:99 (ep-engine_ep_unit_tests+0x162f6be)\n    #2 annotate_rwlock_acquired /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/synchronization/SanitizeThread.h:111 (ep-engine_ep_unit_tests+0x15a9881)\n    #3 folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e::annotateAcquired(folly::annotate_rwlock_level) /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/SharedMutex.h:740 (ep-engine_ep_unit_tests+0x15a9881)\n    #4 folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e::lock() /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/SharedMutex.h:372 (ep-engine_ep_unit_tests+0x15a9881)\n    #5 folly::detail::LockTraitsImpl\u003cfolly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e, (folly::detail::MutexLevel)0, false\u003e::lock(folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e\u0026) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/LockTraits.h:124:11 (ep-engine_ep_unit_tests+0x717b75)\n    #6 std::integral_constant\u003cbool, true\u003e folly::LockPolicyExclusive::lock\u003cfolly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e(folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e\u0026) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/LockTraits.h:479:5 (ep-engine_ep_unit_tests+0x717b45)\n    #7 folly::LockedPtrBase\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e, folly::LockPolicyExclusive\u003e::LockedPtrBase(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/Synchronized.h:1097:10 (ep-engine_ep_unit_tests+0x158cb02)\n    #8 folly::LockedPtr\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e, folly::LockPolicyExclusive\u003e::LockedPtr(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/Synchronized.h:1402:50 (ep-engine_ep_unit_tests+0x158caae)\n    #9 folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e::contextualLock() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/Synchronized.h:653:12 (ep-engine_ep_unit_tests+0x158ceae)\n    #10 std::tuple\u003cstd::conditional\u003cstd::is_const\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e \u003e::value, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e::ConstLockedPtr, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e::LockedPtr\u003e::type, std::conditional\u003cstd::is_const\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const\u003e::value, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const::ConstLockedPtr, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const::LockedPtr\u003e::type\u003e folly::acquireLocked\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const\u003e(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e\u0026, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const\u0026) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/Synchronized.h:1741:18 (ep-engine_ep_unit_tests+0x158ccda)\n    #11 std::pair\u003cstd::conditional\u003cstd::is_const\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e \u003e::value, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e::ConstLockedPtr, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e::LockedPtr\u003e::type, std::conditional\u003cstd::is_const\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const\u003e::value, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const::ConstLockedPtr, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const::LockedPtr\u003e::type\u003e folly::acquireLockedPair\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const\u003e(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e\u0026, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const\u0026) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/Synchronized.h:1753:21 (ep-engine_ep_unit_tests+0x158bbf9)\n    #12 HdrHistogram::operator+\u003d(HdrHistogram const\u0026) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../kv_engine/utilities/hdrhistogram.cc:67:21 (ep-engine_ep_unit_tests+0x158a3bf)\n    #13 HdrHistogramTest_aggregationTest_Test::TestBody() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../kv_engine/engines/ep/tests/module_tests/hdrhistogram_test.cc:317:18 (ep-engine_ep_unit_tests+0x13479b1)\n    #14 void testing::internal::HandleSehExceptionsInMethodIfSupported\u003ctesting::Test, void\u003e(testing::Test*, void (testing::Test::*)(), char const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2433:10 (ep-engine_ep_unit_tests+0x1567683)\n    #15 void testing::internal::HandleExceptionsInMethodIfSupported\u003ctesting::Test, void\u003e(testing::Test*, void (testing::Test::*)(), char const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2469:14 (ep-engine_ep_unit_tests+0x1553012)\n    #16 testing::Test::Run() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2508:5 (ep-engine_ep_unit_tests+0x153b87c)\n    #17 testing::TestInfo::Run() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2684:11 (ep-engine_ep_unit_tests+0x153c26a)\n    #18 testing::TestSuite::Run() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2816:28 (ep-engine_ep_unit_tests+0x153c841)\n    #19 testing::internal::UnitTestImpl::RunAllTests() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:5338:44 (ep-engine_ep_unit_tests+0x1545a21)\n    #20 bool testing::internal::HandleSehExceptionsInMethodIfSupported\u003ctesting::internal::UnitTestImpl, bool\u003e(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2433:10 (ep-engine_ep_unit_tests+0x156aa43)\n    #21 bool testing::internal::HandleExceptionsInMethodIfSupported\u003ctesting::internal::UnitTestImpl, bool\u003e(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2469:14 (ep-engine_ep_unit_tests+0x15551e2)\n    #22 testing::UnitTest::Run() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:4925:10 (ep-engine_ep_unit_tests+0x15455d7)\n    #23 RUN_ALL_TESTS() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/include/gtest/gtest.h:2473:46 (ep-engine_ep_unit_tests+0x1079927)\n    #24 main /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../kv_engine/engines/ep/tests/module_tests/ep_unit_tests_main.cc:175:16 (ep-engine_ep_unit_tests+0x107978e)\n\n    Hint: use TSAN_OPTIONS\u003dsecond_deadlock_stack\u003d1 to get more informative warning message\n\n  Mutex M732257135894671160 acquired here while holding mutex M730849761011117904 in main thread:\n    #0 AnnotateRWLockAcquired \u003cnull\u003e (ep-engine_ep_unit_tests+0x64007b)\n    #1 folly::detail::annotate_rwlock_acquired_impl(void const volatile*, folly::annotate_rwlock_level, char const*, int) /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/synchronization/SanitizeThread.cpp:99 (ep-engine_ep_unit_tests+0x162f6be)\n    #2 annotate_rwlock_acquired /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/synchronization/SanitizeThread.h:111 (ep-engine_ep_unit_tests+0x15ad433)\n    #3 folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e::annotateAcquired(folly::annotate_rwlock_level) /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/SharedMutex.h:740 (ep-engine_ep_unit_tests+0x15ad433)\n    #4 folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e::lock_shared() /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/SharedMutex.h:414 (ep-engine_ep_unit_tests+0x15ad433)\n    #5 folly::detail::LockTraitsImpl\u003cfolly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e, (folly::detail::MutexLevel)1, false\u003e::lock_shared(folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e\u0026) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/LockTraits.h:157:11 (ep-engine_ep_unit_tests+0x703215)\n    #6 std::integral_constant\u003cbool, true\u003e folly::LockPolicyShared::lock\u003cfolly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e(folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e\u0026) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/LockTraits.h:499:5 (ep-engine_ep_unit_tests+0x7031c5)\n    #7 folly::LockedPtrBase\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e, folly::LockPolicyShared\u003e::LockedPtrBase(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/Synchronized.h:1097:10 (ep-engine_ep_unit_tests+0x915242)\n    #8 folly::LockedPtr\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const, folly::LockPolicyShared\u003e::LockedPtr(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/Synchronized.h:1402:50 (ep-engine_ep_unit_tests+0x9151ee)\n    #9 folly::SynchronizedBase\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e, (folly::detail::MutexLevel)1\u003e::rlock() const /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/Synchronized.h:144:12 (ep-engine_ep_unit_tests+0x91502e)\n    #10 HdrHistogram::Iterator::Iterator(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const\u0026, HdrHistogram::Iterator::IterMode) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../kv_engine/utilities/hdrhistogram.h:89:66 (ep-engine_ep_unit_tests+0x158be71)\n    #11 HdrHistogram::makeLinearIterator(long) const /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../kv_engine/utilities/hdrhistogram.cc:162:28 (ep-engine_ep_unit_tests+0x158aafb)\n    #12 HdrHistogramTest_aggregationTest_Test::TestBody() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../kv_engine/engines/ep/tests/module_tests/hdrhistogram_test.cc:322:26 (ep-engine_ep_unit_tests+0x13479e2)\n    #13 void testing::internal::HandleSehExceptionsInMethodIfSupported\u003ctesting::Test, void\u003e(testing::Test*, void (testing::Test::*)(), char const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2433:10 (ep-engine_ep_unit_tests+0x1567683)\n    #14 void testing::internal::HandleExceptionsInMethodIfSupported\u003ctesting::Test, void\u003e(testing::Test*, void (testing::Test::*)(), char const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2469:14 (ep-engine_ep_unit_tests+0x1553012)\n    #15 testing::Test::Run() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2508:5 (ep-engine_ep_unit_tests+0x153b87c)\n    #16 testing::TestInfo::Run() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2684:11 (ep-engine_ep_unit_tests+0x153c26a)\n    #17 testing::TestSuite::Run() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2816:28 (ep-engine_ep_unit_tests+0x153c841)\n    #18 testing::internal::UnitTestImpl::RunAllTests() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:5338:44 (ep-engine_ep_unit_tests+0x1545a21)\n    #19 bool testing::internal::HandleSehExceptionsInMethodIfSupported\u003ctesting::internal::UnitTestImpl, bool\u003e(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2433:10 (ep-engine_ep_unit_tests+0x156aa43)\n    #20 bool testing::internal::HandleExceptionsInMethodIfSupported\u003ctesting::internal::UnitTestImpl, bool\u003e(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2469:14 (ep-engine_ep_unit_tests+0x15551e2)\n    #21 testing::UnitTest::Run() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:4925:10 (ep-engine_ep_unit_tests+0x15455d7)\n    #22 RUN_ALL_TESTS() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/include/gtest/gtest.h:2473:46 (ep-engine_ep_unit_tests+0x1079927)\n    #23 main /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../kv_engine/engines/ep/tests/module_tests/ep_unit_tests_main.cc:175:16 (ep-engine_ep_unit_tests+0x107978e)\n\nChange-Id: I7c3e9369065e5344333c410602267835f9bcc7e1\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"4a5d9f4699d02eee908ea47694428491db677f30","is_merged_in_target_branch":true,"change_id":"Ib709a997cee0e64ff3f66eacf4e778b26b8e0cd4","change_number":137630,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"},"0ab71e206d6a6357246d2f7c705873fc119605dd":{"kind":"REWORK","_number":4,"created":"2020-10-08 13:34:42.000000000","uploader":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/45/137745/4","fetch":{"anonymous http":{"url":"https://review.couchbase.org/kv_engine","ref":"refs/changes/45/137745/4","commands":{"Branch":"git fetch https://review.couchbase.org/kv_engine refs/changes/45/137745/4 \u0026\u0026 git checkout -b change-137745 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/kv_engine refs/changes/45/137745/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/kv_engine refs/changes/45/137745/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/kv_engine refs/changes/45/137745/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/kv_engine refs/changes/45/137745/4","Reset To":"git fetch https://review.couchbase.org/kv_engine refs/changes/45/137745/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4a5d9f4699d02eee908ea47694428491db677f30","subject":"Revert \"MB-41321: 2/4 Clean-up if collection exists in old and new drop containers\""}],"author":{"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","date":"2020-10-08 10:48:19.000000000","tz":60},"committer":{"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","date":"2020-10-08 13:34:20.000000000","tz":60},"subject":"MB-41510: Fix TSAN failure due to lock order inversion","message":"MB-41510: Fix TSAN failure due to lock order inversion\n\nFix TSAN failures in module_tests/hdrhistogram_test.cc, due to\ntheoretical deadlock that could occur when using two iterators that hold\nread locks on different HdrHistograms (this isn\u0027t the case now bug could\nbe if the code was modified). To avoid this WARNING, ensure in our\nHdrHistogramTests that we never hold multiple HdrHistogram::Iterators in\nthe same scope.\n\nExample TSAN Failure:\n  WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock) (pid\u003d16448)\n  Cycle in lock order graph: M732257135894671160 (0x000000000000) \u003d\u003e M730849761011117904 (0x000000000000) \u003d\u003e M732257135894671160\n\n  Mutex M730849761011117904 acquired here while holding mutex M732257135894671160 in main thread:\n    #0 AnnotateRWLockAcquired \u003cnull\u003e (ep-engine_ep_unit_tests+0x64007b)\n    #1 folly::detail::annotate_rwlock_acquired_impl(void const volatile*, folly::annotate_rwlock_level, char const*, int) /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/synchronization/SanitizeThread.cpp:99 (ep-engine_ep_unit_tests+0x162f6be)\n    #2 annotate_rwlock_acquired /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/synchronization/SanitizeThread.h:111 (ep-engine_ep_unit_tests+0x15a9881)\n    #3 folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e::annotateAcquired(folly::annotate_rwlock_level) /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/SharedMutex.h:740 (ep-engine_ep_unit_tests+0x15a9881)\n    #4 folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e::lock() /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/SharedMutex.h:372 (ep-engine_ep_unit_tests+0x15a9881)\n    #5 folly::detail::LockTraitsImpl\u003cfolly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e, (folly::detail::MutexLevel)0, false\u003e::lock(folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e\u0026) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/LockTraits.h:124:11 (ep-engine_ep_unit_tests+0x717b75)\n    #6 std::integral_constant\u003cbool, true\u003e folly::LockPolicyExclusive::lock\u003cfolly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e(folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e\u0026) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/LockTraits.h:479:5 (ep-engine_ep_unit_tests+0x717b45)\n    #7 folly::LockedPtrBase\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e, folly::LockPolicyExclusive\u003e::LockedPtrBase(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/Synchronized.h:1097:10 (ep-engine_ep_unit_tests+0x158cb02)\n    #8 folly::LockedPtr\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e, folly::LockPolicyExclusive\u003e::LockedPtr(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/Synchronized.h:1402:50 (ep-engine_ep_unit_tests+0x158caae)\n    #9 folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e::contextualLock() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/Synchronized.h:653:12 (ep-engine_ep_unit_tests+0x158ceae)\n    #10 std::tuple\u003cstd::conditional\u003cstd::is_const\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e \u003e::value, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e::ConstLockedPtr, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e::LockedPtr\u003e::type, std::conditional\u003cstd::is_const\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const\u003e::value, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const::ConstLockedPtr, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const::LockedPtr\u003e::type\u003e folly::acquireLocked\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const\u003e(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e\u0026, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const\u0026) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/Synchronized.h:1741:18 (ep-engine_ep_unit_tests+0x158ccda)\n    #11 std::pair\u003cstd::conditional\u003cstd::is_const\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e \u003e::value, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e::ConstLockedPtr, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e::LockedPtr\u003e::type, std::conditional\u003cstd::is_const\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const\u003e::value, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const::ConstLockedPtr, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const::LockedPtr\u003e::type\u003e folly::acquireLockedPair\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const\u003e(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e\u0026, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const\u0026) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/Synchronized.h:1753:21 (ep-engine_ep_unit_tests+0x158bbf9)\n    #12 HdrHistogram::operator+\u003d(HdrHistogram const\u0026) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../kv_engine/utilities/hdrhistogram.cc:67:21 (ep-engine_ep_unit_tests+0x158a3bf)\n    #13 HdrHistogramTest_aggregationTest_Test::TestBody() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../kv_engine/engines/ep/tests/module_tests/hdrhistogram_test.cc:317:18 (ep-engine_ep_unit_tests+0x13479b1)\n    #14 void testing::internal::HandleSehExceptionsInMethodIfSupported\u003ctesting::Test, void\u003e(testing::Test*, void (testing::Test::*)(), char const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2433:10 (ep-engine_ep_unit_tests+0x1567683)\n    #15 void testing::internal::HandleExceptionsInMethodIfSupported\u003ctesting::Test, void\u003e(testing::Test*, void (testing::Test::*)(), char const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2469:14 (ep-engine_ep_unit_tests+0x1553012)\n    #16 testing::Test::Run() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2508:5 (ep-engine_ep_unit_tests+0x153b87c)\n    #17 testing::TestInfo::Run() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2684:11 (ep-engine_ep_unit_tests+0x153c26a)\n    #18 testing::TestSuite::Run() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2816:28 (ep-engine_ep_unit_tests+0x153c841)\n    #19 testing::internal::UnitTestImpl::RunAllTests() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:5338:44 (ep-engine_ep_unit_tests+0x1545a21)\n    #20 bool testing::internal::HandleSehExceptionsInMethodIfSupported\u003ctesting::internal::UnitTestImpl, bool\u003e(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2433:10 (ep-engine_ep_unit_tests+0x156aa43)\n    #21 bool testing::internal::HandleExceptionsInMethodIfSupported\u003ctesting::internal::UnitTestImpl, bool\u003e(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2469:14 (ep-engine_ep_unit_tests+0x15551e2)\n    #22 testing::UnitTest::Run() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:4925:10 (ep-engine_ep_unit_tests+0x15455d7)\n    #23 RUN_ALL_TESTS() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/include/gtest/gtest.h:2473:46 (ep-engine_ep_unit_tests+0x1079927)\n    #24 main /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../kv_engine/engines/ep/tests/module_tests/ep_unit_tests_main.cc:175:16 (ep-engine_ep_unit_tests+0x107978e)\n\n    Hint: use TSAN_OPTIONS\u003dsecond_deadlock_stack\u003d1 to get more informative warning message\n\n  Mutex M732257135894671160 acquired here while holding mutex M730849761011117904 in main thread:\n    #0 AnnotateRWLockAcquired \u003cnull\u003e (ep-engine_ep_unit_tests+0x64007b)\n    #1 folly::detail::annotate_rwlock_acquired_impl(void const volatile*, folly::annotate_rwlock_level, char const*, int) /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/synchronization/SanitizeThread.cpp:99 (ep-engine_ep_unit_tests+0x162f6be)\n    #2 annotate_rwlock_acquired /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/synchronization/SanitizeThread.h:111 (ep-engine_ep_unit_tests+0x15ad433)\n    #3 folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e::annotateAcquired(folly::annotate_rwlock_level) /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/SharedMutex.h:740 (ep-engine_ep_unit_tests+0x15ad433)\n    #4 folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e::lock_shared() /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/SharedMutex.h:414 (ep-engine_ep_unit_tests+0x15ad433)\n    #5 folly::detail::LockTraitsImpl\u003cfolly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e, (folly::detail::MutexLevel)1, false\u003e::lock_shared(folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e\u0026) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/LockTraits.h:157:11 (ep-engine_ep_unit_tests+0x703215)\n    #6 std::integral_constant\u003cbool, true\u003e folly::LockPolicyShared::lock\u003cfolly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e(folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e\u0026) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/LockTraits.h:499:5 (ep-engine_ep_unit_tests+0x7031c5)\n    #7 folly::LockedPtrBase\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e, folly::LockPolicyShared\u003e::LockedPtrBase(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/Synchronized.h:1097:10 (ep-engine_ep_unit_tests+0x915242)\n    #8 folly::LockedPtr\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const, folly::LockPolicyShared\u003e::LockedPtr(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/Synchronized.h:1402:50 (ep-engine_ep_unit_tests+0x9151ee)\n    #9 folly::SynchronizedBase\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e, (folly::detail::MutexLevel)1\u003e::rlock() const /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/Synchronized.h:144:12 (ep-engine_ep_unit_tests+0x91502e)\n    #10 HdrHistogram::Iterator::Iterator(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const\u0026, HdrHistogram::Iterator::IterMode) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../kv_engine/utilities/hdrhistogram.h:89:66 (ep-engine_ep_unit_tests+0x158be71)\n    #11 HdrHistogram::makeLinearIterator(long) const /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../kv_engine/utilities/hdrhistogram.cc:162:28 (ep-engine_ep_unit_tests+0x158aafb)\n    #12 HdrHistogramTest_aggregationTest_Test::TestBody() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../kv_engine/engines/ep/tests/module_tests/hdrhistogram_test.cc:322:26 (ep-engine_ep_unit_tests+0x13479e2)\n    #13 void testing::internal::HandleSehExceptionsInMethodIfSupported\u003ctesting::Test, void\u003e(testing::Test*, void (testing::Test::*)(), char const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2433:10 (ep-engine_ep_unit_tests+0x1567683)\n    #14 void testing::internal::HandleExceptionsInMethodIfSupported\u003ctesting::Test, void\u003e(testing::Test*, void (testing::Test::*)(), char const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2469:14 (ep-engine_ep_unit_tests+0x1553012)\n    #15 testing::Test::Run() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2508:5 (ep-engine_ep_unit_tests+0x153b87c)\n    #16 testing::TestInfo::Run() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2684:11 (ep-engine_ep_unit_tests+0x153c26a)\n    #17 testing::TestSuite::Run() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2816:28 (ep-engine_ep_unit_tests+0x153c841)\n    #18 testing::internal::UnitTestImpl::RunAllTests() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:5338:44 (ep-engine_ep_unit_tests+0x1545a21)\n    #19 bool testing::internal::HandleSehExceptionsInMethodIfSupported\u003ctesting::internal::UnitTestImpl, bool\u003e(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2433:10 (ep-engine_ep_unit_tests+0x156aa43)\n    #20 bool testing::internal::HandleExceptionsInMethodIfSupported\u003ctesting::internal::UnitTestImpl, bool\u003e(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2469:14 (ep-engine_ep_unit_tests+0x15551e2)\n    #21 testing::UnitTest::Run() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:4925:10 (ep-engine_ep_unit_tests+0x15455d7)\n    #22 RUN_ALL_TESTS() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/include/gtest/gtest.h:2473:46 (ep-engine_ep_unit_tests+0x1079927)\n    #23 main /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../kv_engine/engines/ep/tests/module_tests/ep_unit_tests_main.cc:175:16 (ep-engine_ep_unit_tests+0x107978e)\n\nChange-Id: I7c3e9369065e5344333c410602267835f9bcc7e1\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"4a5d9f4699d02eee908ea47694428491db677f30","is_merged_in_target_branch":true,"change_id":"Ib709a997cee0e64ff3f66eacf4e778b26b8e0cd4","change_number":137630,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"},"8ee8c85e89592fcfd54d6ae4a1dad06910047c26":{"kind":"REWORK","_number":5,"created":"2020-10-08 15:06:46.000000000","uploader":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/45/137745/5","fetch":{"anonymous http":{"url":"https://review.couchbase.org/kv_engine","ref":"refs/changes/45/137745/5","commands":{"Branch":"git fetch https://review.couchbase.org/kv_engine refs/changes/45/137745/5 \u0026\u0026 git checkout -b change-137745 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/kv_engine refs/changes/45/137745/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/kv_engine refs/changes/45/137745/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/kv_engine refs/changes/45/137745/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/kv_engine refs/changes/45/137745/5","Reset To":"git fetch https://review.couchbase.org/kv_engine refs/changes/45/137745/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5cf5a8015f7ce27368c8071379dcc320ee2147e9","subject":"MB-41857: Use given ops in openDbForRead"}],"author":{"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","date":"2020-10-08 10:48:19.000000000","tz":60},"committer":{"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","date":"2020-10-08 15:06:46.000000000","tz":0},"subject":"MB-41510: Fix TSAN failure due to lock order inversion","message":"MB-41510: Fix TSAN failure due to lock order inversion\n\nFix TSAN failures in module_tests/hdrhistogram_test.cc, due to\ntheoretical deadlock that could occur when using two iterators that hold\nread locks on different HdrHistograms (this isn\u0027t the case now bug could\nbe if the code was modified). To avoid this WARNING, ensure in our\nHdrHistogramTests that we never hold multiple HdrHistogram::Iterators in\nthe same scope.\n\nExample TSAN Failure:\n  WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock) (pid\u003d16448)\n  Cycle in lock order graph: M732257135894671160 (0x000000000000) \u003d\u003e M730849761011117904 (0x000000000000) \u003d\u003e M732257135894671160\n\n  Mutex M730849761011117904 acquired here while holding mutex M732257135894671160 in main thread:\n    #0 AnnotateRWLockAcquired \u003cnull\u003e (ep-engine_ep_unit_tests+0x64007b)\n    #1 folly::detail::annotate_rwlock_acquired_impl(void const volatile*, folly::annotate_rwlock_level, char const*, int) /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/synchronization/SanitizeThread.cpp:99 (ep-engine_ep_unit_tests+0x162f6be)\n    #2 annotate_rwlock_acquired /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/synchronization/SanitizeThread.h:111 (ep-engine_ep_unit_tests+0x15a9881)\n    #3 folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e::annotateAcquired(folly::annotate_rwlock_level) /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/SharedMutex.h:740 (ep-engine_ep_unit_tests+0x15a9881)\n    #4 folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e::lock() /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/SharedMutex.h:372 (ep-engine_ep_unit_tests+0x15a9881)\n    #5 folly::detail::LockTraitsImpl\u003cfolly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e, (folly::detail::MutexLevel)0, false\u003e::lock(folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e\u0026) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/LockTraits.h:124:11 (ep-engine_ep_unit_tests+0x717b75)\n    #6 std::integral_constant\u003cbool, true\u003e folly::LockPolicyExclusive::lock\u003cfolly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e(folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e\u0026) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/LockTraits.h:479:5 (ep-engine_ep_unit_tests+0x717b45)\n    #7 folly::LockedPtrBase\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e, folly::LockPolicyExclusive\u003e::LockedPtrBase(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/Synchronized.h:1097:10 (ep-engine_ep_unit_tests+0x158cb02)\n    #8 folly::LockedPtr\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e, folly::LockPolicyExclusive\u003e::LockedPtr(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/Synchronized.h:1402:50 (ep-engine_ep_unit_tests+0x158caae)\n    #9 folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e::contextualLock() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/Synchronized.h:653:12 (ep-engine_ep_unit_tests+0x158ceae)\n    #10 std::tuple\u003cstd::conditional\u003cstd::is_const\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e \u003e::value, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e::ConstLockedPtr, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e::LockedPtr\u003e::type, std::conditional\u003cstd::is_const\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const\u003e::value, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const::ConstLockedPtr, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const::LockedPtr\u003e::type\u003e folly::acquireLocked\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const\u003e(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e\u0026, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const\u0026) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/Synchronized.h:1741:18 (ep-engine_ep_unit_tests+0x158ccda)\n    #11 std::pair\u003cstd::conditional\u003cstd::is_const\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e \u003e::value, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e::ConstLockedPtr, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e::LockedPtr\u003e::type, std::conditional\u003cstd::is_const\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const\u003e::value, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const::ConstLockedPtr, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const::LockedPtr\u003e::type\u003e folly::acquireLockedPair\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const\u003e(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e\u0026, folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const\u0026) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/Synchronized.h:1753:21 (ep-engine_ep_unit_tests+0x158bbf9)\n    #12 HdrHistogram::operator+\u003d(HdrHistogram const\u0026) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../kv_engine/utilities/hdrhistogram.cc:67:21 (ep-engine_ep_unit_tests+0x158a3bf)\n    #13 HdrHistogramTest_aggregationTest_Test::TestBody() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../kv_engine/engines/ep/tests/module_tests/hdrhistogram_test.cc:317:18 (ep-engine_ep_unit_tests+0x13479b1)\n    #14 void testing::internal::HandleSehExceptionsInMethodIfSupported\u003ctesting::Test, void\u003e(testing::Test*, void (testing::Test::*)(), char const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2433:10 (ep-engine_ep_unit_tests+0x1567683)\n    #15 void testing::internal::HandleExceptionsInMethodIfSupported\u003ctesting::Test, void\u003e(testing::Test*, void (testing::Test::*)(), char const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2469:14 (ep-engine_ep_unit_tests+0x1553012)\n    #16 testing::Test::Run() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2508:5 (ep-engine_ep_unit_tests+0x153b87c)\n    #17 testing::TestInfo::Run() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2684:11 (ep-engine_ep_unit_tests+0x153c26a)\n    #18 testing::TestSuite::Run() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2816:28 (ep-engine_ep_unit_tests+0x153c841)\n    #19 testing::internal::UnitTestImpl::RunAllTests() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:5338:44 (ep-engine_ep_unit_tests+0x1545a21)\n    #20 bool testing::internal::HandleSehExceptionsInMethodIfSupported\u003ctesting::internal::UnitTestImpl, bool\u003e(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2433:10 (ep-engine_ep_unit_tests+0x156aa43)\n    #21 bool testing::internal::HandleExceptionsInMethodIfSupported\u003ctesting::internal::UnitTestImpl, bool\u003e(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2469:14 (ep-engine_ep_unit_tests+0x15551e2)\n    #22 testing::UnitTest::Run() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:4925:10 (ep-engine_ep_unit_tests+0x15455d7)\n    #23 RUN_ALL_TESTS() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/include/gtest/gtest.h:2473:46 (ep-engine_ep_unit_tests+0x1079927)\n    #24 main /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../kv_engine/engines/ep/tests/module_tests/ep_unit_tests_main.cc:175:16 (ep-engine_ep_unit_tests+0x107978e)\n\n    Hint: use TSAN_OPTIONS\u003dsecond_deadlock_stack\u003d1 to get more informative warning message\n\n  Mutex M732257135894671160 acquired here while holding mutex M730849761011117904 in main thread:\n    #0 AnnotateRWLockAcquired \u003cnull\u003e (ep-engine_ep_unit_tests+0x64007b)\n    #1 folly::detail::annotate_rwlock_acquired_impl(void const volatile*, folly::annotate_rwlock_level, char const*, int) /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/synchronization/SanitizeThread.cpp:99 (ep-engine_ep_unit_tests+0x162f6be)\n    #2 annotate_rwlock_acquired /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/synchronization/SanitizeThread.h:111 (ep-engine_ep_unit_tests+0x15ad433)\n    #3 folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e::annotateAcquired(folly::annotate_rwlock_level) /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/SharedMutex.h:740 (ep-engine_ep_unit_tests+0x15ad433)\n    #4 folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e::lock_shared() /home/couchbase/jenkins/workspace/cbdeps-platform-build-old/deps/packages/build/folly/follytsan-prefix/src/follytsan/folly/SharedMutex.h:414 (ep-engine_ep_unit_tests+0x15ad433)\n    #5 folly::detail::LockTraitsImpl\u003cfolly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e, (folly::detail::MutexLevel)1, false\u003e::lock_shared(folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e\u0026) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/LockTraits.h:157:11 (ep-engine_ep_unit_tests+0x703215)\n    #6 std::integral_constant\u003cbool, true\u003e folly::LockPolicyShared::lock\u003cfolly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e(folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e\u0026) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/LockTraits.h:499:5 (ep-engine_ep_unit_tests+0x7031c5)\n    #7 folly::LockedPtrBase\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e, folly::LockPolicyShared\u003e::LockedPtrBase(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/Synchronized.h:1097:10 (ep-engine_ep_unit_tests+0x915242)\n    #8 folly::LockedPtr\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const, folly::LockPolicyShared\u003e::LockedPtr(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/Synchronized.h:1402:50 (ep-engine_ep_unit_tests+0x9151ee)\n    #9 folly::SynchronizedBase\u003cfolly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e, (folly::detail::MutexLevel)1\u003e::rlock() const /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/tlm/deps/folly.exploded/include/folly/Synchronized.h:144:12 (ep-engine_ep_unit_tests+0x91502e)\n    #10 HdrHistogram::Iterator::Iterator(folly::Synchronized\u003cstd::unique_ptr\u003chdr_histogram, HdrHistogram::HdrDeleter\u003e, folly::SharedMutexImpl\u003cfalse, void, std::atomic, false, true\u003e \u003e const\u0026, HdrHistogram::Iterator::IterMode) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../kv_engine/utilities/hdrhistogram.h:89:66 (ep-engine_ep_unit_tests+0x158be71)\n    #11 HdrHistogram::makeLinearIterator(long) const /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../kv_engine/utilities/hdrhistogram.cc:162:28 (ep-engine_ep_unit_tests+0x158aafb)\n    #12 HdrHistogramTest_aggregationTest_Test::TestBody() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../kv_engine/engines/ep/tests/module_tests/hdrhistogram_test.cc:322:26 (ep-engine_ep_unit_tests+0x13479e2)\n    #13 void testing::internal::HandleSehExceptionsInMethodIfSupported\u003ctesting::Test, void\u003e(testing::Test*, void (testing::Test::*)(), char const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2433:10 (ep-engine_ep_unit_tests+0x1567683)\n    #14 void testing::internal::HandleExceptionsInMethodIfSupported\u003ctesting::Test, void\u003e(testing::Test*, void (testing::Test::*)(), char const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2469:14 (ep-engine_ep_unit_tests+0x1553012)\n    #15 testing::Test::Run() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2508:5 (ep-engine_ep_unit_tests+0x153b87c)\n    #16 testing::TestInfo::Run() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2684:11 (ep-engine_ep_unit_tests+0x153c26a)\n    #17 testing::TestSuite::Run() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2816:28 (ep-engine_ep_unit_tests+0x153c841)\n    #18 testing::internal::UnitTestImpl::RunAllTests() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:5338:44 (ep-engine_ep_unit_tests+0x1545a21)\n    #19 bool testing::internal::HandleSehExceptionsInMethodIfSupported\u003ctesting::internal::UnitTestImpl, bool\u003e(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2433:10 (ep-engine_ep_unit_tests+0x156aa43)\n    #20 bool testing::internal::HandleExceptionsInMethodIfSupported\u003ctesting::internal::UnitTestImpl, bool\u003e(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:2469:14 (ep-engine_ep_unit_tests+0x15551e2)\n    #21 testing::UnitTest::Run() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/src/gtest.cc:4925:10 (ep-engine_ep_unit_tests+0x15455d7)\n    #22 RUN_ALL_TESTS() /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../third_party/googletest/googletest/include/gtest/gtest.h:2473:46 (ep-engine_ep_unit_tests+0x1079927)\n    #23 main /home/couchbase/jenkins/workspace/kv_engine.threadsanitizer_master/build/../kv_engine/engines/ep/tests/module_tests/ep_unit_tests_main.cc:175:16 (ep-engine_ep_unit_tests+0x107978e)\n\nChange-Id: I7c3e9369065e5344333c410602267835f9bcc7e1\nReviewed-on: http://review.couchbase.org/c/kv_engine/+/137745\nReviewed-by: Dave Rigby \u003cdaver@couchbase.com\u003e\nTested-by: Build Bot \u003cbuild@couchbase.com\u003e\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"5cf5a8015f7ce27368c8071379dcc320ee2147e9","is_merged_in_target_branch":true,"change_id":"Ia77e10bc1a7b6c4a479d7c935561590a4713601c","change_number":137574,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}},{"label":"Well-Formed","status":"MAY"}]},{"status":"CLOSED"}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Custom-Rule","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Custom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["Custom-Rule"],"failing_atoms":[]}}]}