)]}'
{"id":"kv_engine~152230","triplet_id":"kv_engine~master~I87f13bc3a7cdf616b52d18502dd724fcf630d3b9","project":"kv_engine","branch":"master","hashtags":[],"change_id":"I87f13bc3a7cdf616b52d18502dd724fcf630d3b9","subject":"MB-45378: Fix static init fiasco with ExecutorPool \u0026 GoogleLog","status":"MERGED","created":"2021-04-27 15:49:01.000000000","updated":"2021-04-29 08:48:44.000000000","submitted":"2021-04-29 06:22:48.000000000","submitter":{"_account_id":1000002,"name":"Trond Norbye","display_name":"Trond","email":"trond.norbye@couchbase.com","username":"trond","avatars":[{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"152230-1619677368261-f4e2741e","meta_rev_id":"7c8eed5bfc8d74c948fe7c6fd6658f0e65cb2332","_number":152230,"virtual_id_number":152230,"owner":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000002,"name":"Trond Norbye","display_name":"Trond","email":"trond.norbye@couchbase.com","username":"trond","avatars":[{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-04-29 06:22:48.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000002,"name":"Trond Norbye","display_name":"Trond","email":"trond.norbye@couchbase.com","username":"trond","avatars":[{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-04-29 06:22:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000002,"name":"Trond Norbye","display_name":"Trond","email":"trond.norbye@couchbase.com","username":"trond","avatars":[{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-04-29 06:22:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]}],"values":{"-2":"Do not submit","-1":"I would prefer that you didn\u0027t submit this"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Well-Formed":{"all":[{"value":0,"_account_id":1000002,"name":"Trond Norbye","display_name":"Trond","email":"trond.norbye@couchbase.com","username":"trond","avatars":[{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]}],"values":{"-1":"Commit is not well-formed"," 0":"Well-formedness not checked","+1":"Commit is well-formed"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":1004341,"name":"Ben Huddleston","email":"ben.huddleston@couchbase.com","username":"BenHuddleston","avatars":[{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1003828,"name":"James H","email":"james.harrison@couchbase.com","username":"jameseh96","avatars":[{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1001547,"name":"Dan Owen","email":"owend@couchbase.com","username":"owend","avatars":[{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1004059,"name":"Paolo Cocchi","email":"paolo.cocchi@couchbase.com","username":"paolococchi","avatars":[{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1001546,"name":"Jim Walker","email":"jim@couchbase.com","username":"jim","avatars":[{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1002319,"name":"Dave Finlay","email":"dave.finlay@couchbase.com","username":"dave-finlay","avatars":[{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"Trond Norbye","display_name":"Trond","email":"trond.norbye@couchbase.com","username":"trond","avatars":[{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},{"_account_id":1001546,"name":"Jim Walker","email":"jim@couchbase.com","username":"jim","avatars":[{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1001547,"name":"Dan Owen","email":"owend@couchbase.com","username":"owend","avatars":[{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1002319,"name":"Dave Finlay","email":"dave.finlay@couchbase.com","username":"dave-finlay","avatars":[{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1003828,"name":"James H","email":"james.harrison@couchbase.com","username":"jameseh96","avatars":[{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1004059,"name":"Paolo Cocchi","email":"paolo.cocchi@couchbase.com","username":"paolococchi","avatars":[{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1004341,"name":"Ben Huddleston","email":"ben.huddleston@couchbase.com","username":"BenHuddleston","avatars":[{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-04-27 16:12:17.000000000","updated_by":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-04-28 15:47:45.000000000","updated_by":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":1002319,"name":"Dave Finlay","email":"dave.finlay@couchbase.com","username":"dave-finlay","avatars":[{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2021-04-28 15:47:45.000000000","updated_by":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":1001546,"name":"Jim Walker","email":"jim@couchbase.com","username":"jim","avatars":[{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2021-04-28 15:47:45.000000000","updated_by":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":1004059,"name":"Paolo Cocchi","email":"paolo.cocchi@couchbase.com","username":"paolococchi","avatars":[{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2021-04-28 15:47:45.000000000","updated_by":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":1001547,"name":"Dan Owen","email":"owend@couchbase.com","username":"owend","avatars":[{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2021-04-28 15:47:45.000000000","updated_by":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":1003828,"name":"James H","email":"james.harrison@couchbase.com","username":"jameseh96","avatars":[{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2021-04-28 15:47:45.000000000","updated_by":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":1004341,"name":"Ben Huddleston","email":"ben.huddleston@couchbase.com","username":"BenHuddleston","avatars":[{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2021-04-28 15:47:45.000000000","updated_by":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2021-04-28 15:47:45.000000000","updated_by":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":1000002,"name":"Trond Norbye","display_name":"Trond","email":"trond.norbye@couchbase.com","username":"trond","avatars":[{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"}],"messages":[{"id":"da547d382ef41f15185bfb383926dd4980c7f5a4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-04-27 15:49:01.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b3dc808cad6c6c5a25f69ebdba41722b6bed825a","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2021-04-27 16:12:17.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-windows-master/35317/ : FAILURE\n\nNo problems were identified. If you know why this problem occurred, please add a suitable Cause for it. ( http://cv.jenkins.couchbase.com/job/kv_engine-windows-master/35317/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_tidy/8560/ : FAILURE\n\n\u003cp\u003eclang-tidy suggested the following changes:\n\u003cpre\u003e\n\ncat \u0026lt;\u0026lt;\u0026quot;EOF\u0026quot; | patch -p1\ndiff --git a/engines/ep/src/fakes/fake_executorpool.h b/engines/ep/src/fakes/fake_executorpool.h\nindex 5ea67e392..fa36a2446 100644\n--- a/engines/ep/src/fakes/fake_executorpool.h\n+++ b/engines/ep/src/fakes/fake_executorpool.h\n@@ -29,6 +29,8 @@\n \n #include \u0026lt;folly/portability/GTest.h\u0026gt;\n \n+#include \u0026lt;memory\u0026gt;\n+\n class SingleThreadedExecutorPool : public CB3ExecutorPool {\n public:\n \n@@ -47,7 +49,7 @@ public:\n \n         EventuallyPersistentEngine *epe \u003d\n                 ObjectRegistry::onSwitchThread(nullptr, true);\n-        instance.reset(new SingleThreadedExecutorPool());\n+        instance \u003d std::make_unique\u0026lt;SingleThreadedExecutorPool\u0026gt;();\n         ObjectRegistry::onSwitchThread(epe);\n     }\n \ndiff --git a/engines/ep/tests/mock/mock_executor_pool.cc b/engines/ep/tests/mock/mock_executor_pool.cc\nindex ed5445111..e28569b6d 100644\n--- a/engines/ep/tests/mock/mock_executor_pool.cc\n+++ b/engines/ep/tests/mock/mock_executor_pool.cc\n@@ -10,6 +10,8 @@\n  */\n \n #include \u0026quot;mock_executor_pool.h\u0026quot;\n+\n+#include \u0026lt;memory\u0026gt;\n #include \u0026quot;objectregistry.h\u0026quot;\n #include \u0026quot;taskqueue.h\u0026quot;\n \n@@ -20,7 +22,7 @@ void MockExecutorPool::replaceExecutorPoolWithMock() {\n         executor-\u0026gt;shutdown();\n     }\n     auto* epEngine \u003d ObjectRegistry::onSwitchThread(nullptr, true);\n-    executor.reset(new MockExecutorPool());\n+    executor \u003d std::make_unique\u0026lt;MockExecutorPool\u0026gt;();\n     ObjectRegistry::onSwitchThread(epEngine);\n }\n \nEOF\n\n\u003c/pre\u003e ( http://cv.jenkins.couchbase.com/job/kv_engine-clang_tidy/8560/ )\n\nclang-tidy found the following problems:\n\n\u003cpre\u003e\n/home/couchbase/jenkins/workspace/kv_engine-clang_tidy/kv_engine/engines/ep/src/fakes/fake_executorpool.h:50:18: warning: use std::make_unique instead [modernize-make-unique]\n        instance.reset(new SingleThreadedExecutorPool());\n                ~^~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n                 \u003d std::make_unique\u003cSingleThreadedExecutorPool\u003e\n/home/couchbase/jenkins/workspace/kv_engine-clang_tidy/kv_engine/engines/ep/src/fakes/fake_executorpool.h:31:1: note: FIX-IT applied suggested code changes\n^\n/home/couchbase/jenkins/workspace/kv_engine-clang_tidy/kv_engine/engines/ep/src/fakes/fake_executorpool.h:50:17: note: FIX-IT applied suggested code changes\n        instance.reset(new SingleThreadedExecutorPool());\n                ^\n/home/couchbase/jenkins/workspace/kv_engine-clang_tidy/kv_engine/engines/ep/src/fakes/fake_executorpool.h:50:24: note: FIX-IT applied suggested code changes\n        instance.reset(new SingleThreadedExecutorPool());\n                       ^\n/home/couchbase/jenkins/workspace/kv_engine-clang_tidy/kv_engine/engines/ep/tests/mock/mock_executor_pool.cc:23:14: warning: use std::make_unique instead [modernize-make-unique]\n    executor.reset(new MockExecutorPool());\n            ~^~~~~ ~~~~~~~~~~~~~~~~~~~~~~\n             \u003d std::make_unique\u003cMockExecutorPool\u003e\n/home/couchbase/jenkins/workspace/kv_engine-clang_tidy/kv_engine/engines/ep/tests/mock/mock_executor_pool.cc:13:1: note: FIX-IT applied suggested code changes\n#include \"objectregistry.h\"\n^\n/home/couchbase/jenkins/workspace/kv_engine-clang_tidy/kv_engine/engines/ep/tests/mock/mock_executor_pool.cc:23:13: note: FIX-IT applied suggested code changes\n    executor.reset(new MockExecutorPool());\n            ^\n/home/couchbase/jenkins/workspace/kv_engine-clang_tidy/kv_engine/engines/ep/tests/mock/mock_executor_pool.cc:23:20: note: FIX-IT applied suggested code changes\n    executor.reset(new MockExecutorPool());\n                   ^\nclang-tidy suggested the following changes:\n\ncat \u0026lt;\u0026lt;\u0026quot;EOF\u0026quot; | patch -p1\ndiff --git a/engines/ep/src/fakes/fake_executorpool.h b/engines/ep/src/fakes/fake_executorpool.h\nindex 5ea67e392..fa36a2446 100644\n--- a/engines/ep/src/fakes/fake_executorpool.h\n+++ b/engines/ep/src/fakes/fake_executorpool.h\n@@ -29,6 +29,8 @@\n \n #include \u0026lt;folly/portability/GTest.h\u0026gt;\n \n+#include \u0026lt;memory\u0026gt;\n+\n class SingleThreadedExecutorPool : public CB3ExecutorPool {\n public:\n \n@@ -47,7 +49,7 @@ public:\n \n         EventuallyPersistentEngine *epe \u003d\n                 ObjectRegistry::onSwitchThread(nullptr, true);\n-        instance.reset(new SingleThreadedExecutorPool());\n+        instance \u003d std::make_unique\u0026lt;SingleThreadedExecutorPool\u0026gt;();\n         ObjectRegistry::onSwitchThread(epe);\n     }\n \ndiff --git a/engines/ep/tests/mock/mock_executor_pool.cc b/engines/ep/tests/mock/mock_executor_pool.cc\nindex ed5445111..e28569b6d 100644\n--- a/engines/ep/tests/mock/mock_executor_pool.cc\n+++ b/engines/ep/tests/mock/mock_executor_pool.cc\n@@ -10,6 +10,8 @@\n  */\n \n #include \u0026quot;mock_executor_pool.h\u0026quot;\n+\n+#include \u0026lt;memory\u0026gt;\n #include \u0026quot;objectregistry.h\u0026quot;\n #include \u0026quot;taskqueue.h\u0026quot;\n \n@@ -20,7 +22,7 @@ void MockExecutorPool::replaceExecutorPoolWithMock() {\n         executor-\u0026gt;shutdown();\n     }\n     auto* epEngine \u003d ObjectRegistry::onSwitchThread(nullptr, true);\n-    executor.reset(new MockExecutorPool());\n+    executor \u003d std::make_unique\u0026lt;MockExecutorPool\u0026gt;();\n     ObjectRegistry::onSwitchThread(epEngine);\n }\n \nEOF\n\n\u003c/pre\u003e ( http://cv.jenkins.couchbase.com/job/kv_engine-clang_tidy/8560/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_analyzer-master/30217/ : FAILURE\n\nNo problems were identified. If you know why this problem occurred, please add a suitable Cause for it. ( http://cv.jenkins.couchbase.com/job/kv_engine-clang_analyzer-master/30217/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/18031/ : FAILURE\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.threadsanitizer/job/master/10480/ : FAILURE\n\nThreadSanitizer issue: heap-use-after-free /opt/gcc-10.2.0/lib/gcc/x86_64-pc-linux-gnu/10.2.0/../../../../include/c++/10.2.0/bits/hashtable.h:1573 in std::_Hashtable\u003cphosphor::ChunkTenant*, phosphor::ChunkTenant*, std::allocator\u003cphosphor::ChunkTenant*\u003e, std::__detail::_Identity, std::equal_to\u003cphosphor::ChunkTenant*\u003e, std::hash\u003cphosphor::ChunkTenant*\u003e, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits\u003cfalse, true, true\u003e \u003e::_M_find_before_node(unsigned long, phosphor::ChunkTenant* const\u0026, unsigned long) const  ( http://cv.jenkins.couchbase.com/job/kv_engine.threadsanitizer/job/master/10480/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.macos/job/master/9158/ : FAILURE\n\nNo problems were identified. If you know why this problem occurred, please add a suitable Cause for it. ( http://cv.jenkins.couchbase.com/job/kv_engine.macos/job/master/9158/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_format_9/7109/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux-CE/job/master/10088/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux/job/master/10231/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"2fe94a3b6500987daa92b68c26ed317f30818a69","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-04-28 11:48:03.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"be1dfb0ceced2d8c6bf65e0d86d7c18146fd2e3b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-04-28 12:34:31.000000000","message":"Patch Set 3: Patch Set 2 was rebased","accounts_in_message":[],"_revision_number":3},{"id":"bd813063b9ee2f36d0f1e7f769712907ce9c7171","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2021-04-28 12:34:43.000000000","message":"Patch Set 2: Verified-1\n\nBuild Failed \n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.threadsanitizer/job/master/10502/ : ABORTED\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-windows-master/35354/ : FAILURE\n\nNo problems were identified. If you know why this problem occurred, please add a suitable Cause for it. ( http://cv.jenkins.couchbase.com/job/kv_engine-windows-master/35354/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/18055/ : FAILURE\n\nOne of more core files found at the end of the build. Data for post-mortem saved to archived_core_dumps.tar.bz2 under \"Build Artifacts\". ( http://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/18055/ )\n\nAddressSanitizer issue: heap-use-after-free /opt/gcc-10.2.0/lib/gcc/x86_64-pc-linux-gnu/10.2.0/../../../../include/c++/10.2.0/bits/hashtable.h:1573:31 in std::_Hashtable\u003cphosphor::ChunkTenant*, phosphor::ChunkTenant*, std::allocator\u003cphosphor::ChunkTenant*\u003e, std::__detail::_Identity, std::equal_to\u003cphosphor::ChunkTenant*\u003e, std::hash\u003cphosphor::ChunkTenant*\u003e, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits\u003cfalse, true, true\u003e \u003e::_M_find_before_node(unsigned long, phosphor::ChunkTenant* const\u0026, unsigned long) const ( http://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/18055/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.macos/job/master/9181/ : FAILURE\n\nNo problems were identified. If you know why this problem occurred, please add a suitable Cause for it. ( http://cv.jenkins.couchbase.com/job/kv_engine.macos/job/master/9181/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_format_9/7132/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_tidy/8582/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux/job/master/10253/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux-CE/job/master/10110/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_analyzer-master/30234/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"00392ccac536e43a1065ed182ca88852feda553e","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2021-04-28 13:27:25.000000000","message":"Patch Set 3: Verified-1\n\nBuild Failed \n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-windows-master/35359/ : FAILURE\n\nTimeout of a CTest test 408/409 Test #265: ep_testsuite_dcp.value_eviction.comp_passive ..................................................................................} ( http://cv.jenkins.couchbase.com/job/kv_engine-windows-master/35359/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.macos/job/master/9187/ : FAILURE\n\nNo problems were identified. If you know why this problem occurred, please add a suitable Cause for it. ( http://cv.jenkins.couchbase.com/job/kv_engine.macos/job/master/9187/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_format_9/7136/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_tidy/8587/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_analyzer-master/30239/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux-CE/job/master/10115/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux/job/master/10258/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.threadsanitizer/job/master/10507/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/18060/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"00c3a72a61b504eab991946a2e44c422a4544035","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2021-04-28 14:10:27.000000000","message":"Patch Set 3:\n\nBuild Failed \n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-windows-master/35359/ : FAILURE\n\nTimeout of a CTest test 408/409 Test #265: ep_testsuite_dcp.value_eviction.comp_passive ..................................................................................} ( http://cv.jenkins.couchbase.com/job/kv_engine-windows-master/35359/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.macos/job/master/9192/ : FAILURE\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_format_9/7136/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_tidy/8587/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_analyzer-master/30239/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux-CE/job/master/10115/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux/job/master/10258/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.threadsanitizer/job/master/10507/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/18060/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"df6a8e71bfbd46f01feec82f7f31662877c3b477","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2021-04-28 14:19:47.000000000","message":"Patch Set 3:\n\nBuild Failed \n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-windows-master/35359/ : FAILURE\n\nTimeout of a CTest test 408/409 Test #265: ep_testsuite_dcp.value_eviction.comp_passive ..................................................................................} ( http://cv.jenkins.couchbase.com/job/kv_engine-windows-master/35359/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.macos/job/master/9194/ : FAILURE\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_format_9/7136/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_tidy/8587/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_analyzer-master/30239/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux-CE/job/master/10115/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux/job/master/10258/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.threadsanitizer/job/master/10507/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/18060/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"1e7d2e0169775861280a755ead54b7acd7677208","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-04-28 14:25:10.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"49b1bdc76f11212cce17f4cca8d6d6cbbe2d366b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-04-28 14:55:18.000000000","message":"Patch Set 5: Patch Set 4 was rebased","accounts_in_message":[],"_revision_number":5},{"id":"7b155334f9a23b3002af8fb6567d4dc1ceaba4c5","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2021-04-28 14:55:22.000000000","message":"Patch Set 4: Verified-1\n\nBuild Failed \n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-windows-master/35370/ : ABORTED\n\nFailure of GoogleTest \"Persistent/DcpStreamSyncReplPersistentTest.ProducerAllowsSeqnoAckLEQToLastSent/persistent\":\n\n\u003cpre\u003e\n[ RUN      ] Persistent/DcpStreamSyncReplPersistentTest.ProducerAllowsSeqnoAckLEQToLastSent/persistent\nunknown file: error: C++ exception with description \"cb::io::rmrf: remove of file \\\\?\\C:\\Jenkins\\workspace\\kv_engine-windows-master\\build\\kv_engine\\ep_engine_ep_unit_tests.db\\test.282501\\magma.1\\wal\\wal.1 under ep_engine_ep_unit_tests.db/test.282501 failed: The data is invalid.\" thrown in TearDown().\n[  FAILED  ] Persistent/DcpStreamSyncReplPersistentTest.ProducerAllowsSeqnoAckLEQToLastSent/persistent, where GetParam() \u003d \"persistent\" (40 ms)\nPersistent/DcpStreamSyncReplPersistentTest.ProducerAllowsSeqnoAckLEQToLastSent/persistent\n\u003c/pre\u003e\n ( http://cv.jenkins.couchbase.com/job/kv_engine-windows-master/35370/ )\n\nBuild which was aborted due to a newer patch set being uploaded for the given review. ( http://cv.jenkins.couchbase.com/job/kv_engine-windows-master/35370/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/18068/ : ABORTED\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.threadsanitizer/job/master/10515/ : ABORTED\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_format_9/7144/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_analyzer-master/30248/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_tidy/8595/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux-CE/job/master/10123/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux/job/master/10266/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.macos/job/master/9197/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"c0369de7c9aed7e5b2187bda76d14f613c901991","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2021-04-28 15:41:34.000000000","message":"Patch Set 5: Verified+1\n\nBuild Successful \n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-windows-master/35376/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_format_9/7149/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_analyzer-master/30253/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_tidy/8600/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.macos/job/master/9202/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux-CE/job/master/10128/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.threadsanitizer/job/master/10520/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/18073/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux/job/master/10271/ : SUCCESS","accounts_in_message":[],"_revision_number":5},{"id":"bc10bfd4894024c36a00e8822fa32e4601333b4a","author":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-04-28 16:43:39.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"b91747aaead12e740c23b2a854499c1714f3e891","author":{"_account_id":1000002,"name":"Trond Norbye","display_name":"Trond","email":"trond.norbye@couchbase.com","username":"trond","avatars":[{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-04-29 06:22:41.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"99f288af6541fa2e52cf44db54b4235bfb3092a1","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Trond Norbye","display_name":"Trond","email":"trond.norbye@couchbase.com","username":"trond","avatars":[{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-04-29 06:22:48.000000000","message":"Change has been successfully cherry-picked as 5c90329b8cb4e8fddd34fafa5252e2b06646fd7e by Trond Norbye","accounts_in_message":[],"_revision_number":6},{"id":"f7a8071a25cd48c8e69830593808598e18cc7659","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2021-04-29 06:22:55.000000000","message":"Patch Set 6:\n\nBuild Started http://cv.jenkins.couchbase.com/job/kv_engine-master-post-commit/7499/ (2/2)","accounts_in_message":[],"_revision_number":6},{"id":"7c8eed5bfc8d74c948fe7c6fd6658f0e65cb2332","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2021-04-29 08:48:44.000000000","message":"Patch Set 6:\n\nBuild Failed \n\nhttp://cv.jenkins.couchbase.com/job/kv-engine-master-perf/4769/ : FAILURE\n\nCMake error: tlm/cmake/Modules/FindCouchbaseErlang.cmake:68 (MESSAGE) ( http://cv.jenkins.couchbase.com/job/kv-engine-master-perf/4769/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-master-post-commit/7499/ : SUCCESS\u0027","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"5c90329b8cb4e8fddd34fafa5252e2b06646fd7e","revisions":{"ac2fa95227c9e6b83ef998eb25594ef2db93e927":{"kind":"REWORK","_number":1,"created":"2021-04-27 15:49:01.000000000","uploader":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/30/152230/1","fetch":{"anonymous http":{"url":"https://review.couchbase.org/kv_engine","ref":"refs/changes/30/152230/1","commands":{"Branch":"git fetch https://review.couchbase.org/kv_engine refs/changes/30/152230/1 \u0026\u0026 git checkout -b change-152230 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/kv_engine refs/changes/30/152230/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/kv_engine refs/changes/30/152230/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/kv_engine refs/changes/30/152230/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/kv_engine refs/changes/30/152230/1","Reset To":"git fetch https://review.couchbase.org/kv_engine refs/changes/30/152230/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8d1b5cb788bd1c242df3548e187d09057b0a6c4f","subject":"MB-45378: Avoid crash with boost::fs global object"}],"author":{"name":"Dave Rigby","email":"daver@couchbase.com","date":"2021-04-27 15:34:57.000000000","tz":60},"committer":{"name":"Dave Rigby","email":"daver@couchbase.com","date":"2021-04-27 15:48:20.000000000","tz":60},"subject":"WIP: Fix static init fiasco with ExecutorPool","message":"WIP: Fix static init fiasco with ExecutorPool\n\nChange-Id: I87f13bc3a7cdf616b52d18502dd724fcf630d3b9\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"8d1b5cb788bd1c242df3548e187d09057b0a6c4f","is_merged_in_target_branch":false,"change_id":"I1783e669392b9abedabfe59d0249e429a51fe826","change_number":152073,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/master"},"21e1996bf289ecbf7310ba54c8c91097a23d9336":{"kind":"REWORK","_number":2,"created":"2021-04-28 11:48:03.000000000","uploader":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/30/152230/2","fetch":{"anonymous http":{"url":"https://review.couchbase.org/kv_engine","ref":"refs/changes/30/152230/2","commands":{"Branch":"git fetch https://review.couchbase.org/kv_engine refs/changes/30/152230/2 \u0026\u0026 git checkout -b change-152230 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/kv_engine refs/changes/30/152230/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/kv_engine refs/changes/30/152230/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/kv_engine refs/changes/30/152230/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/kv_engine refs/changes/30/152230/2","Reset To":"git fetch https://review.couchbase.org/kv_engine refs/changes/30/152230/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f4d13489e8c0dcb9040ff63b765c502dde67eb7a","subject":"MB-45378: Avoid crash with boost::fs global object"}],"author":{"name":"Dave Rigby","email":"daver@couchbase.com","date":"2021-04-27 15:34:57.000000000","tz":60},"committer":{"name":"Dave Rigby","email":"daver@couchbase.com","date":"2021-04-28 11:47:57.000000000","tz":60},"subject":"MB-45378: Fix static init fiasco with ExecutorPool \u0026 GoogleLog","message":"MB-45378: Fix static init fiasco with ExecutorPool \u0026 GoogleLog\n\nWhen converting platform to be statically linked, a crash is seen\nduring shutdown of ep-engine_ep_unit_tests.DcpConnMapTest tests on\nMSVC. The ExecutorPool is consuming messages on the background threads\n(I believe to coordinate shutdown), and during that it attempts to log\na warning message to Google Log.\n\nThe cause of the crash is a change in the static initialisation (and\ndeinitialization) order - the GoogleLog singleton instance as used\ninternally by Folly is deinitialized before ExecutorPool singleton. As\nsuch, when the ExecutorPool singleton is shutting down, it attempts to\nlog a message to a non-existant GLog instance and a nullptr is\ndeferenced.\n\nFix by changing ExecutorPool singleton to use C++11 magic static\n(Meyer singleton); which ensures it is destructed earlier, before\nGLog.\n\nChange-Id: I87f13bc3a7cdf616b52d18502dd724fcf630d3b9\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"f4d13489e8c0dcb9040ff63b765c502dde67eb7a","is_merged_in_target_branch":false,"change_id":"I1783e669392b9abedabfe59d0249e429a51fe826","change_number":152073,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/master"},"29f9a27865139880150b69fd1a36caa5e888733a":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2021-04-28 12:34:31.000000000","uploader":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/30/152230/3","fetch":{"anonymous http":{"url":"https://review.couchbase.org/kv_engine","ref":"refs/changes/30/152230/3","commands":{"Branch":"git fetch https://review.couchbase.org/kv_engine refs/changes/30/152230/3 \u0026\u0026 git checkout -b change-152230 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/kv_engine refs/changes/30/152230/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/kv_engine refs/changes/30/152230/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/kv_engine refs/changes/30/152230/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/kv_engine refs/changes/30/152230/3","Reset To":"git fetch https://review.couchbase.org/kv_engine refs/changes/30/152230/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9876689bb3fd74aa5e8fec05fc880c739327cc04","subject":"MB-45378: Fix static init fiasco with ExecutorPool \u0026 phosphor"}],"author":{"name":"Dave Rigby","email":"daver@couchbase.com","date":"2021-04-27 15:34:57.000000000","tz":60},"committer":{"name":"Dave Rigby","email":"daver@couchbase.com","date":"2021-04-28 12:34:31.000000000","tz":0},"subject":"MB-45378: Fix static init fiasco with ExecutorPool \u0026 GoogleLog","message":"MB-45378: Fix static init fiasco with ExecutorPool \u0026 GoogleLog\n\nWhen converting platform to be statically linked, a crash is seen\nduring shutdown of ep-engine_ep_unit_tests.DcpConnMapTest tests on\nMSVC. The ExecutorPool is consuming messages on the background threads\n(I believe to coordinate shutdown), and during that it attempts to log\na warning message to Google Log.\n\nThe cause of the crash is a change in the static initialisation (and\ndeinitialization) order - the GoogleLog singleton instance as used\ninternally by Folly is deinitialized before ExecutorPool singleton. As\nsuch, when the ExecutorPool singleton is shutting down, it attempts to\nlog a message to a non-existant GLog instance and a nullptr is\ndeferenced.\n\nFix by changing ExecutorPool singleton to use C++11 magic static\n(Meyer singleton); which ensures it is destructed earlier, before\nGLog.\n\nChange-Id: I87f13bc3a7cdf616b52d18502dd724fcf630d3b9\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"9876689bb3fd74aa5e8fec05fc880c739327cc04","is_merged_in_target_branch":false,"change_id":"I1953129cce0d05a42f0790724c470e38b2dd0701","change_number":152326,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master","description":"Rebase"},"331e0af5be96a269b74863cd70fa63fe3c45178a":{"kind":"REWORK","_number":4,"created":"2021-04-28 14:25:10.000000000","uploader":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/30/152230/4","fetch":{"anonymous http":{"url":"https://review.couchbase.org/kv_engine","ref":"refs/changes/30/152230/4","commands":{"Branch":"git fetch https://review.couchbase.org/kv_engine refs/changes/30/152230/4 \u0026\u0026 git checkout -b change-152230 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/kv_engine refs/changes/30/152230/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/kv_engine refs/changes/30/152230/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/kv_engine refs/changes/30/152230/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/kv_engine refs/changes/30/152230/4","Reset To":"git fetch https://review.couchbase.org/kv_engine refs/changes/30/152230/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9876689bb3fd74aa5e8fec05fc880c739327cc04","subject":"MB-45378: Fix static init fiasco with ExecutorPool \u0026 phosphor"}],"author":{"name":"Dave Rigby","email":"daver@couchbase.com","date":"2021-04-27 15:34:57.000000000","tz":60},"committer":{"name":"Dave Rigby","email":"daver@couchbase.com","date":"2021-04-28 14:24:41.000000000","tz":60},"subject":"MB-45378: Fix static init fiasco with ExecutorPool \u0026 GoogleLog","message":"MB-45378: Fix static init fiasco with ExecutorPool \u0026 GoogleLog\n\nWhen converting platform to be statically linked, a crash is seen\nduring shutdown of ep-engine_ep_unit_tests.DcpConnMapTest tests on\nMSVC. The ExecutorPool is consuming messages on the background threads\n(I believe to coordinate shutdown), and during that it attempts to log\na warning message to Google Log.\n\nThe cause of the crash is a change in the static initialisation (and\ndeinitialization) order - the GoogleLog singleton instance as used\ninternally by Folly is deinitialized before ExecutorPool singleton. As\nsuch, when the ExecutorPool singleton is shutting down, it attempts to\nlog a message to a non-existant GLog instance and a nullptr is\ndeferenced.\n\nFix by changing ExecutorPool singleton to use C++11 magic static\n(Meyer singleton); which ensures it is destructed earlier, before\nGLog.\n\nAdditionally, while the above is sufficient to fix this issue on macOS\nCatalina, on Mojave this introduces _another_ crash as some Folly\nhazard pointer singletons appear to already have been destructed and\nthe following crash is seen:\n\n    * thread #1, queue \u003d \u0027com.apple.main-thread\u0027, stop reason \u003d signal SIGABRT\n      * frame #0: 0x00007fff7412f2c6 libsystem_kernel.dylib`__pthread_kill + 10\n        frame #1: 0x00007fff741eabf1 libsystem_pthread.dylib`pthread_kill + 284\n        frame #2: 0x00007fff740996a6 libsystem_c.dylib`abort + 127\n        frame #3: 0x00007fff741a8077 libsystem_malloc.dylib`malloc_vreport + 545\n        frame #4: 0x00007fff741a7e38 libsystem_malloc.dylib`malloc_report + 151\n        frame #5: 0x00007fff73ff3cf9 libdyld.dylib`_tlv_atexit + 155\n        frame #6: 0x000000010143cb2d ep-engine_ep_unit_tests`folly::SingletonThreadLocal\u003cfolly::hazptr_tc\u003cstd::__1::atomic\u003e, folly::hazptr_tc_tls_tag, folly::detail::DefaultMake\u003cfolly::hazptr_tc\u003cstd::__1::atomic\u003e \u003e, folly::hazptr_tc_tls_tag\u003e::getSlow(cache\u003d0x000000010b5606b8) at SingletonThreadLocal.h:157 [opt]\n        frame #7: 0x0000000101437a19 ep-engine_ep_unit_tests`folly::UnboundedBlockingQueue\u003cfolly::CPUThreadPoolExecutor::CPUTask\u003e::add(folly::CPUThreadPoolExecutor::CPUTask) [inlined] folly::SingletonThreadLocal\u003cfolly::hazptr_tc\u003cstd::__1::atomic\u003e, folly::hazptr_tc_tls_tag, folly::detail::DefaultMake\u003cfolly::hazptr_tc\u003cstd::__1::atomic\u003e \u003e, folly::hazptr_tc_tls_tag\u003e::get() at SingletonThreadLocal.h:167 [opt]\n        frame #8: 0x0000000101437a08 ep-engine_ep_unit_tests`folly::UnboundedBlockingQueue\u003cfolly::CPUThreadPoolExecutor::CPUTask\u003e::add(folly::CPUThreadPoolExecutor::CPUTask) [inlined] folly::hazptr_tc\u003cstd::__1::atomic\u003e\u0026 folly::hazptr_tc_tls\u003cstd::__1::atomic\u003e() at HazptrThrLocal.h:166 [opt]\n        frame #9: 0x0000000101437a08 ep-engine_ep_unit_tests`folly::UnboundedBlockingQueue\u003cfolly::CPUThreadPoolExecutor::CPUTask\u003e::add(folly::CPUThreadPoolExecutor::CPUTask) at HazptrHolder.h:64 [opt]\n        frame #10: 0x0000000101437a08 ep-engine_ep_unit_tests`folly::UnboundedBlockingQueue\u003cfolly::CPUThreadPoolExecutor::CPUTask\u003e::add(folly::CPUThreadPoolExecutor::CPUTask) [inlined] folly::hazptr_holder\u003cstd::__1::atomic\u003e::hazptr_holder(this\u003d\u003cunavailable\u003e, domain\u003d\u003cunavailable\u003e) at HazptrHolder.h:61 [opt]\n        frame #11: 0x0000000101437a08 ep-engine_ep_unit_tests`folly::UnboundedBlockingQueue\u003cfolly::CPUThreadPoolExecutor::CPUTask\u003e::add(folly::CPUThreadPoolExecutor::CPUTask) at UnboundedQueue.h:374 [opt]\n        frame #12: 0x00000001014379e7 ep-engine_ep_unit_tests`folly::UnboundedBlockingQueue\u003cfolly::CPUThreadPoolExecutor::CPUTask\u003e::add(folly::CPUThreadPoolExecutor::CPUTask) [inlined] folly::UnboundedQueue\u003cfolly::CPUThreadPoolExecutor::CPUTask, false, false, false, 6ul, 7ul, std::__1::atomic\u003e::enqueue(this\u003d0x00007ffeefbff770, arg\u003d0x00007ffeefbff690) at UnboundedQueue.h:271 [opt]\n        frame #13: 0x00000001014379e7 ep-engine_ep_unit_tests`folly::UnboundedBlockingQueue\u003cfolly::CPUThreadPoolExecutor::CPUTask\u003e::add(this\u003d0x000000010ba00f80, item\u003dCPUTask @ 0x00007ffeefbff690) at UnboundedBlockingQueue.h:31 [opt]\n        frame #14: 0x0000000101437bfc ep-engine_ep_unit_tests`folly::BlockingQueue\u003cfolly::CPUThreadPoolExecutor::CPUTask\u003e::addWithPriority(this\u003d0x000000010ba00f80, item\u003dCPUTask @ 0x00007ffeefbff770, (null)\u003d\u003cunavailable\u003e) at BlockingQueue.h:57 [opt]\n        frame #15: 0x0000000101436b00 ep-engine_ep_unit_tests`folly::CPUThreadPoolExecutor::stopThreads(this\u003d0x000000010bf8de00, n\u003d2) at CPUThreadPoolExecutor.cpp:281 [opt]\n        frame #16: 0x000000010144bae3 ep-engine_ep_unit_tests`folly::ThreadPoolExecutor::stop() [inlined] folly::ThreadPoolExecutor::removeThreads(this\u003d\u003cunavailable\u003e, n\u003d\u003cunavailable\u003e) at ThreadPoolExecutor.cpp:233 [opt]\n        frame #17: 0x000000010144bad0 ep-engine_ep_unit_tests`folly::ThreadPoolExecutor::stop(this\u003d0x000000010bf8de00) at ThreadPoolExecutor.cpp:251 [opt]\n        frame #18: 0x00000001014352d4 ep-engine_ep_unit_tests`folly::CPUThreadPoolExecutor::~CPUThreadPoolExecutor(this\u003d0x000000010bf8de00, vtt\u003d0x00000001019fd6c8) at CPUThreadPoolExecutor.cpp:126 [opt]\n        frame #19: 0x0000000101435465 ep-engine_ep_unit_tests`folly::CPUThreadPoolExecutor::~CPUThreadPoolExecutor() [inlined] folly::CPUThreadPoolExecutor::~CPUThreadPoolExecutor(this\u003d0x000000010bf8de00) at CPUThreadPoolExecutor.cpp:124 [opt]\n        frame #20: 0x0000000101435459 ep-engine_ep_unit_tests`folly::CPUThreadPoolExecutor::~CPUThreadPoolExecutor(this\u003d0x000000010bf8de00) at CPUThreadPoolExecutor.cpp:124 [opt]\n        frame #21: 0x000000010023240a ep-engine_ep_unit_tests`FollyExecutorPool::~FollyExecutorPool(this\u003d0x000000010b7eed40) at folly_executorpool.cc:757 [opt]\n        frame #22: 0x00000001002325ee ep-engine_ep_unit_tests`FollyExecutorPool::~FollyExecutorPool(this\u003d0x000000010b7eed40) at folly_executorpool.cc:751 [opt]\n        frame #23: 0x00007fff7409a3cf libsystem_c.dylib`__cxa_finalize_ranges + 319\n        frame #24: 0x00007fff7409a6b3 libsystem_c.dylib`exit + 55\n\nAddress _this_ with a somewhat belt-and-braces approach - also\nmanually shutdown the ExecutorPool in DcpConnMapTest::TearDown - as is\ndone in other tests.\n\nChange-Id: I87f13bc3a7cdf616b52d18502dd724fcf630d3b9\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"9876689bb3fd74aa5e8fec05fc880c739327cc04","is_merged_in_target_branch":false,"change_id":"I1953129cce0d05a42f0790724c470e38b2dd0701","change_number":152326,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"},"107f79d3e817e9b929555bed027a4fc5ec9e85b0":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2021-04-28 14:55:18.000000000","uploader":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/30/152230/5","fetch":{"anonymous http":{"url":"https://review.couchbase.org/kv_engine","ref":"refs/changes/30/152230/5","commands":{"Branch":"git fetch https://review.couchbase.org/kv_engine refs/changes/30/152230/5 \u0026\u0026 git checkout -b change-152230 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/kv_engine refs/changes/30/152230/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/kv_engine refs/changes/30/152230/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/kv_engine refs/changes/30/152230/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/kv_engine refs/changes/30/152230/5","Reset To":"git fetch https://review.couchbase.org/kv_engine refs/changes/30/152230/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"868aec85a61b79a13928026ca62c9e8852301375","subject":"MB-45378: Fix static init fiasco with ExecutorPool \u0026 phosphor"}],"author":{"name":"Dave Rigby","email":"daver@couchbase.com","date":"2021-04-27 15:34:57.000000000","tz":60},"committer":{"name":"Dave Rigby","email":"daver@couchbase.com","date":"2021-04-28 14:55:18.000000000","tz":0},"subject":"MB-45378: Fix static init fiasco with ExecutorPool \u0026 GoogleLog","message":"MB-45378: Fix static init fiasco with ExecutorPool \u0026 GoogleLog\n\nWhen converting platform to be statically linked, a crash is seen\nduring shutdown of ep-engine_ep_unit_tests.DcpConnMapTest tests on\nMSVC. The ExecutorPool is consuming messages on the background threads\n(I believe to coordinate shutdown), and during that it attempts to log\na warning message to Google Log.\n\nThe cause of the crash is a change in the static initialisation (and\ndeinitialization) order - the GoogleLog singleton instance as used\ninternally by Folly is deinitialized before ExecutorPool singleton. As\nsuch, when the ExecutorPool singleton is shutting down, it attempts to\nlog a message to a non-existant GLog instance and a nullptr is\ndeferenced.\n\nFix by changing ExecutorPool singleton to use C++11 magic static\n(Meyer singleton); which ensures it is destructed earlier, before\nGLog.\n\nAdditionally, while the above is sufficient to fix this issue on macOS\nCatalina, on Mojave this introduces _another_ crash as some Folly\nhazard pointer singletons appear to already have been destructed and\nthe following crash is seen:\n\n    * thread #1, queue \u003d \u0027com.apple.main-thread\u0027, stop reason \u003d signal SIGABRT\n      * frame #0: 0x00007fff7412f2c6 libsystem_kernel.dylib`__pthread_kill + 10\n        frame #1: 0x00007fff741eabf1 libsystem_pthread.dylib`pthread_kill + 284\n        frame #2: 0x00007fff740996a6 libsystem_c.dylib`abort + 127\n        frame #3: 0x00007fff741a8077 libsystem_malloc.dylib`malloc_vreport + 545\n        frame #4: 0x00007fff741a7e38 libsystem_malloc.dylib`malloc_report + 151\n        frame #5: 0x00007fff73ff3cf9 libdyld.dylib`_tlv_atexit + 155\n        frame #6: 0x000000010143cb2d ep-engine_ep_unit_tests`folly::SingletonThreadLocal\u003cfolly::hazptr_tc\u003cstd::__1::atomic\u003e, folly::hazptr_tc_tls_tag, folly::detail::DefaultMake\u003cfolly::hazptr_tc\u003cstd::__1::atomic\u003e \u003e, folly::hazptr_tc_tls_tag\u003e::getSlow(cache\u003d0x000000010b5606b8) at SingletonThreadLocal.h:157 [opt]\n        frame #7: 0x0000000101437a19 ep-engine_ep_unit_tests`folly::UnboundedBlockingQueue\u003cfolly::CPUThreadPoolExecutor::CPUTask\u003e::add(folly::CPUThreadPoolExecutor::CPUTask) [inlined] folly::SingletonThreadLocal\u003cfolly::hazptr_tc\u003cstd::__1::atomic\u003e, folly::hazptr_tc_tls_tag, folly::detail::DefaultMake\u003cfolly::hazptr_tc\u003cstd::__1::atomic\u003e \u003e, folly::hazptr_tc_tls_tag\u003e::get() at SingletonThreadLocal.h:167 [opt]\n        frame #8: 0x0000000101437a08 ep-engine_ep_unit_tests`folly::UnboundedBlockingQueue\u003cfolly::CPUThreadPoolExecutor::CPUTask\u003e::add(folly::CPUThreadPoolExecutor::CPUTask) [inlined] folly::hazptr_tc\u003cstd::__1::atomic\u003e\u0026 folly::hazptr_tc_tls\u003cstd::__1::atomic\u003e() at HazptrThrLocal.h:166 [opt]\n        frame #9: 0x0000000101437a08 ep-engine_ep_unit_tests`folly::UnboundedBlockingQueue\u003cfolly::CPUThreadPoolExecutor::CPUTask\u003e::add(folly::CPUThreadPoolExecutor::CPUTask) at HazptrHolder.h:64 [opt]\n        frame #10: 0x0000000101437a08 ep-engine_ep_unit_tests`folly::UnboundedBlockingQueue\u003cfolly::CPUThreadPoolExecutor::CPUTask\u003e::add(folly::CPUThreadPoolExecutor::CPUTask) [inlined] folly::hazptr_holder\u003cstd::__1::atomic\u003e::hazptr_holder(this\u003d\u003cunavailable\u003e, domain\u003d\u003cunavailable\u003e) at HazptrHolder.h:61 [opt]\n        frame #11: 0x0000000101437a08 ep-engine_ep_unit_tests`folly::UnboundedBlockingQueue\u003cfolly::CPUThreadPoolExecutor::CPUTask\u003e::add(folly::CPUThreadPoolExecutor::CPUTask) at UnboundedQueue.h:374 [opt]\n        frame #12: 0x00000001014379e7 ep-engine_ep_unit_tests`folly::UnboundedBlockingQueue\u003cfolly::CPUThreadPoolExecutor::CPUTask\u003e::add(folly::CPUThreadPoolExecutor::CPUTask) [inlined] folly::UnboundedQueue\u003cfolly::CPUThreadPoolExecutor::CPUTask, false, false, false, 6ul, 7ul, std::__1::atomic\u003e::enqueue(this\u003d0x00007ffeefbff770, arg\u003d0x00007ffeefbff690) at UnboundedQueue.h:271 [opt]\n        frame #13: 0x00000001014379e7 ep-engine_ep_unit_tests`folly::UnboundedBlockingQueue\u003cfolly::CPUThreadPoolExecutor::CPUTask\u003e::add(this\u003d0x000000010ba00f80, item\u003dCPUTask @ 0x00007ffeefbff690) at UnboundedBlockingQueue.h:31 [opt]\n        frame #14: 0x0000000101437bfc ep-engine_ep_unit_tests`folly::BlockingQueue\u003cfolly::CPUThreadPoolExecutor::CPUTask\u003e::addWithPriority(this\u003d0x000000010ba00f80, item\u003dCPUTask @ 0x00007ffeefbff770, (null)\u003d\u003cunavailable\u003e) at BlockingQueue.h:57 [opt]\n        frame #15: 0x0000000101436b00 ep-engine_ep_unit_tests`folly::CPUThreadPoolExecutor::stopThreads(this\u003d0x000000010bf8de00, n\u003d2) at CPUThreadPoolExecutor.cpp:281 [opt]\n        frame #16: 0x000000010144bae3 ep-engine_ep_unit_tests`folly::ThreadPoolExecutor::stop() [inlined] folly::ThreadPoolExecutor::removeThreads(this\u003d\u003cunavailable\u003e, n\u003d\u003cunavailable\u003e) at ThreadPoolExecutor.cpp:233 [opt]\n        frame #17: 0x000000010144bad0 ep-engine_ep_unit_tests`folly::ThreadPoolExecutor::stop(this\u003d0x000000010bf8de00) at ThreadPoolExecutor.cpp:251 [opt]\n        frame #18: 0x00000001014352d4 ep-engine_ep_unit_tests`folly::CPUThreadPoolExecutor::~CPUThreadPoolExecutor(this\u003d0x000000010bf8de00, vtt\u003d0x00000001019fd6c8) at CPUThreadPoolExecutor.cpp:126 [opt]\n        frame #19: 0x0000000101435465 ep-engine_ep_unit_tests`folly::CPUThreadPoolExecutor::~CPUThreadPoolExecutor() [inlined] folly::CPUThreadPoolExecutor::~CPUThreadPoolExecutor(this\u003d0x000000010bf8de00) at CPUThreadPoolExecutor.cpp:124 [opt]\n        frame #20: 0x0000000101435459 ep-engine_ep_unit_tests`folly::CPUThreadPoolExecutor::~CPUThreadPoolExecutor(this\u003d0x000000010bf8de00) at CPUThreadPoolExecutor.cpp:124 [opt]\n        frame #21: 0x000000010023240a ep-engine_ep_unit_tests`FollyExecutorPool::~FollyExecutorPool(this\u003d0x000000010b7eed40) at folly_executorpool.cc:757 [opt]\n        frame #22: 0x00000001002325ee ep-engine_ep_unit_tests`FollyExecutorPool::~FollyExecutorPool(this\u003d0x000000010b7eed40) at folly_executorpool.cc:751 [opt]\n        frame #23: 0x00007fff7409a3cf libsystem_c.dylib`__cxa_finalize_ranges + 319\n        frame #24: 0x00007fff7409a6b3 libsystem_c.dylib`exit + 55\n\nAddress _this_ with a somewhat belt-and-braces approach - also\nmanually shutdown the ExecutorPool in DcpConnMapTest::TearDown - as is\ndone in other tests.\n\nChange-Id: I87f13bc3a7cdf616b52d18502dd724fcf630d3b9\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"868aec85a61b79a13928026ca62c9e8852301375","is_merged_in_target_branch":false,"change_id":"I1953129cce0d05a42f0790724c470e38b2dd0701","change_number":152326,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/master","description":"Rebase"},"5c90329b8cb4e8fddd34fafa5252e2b06646fd7e":{"kind":"REWORK","_number":6,"created":"2021-04-29 06:22:48.000000000","uploader":{"_account_id":1000002,"name":"Trond Norbye","display_name":"Trond","email":"trond.norbye@couchbase.com","username":"trond","avatars":[{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/30/152230/6","fetch":{"anonymous http":{"url":"https://review.couchbase.org/kv_engine","ref":"refs/changes/30/152230/6","commands":{"Branch":"git fetch https://review.couchbase.org/kv_engine refs/changes/30/152230/6 \u0026\u0026 git checkout -b change-152230 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/kv_engine refs/changes/30/152230/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/kv_engine refs/changes/30/152230/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/kv_engine refs/changes/30/152230/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/kv_engine refs/changes/30/152230/6","Reset To":"git fetch https://review.couchbase.org/kv_engine refs/changes/30/152230/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5b78cd95c0e5326c470de223378ec41b57acb92b","subject":"MB-45378: Fix static init fiasco with ExecutorPool \u0026 phosphor"}],"author":{"name":"Dave Rigby","email":"daver@couchbase.com","date":"2021-04-27 15:34:57.000000000","tz":60},"committer":{"name":"Trond Norbye","email":"trond.norbye@couchbase.com","date":"2021-04-29 06:22:48.000000000","tz":0},"subject":"MB-45378: Fix static init fiasco with ExecutorPool \u0026 GoogleLog","message":"MB-45378: Fix static init fiasco with ExecutorPool \u0026 GoogleLog\n\nWhen converting platform to be statically linked, a crash is seen\nduring shutdown of ep-engine_ep_unit_tests.DcpConnMapTest tests on\nMSVC. The ExecutorPool is consuming messages on the background threads\n(I believe to coordinate shutdown), and during that it attempts to log\na warning message to Google Log.\n\nThe cause of the crash is a change in the static initialisation (and\ndeinitialization) order - the GoogleLog singleton instance as used\ninternally by Folly is deinitialized before ExecutorPool singleton. As\nsuch, when the ExecutorPool singleton is shutting down, it attempts to\nlog a message to a non-existant GLog instance and a nullptr is\ndeferenced.\n\nFix by changing ExecutorPool singleton to use C++11 magic static\n(Meyer singleton); which ensures it is destructed earlier, before\nGLog.\n\nAdditionally, while the above is sufficient to fix this issue on macOS\nCatalina, on Mojave this introduces _another_ crash as some Folly\nhazard pointer singletons appear to already have been destructed and\nthe following crash is seen:\n\n    * thread #1, queue \u003d \u0027com.apple.main-thread\u0027, stop reason \u003d signal SIGABRT\n      * frame #0: 0x00007fff7412f2c6 libsystem_kernel.dylib`__pthread_kill + 10\n        frame #1: 0x00007fff741eabf1 libsystem_pthread.dylib`pthread_kill + 284\n        frame #2: 0x00007fff740996a6 libsystem_c.dylib`abort + 127\n        frame #3: 0x00007fff741a8077 libsystem_malloc.dylib`malloc_vreport + 545\n        frame #4: 0x00007fff741a7e38 libsystem_malloc.dylib`malloc_report + 151\n        frame #5: 0x00007fff73ff3cf9 libdyld.dylib`_tlv_atexit + 155\n        frame #6: 0x000000010143cb2d ep-engine_ep_unit_tests`folly::SingletonThreadLocal\u003cfolly::hazptr_tc\u003cstd::__1::atomic\u003e, folly::hazptr_tc_tls_tag, folly::detail::DefaultMake\u003cfolly::hazptr_tc\u003cstd::__1::atomic\u003e \u003e, folly::hazptr_tc_tls_tag\u003e::getSlow(cache\u003d0x000000010b5606b8) at SingletonThreadLocal.h:157 [opt]\n        frame #7: 0x0000000101437a19 ep-engine_ep_unit_tests`folly::UnboundedBlockingQueue\u003cfolly::CPUThreadPoolExecutor::CPUTask\u003e::add(folly::CPUThreadPoolExecutor::CPUTask) [inlined] folly::SingletonThreadLocal\u003cfolly::hazptr_tc\u003cstd::__1::atomic\u003e, folly::hazptr_tc_tls_tag, folly::detail::DefaultMake\u003cfolly::hazptr_tc\u003cstd::__1::atomic\u003e \u003e, folly::hazptr_tc_tls_tag\u003e::get() at SingletonThreadLocal.h:167 [opt]\n        frame #8: 0x0000000101437a08 ep-engine_ep_unit_tests`folly::UnboundedBlockingQueue\u003cfolly::CPUThreadPoolExecutor::CPUTask\u003e::add(folly::CPUThreadPoolExecutor::CPUTask) [inlined] folly::hazptr_tc\u003cstd::__1::atomic\u003e\u0026 folly::hazptr_tc_tls\u003cstd::__1::atomic\u003e() at HazptrThrLocal.h:166 [opt]\n        frame #9: 0x0000000101437a08 ep-engine_ep_unit_tests`folly::UnboundedBlockingQueue\u003cfolly::CPUThreadPoolExecutor::CPUTask\u003e::add(folly::CPUThreadPoolExecutor::CPUTask) at HazptrHolder.h:64 [opt]\n        frame #10: 0x0000000101437a08 ep-engine_ep_unit_tests`folly::UnboundedBlockingQueue\u003cfolly::CPUThreadPoolExecutor::CPUTask\u003e::add(folly::CPUThreadPoolExecutor::CPUTask) [inlined] folly::hazptr_holder\u003cstd::__1::atomic\u003e::hazptr_holder(this\u003d\u003cunavailable\u003e, domain\u003d\u003cunavailable\u003e) at HazptrHolder.h:61 [opt]\n        frame #11: 0x0000000101437a08 ep-engine_ep_unit_tests`folly::UnboundedBlockingQueue\u003cfolly::CPUThreadPoolExecutor::CPUTask\u003e::add(folly::CPUThreadPoolExecutor::CPUTask) at UnboundedQueue.h:374 [opt]\n        frame #12: 0x00000001014379e7 ep-engine_ep_unit_tests`folly::UnboundedBlockingQueue\u003cfolly::CPUThreadPoolExecutor::CPUTask\u003e::add(folly::CPUThreadPoolExecutor::CPUTask) [inlined] folly::UnboundedQueue\u003cfolly::CPUThreadPoolExecutor::CPUTask, false, false, false, 6ul, 7ul, std::__1::atomic\u003e::enqueue(this\u003d0x00007ffeefbff770, arg\u003d0x00007ffeefbff690) at UnboundedQueue.h:271 [opt]\n        frame #13: 0x00000001014379e7 ep-engine_ep_unit_tests`folly::UnboundedBlockingQueue\u003cfolly::CPUThreadPoolExecutor::CPUTask\u003e::add(this\u003d0x000000010ba00f80, item\u003dCPUTask @ 0x00007ffeefbff690) at UnboundedBlockingQueue.h:31 [opt]\n        frame #14: 0x0000000101437bfc ep-engine_ep_unit_tests`folly::BlockingQueue\u003cfolly::CPUThreadPoolExecutor::CPUTask\u003e::addWithPriority(this\u003d0x000000010ba00f80, item\u003dCPUTask @ 0x00007ffeefbff770, (null)\u003d\u003cunavailable\u003e) at BlockingQueue.h:57 [opt]\n        frame #15: 0x0000000101436b00 ep-engine_ep_unit_tests`folly::CPUThreadPoolExecutor::stopThreads(this\u003d0x000000010bf8de00, n\u003d2) at CPUThreadPoolExecutor.cpp:281 [opt]\n        frame #16: 0x000000010144bae3 ep-engine_ep_unit_tests`folly::ThreadPoolExecutor::stop() [inlined] folly::ThreadPoolExecutor::removeThreads(this\u003d\u003cunavailable\u003e, n\u003d\u003cunavailable\u003e) at ThreadPoolExecutor.cpp:233 [opt]\n        frame #17: 0x000000010144bad0 ep-engine_ep_unit_tests`folly::ThreadPoolExecutor::stop(this\u003d0x000000010bf8de00) at ThreadPoolExecutor.cpp:251 [opt]\n        frame #18: 0x00000001014352d4 ep-engine_ep_unit_tests`folly::CPUThreadPoolExecutor::~CPUThreadPoolExecutor(this\u003d0x000000010bf8de00, vtt\u003d0x00000001019fd6c8) at CPUThreadPoolExecutor.cpp:126 [opt]\n        frame #19: 0x0000000101435465 ep-engine_ep_unit_tests`folly::CPUThreadPoolExecutor::~CPUThreadPoolExecutor() [inlined] folly::CPUThreadPoolExecutor::~CPUThreadPoolExecutor(this\u003d0x000000010bf8de00) at CPUThreadPoolExecutor.cpp:124 [opt]\n        frame #20: 0x0000000101435459 ep-engine_ep_unit_tests`folly::CPUThreadPoolExecutor::~CPUThreadPoolExecutor(this\u003d0x000000010bf8de00) at CPUThreadPoolExecutor.cpp:124 [opt]\n        frame #21: 0x000000010023240a ep-engine_ep_unit_tests`FollyExecutorPool::~FollyExecutorPool(this\u003d0x000000010b7eed40) at folly_executorpool.cc:757 [opt]\n        frame #22: 0x00000001002325ee ep-engine_ep_unit_tests`FollyExecutorPool::~FollyExecutorPool(this\u003d0x000000010b7eed40) at folly_executorpool.cc:751 [opt]\n        frame #23: 0x00007fff7409a3cf libsystem_c.dylib`__cxa_finalize_ranges + 319\n        frame #24: 0x00007fff7409a6b3 libsystem_c.dylib`exit + 55\n\nAddress _this_ with a somewhat belt-and-braces approach - also\nmanually shutdown the ExecutorPool in DcpConnMapTest::TearDown - as is\ndone in other tests.\n\nChange-Id: I87f13bc3a7cdf616b52d18502dd724fcf630d3b9\nReviewed-on: http://review.couchbase.org/c/kv_engine/+/152230\nTested-by: Build Bot \u003cbuild@couchbase.com\u003e\nReviewed-by: Richard de Mellow \u003crichard.demellow@couchbase.com\u003e\nReviewed-by: Trond Norbye \u003ctrond.norbye@couchbase.com\u003e\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"5b78cd95c0e5326c470de223378ec41b57acb92b","is_merged_in_target_branch":true,"change_id":"I1953129cce0d05a42f0790724c470e38b2dd0701","change_number":152326,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000002,"name":"Trond Norbye","display_name":"Trond","email":"trond.norbye@couchbase.com","username":"trond","avatars":[{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}},{"label":"Well-Formed","status":"MAY"}]},{"status":"CLOSED"}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Custom-Rule","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Custom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["Custom-Rule"],"failing_atoms":[]}}]}