)]}'
{"engines/ep/src/paging_visitor.h":[{"author":{"_account_id":1004341,"name":"Ben Huddleston","email":"ben.huddleston@couchbase.com","username":"BenHuddleston","avatars":[{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4a99bc598ab0ed23359d8d506b0d4b2c04803957","unresolved":true,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    // The current vbucket that the eviction algorithm is operating on."},{"line_number":125,"context_line":"    // Only valid while inside visitBucket()."},{"line_number":126,"context_line":"    VBucket* currentBucket{nullptr};"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    // The frequency counter threshold that is used to determine whether we"},{"line_number":129,"context_line":"    // should evict items from the hash table."}],"source_content_type":"text/x-csrc","patch_set":3,"id":"598afbdb_b256b667","line":126,"range":{"start_line":126,"start_character":0,"end_line":126,"end_character":5},"updated":"2021-10-20 16:13:42.000000000","message":"I guess it\u0027s more intrusive to change but feels more like this should be a local variable","commit_id":"497483534da27c59b79e35914d65c9a3b8248c55"},{"author":{"_account_id":1004341,"name":"Ben Huddleston","email":"ben.huddleston@couchbase.com","username":"BenHuddleston","avatars":[{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"d551c3d66a49097dc8bc1b936f5dea939069b97e","unresolved":true,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    // The current vbucket that the eviction algorithm is operating on."},{"line_number":125,"context_line":"    // Only valid while inside visitBucket()."},{"line_number":126,"context_line":"    VBucket* currentBucket{nullptr};"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    // The frequency counter threshold that is used to determine whether we"},{"line_number":129,"context_line":"    // should evict items from the hash table."}],"source_content_type":"text/x-csrc","patch_set":3,"id":"555a0eaf_2c34909e","line":126,"range":{"start_line":126,"start_character":0,"end_line":126,"end_character":5},"in_reply_to":"0edbe982_f60a27ce","updated":"2021-10-20 16:19:34.000000000","message":"Fair enough","commit_id":"497483534da27c59b79e35914d65c9a3b8248c55"},{"author":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"d08fd69e05203ea14809a12aa8f8c97e61f704b0","unresolved":true,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    // The current vbucket that the eviction algorithm is operating on."},{"line_number":125,"context_line":"    // Only valid while inside visitBucket()."},{"line_number":126,"context_line":"    VBucket* currentBucket{nullptr};"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    // The frequency counter threshold that is used to determine whether we"},{"line_number":129,"context_line":"    // should evict items from the hash table."}],"source_content_type":"text/x-csrc","patch_set":3,"id":"0edbe982_f60a27ce","line":126,"range":{"start_line":126,"start_character":0,"end_line":126,"end_character":5},"in_reply_to":"598afbdb_b256b667","updated":"2021-10-20 16:17:48.000000000","message":"Unfortunately it cannot be with current structure - basically the VBuckets-level visitor method visitVBucket() calls the visit() method on KVBucket; which in turn calls back into PagingVisitor::visit(StoredValue\u0026) - it is that method which needs to know the current vBucket.\n\n(I did experiment with changing the signature of visit to be visit(VBucket\u0026, StoredValue\u0026) but it was very invasive for the ~dozen or so visitors we have which don\u0027t care about the VBucket, compared to the 2 visitors we have which do.)","commit_id":"497483534da27c59b79e35914d65c9a3b8248c55"}]}