)]}'
{"id":"kv_engine~163783","triplet_id":"kv_engine~master~I340a3e4dc3d9234c4a34866b410fb8295a1c98d1","project":"kv_engine","branch":"master","hashtags":[],"change_id":"I340a3e4dc3d9234c4a34866b410fb8295a1c98d1","subject":"MB-48925 1/3: Don\u0027t extend VBucket lifetime via bg Tasks","status":"MERGED","created":"2021-10-18 13:35:53.000000000","updated":"2021-10-20 17:00:52.000000000","submitted":"2021-10-20 16:10:53.000000000","submitter":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"total_comment_count":3,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"163783-1634746253122-db43a802","meta_rev_id":"1832a2db30e28ef8dcce0e2fa36fda0438e47ef6","_number":163783,"virtual_id_number":163783,"owner":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"all":[{"value":0,"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-10-20 16:10:53.000000000","_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":1003828,"name":"James H","email":"james.harrison@couchbase.com","username":"jameseh96","avatars":[{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"tag":"autogenerated:gerrit:merged","value":0,"date":"2021-10-20 16:10:53.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1003828,"name":"James H","email":"james.harrison@couchbase.com","username":"jameseh96","avatars":[{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-10-20 16:10:53.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-10-20 16:10:53.000000000","_account_id":1003828,"name":"James H","email":"james.harrison@couchbase.com","username":"jameseh96","avatars":[{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]}],"values":{"-2":"Do not submit","-1":"I would prefer that you didn\u0027t submit this"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Well-Formed":{"all":[{"value":0,"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":1003828,"name":"James H","email":"james.harrison@couchbase.com","username":"jameseh96","avatars":[{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]}],"values":{"-1":"Commit is not well-formed"," 0":"Well-formedness not checked","+1":"Commit is well-formed"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":1000002,"name":"Trond Norbye","display_name":"Trond","email":"trond.norbye@couchbase.com","username":"trond","avatars":[{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1004341,"name":"Ben Huddleston","email":"ben.huddleston@couchbase.com","username":"BenHuddleston","avatars":[{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1001547,"name":"Dan Owen","email":"owend@couchbase.com","username":"owend","avatars":[{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1004059,"name":"Paolo Cocchi","email":"paolo.cocchi@couchbase.com","username":"paolococchi","avatars":[{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1001546,"name":"Jim Walker","email":"jim@couchbase.com","username":"jim","avatars":[{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1002319,"name":"Dave Finlay","email":"dave.finlay@couchbase.com","username":"dave-finlay","avatars":[{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"Trond Norbye","display_name":"Trond","email":"trond.norbye@couchbase.com","username":"trond","avatars":[{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1001546,"name":"Jim Walker","email":"jim@couchbase.com","username":"jim","avatars":[{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1001547,"name":"Dan Owen","email":"owend@couchbase.com","username":"owend","avatars":[{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1002319,"name":"Dave Finlay","email":"dave.finlay@couchbase.com","username":"dave-finlay","avatars":[{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1003828,"name":"James H","email":"james.harrison@couchbase.com","username":"jameseh96","avatars":[{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1004059,"name":"Paolo Cocchi","email":"paolo.cocchi@couchbase.com","username":"paolococchi","avatars":[{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1004341,"name":"Ben Huddleston","email":"ben.huddleston@couchbase.com","username":"BenHuddleston","avatars":[{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-10-19 14:27:39.000000000","updated_by":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-10-19 15:27:41.000000000","updated_by":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":1002319,"name":"Dave Finlay","email":"dave.finlay@couchbase.com","username":"dave-finlay","avatars":[{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/aa50dbeeeae1f0a9a777fcf4b80c4fb9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2021-10-19 15:27:41.000000000","updated_by":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":1001546,"name":"Jim Walker","email":"jim@couchbase.com","username":"jim","avatars":[{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a06928c0be234da34bb6fc731e04a0d7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2021-10-19 15:27:41.000000000","updated_by":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":1004059,"name":"Paolo Cocchi","email":"paolo.cocchi@couchbase.com","username":"paolococchi","avatars":[{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2021-10-19 15:27:41.000000000","updated_by":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":1001547,"name":"Dan Owen","email":"owend@couchbase.com","username":"owend","avatars":[{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0761a726bc37606caee7ec6bf566deca.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2021-10-19 15:27:41.000000000","updated_by":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":1003828,"name":"James H","email":"james.harrison@couchbase.com","username":"jameseh96","avatars":[{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2021-10-19 15:27:41.000000000","updated_by":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":1004341,"name":"Ben Huddleston","email":"ben.huddleston@couchbase.com","username":"BenHuddleston","avatars":[{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2021-10-19 15:27:41.000000000","updated_by":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2021-10-19 15:27:41.000000000","updated_by":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":1000002,"name":"Trond Norbye","display_name":"Trond","email":"trond.norbye@couchbase.com","username":"trond","avatars":[{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"}],"messages":[{"id":"eeda8b6cc15c483a3f7352ab62d17f088aa2a447","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-10-18 13:35:53.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2533e5acbcaaea0f3bc690296515cd1b735eb894","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-10-18 16:13:04.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"4c6b360987e709a57d0ab076fa25d10ba2232ff7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-10-19 10:18:46.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"6a6343a847dd08b53c0ad6b8439e03144c9d78eb","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2021-10-19 14:27:39.000000000","message":"Patch Set 3: Verified-1\n\nBuild Failed \n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_tidy-master/13557/ : FAILURE\n\nclang-tidy found the following problems:\n\n\u003cpre\u003e\n/home/couchbase/jenkins/workspace/kv_engine-clang_tidy-master/build-kv_engine-clang-tidy/tlm/deps/folly.exploded/include/folly/portability/GMock.h:32:10: error: \"gmock/gmock.h\" file not found [clang-diagnostic-error]\n#include \u003cgmock/gmock.h\u003e\n         ^\n\n\u003c/pre\u003e ( http://cv.jenkins.couchbase.com/job/kv_engine-clang_tidy-master/13557/ )\n\nCompile error at /home/couchbase/jenkins/workspace/kv_engine-clang_tidy-master/build-kv_engine-clang-tidy/tlm/deps/folly.exploded/include/folly/portability/GMock.h:32:10:\nerror: \"gmock/gmock.h\" file not found [clang-diagnostic-error]\n ( http://cv.jenkins.couchbase.com/job/kv_engine-clang_tidy-master/13557/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.threadsanitizer/job/master/16101/ : FAILURE\n\nFailure of an engine_testapp test:\n\n\u003cpre\u003e\nRunning [0016/0093]: test dcp replica stream one collection...../kv_engine/engines/ep/tests/ep_testsuite_dcp.cc:715 Test failed: `\" (Expected `118\", got `94\" - Buffer Size did not get set correctly)\n[2021-10-19T14:12:39.597Z] (23624 ms) FAIL\n\u003c/pre\u003e\n ( http://cv.jenkins.couchbase.com/job/kv_engine.threadsanitizer/job/master/16101/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-windows-master/41249/ : FAILURE\n\nFailure of an engine_testapp test:\n\n\u003cpre\u003e\nRunning [0128/0159]: test add with item_eviction...(9 ms) SKIPPED\n\n\n99% tests passed, 1 tests failed out of 413\n\nTotal Test time (real) \u003d 666.31 sec\n\nThe following tests FAIL\n\u003c/pre\u003e\n ( http://cv.jenkins.couchbase.com/job/kv_engine-windows-master/41249/ )\n\nTimeout of a CTest test 413/413 Test #264: ep_testsuite.value_eviction.comp_passive ......................................................................................} ( http://cv.jenkins.couchbase.com/job/kv_engine-windows-master/41249/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_analyzer-master/35046/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_format_9/12356/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.libFuzzer/job/master/3189/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux-CE/job/master/15166/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.macos/job/master/14324/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.aarch64-linux/job/master/3258/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux/job/master/15451/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/23487/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"3b3b27934f4552a8af4d51ffcbcad434fc1ecee7","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2021-10-19 14:51:48.000000000","message":"Patch Set 3:\n\nBuild Failed \n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_tidy-master/13557/ : FAILURE\n\nclang-tidy found the following problems:\n\n\u003cpre\u003e\n/home/couchbase/jenkins/workspace/kv_engine-clang_tidy-master/build-kv_engine-clang-tidy/tlm/deps/folly.exploded/include/folly/portability/GMock.h:32:10: error: \"gmock/gmock.h\" file not found [clang-diagnostic-error]\n#include \u003cgmock/gmock.h\u003e\n         ^\n\n\u003c/pre\u003e ( http://cv.jenkins.couchbase.com/job/kv_engine-clang_tidy-master/13557/ )\n\nCompile error at /home/couchbase/jenkins/workspace/kv_engine-clang_tidy-master/build-kv_engine-clang-tidy/tlm/deps/folly.exploded/include/folly/portability/GMock.h:32:10:\nerror: \"gmock/gmock.h\" file not found [clang-diagnostic-error]\n ( http://cv.jenkins.couchbase.com/job/kv_engine-clang_tidy-master/13557/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_analyzer-master/35046/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-clang_format_9/12356/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.libFuzzer/job/master/3189/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux-CE/job/master/15166/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.macos/job/master/14324/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.aarch64-linux/job/master/3258/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.linux/job/master/15451/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.ASan-UBSan/job/master/23487/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-windows-master/41251/ : SUCCESS\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine.threadsanitizer/job/master/16103/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"7b3bbf26cca82d4b482d4273f8b07244fdb89b20","author":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-10-19 15:27:41.000000000","message":"Patch Set 3: Verified+1\n\nOverriding Verified - clang_tidy failure is due to header files not handled by clang-tidy.","accounts_in_message":[],"_revision_number":3},{"id":"ea9d7a9061ba8da0946dcbed7a79ea7241b09348","tag":"autogenerated:gerrit:deleteVote","author":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-10-20 08:13:21.000000000","message":"Removed Verified-1 by Build Bot \u003cbuild@couchbase.com\u003e\n","accounts_in_message":[],"_revision_number":3},{"id":"705b5a47db0efadbd69e08ac6d1db69b360e9a29","author":{"_account_id":1004368,"name":"Richard de Mellow","email":"richard.demellow@couchbase.com","username":"rdemellow","avatars":[{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/35c97da872c07458f5e5bc4938b2489f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-10-20 10:08:46.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"dea066aa3ea1d74f9ec4b4252803661ef8fe6006","author":{"_account_id":1003828,"name":"James H","email":"james.harrison@couchbase.com","username":"jameseh96","avatars":[{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-10-20 16:05:07.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"72c87b57b053b1986c6ec4ffa456d51ad9124a36","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-10-20 16:10:53.000000000","message":"Change has been successfully cherry-picked as db499ba5c02fdedb2b1c64ab13c93819d293bd90 by Dave Rigby","accounts_in_message":[],"_revision_number":4},{"id":"75d1b95db2ddf2cbf06c8050e3672f38e366276b","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2021-10-20 16:12:22.000000000","message":"Patch Set 4:\n\nBuild Started http://cv.jenkins.couchbase.com/job/kv_engine-post-commit-master/9301/ (1/2)","accounts_in_message":[],"_revision_number":4},{"id":"4a99bc598ab0ed23359d8d506b0d4b2c04803957","author":{"_account_id":1004341,"name":"Ben Huddleston","email":"ben.huddleston@couchbase.com","username":"BenHuddleston","avatars":[{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-10-20 16:13:42.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"e9152592b59343a25658d55c0ab44d889bd3317d","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2021-10-20 16:17:19.000000000","message":"Patch Set 4:\n\nBuild Started http://cv.jenkins.couchbase.com/job/kv_engine-post-commit-TSan-master/6146/ (2/2)","accounts_in_message":[],"_revision_number":4},{"id":"d08fd69e05203ea14809a12aa8f8c97e61f704b0","author":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-10-20 16:17:48.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"d551c3d66a49097dc8bc1b936f5dea939069b97e","author":{"_account_id":1004341,"name":"Ben Huddleston","email":"ben.huddleston@couchbase.com","username":"BenHuddleston","avatars":[{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2021-10-20 16:19:34.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"1832a2db30e28ef8dcce0e2fa36fda0438e47ef6","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000011,"name":"Build Bot","email":"build@couchbase.com","username":"buildbot","avatars":[{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0ba35a43c05d6329d9b2136bab05a733.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2021-10-20 17:00:52.000000000","message":"Patch Set 4:\n\nBuild Unstable \n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-post-commit-TSan-master/6146/ : UNSTABLE\n\nFailure of a testrunner test ( http://cv.jenkins.couchbase.com/job/kv_engine-post-commit-TSan-master/6146/ )\n\nERROR: do_warmup_100k (memcapable.WarmUpMemcachedTest)\n ( http://cv.jenkins.couchbase.com/job/kv_engine-post-commit-TSan-master/6146/ )\n\nhttp://cv.jenkins.couchbase.com/job/kv_engine-post-commit-master/9301/ : SUCCESS\u0027","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"db499ba5c02fdedb2b1c64ab13c93819d293bd90","revisions":{"c0608a23d580106f21cd3a56cbbeb328b5d5ae82":{"kind":"REWORK","_number":1,"created":"2021-10-18 13:35:53.000000000","uploader":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/83/163783/1","fetch":{"anonymous http":{"url":"https://review.couchbase.org/kv_engine","ref":"refs/changes/83/163783/1","commands":{"Branch":"git fetch https://review.couchbase.org/kv_engine refs/changes/83/163783/1 \u0026\u0026 git checkout -b change-163783 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/kv_engine refs/changes/83/163783/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/kv_engine refs/changes/83/163783/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/kv_engine refs/changes/83/163783/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/kv_engine refs/changes/83/163783/1","Reset To":"git fetch https://review.couchbase.org/kv_engine refs/changes/83/163783/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"fec0b98691daa4662694591f642652f59c5680cb","subject":"MB-47386: Change default max_checkpoints from 2 to 10"}],"author":{"name":"Dave Rigby","email":"daver@couchbase.com","date":"2021-10-15 16:09:08.000000000","tz":60},"committer":{"name":"Dave Rigby","email":"daver@couchbase.com","date":"2021-10-18 13:35:32.000000000","tz":60},"subject":"MB-48925 1/3: Don\u0027t extend VBucket lifetime via bg Tasks","message":"MB-48925 1/3: Don\u0027t extend VBucket lifetime via bg Tasks\n\nDuring bucket shutdown we intermittently see an exception thrown\nduring task scheduling on a background NonIO thread, which crashes the\nmemcached process.\n\n+Analysis+\n\nBug is as follows. Starting at the main thread which is deleting the Bucket (Thread 1):\n\n    (gdb) bt\n    ...\n    #10 0x0000000000649bf3 in FollyExecutorPool::schedule(std::shared_ptr\u003cGlobalTask\u003e) () at /c++/10.2.0/new:175\n    #11 0x000000000084271b in EPVBucket::scheduleDeferredDeletion(EventuallyPersistentEngine\u0026) () at /c++/10.2.0/ext/atomicity.h:100\n    #12 0x00000000006dfe7a in VBucket::DeferredDeleter::operator()(VBucket*) const () at kv_engine/engines/ep/src/vbucket.cc:3990\n    #13 0x000000000086f874 in std::_Sp_counted_deleter\u003cEPVBucket*, VBucket::DeferredDeleter, ...\u003e::_M_dispose () at /c++/10.2.0/bits/shared_ptr_base.h:453\n    ...\n    #18 std::shared_ptr\u003cVBucket\u003e::~shared_ptr (this\u003d0x7b44000515d0, __in_chrg\u003d\u003coptimized out\u003e) at /c++/10.2.0/bits/shared_ptr.h:121\n    #19 PagingVisitor::~PagingVisitor (this\u003d0x7b4400051540, __in_chrg\u003d\u003coptimized out\u003e) at kv_engine/engines/ep/src/paging_visitor.h:39\n    ...\n    #31 std::__shared_ptr\u003cGlobalTask, (__gnu_cxx::_Lock_policy)2\u003e::reset () at /c++/10.2.0/bits/shared_ptr_base.h:1301\n    #32 EventuallyPersistentEngine::waitForTasks(std::vector\u003cstd::shared_ptr\u003cGlobalTask\u003e, std::allocator\u003cstd::shared_ptr\u003cGlobalTask\u003e \u003e \u003e\u0026) () at kv_engine/engines/ep/src/ep_engine.cc:6752\n    #33 0x000000000082396f in EventuallyPersistentEngine::destroyInner(bool) () at kv_engine/engines/ep/src/ep_engine.cc:2135\n\n1. PagingVisitor is still in existence running after\n   `EventuallyPersistentEngine::destroyInner` - see frame #19. This is\n   because all tasks belonging to bucket were returned from\n   unregisterTaskable() just before.\n\n2. PagingVisitor (via VBCBAdaptor) is destroyed, it decrements the\n   refcount on the shared_ptr\u003cVBucket\u003e it owns - see frame #18.\n\n3. That is the last reference to the VBucket, which results in\n   VBucket::DeferredDeleter being invoked which in turn schedules a\n   task to delete the VBucket (disk and memory) in the background -\n   see frame #11.\n\nWe see the schedule\u0027s lambda happen on the SchedulerPool0 thread (T:35):\n\n    Thread 35 \"SchedulerPool0\" hit Catchpoint 1 (exception thrown), __cxxabiv1::__cxa_throw (..., tinfo\u003d0x10c4ec8 \u003ctypeinfo for std::out_of_range@@GLIBCXX_3.4\u003e, ...) at /tmp/deploy/objdir/../gcc-10.2.0/libstdc++-v3/libsupc++/eh_throw.cc:80\n    (gdb) bt\n    #1  0x00007ffff4cad7d2 in std::__throw_out_of_range (__s\u003d__s@entry\u003d0xcc68e6 \"_Map_base::at\") at /tmp/deploy/objdir/../gcc-10.2.0/libstdc++-v3/src/c++11/functexcept.cc:82\n    ...\n    #3  0x00000000005504ee in std::unordered_map\u003c...\u003e::at (__k\u003d@0x7fffe83a8f88: 0x7b7400000848, this\u003d0x7b1000005580) at /c++/10.2.0/bits/unordered_map.h:1000\n    #4  FollyExecutorPool::State::scheduleTask (this\u003d..., executor\u003d..., pool\u003d..., task\u003d...) at kv_engine/executor/folly_executorpool.cc:415\n    ...\n    #8  folly::EventBase::runInEventBaseThreadAndWait(...) at folly/io/async/EventBase.cpp:671\n    ...\n\nIn FollyExecutorPool::State::scheduleTask (frame #3) we attempt to\nlookup the Taskable (Bucket) in the ExecutorPool\u0027s map, however given\nits already been unregistered, the taskable is not found an the\nstd::out_of_range exception is thrown.\n\nThis is a lifetime issue. We have VBucket objects potentially being\nkept alive longer than their expected lifetime by virtue of background\ntasks having shared ownership of them - and those background tasks\noutlive the lifetime of their parent object (KVBucket), and crucially\npast when the owning Bucket is unregistered with the ExecutorPool and\ncan no longer schedule tasks.\n\nWhen it then _does+ attempt to schedule a task against an unregistered\n(and deleted) Taskable; we see the crash.\n\n+Solution+\n\nThere\u0027s arguably two problems which should be addressed (although\ntechnically only one of the two is required to encounter this crash):\n\n1. Background tasks owning VBuckets when they are not executing.\n2. Background tasks outliving their associated Taskable (aka Bucket).\n\nThis patch addresses the critical issue of (1) - we remove the\n(shared) ownership of VBucket from the background tasks which\nprevioulsy had it - both PagingVisitor which is the problematic class\nin this scenario, but also in the other background Tasks which\npotentially have the same problem.\n\nThe 2nd patch will tighten up the API for visiting VBuckets, so\nvisitors are not passed a VBucketPtr, but instead VBucket\u0026 which\nreduces the chance of similar problems happening in future.\n\nThe 3rd patch will adddress Background Taks outliving their Taskable.\n\nChange-Id: I340a3e4dc3d9234c4a34866b410fb8295a1c98d1\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"fec0b98691daa4662694591f642652f59c5680cb","is_merged_in_target_branch":true,"change_id":"Iccf03688b143ae6516f317536ba99a1d60f18dfb","change_number":163334,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/master"},"731aac57a53bb7f46760fd077758ac64f9e083ab":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2021-10-18 16:13:04.000000000","uploader":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/83/163783/2","fetch":{"anonymous http":{"url":"https://review.couchbase.org/kv_engine","ref":"refs/changes/83/163783/2","commands":{"Branch":"git fetch https://review.couchbase.org/kv_engine refs/changes/83/163783/2 \u0026\u0026 git checkout -b change-163783 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/kv_engine refs/changes/83/163783/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/kv_engine refs/changes/83/163783/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/kv_engine refs/changes/83/163783/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/kv_engine refs/changes/83/163783/2","Reset To":"git fetch https://review.couchbase.org/kv_engine refs/changes/83/163783/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"326f424b0aadd0e51ad59007724ae2a34400f4ad","subject":"MB-47604: Check secondary callbacks not made by primary for getRange"}],"author":{"name":"Dave Rigby","email":"daver@couchbase.com","date":"2021-10-15 16:09:08.000000000","tz":60},"committer":{"name":"Dave Rigby","email":"daver@couchbase.com","date":"2021-10-18 16:11:31.000000000","tz":60},"subject":"MB-48925 1/3: Don\u0027t extend VBucket lifetime via bg Tasks","message":"MB-48925 1/3: Don\u0027t extend VBucket lifetime via bg Tasks\n\nDuring bucket shutdown we intermittently see an exception thrown\nduring task scheduling on a background NonIO thread, which crashes the\nmemcached process.\n\n+Analysis+\n\nBug is as follows. Starting at the main thread which is deleting the Bucket (Thread 1):\n\n    (gdb) bt\n    ...\n    #10 0x0000000000649bf3 in FollyExecutorPool::schedule(std::shared_ptr\u003cGlobalTask\u003e) () at /c++/10.2.0/new:175\n    #11 0x000000000084271b in EPVBucket::scheduleDeferredDeletion(EventuallyPersistentEngine\u0026) () at /c++/10.2.0/ext/atomicity.h:100\n    #12 0x00000000006dfe7a in VBucket::DeferredDeleter::operator()(VBucket*) const () at kv_engine/engines/ep/src/vbucket.cc:3990\n    #13 0x000000000086f874 in std::_Sp_counted_deleter\u003cEPVBucket*, VBucket::DeferredDeleter, ...\u003e::_M_dispose () at /c++/10.2.0/bits/shared_ptr_base.h:453\n    ...\n    #18 std::shared_ptr\u003cVBucket\u003e::~shared_ptr (this\u003d0x7b44000515d0, __in_chrg\u003d\u003coptimized out\u003e) at /c++/10.2.0/bits/shared_ptr.h:121\n    #19 PagingVisitor::~PagingVisitor (this\u003d0x7b4400051540, __in_chrg\u003d\u003coptimized out\u003e) at kv_engine/engines/ep/src/paging_visitor.h:39\n    ...\n    #31 std::__shared_ptr\u003cGlobalTask, (__gnu_cxx::_Lock_policy)2\u003e::reset () at /c++/10.2.0/bits/shared_ptr_base.h:1301\n    #32 EventuallyPersistentEngine::waitForTasks(std::vector\u003cstd::shared_ptr\u003cGlobalTask\u003e, std::allocator\u003cstd::shared_ptr\u003cGlobalTask\u003e \u003e \u003e\u0026) () at kv_engine/engines/ep/src/ep_engine.cc:6752\n    #33 0x000000000082396f in EventuallyPersistentEngine::destroyInner(bool) () at kv_engine/engines/ep/src/ep_engine.cc:2135\n\n1. PagingVisitor is still in existence running after\n   `EventuallyPersistentEngine::destroyInner` - see frame #19. This is\n   because all tasks belonging to bucket were returned from\n   unregisterTaskable() just before.\n\n2. PagingVisitor (via VBCBAdaptor) is destroyed, it decrements the\n   refcount on the shared_ptr\u003cVBucket\u003e it owns - see frame #18.\n\n3. That is the last reference to the VBucket, which results in\n   VBucket::DeferredDeleter being invoked which in turn schedules a\n   task to delete the VBucket (disk and memory) in the background -\n   see frame #11.\n\nWe see the schedule\u0027s lambda happen on the SchedulerPool0 thread (T:35):\n\n    Thread 35 \"SchedulerPool0\" hit Catchpoint 1 (exception thrown), __cxxabiv1::__cxa_throw (..., tinfo\u003d0x10c4ec8 \u003ctypeinfo for std::out_of_range@@GLIBCXX_3.4\u003e, ...) at /tmp/deploy/objdir/../gcc-10.2.0/libstdc++-v3/libsupc++/eh_throw.cc:80\n    (gdb) bt\n    #1  0x00007ffff4cad7d2 in std::__throw_out_of_range (__s\u003d__s@entry\u003d0xcc68e6 \"_Map_base::at\") at /tmp/deploy/objdir/../gcc-10.2.0/libstdc++-v3/src/c++11/functexcept.cc:82\n    ...\n    #3  0x00000000005504ee in std::unordered_map\u003c...\u003e::at (__k\u003d@0x7fffe83a8f88: 0x7b7400000848, this\u003d0x7b1000005580) at /c++/10.2.0/bits/unordered_map.h:1000\n    #4  FollyExecutorPool::State::scheduleTask (this\u003d..., executor\u003d..., pool\u003d..., task\u003d...) at kv_engine/executor/folly_executorpool.cc:415\n    ...\n    #8  folly::EventBase::runInEventBaseThreadAndWait(...) at folly/io/async/EventBase.cpp:671\n    ...\n\nIn FollyExecutorPool::State::scheduleTask (frame #3) we attempt to\nlookup the Taskable (Bucket) in the ExecutorPool\u0027s map, however given\nits already been unregistered, the taskable is not found an the\nstd::out_of_range exception is thrown.\n\nThis is a lifetime issue. We have VBucket objects potentially being\nkept alive longer than their expected lifetime by virtue of background\ntasks having shared ownership of them - and those background tasks\noutlive the lifetime of their parent object (KVBucket), and crucially\npast when the owning Bucket is unregistered with the ExecutorPool and\ncan no longer schedule tasks.\n\nWhen it then _does+ attempt to schedule a task against an unregistered\n(and deleted) Taskable; we see the crash.\n\n+Solution+\n\nThere\u0027s arguably two problems which should be addressed (although\ntechnically only one of the two is required to encounter this crash):\n\n1. Background tasks owning VBuckets when they are not executing.\n2. Background tasks outliving their associated Taskable (aka Bucket).\n\nThis patch addresses the critical issue of (1) - we remove the\n(shared) ownership of VBucket from the background tasks which\nprevioulsy had it - both PagingVisitor which is the problematic class\nin this scenario, but also in the other background Tasks which\npotentially have the same problem.\n\nThe 2nd patch will tighten up the API for visiting VBuckets, so\nvisitors are not passed a VBucketPtr, but instead VBucket\u0026 which\nreduces the chance of similar problems happening in future.\n\nThe 3rd patch will adddress Background Taks outliving their Taskable.\n\nChange-Id: I340a3e4dc3d9234c4a34866b410fb8295a1c98d1\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"326f424b0aadd0e51ad59007724ae2a34400f4ad","is_merged_in_target_branch":true,"change_id":"I78adbb3eca48f3505aeec1119eb0f6e5002725ec","change_number":163478,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/master"},"497483534da27c59b79e35914d65c9a3b8248c55":{"kind":"REWORK","_number":3,"created":"2021-10-19 10:18:46.000000000","uploader":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/83/163783/3","fetch":{"anonymous http":{"url":"https://review.couchbase.org/kv_engine","ref":"refs/changes/83/163783/3","commands":{"Branch":"git fetch https://review.couchbase.org/kv_engine refs/changes/83/163783/3 \u0026\u0026 git checkout -b change-163783 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/kv_engine refs/changes/83/163783/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/kv_engine refs/changes/83/163783/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/kv_engine refs/changes/83/163783/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/kv_engine refs/changes/83/163783/3","Reset To":"git fetch https://review.couchbase.org/kv_engine refs/changes/83/163783/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"326f424b0aadd0e51ad59007724ae2a34400f4ad","subject":"MB-47604: Check secondary callbacks not made by primary for getRange"}],"author":{"name":"Dave Rigby","email":"daver@couchbase.com","date":"2021-10-15 16:09:08.000000000","tz":60},"committer":{"name":"Dave Rigby","email":"daver@couchbase.com","date":"2021-10-19 10:18:27.000000000","tz":60},"subject":"MB-48925 1/3: Don\u0027t extend VBucket lifetime via bg Tasks","message":"MB-48925 1/3: Don\u0027t extend VBucket lifetime via bg Tasks\n\nDuring bucket shutdown we intermittently see an exception thrown\nduring task scheduling on a background NonIO thread, which crashes the\nmemcached process.\n\n+Analysis+\n\nBug is as follows. Starting at the main thread which is deleting the Bucket (Thread 1):\n\n    (gdb) bt\n    ...\n    #10 0x0000000000649bf3 in FollyExecutorPool::schedule(std::shared_ptr\u003cGlobalTask\u003e) () at /c++/10.2.0/new:175\n    #11 0x000000000084271b in EPVBucket::scheduleDeferredDeletion(EventuallyPersistentEngine\u0026) () at /c++/10.2.0/ext/atomicity.h:100\n    #12 0x00000000006dfe7a in VBucket::DeferredDeleter::operator()(VBucket*) const () at kv_engine/engines/ep/src/vbucket.cc:3990\n    #13 0x000000000086f874 in std::_Sp_counted_deleter\u003cEPVBucket*, VBucket::DeferredDeleter, ...\u003e::_M_dispose () at /c++/10.2.0/bits/shared_ptr_base.h:453\n    ...\n    #18 std::shared_ptr\u003cVBucket\u003e::~shared_ptr (this\u003d0x7b44000515d0, __in_chrg\u003d\u003coptimized out\u003e) at /c++/10.2.0/bits/shared_ptr.h:121\n    #19 PagingVisitor::~PagingVisitor (this\u003d0x7b4400051540, __in_chrg\u003d\u003coptimized out\u003e) at kv_engine/engines/ep/src/paging_visitor.h:39\n    ...\n    #31 std::__shared_ptr\u003cGlobalTask, (__gnu_cxx::_Lock_policy)2\u003e::reset () at /c++/10.2.0/bits/shared_ptr_base.h:1301\n    #32 EventuallyPersistentEngine::waitForTasks(std::vector\u003cstd::shared_ptr\u003cGlobalTask\u003e, std::allocator\u003cstd::shared_ptr\u003cGlobalTask\u003e \u003e \u003e\u0026) () at kv_engine/engines/ep/src/ep_engine.cc:6752\n    #33 0x000000000082396f in EventuallyPersistentEngine::destroyInner(bool) () at kv_engine/engines/ep/src/ep_engine.cc:2135\n\n1. PagingVisitor is still in existence running after\n   `EventuallyPersistentEngine::destroyInner` - see frame #19. This is\n   because all tasks belonging to bucket were returned from\n   unregisterTaskable() just before.\n\n2. PagingVisitor (via VBCBAdaptor) is destroyed, it decrements the\n   refcount on the shared_ptr\u003cVBucket\u003e it owns - see frame #18.\n\n3. That is the last reference to the VBucket, which results in\n   VBucket::DeferredDeleter being invoked which in turn schedules a\n   task to delete the VBucket (disk and memory) in the background -\n   see frame #11.\n\nWe see the schedule\u0027s lambda happen on the SchedulerPool0 thread (T:35):\n\n    Thread 35 \"SchedulerPool0\" hit Catchpoint 1 (exception thrown), __cxxabiv1::__cxa_throw (..., tinfo\u003d0x10c4ec8 \u003ctypeinfo for std::out_of_range@@GLIBCXX_3.4\u003e, ...) at /tmp/deploy/objdir/../gcc-10.2.0/libstdc++-v3/libsupc++/eh_throw.cc:80\n    (gdb) bt\n    #1  0x00007ffff4cad7d2 in std::__throw_out_of_range (__s\u003d__s@entry\u003d0xcc68e6 \"_Map_base::at\") at /tmp/deploy/objdir/../gcc-10.2.0/libstdc++-v3/src/c++11/functexcept.cc:82\n    ...\n    #3  0x00000000005504ee in std::unordered_map\u003c...\u003e::at (__k\u003d@0x7fffe83a8f88: 0x7b7400000848, this\u003d0x7b1000005580) at /c++/10.2.0/bits/unordered_map.h:1000\n    #4  FollyExecutorPool::State::scheduleTask (this\u003d..., executor\u003d..., pool\u003d..., task\u003d...) at kv_engine/executor/folly_executorpool.cc:415\n    ...\n    #8  folly::EventBase::runInEventBaseThreadAndWait(...) at folly/io/async/EventBase.cpp:671\n    ...\n\nIn FollyExecutorPool::State::scheduleTask (frame #3) we attempt to\nlookup the Taskable (Bucket) in the ExecutorPool\u0027s map, however given\nits already been unregistered, the taskable is not found an the\nstd::out_of_range exception is thrown.\n\nThis is a lifetime issue. We have VBucket objects potentially being\nkept alive longer than their expected lifetime by virtue of background\ntasks having shared ownership of them - and those background tasks\noutlive the lifetime of their parent object (KVBucket), and crucially\npast when the owning Bucket is unregistered with the ExecutorPool and\ncan no longer schedule tasks.\n\nWhen it then _does+ attempt to schedule a task against an unregistered\n(and deleted) Taskable; we see the crash.\n\n+Solution+\n\nThere\u0027s arguably two problems which should be addressed (although\ntechnically only one of the two is required to encounter this crash):\n\n1. Background tasks owning VBuckets when they are not executing.\n2. Background tasks outliving their associated Taskable (aka Bucket).\n\nThis patch addresses the critical issue of (1) - we remove the\n(shared) ownership of VBucket from the background tasks which\nprevioulsy had it - both PagingVisitor which is the problematic class\nin this scenario, but also in the other background Tasks which\npotentially have the same problem.\n\nThe 2nd patch will tighten up the API for visiting VBuckets, so\nvisitors are not passed a VBucketPtr, but instead VBucket\u0026 which\nreduces the chance of similar problems happening in future.\n\nThe 3rd patch will adddress Background Taks outliving their Taskable.\n\nChange-Id: I340a3e4dc3d9234c4a34866b410fb8295a1c98d1\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"326f424b0aadd0e51ad59007724ae2a34400f4ad","is_merged_in_target_branch":true,"change_id":"I78adbb3eca48f3505aeec1119eb0f6e5002725ec","change_number":163478,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/master"},"db499ba5c02fdedb2b1c64ab13c93819d293bd90":{"kind":"REWORK","_number":4,"created":"2021-10-20 16:10:53.000000000","uploader":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/83/163783/4","fetch":{"anonymous http":{"url":"https://review.couchbase.org/kv_engine","ref":"refs/changes/83/163783/4","commands":{"Branch":"git fetch https://review.couchbase.org/kv_engine refs/changes/83/163783/4 \u0026\u0026 git checkout -b change-163783 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/kv_engine refs/changes/83/163783/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/kv_engine refs/changes/83/163783/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/kv_engine refs/changes/83/163783/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/kv_engine refs/changes/83/163783/4","Reset To":"git fetch https://review.couchbase.org/kv_engine refs/changes/83/163783/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9e5480fe71a8c6cc41f17bf931bd1a6ea143df1c","subject":"Fix ExpiryPagerComment"}],"author":{"name":"Dave Rigby","email":"daver@couchbase.com","date":"2021-10-15 16:09:08.000000000","tz":60},"committer":{"name":"Dave Rigby","email":"daver@couchbase.com","date":"2021-10-20 16:10:53.000000000","tz":0},"subject":"MB-48925 1/3: Don\u0027t extend VBucket lifetime via bg Tasks","message":"MB-48925 1/3: Don\u0027t extend VBucket lifetime via bg Tasks\n\nDuring bucket shutdown we intermittently see an exception thrown\nduring task scheduling on a background NonIO thread, which crashes the\nmemcached process.\n\n+Analysis+\n\nBug is as follows. Starting at the main thread which is deleting the Bucket (Thread 1):\n\n    (gdb) bt\n    ...\n    #10 0x0000000000649bf3 in FollyExecutorPool::schedule(std::shared_ptr\u003cGlobalTask\u003e) () at /c++/10.2.0/new:175\n    #11 0x000000000084271b in EPVBucket::scheduleDeferredDeletion(EventuallyPersistentEngine\u0026) () at /c++/10.2.0/ext/atomicity.h:100\n    #12 0x00000000006dfe7a in VBucket::DeferredDeleter::operator()(VBucket*) const () at kv_engine/engines/ep/src/vbucket.cc:3990\n    #13 0x000000000086f874 in std::_Sp_counted_deleter\u003cEPVBucket*, VBucket::DeferredDeleter, ...\u003e::_M_dispose () at /c++/10.2.0/bits/shared_ptr_base.h:453\n    ...\n    #18 std::shared_ptr\u003cVBucket\u003e::~shared_ptr (this\u003d0x7b44000515d0, __in_chrg\u003d\u003coptimized out\u003e) at /c++/10.2.0/bits/shared_ptr.h:121\n    #19 PagingVisitor::~PagingVisitor (this\u003d0x7b4400051540, __in_chrg\u003d\u003coptimized out\u003e) at kv_engine/engines/ep/src/paging_visitor.h:39\n    ...\n    #31 std::__shared_ptr\u003cGlobalTask, (__gnu_cxx::_Lock_policy)2\u003e::reset () at /c++/10.2.0/bits/shared_ptr_base.h:1301\n    #32 EventuallyPersistentEngine::waitForTasks(std::vector\u003cstd::shared_ptr\u003cGlobalTask\u003e, std::allocator\u003cstd::shared_ptr\u003cGlobalTask\u003e \u003e \u003e\u0026) () at kv_engine/engines/ep/src/ep_engine.cc:6752\n    #33 0x000000000082396f in EventuallyPersistentEngine::destroyInner(bool) () at kv_engine/engines/ep/src/ep_engine.cc:2135\n\n1. PagingVisitor is still in existence running after\n   `EventuallyPersistentEngine::destroyInner` - see frame #19. This is\n   because all tasks belonging to bucket were returned from\n   unregisterTaskable() just before.\n\n2. PagingVisitor (via VBCBAdaptor) is destroyed, it decrements the\n   refcount on the shared_ptr\u003cVBucket\u003e it owns - see frame #18.\n\n3. That is the last reference to the VBucket, which results in\n   VBucket::DeferredDeleter being invoked which in turn schedules a\n   task to delete the VBucket (disk and memory) in the background -\n   see frame #11.\n\nWe see the schedule\u0027s lambda happen on the SchedulerPool0 thread (T:35):\n\n    Thread 35 \"SchedulerPool0\" hit Catchpoint 1 (exception thrown), __cxxabiv1::__cxa_throw (..., tinfo\u003d0x10c4ec8 \u003ctypeinfo for std::out_of_range@@GLIBCXX_3.4\u003e, ...) at /tmp/deploy/objdir/../gcc-10.2.0/libstdc++-v3/libsupc++/eh_throw.cc:80\n    (gdb) bt\n    #1  0x00007ffff4cad7d2 in std::__throw_out_of_range (__s\u003d__s@entry\u003d0xcc68e6 \"_Map_base::at\") at /tmp/deploy/objdir/../gcc-10.2.0/libstdc++-v3/src/c++11/functexcept.cc:82\n    ...\n    #3  0x00000000005504ee in std::unordered_map\u003c...\u003e::at (__k\u003d@0x7fffe83a8f88: 0x7b7400000848, this\u003d0x7b1000005580) at /c++/10.2.0/bits/unordered_map.h:1000\n    #4  FollyExecutorPool::State::scheduleTask (this\u003d..., executor\u003d..., pool\u003d..., task\u003d...) at kv_engine/executor/folly_executorpool.cc:415\n    ...\n    #8  folly::EventBase::runInEventBaseThreadAndWait(...) at folly/io/async/EventBase.cpp:671\n    ...\n\nIn FollyExecutorPool::State::scheduleTask (frame #3) we attempt to\nlookup the Taskable (Bucket) in the ExecutorPool\u0027s map, however given\nits already been unregistered, the taskable is not found an the\nstd::out_of_range exception is thrown.\n\nThis is a lifetime issue. We have VBucket objects potentially being\nkept alive longer than their expected lifetime by virtue of background\ntasks having shared ownership of them - and those background tasks\noutlive the lifetime of their parent object (KVBucket), and crucially\npast when the owning Bucket is unregistered with the ExecutorPool and\ncan no longer schedule tasks.\n\nWhen it then _does+ attempt to schedule a task against an unregistered\n(and deleted) Taskable; we see the crash.\n\n+Solution+\n\nThere\u0027s arguably two problems which should be addressed (although\ntechnically only one of the two is required to encounter this crash):\n\n1. Background tasks owning VBuckets when they are not executing.\n2. Background tasks outliving their associated Taskable (aka Bucket).\n\nThis patch addresses the critical issue of (1) - we remove the\n(shared) ownership of VBucket from the background tasks which\nprevioulsy had it - both PagingVisitor which is the problematic class\nin this scenario, but also in the other background Tasks which\npotentially have the same problem.\n\nThe 2nd patch will tighten up the API for visiting VBuckets, so\nvisitors are not passed a VBucketPtr, but instead VBucket\u0026 which\nreduces the chance of similar problems happening in future.\n\nThe 3rd patch will adddress Background Taks outliving their Taskable.\n\nChange-Id: I340a3e4dc3d9234c4a34866b410fb8295a1c98d1\nReviewed-on: http://review.couchbase.org/c/kv_engine/+/163783\nTested-by: Dave Rigby \u003cdaver@couchbase.com\u003e\nReviewed-by: Richard de Mellow \u003crichard.demellow@couchbase.com\u003e\nReviewed-by: James H \u003cjames.harrison@couchbase.com\u003e\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"9e5480fe71a8c6cc41f17bf931bd1a6ea143df1c","is_merged_in_target_branch":true,"change_id":"I4e0f18c81b6392d146c66cbda4838555fd09667f","change_number":163982,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1003828,"name":"James H","email":"james.harrison@couchbase.com","username":"jameseh96","avatars":[{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}},{"label":"Well-Formed","status":"MAY"}]},{"status":"CLOSED"}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Custom-Rule","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Custom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["Custom-Rule"],"failing_atoms":[]}}]}