)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1004964,"name":"Vesko Karaganev","email":"vesko.karaganev@couchbase.com","username":"veselink1","avatars":[{"url":"https://www.gravatar.com/avatar/0d261762ccab34b23c8e459b684102fc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0d261762ccab34b23c8e459b684102fc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0d261762ccab34b23c8e459b684102fc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0d261762ccab34b23c8e459b684102fc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"96b802bd83910e2bd68b00e8a3809a9740098def","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ee3b052a_9483c53a","updated":"2023-04-14 08:14:51.000000000","message":"Seeing the read is coming from doEngineStats(), we probably want all of the members accessed without a lock to be atomic.","commit_id":"90f7f549b1693e419da8eea2d7cacd0d997fae03"},{"author":{"_account_id":1004964,"name":"Vesko Karaganev","email":"vesko.karaganev@couchbase.com","username":"veselink1","avatars":[{"url":"https://www.gravatar.com/avatar/0d261762ccab34b23c8e459b684102fc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0d261762ccab34b23c8e459b684102fc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0d261762ccab34b23c8e459b684102fc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0d261762ccab34b23c8e459b684102fc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"667ccce2ad259017ee8fccb557235a997d2a8b8e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"053f349c_da1ddbaa","in_reply_to":"365f906a_c746f829","updated":"2023-09-06 12:27:46.000000000","message":"Ack","commit_id":"90f7f549b1693e419da8eea2d7cacd0d997fae03"},{"author":{"_account_id":1003828,"name":"James H","email":"james.harrison@couchbase.com","username":"jameseh96","avatars":[{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"9d618b9a7a52e25a177266c51536121d1072fa91","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8db107b5_d6b6d48e","in_reply_to":"44e9529e_b219935a","updated":"2023-04-14 12:29:54.000000000","message":"Hmmm, actually there\u0027s at least highestPurgedDeletedSeqno that is read without the lock...","commit_id":"90f7f549b1693e419da8eea2d7cacd0d997fae03"},{"author":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"025dd048fa1424bf2139615c56acad1d0e901250","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"365f906a_c746f829","in_reply_to":"8db107b5_d6b6d48e","updated":"2023-08-11 10:45:29.000000000","message":"James: Did you reach any conclusion on this ?","commit_id":"90f7f549b1693e419da8eea2d7cacd0d997fae03"},{"author":{"_account_id":1003828,"name":"James H","email":"james.harrison@couchbase.com","username":"jameseh96","avatars":[{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f35626ccfbe73bc2496f23d91fc7ff55e88cd96c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"44e9529e_b219935a","in_reply_to":"ee3b052a_9483c53a","updated":"2023-04-14 12:24:12.000000000","message":"Looks like all the other members read for stats are either atomic or take the lock in the getter?","commit_id":"90f7f549b1693e419da8eea2d7cacd0d997fae03"},{"author":{"_account_id":1004964,"name":"Vesko Karaganev","email":"vesko.karaganev@couchbase.com","username":"veselink1","avatars":[{"url":"https://www.gravatar.com/avatar/0d261762ccab34b23c8e459b684102fc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0d261762ccab34b23c8e459b684102fc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0d261762ccab34b23c8e459b684102fc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0d261762ccab34b23c8e459b684102fc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"0de28ddb11b201366a9e8f5627b8f41903fc174d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"86ec9783_f7ee7297","updated":"2023-09-11 13:02:37.000000000","message":"Override BuildBot: known ASan-UBSan failure","commit_id":"84105e7f88ccca345f86b12578b18496ac265a9c"},{"author":{"_account_id":1004964,"name":"Vesko Karaganev","email":"vesko.karaganev@couchbase.com","username":"veselink1","avatars":[{"url":"https://www.gravatar.com/avatar/0d261762ccab34b23c8e459b684102fc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0d261762ccab34b23c8e459b684102fc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0d261762ccab34b23c8e459b684102fc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0d261762ccab34b23c8e459b684102fc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"305f2d7cb0a7228626357472af245cd577aaaac1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"50cf3d0b_2f70753e","updated":"2023-09-18 12:36:10.000000000","message":"Ping for review","commit_id":"84105e7f88ccca345f86b12578b18496ac265a9c"}],"engines/ep/src/linked_list.h":[{"author":{"_account_id":1000966,"name":"Dave Rigby","email":"daver@couchbase.com","username":"drigby","avatars":[{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/514e75a8d75cc1fcdb22433d445ae8f1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f3a3bd8f31ee90644e8432c79cdbabc8f5bacbc7","unresolved":true,"context_lines":[{"line_number":264,"context_line":"    /**"},{"line_number":265,"context_line":"     * Indicates the number of elements in the list that are stale (old,"},{"line_number":266,"context_line":"     * duplicate values). Stale items are owned by the list and hence must"},{"line_number":267,"context_line":"     * periodically clean them up."},{"line_number":268,"context_line":"     */"},{"line_number":269,"context_line":"    cb::AtomicNonNegativeCounter\u003cuint64_t\u003e numStaleItems;"},{"line_number":270,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"eb715450_e4393024","line":267,"updated":"2023-04-13 15:27:32.000000000","message":"Please document why atomic.","commit_id":"90f7f549b1693e419da8eea2d7cacd0d997fae03"},{"author":{"_account_id":1003828,"name":"James H","email":"james.harrison@couchbase.com","username":"jameseh96","avatars":[{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/70d2875f461e17e71a2a16972681c794.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f35626ccfbe73bc2496f23d91fc7ff55e88cd96c","unresolved":false,"context_lines":[{"line_number":264,"context_line":"    /**"},{"line_number":265,"context_line":"     * Indicates the number of elements in the list that are stale (old,"},{"line_number":266,"context_line":"     * duplicate values). Stale items are owned by the list and hence must"},{"line_number":267,"context_line":"     * periodically clean them up."},{"line_number":268,"context_line":"     */"},{"line_number":269,"context_line":"    cb::AtomicNonNegativeCounter\u003cuint64_t\u003e numStaleItems;"},{"line_number":270,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"b5f351ed_e480c026","line":267,"in_reply_to":"eb715450_e4393024","updated":"2023-04-14 12:24:12.000000000","message":"Done","commit_id":"90f7f549b1693e419da8eea2d7cacd0d997fae03"},{"author":{"_account_id":1004059,"name":"Paolo Cocchi","email":"paolo.cocchi@couchbase.com","username":"paolococchi","avatars":[{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"259f8daf438237cad184dd0a92fbc57f67fc4721","unresolved":true,"context_lines":[{"line_number":245,"context_line":"     * This should be non-decrementing, apart from a rollback where it will be"},{"line_number":246,"context_line":"     * reset."},{"line_number":247,"context_line":"     *"},{"line_number":248,"context_line":"     * Atomic as read for stats without taking the listWriteLock."},{"line_number":249,"context_line":"     */"},{"line_number":250,"context_line":"    AtomicMonotonic\u003cseqno_t\u003e highestPurgedDeletedSeqno;"},{"line_number":251,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"1c0d739c_bf6a2c5f","line":248,"range":{"start_line":248,"start_character":7,"end_line":248,"end_character":65},"updated":"2023-09-06 11:31:57.000000000","message":"By using atomic here and not taking the lock, in general the stat isn\u0027t in-sync with the LinkedList state. The same applies to stats below.\n\nAre we ok with that?","commit_id":"84105e7f88ccca345f86b12578b18496ac265a9c"},{"author":{"_account_id":1004059,"name":"Paolo Cocchi","email":"paolo.cocchi@couchbase.com","username":"paolococchi","avatars":[{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/3367cfbc4fbf29e6d6b3a5397e41849d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"dee2139b3013f4d488634ecfd39875ea779dbc65","unresolved":true,"context_lines":[{"line_number":245,"context_line":"     * This should be non-decrementing, apart from a rollback where it will be"},{"line_number":246,"context_line":"     * reset."},{"line_number":247,"context_line":"     *"},{"line_number":248,"context_line":"     * Atomic as read for stats without taking the listWriteLock."},{"line_number":249,"context_line":"     */"},{"line_number":250,"context_line":"    AtomicMonotonic\u003cseqno_t\u003e highestPurgedDeletedSeqno;"},{"line_number":251,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"aebef627_e0118121","line":248,"range":{"start_line":248,"start_character":7,"end_line":248,"end_character":65},"in_reply_to":"1c0d739c_bf6a2c5f","updated":"2023-09-06 11:33:49.000000000","message":"My point is, at cbstats we\u0027ll have some stats that are consistent with the LinkedList state (the ones that we read under lock) and others that are not.\nAt that point we don\u0027t have a full consistent view of the LL state","commit_id":"84105e7f88ccca345f86b12578b18496ac265a9c"},{"author":{"_account_id":1004964,"name":"Vesko Karaganev","email":"vesko.karaganev@couchbase.com","username":"veselink1","avatars":[{"url":"https://www.gravatar.com/avatar/0d261762ccab34b23c8e459b684102fc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/0d261762ccab34b23c8e459b684102fc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/0d261762ccab34b23c8e459b684102fc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/0d261762ccab34b23c8e459b684102fc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"667ccce2ad259017ee8fccb557235a997d2a8b8e","unresolved":false,"context_lines":[{"line_number":245,"context_line":"     * This should be non-decrementing, apart from a rollback where it will be"},{"line_number":246,"context_line":"     * reset."},{"line_number":247,"context_line":"     *"},{"line_number":248,"context_line":"     * Atomic as read for stats without taking the listWriteLock."},{"line_number":249,"context_line":"     */"},{"line_number":250,"context_line":"    AtomicMonotonic\u003cseqno_t\u003e highestPurgedDeletedSeqno;"},{"line_number":251,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"05bc9f2f_cc42dbc2","line":248,"range":{"start_line":248,"start_character":7,"end_line":248,"end_character":65},"in_reply_to":"aebef627_e0118121","updated":"2023-09-06 12:27:46.000000000","message":"You\u0027re right, but I think that is okay, as it applies to most (all?) of the stats we expose. \n\nWe expose the aggregates of those stats (summed by vbstate), so if we wanted to have a consistent view, we\u0027d have to lock down all vBuckets just to have a consistent view.","commit_id":"84105e7f88ccca345f86b12578b18496ac265a9c"}]}