)]}'
{"src/ssl/ssl_common.c":[{"author":{"_account_id":1000002,"name":"Trond Norbye","display_name":"Trond","email":"trond.norbye@couchbase.com","username":"trond","avatars":[{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"6f3c683f92fddcad523a393a2de47b0826cf757e","unresolved":true,"context_lines":[{"line_number":324,"context_line":"#if (OPENSSL_VERSION_NUMBER \u003c 0x30000000L)"},{"line_number":325,"context_line":"#define lcb_openssl_func_error_string(err) ERR_func_error_string(err)"},{"line_number":326,"context_line":"#else"},{"line_number":327,"context_line":"#define lcb_openssl_func_error_string(err) (char*)NULL"},{"line_number":328,"context_line":"#endif"},{"line_number":329,"context_line":"static lcb_STATUS add_certificate_authority(const lcb_settings *settings, SSL_CTX *ctx, const char *certificate_value,"},{"line_number":330,"context_line":"                                            int certificate_length)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"14c580cc_1088469d","line":327,"range":{"start_line":327,"start_character":43,"end_line":327,"end_character":54},"updated":"2023-04-25 17:37:51.000000000","message":"Is it safe to pass null into something which expects %s ? I believe it is undefined behavior, but glibc prints null... I think its safer to use something like:\n\n    #define lcb_blah_bla(err) \"null\"\n\n(if that is what you want to be printed out).","commit_id":"27fa189ed5ae1530a43bd7d28c5b4819a7d63653"},{"author":{"_account_id":1000201,"name":"Sergey Avseyev","email":"sergey.avseyev@gmail.com","username":"avsej","avatars":[{"url":"https://www.gravatar.com/avatar/dd70f9d8cc5f9ee488d68e7a787ba526.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dd70f9d8cc5f9ee488d68e7a787ba526.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dd70f9d8cc5f9ee488d68e7a787ba526.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dd70f9d8cc5f9ee488d68e7a787ba526.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"58f40e747478a164273b60128c36911b02e8efad","unresolved":true,"context_lines":[{"line_number":324,"context_line":"#if (OPENSSL_VERSION_NUMBER \u003c 0x30000000L)"},{"line_number":325,"context_line":"#define lcb_openssl_func_error_string(err) ERR_func_error_string(err)"},{"line_number":326,"context_line":"#else"},{"line_number":327,"context_line":"#define lcb_openssl_func_error_string(err) (char*)NULL"},{"line_number":328,"context_line":"#endif"},{"line_number":329,"context_line":"static lcb_STATUS add_certificate_authority(const lcb_settings *settings, SSL_CTX *ctx, const char *certificate_value,"},{"line_number":330,"context_line":"                                            int certificate_length)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"207866cb_46c55b97","line":327,"range":{"start_line":327,"start_character":43,"end_line":327,"end_character":54},"in_reply_to":"14c580cc_1088469d","updated":"2023-04-25 17:41:42.000000000","message":"Makes sense. I will create another patch","commit_id":"27fa189ed5ae1530a43bd7d28c5b4819a7d63653"}]}