)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000002,"name":"Trond Norbye","display_name":"Trond","email":"trond.norbye@couchbase.com","username":"trond","avatars":[{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"180347d7e1165d19dfe7ab774a0f92fa969debf6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f369c186_201d7ac8","updated":"2023-04-27 10:26:22.000000000","message":"It removes the warning, but the code is still unsafe as we don\u0027t check the result from snprint in the cases where the input could be bigger than what would fit in the buffer. Windows and linux behaves differently in that case if my memory serves me right (I believe windows stops, but don\u0027t terminate the string and linux terminates the string) which means that it could fail with the same buffer overflow in the \"next call\" which expected the string to be terminated.\n\nAll of that being said, given that a lot of the code is C++ I wonder if it would have been safer to just use std::strings and fmt for formatting ;)","commit_id":"622a80fef68fe6e1e09ed695ec15eddb0389571f"}]}