)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000208,"name":"Aliaksey Artamonau","email":"aliaksey.artamonau@couchbase.com","username":"aartamonau","avatars":[{"url":"https://www.gravatar.com/avatar/bb71c4f683f0911004c62e00ca56922a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/bb71c4f683f0911004c62e00ca56922a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/bb71c4f683f0911004c62e00ca56922a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/bb71c4f683f0911004c62e00ca56922a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c5edb38db70f27b0a4b0e1dd5d7e8d7dc5c7f959","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Allows creation of a bucket with magma as the storage backend."},{"line_number":10,"context_line":"StorageBackend will be specified in the REST Api."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"UiType    StorageBackend  InternalType  storage_mode  KvType    backend"},{"line_number":13,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d    \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d   \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d    \u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"memcached   n/a           memcached     n/a           memcached   n/a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"046a7282_8b27c6db","line":12,"range":{"start_line":12,"start_character":54,"end_line":12,"end_character":60},"updated":"2020-01-08 21:04:34.000000000","message":"Shouldn\u0027t \"memcached\" be \"n/a\", and \"membase\" be \"persistent\" in this column? I assume KvType corresponds to the \"bucket_type\" parameter we pass to ep-engine when we create membase buckets.","commit_id":"5a3559375f66fea77185d1faefc5436be4f59294"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"8d7386e314cb8fdfad9306edf126925dfe1bbd21","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Allows creation of a bucket with magma as the storage backend."},{"line_number":10,"context_line":"StorageBackend will be specified in the REST Api."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"UiType    StorageBackend  InternalType  storage_mode  KvType    backend"},{"line_number":13,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d    \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d   \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d    \u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"memcached   n/a           memcached     n/a           memcached   n/a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9fbd52ca_7c34f296","line":12,"range":{"start_line":12,"start_character":54,"end_line":12,"end_character":60},"in_reply_to":"046a7282_8b27c6db","updated":"2020-01-09 21:37:08.000000000","message":"I don\u0027t recall what I was thinking at that moment but what you say makes sense.","commit_id":"5a3559375f66fea77185d1faefc5436be4f59294"}],"src/bucket_info_cache.erl":[{"author":{"_account_id":1000208,"name":"Aliaksey Artamonau","email":"aliaksey.artamonau@couchbase.com","username":"aartamonau","avatars":[{"url":"https://www.gravatar.com/avatar/bb71c4f683f0911004c62e00ca56922a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/bb71c4f683f0911004c62e00ca56922a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/bb71c4f683f0911004c62e00ca56922a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/bb71c4f683f0911004c62e00ca56922a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"360d6e5c4b8b20fd85767e602d67373737c27657","unresolved":false,"context_lines":[{"line_number":221,"context_line":"    {ok, Rev, ejson:encode(J), BucketConfig}."},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"maybe_add_ddocs(StorageMode, BucketBin, VBMapInfo)"},{"line_number":224,"context_line":"  when StorageMode \u003d:\u003d couchstore;"},{"line_number":225,"context_line":"       StorageMode \u003d:\u003d magma -\u003e"},{"line_number":226,"context_line":"    [{ddocs, {[{uri, \u003c\u003c\"/pools/default/buckets/\", BucketBin/binary,"},{"line_number":227,"context_line":"                       \"/ddocs\"\u003e\u003e}]}} | VBMapInfo];"},{"line_number":228,"context_line":"maybe_add_ddocs(ephemeral, _BucketBin, VBMapInfo) -\u003e"}],"source_content_type":"text/x-erlang","patch_set":3,"id":"5fb8d63f_0e11419d","line":225,"range":{"start_line":224,"start_character":0,"end_line":225,"end_character":31},"updated":"2020-01-08 21:57:31.000000000","message":"Should probably replaced with a call to ns_bucket:can_have_views (since we have it anyway).","commit_id":"5a3559375f66fea77185d1faefc5436be4f59294"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"8d7386e314cb8fdfad9306edf126925dfe1bbd21","unresolved":false,"context_lines":[{"line_number":221,"context_line":"    {ok, Rev, ejson:encode(J), BucketConfig}."},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"maybe_add_ddocs(StorageMode, BucketBin, VBMapInfo)"},{"line_number":224,"context_line":"  when StorageMode \u003d:\u003d couchstore;"},{"line_number":225,"context_line":"       StorageMode \u003d:\u003d magma -\u003e"},{"line_number":226,"context_line":"    [{ddocs, {[{uri, \u003c\u003c\"/pools/default/buckets/\", BucketBin/binary,"},{"line_number":227,"context_line":"                       \"/ddocs\"\u003e\u003e}]}} | VBMapInfo];"},{"line_number":228,"context_line":"maybe_add_ddocs(ephemeral, _BucketBin, VBMapInfo) -\u003e"}],"source_content_type":"text/x-erlang","patch_set":3,"id":"29a41865_52e1f8d4","line":225,"range":{"start_line":224,"start_character":0,"end_line":225,"end_character":31},"in_reply_to":"5fb8d63f_0e11419d","updated":"2020-01-09 21:37:08.000000000","message":"Done","commit_id":"5a3559375f66fea77185d1faefc5436be4f59294"},{"author":{"_account_id":1000487,"name":"Artem Stemkovski","email":"artem@couchbase.com","username":"astemkov","avatars":[{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f31890e7d3e24ca5ccce7635d3933a0889874249","unresolved":false,"context_lines":[{"line_number":201,"context_line":"                {struct, VBMap} \u003d ns_bucket:json_map_with_full_config(?LOCALHOST_MARKER_STRING,"},{"line_number":202,"context_line":"                                                                      BucketConfig, Config),"},{"line_number":203,"context_line":"                VBMapInfo \u003d [{vBucketServerMap, {VBMap}} | Caps],"},{"line_number":204,"context_line":"                CanHaveViews \u003d ns_bucket:can_have_views(BucketConfig),"},{"line_number":205,"context_line":"                maybe_add_ddocs(CanHaveViews, BucketBin, VBMapInfo)"},{"line_number":206,"context_line":"        end,"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    %% We\u0027re computing rev using config\u0027s global rev which allows us"}],"source_content_type":"text/x-erlang","patch_set":7,"id":"1b0a5b85_c8a9189c","line":205,"range":{"start_line":204,"start_character":16,"end_line":205,"end_character":67},"updated":"2020-01-16 22:38:25.000000000","message":"why don\u0027t you do:\ncase ns_bucket:can_have_views(BucketConfig) of\n\nadding new fun here decreases readability, imho","commit_id":"fc050d463f011ff2d7d890e85dbe63447143801c"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"661ed4c3f347d74b9499498fa8cd3cb83a02b454","unresolved":false,"context_lines":[{"line_number":201,"context_line":"                {struct, VBMap} \u003d ns_bucket:json_map_with_full_config(?LOCALHOST_MARKER_STRING,"},{"line_number":202,"context_line":"                                                                      BucketConfig, Config),"},{"line_number":203,"context_line":"                VBMapInfo \u003d [{vBucketServerMap, {VBMap}} | Caps],"},{"line_number":204,"context_line":"                CanHaveViews \u003d ns_bucket:can_have_views(BucketConfig),"},{"line_number":205,"context_line":"                maybe_add_ddocs(CanHaveViews, BucketBin, VBMapInfo)"},{"line_number":206,"context_line":"        end,"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    %% We\u0027re computing rev using config\u0027s global rev which allows us"}],"source_content_type":"text/x-erlang","patch_set":7,"id":"ad498a94_7867f380","line":205,"range":{"start_line":204,"start_character":16,"end_line":205,"end_character":67},"in_reply_to":"1b0a5b85_c8a9189c","updated":"2020-01-16 23:30:41.000000000","message":"Done","commit_id":"fc050d463f011ff2d7d890e85dbe63447143801c"}],"src/memcached_bucket_config.erl":[{"author":{"_account_id":1000487,"name":"Artem Stemkovski","email":"artem@couchbase.com","username":"astemkov","avatars":[{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e73ae7e79fa4e1ebf1159ca7603fd357d556da32","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    [{\"cache_size\", [], MemQuota},"},{"line_number":79,"context_line":"     {\"uuid\", [], UUID}]."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"storage_mode_to_backend_type(StorageMode)"},{"line_number":82,"context_line":"  when StorageMode \u003d:\u003d couchstore;"},{"line_number":83,"context_line":"       StorageMode \u003d:\u003d ephemeral -\u003e"},{"line_number":84,"context_line":"    %% This isn\u0027t used by kv for ephemeral buckets but changing it to"},{"line_number":85,"context_line":"    %% something else requires non-zero changes to kv-engine which aren\u0027t"},{"line_number":86,"context_line":"    %% felt to provide any \"real\" value."},{"line_number":87,"context_line":"    couchdb;"},{"line_number":88,"context_line":"storage_mode_to_backend_type(magma) -\u003e"},{"line_number":89,"context_line":"    magma."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"storage_mode_to_bucket_type(StorageMode)"},{"line_number":92,"context_line":"  when StorageMode \u003d:\u003d couchstore;"}],"source_content_type":"text/x-erlang","patch_set":6,"id":"821b398b_6f2caea1","line":89,"range":{"start_line":81,"start_character":0,"end_line":89,"end_character":10},"updated":"2020-01-14 03:48:36.000000000","message":"can you move this to ns_bucket too?","commit_id":"2d8eb77cec45fb77e35b6d1a3e91ab6e56237335"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"203d0284de32798be72d83775cab252a49ba29de","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    [{\"cache_size\", [], MemQuota},"},{"line_number":79,"context_line":"     {\"uuid\", [], UUID}]."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"storage_mode_to_backend_type(StorageMode)"},{"line_number":82,"context_line":"  when StorageMode \u003d:\u003d couchstore;"},{"line_number":83,"context_line":"       StorageMode \u003d:\u003d ephemeral -\u003e"},{"line_number":84,"context_line":"    %% This isn\u0027t used by kv for ephemeral buckets but changing it to"},{"line_number":85,"context_line":"    %% something else requires non-zero changes to kv-engine which aren\u0027t"},{"line_number":86,"context_line":"    %% felt to provide any \"real\" value."},{"line_number":87,"context_line":"    couchdb;"},{"line_number":88,"context_line":"storage_mode_to_backend_type(magma) -\u003e"},{"line_number":89,"context_line":"    magma."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"storage_mode_to_bucket_type(StorageMode)"},{"line_number":92,"context_line":"  when StorageMode \u003d:\u003d couchstore;"}],"source_content_type":"text/x-erlang","patch_set":6,"id":"9bdd4d04_8c9fda30","line":89,"range":{"start_line":81,"start_character":0,"end_line":89,"end_character":10},"in_reply_to":"821b398b_6f2caea1","updated":"2020-01-14 19:30:19.000000000","message":"This gets changed in a downstream change so I\u0027ll address it there.","commit_id":"2d8eb77cec45fb77e35b6d1a3e91ab6e56237335"},{"author":{"_account_id":1000487,"name":"Artem Stemkovski","email":"artem@couchbase.com","username":"astemkov","avatars":[{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e73ae7e79fa4e1ebf1159ca7603fd357d556da32","unresolved":false,"context_lines":[{"line_number":88,"context_line":"storage_mode_to_backend_type(magma) -\u003e"},{"line_number":89,"context_line":"    magma."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"storage_mode_to_bucket_type(StorageMode)"},{"line_number":92,"context_line":"  when StorageMode \u003d:\u003d couchstore;"},{"line_number":93,"context_line":"       StorageMode \u003d:\u003d magma -\u003e"},{"line_number":94,"context_line":"    persistent;"},{"line_number":95,"context_line":"storage_mode_to_bucket_type(ephemeral) -\u003e"},{"line_number":96,"context_line":"    ephemeral."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"maybe_restart() -\u003e"},{"line_number":99,"context_line":"    case ns_config:read_key_fast(dont_reload_bucket_on_cfg_change, false) of"}],"source_content_type":"text/x-erlang","patch_set":6,"id":"e0931c11_a30fb9e3","line":96,"range":{"start_line":91,"start_character":0,"end_line":96,"end_character":14},"updated":"2020-01-14 03:48:36.000000000","message":"why not use ns_bucket:is_persistent ?","commit_id":"2d8eb77cec45fb77e35b6d1a3e91ab6e56237335"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"203d0284de32798be72d83775cab252a49ba29de","unresolved":false,"context_lines":[{"line_number":88,"context_line":"storage_mode_to_backend_type(magma) -\u003e"},{"line_number":89,"context_line":"    magma."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"storage_mode_to_bucket_type(StorageMode)"},{"line_number":92,"context_line":"  when StorageMode \u003d:\u003d couchstore;"},{"line_number":93,"context_line":"       StorageMode \u003d:\u003d magma -\u003e"},{"line_number":94,"context_line":"    persistent;"},{"line_number":95,"context_line":"storage_mode_to_bucket_type(ephemeral) -\u003e"},{"line_number":96,"context_line":"    ephemeral."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"maybe_restart() -\u003e"},{"line_number":99,"context_line":"    case ns_config:read_key_fast(dont_reload_bucket_on_cfg_change, false) of"}],"source_content_type":"text/x-erlang","patch_set":6,"id":"4165fd8e_8d10d763","line":96,"range":{"start_line":91,"start_character":0,"end_line":96,"end_character":14},"in_reply_to":"e0931c11_a30fb9e3","updated":"2020-01-14 19:30:19.000000000","message":"Done","commit_id":"2d8eb77cec45fb77e35b6d1a3e91ab6e56237335"},{"author":{"_account_id":1000487,"name":"Artem Stemkovski","email":"artem@couchbase.com","username":"astemkov","avatars":[{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e73ae7e79fa4e1ebf1159ca7603fd357d556da32","unresolved":false,"context_lines":[{"line_number":133,"context_line":"                              ?DEFAULT_EPHEMERAL_PURGE_INTERVAL_DAYS),"},{"line_number":134,"context_line":"    erlang:round(Val * 24 * 3600);"},{"line_number":135,"context_line":"ephemeral_metadata_purge_age(StorageMode, _BucketConfig)"},{"line_number":136,"context_line":"  when StorageMode \u003d:\u003d couchstore;"},{"line_number":137,"context_line":"       StorageMode \u003d:\u003d magma -\u003e"},{"line_number":138,"context_line":"    undefined."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"get(Config, BucketName) -\u003e"}],"source_content_type":"text/x-erlang","patch_set":6,"id":"77d4a302_cf1214ee","line":137,"range":{"start_line":136,"start_character":0,"end_line":137,"end_character":31},"updated":"2020-01-14 03:48:36.000000000","message":"is_persistent","commit_id":"2d8eb77cec45fb77e35b6d1a3e91ab6e56237335"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"203d0284de32798be72d83775cab252a49ba29de","unresolved":false,"context_lines":[{"line_number":133,"context_line":"                              ?DEFAULT_EPHEMERAL_PURGE_INTERVAL_DAYS),"},{"line_number":134,"context_line":"    erlang:round(Val * 24 * 3600);"},{"line_number":135,"context_line":"ephemeral_metadata_purge_age(StorageMode, _BucketConfig)"},{"line_number":136,"context_line":"  when StorageMode \u003d:\u003d couchstore;"},{"line_number":137,"context_line":"       StorageMode \u003d:\u003d magma -\u003e"},{"line_number":138,"context_line":"    undefined."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"get(Config, BucketName) -\u003e"}],"source_content_type":"text/x-erlang","patch_set":6,"id":"7ff53333_2a4468b9","line":137,"range":{"start_line":136,"start_character":0,"end_line":137,"end_character":31},"in_reply_to":"77d4a302_cf1214ee","updated":"2020-01-14 19:30:19.000000000","message":"Done","commit_id":"2d8eb77cec45fb77e35b6d1a3e91ab6e56237335"},{"author":{"_account_id":1000487,"name":"Artem Stemkovski","email":"artem@couchbase.com","username":"astemkov","avatars":[{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f31890e7d3e24ca5ccce7635d3933a0889874249","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            []"},{"line_number":97,"context_line":"    end."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"item_eviction_policy(BucketConfig) -\u003e"},{"line_number":100,"context_line":"    UsesItemEviction \u003d ns_bucket:uses_item_eviction(BucketConfig),"},{"line_number":101,"context_line":"    do_item_eviction_policy(UsesItemEviction, BucketConfig)."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"do_item_eviction_policy(true, BucketConfig) -\u003e"},{"line_number":104,"context_line":"    proplists:get_value(eviction_policy, BucketConfig, value_only);"},{"line_number":105,"context_line":"do_item_eviction_policy(false, _BucketConfig) -\u003e"},{"line_number":106,"context_line":"    undefined."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"ephemeral_full_policy(BucketConfig) -\u003e"},{"line_number":109,"context_line":"    UsesFullEviction \u003d ns_bucket:uses_full_eviction(BucketConfig),"},{"line_number":110,"context_line":"    do_full_policy(UsesFullEviction, BucketConfig)."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"do_full_policy(true, BucketConfig) -\u003e"},{"line_number":113,"context_line":"    case proplists:get_value(eviction_policy, BucketConfig, no_eviction) of"},{"line_number":114,"context_line":"        nru_eviction -\u003e"},{"line_number":115,"context_line":"            auto_delete;"},{"line_number":116,"context_line":"        no_eviction -\u003e"},{"line_number":117,"context_line":"            fail_new_data"},{"line_number":118,"context_line":"    end;"},{"line_number":119,"context_line":"do_full_policy(false, _BucketConfig) -\u003e"},{"line_number":120,"context_line":"    undefined."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"ephemeral_metadata_purge_age(BucketName, BucketConfig) -\u003e"},{"line_number":123,"context_line":"    case ns_bucket:is_persistent(BucketName) of"}],"source_content_type":"text/x-erlang","patch_set":7,"id":"66860496_1218ac04","line":120,"range":{"start_line":99,"start_character":0,"end_line":120,"end_character":14},"updated":"2020-01-16 22:38:25.000000000","message":"maybe this way:\n\nget_eviction_policy(Persistent, BucketConfig) -\u003e\n     case ns_bucket:is_persistent(BucketConfig) of\n        Persistent -\u003e\n           case ns_bucket:eviction_policy(BucketConfig) of\n              nru_eviction -\u003e\n                 auto_delete;\n              no_eviction -\u003e\n                 fail_new_data;\n              Other -\u003e\n                 Other\n           end;    \n        _ -\u003e\n           undefined\n     end.","commit_id":"fc050d463f011ff2d7d890e85dbe63447143801c"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"8aa038a73828b9e4753e419d8c46480439b1713b","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            []"},{"line_number":97,"context_line":"    end."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"item_eviction_policy(BucketConfig) -\u003e"},{"line_number":100,"context_line":"    UsesItemEviction \u003d ns_bucket:uses_item_eviction(BucketConfig),"},{"line_number":101,"context_line":"    do_item_eviction_policy(UsesItemEviction, BucketConfig)."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"do_item_eviction_policy(true, BucketConfig) -\u003e"},{"line_number":104,"context_line":"    proplists:get_value(eviction_policy, BucketConfig, value_only);"},{"line_number":105,"context_line":"do_item_eviction_policy(false, _BucketConfig) -\u003e"},{"line_number":106,"context_line":"    undefined."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"ephemeral_full_policy(BucketConfig) -\u003e"},{"line_number":109,"context_line":"    UsesFullEviction \u003d ns_bucket:uses_full_eviction(BucketConfig),"},{"line_number":110,"context_line":"    do_full_policy(UsesFullEviction, BucketConfig)."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"do_full_policy(true, BucketConfig) -\u003e"},{"line_number":113,"context_line":"    case proplists:get_value(eviction_policy, BucketConfig, no_eviction) of"},{"line_number":114,"context_line":"        nru_eviction -\u003e"},{"line_number":115,"context_line":"            auto_delete;"},{"line_number":116,"context_line":"        no_eviction -\u003e"},{"line_number":117,"context_line":"            fail_new_data"},{"line_number":118,"context_line":"    end;"},{"line_number":119,"context_line":"do_full_policy(false, _BucketConfig) -\u003e"},{"line_number":120,"context_line":"    undefined."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"ephemeral_metadata_purge_age(BucketName, BucketConfig) -\u003e"},{"line_number":123,"context_line":"    case ns_bucket:is_persistent(BucketName) of"}],"source_content_type":"text/x-erlang","patch_set":7,"id":"4f121ac8_1d8f8000","line":120,"range":{"start_line":99,"start_character":0,"end_line":120,"end_character":14},"in_reply_to":"66860496_1218ac04","updated":"2020-01-17 00:43:39.000000000","message":"\u003e maybe this way:\n \u003e \n \u003e get_eviction_policy(Persistent, BucketConfig) -\u003e\n \u003e case ns_bucket:is_persistent(BucketConfig) of\n \u003e Persistent -\u003e\n \u003e case ns_bucket:eviction_policy(BucketConfig) of\n \u003e nru_eviction -\u003e\n \u003e auto_delete;\n \u003e no_eviction -\u003e\n \u003e fail_new_data;\n \u003e Other -\u003e\n \u003e Other\n \u003e end;\n \u003e _ -\u003e\n \u003e undefined\n \u003e end.","commit_id":"fc050d463f011ff2d7d890e85dbe63447143801c"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"661ed4c3f347d74b9499498fa8cd3cb83a02b454","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            []"},{"line_number":97,"context_line":"    end."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"item_eviction_policy(BucketConfig) -\u003e"},{"line_number":100,"context_line":"    UsesItemEviction \u003d ns_bucket:uses_item_eviction(BucketConfig),"},{"line_number":101,"context_line":"    do_item_eviction_policy(UsesItemEviction, BucketConfig)."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"do_item_eviction_policy(true, BucketConfig) -\u003e"},{"line_number":104,"context_line":"    proplists:get_value(eviction_policy, BucketConfig, value_only);"},{"line_number":105,"context_line":"do_item_eviction_policy(false, _BucketConfig) -\u003e"},{"line_number":106,"context_line":"    undefined."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"ephemeral_full_policy(BucketConfig) -\u003e"},{"line_number":109,"context_line":"    UsesFullEviction \u003d ns_bucket:uses_full_eviction(BucketConfig),"},{"line_number":110,"context_line":"    do_full_policy(UsesFullEviction, BucketConfig)."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"do_full_policy(true, BucketConfig) -\u003e"},{"line_number":113,"context_line":"    case proplists:get_value(eviction_policy, BucketConfig, no_eviction) of"},{"line_number":114,"context_line":"        nru_eviction -\u003e"},{"line_number":115,"context_line":"            auto_delete;"},{"line_number":116,"context_line":"        no_eviction -\u003e"},{"line_number":117,"context_line":"            fail_new_data"},{"line_number":118,"context_line":"    end;"},{"line_number":119,"context_line":"do_full_policy(false, _BucketConfig) -\u003e"},{"line_number":120,"context_line":"    undefined."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"ephemeral_metadata_purge_age(BucketName, BucketConfig) -\u003e"},{"line_number":123,"context_line":"    case ns_bucket:is_persistent(BucketName) of"}],"source_content_type":"text/x-erlang","patch_set":7,"id":"f464dfd5_fb8fef83","line":120,"range":{"start_line":99,"start_character":0,"end_line":120,"end_character":14},"in_reply_to":"66860496_1218ac04","updated":"2020-01-16 23:30:41.000000000","message":"Yes, this does look to work....will try it.","commit_id":"fc050d463f011ff2d7d890e85dbe63447143801c"},{"author":{"_account_id":1000487,"name":"Artem Stemkovski","email":"artem@couchbase.com","username":"astemkov","avatars":[{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f31890e7d3e24ca5ccce7635d3933a0889874249","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    undefined."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"ephemeral_metadata_purge_age(BucketName, BucketConfig) -\u003e"},{"line_number":123,"context_line":"    case ns_bucket:is_persistent(BucketName) of"},{"line_number":124,"context_line":"        true -\u003e"},{"line_number":125,"context_line":"            undefined;"},{"line_number":126,"context_line":"        false -\u003e"}],"source_content_type":"text/x-erlang","patch_set":7,"id":"e05526fe_2722d0e9","line":123,"range":{"start_line":123,"start_character":9,"end_line":123,"end_character":32},"updated":"2020-01-16 22:38:25.000000000","message":"this does unnecessary get_bucket. I would modify is_persistent to take BucketConfig as parameter.","commit_id":"fc050d463f011ff2d7d890e85dbe63447143801c"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"661ed4c3f347d74b9499498fa8cd3cb83a02b454","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    undefined."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"ephemeral_metadata_purge_age(BucketName, BucketConfig) -\u003e"},{"line_number":123,"context_line":"    case ns_bucket:is_persistent(BucketName) of"},{"line_number":124,"context_line":"        true -\u003e"},{"line_number":125,"context_line":"            undefined;"},{"line_number":126,"context_line":"        false -\u003e"}],"source_content_type":"text/x-erlang","patch_set":7,"id":"fe9ca5b0_8ae73358","line":123,"range":{"start_line":123,"start_character":9,"end_line":123,"end_character":32},"in_reply_to":"e05526fe_2722d0e9","updated":"2020-01-16 23:30:41.000000000","message":"Will do","commit_id":"fc050d463f011ff2d7d890e85dbe63447143801c"}],"src/menelaus_web_buckets.erl":[{"author":{"_account_id":1000208,"name":"Aliaksey Artamonau","email":"aliaksey.artamonau@couchbase.com","username":"aartamonau","avatars":[{"url":"https://www.gravatar.com/avatar/bb71c4f683f0911004c62e00ca56922a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/bb71c4f683f0911004c62e00ca56922a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/bb71c4f683f0911004c62e00ca56922a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/bb71c4f683f0911004c62e00ca56922a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"360d6e5c4b8b20fd85767e602d67373737c27657","unresolved":false,"context_lines":[{"line_number":399,"context_line":"              | Suffix4]}."},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"build_ddocs_uri(StorageMode, Id, BucketConfig)"},{"line_number":402,"context_line":"  when StorageMode \u003d:\u003d couchstore;"},{"line_number":403,"context_line":"       StorageMode \u003d:\u003d magma -\u003e"},{"line_number":404,"context_line":"    DDocsURI \u003d bin_concat_path([\"pools\", \"default\", \"buckets\","},{"line_number":405,"context_line":"                                Id, \"ddocs\"]),"},{"line_number":406,"context_line":"    [{ddocs, {struct, [{uri, DDocsURI}]}},"}],"source_content_type":"text/x-erlang","patch_set":3,"id":"906f595f_4647c24a","line":403,"range":{"start_line":402,"start_character":7,"end_line":403,"end_character":31},"updated":"2020-01-08 21:57:31.000000000","message":"Should use ns_bucket:can_have_views.","commit_id":"5a3559375f66fea77185d1faefc5436be4f59294"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"8d7386e314cb8fdfad9306edf126925dfe1bbd21","unresolved":false,"context_lines":[{"line_number":399,"context_line":"              | Suffix4]}."},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"build_ddocs_uri(StorageMode, Id, BucketConfig)"},{"line_number":402,"context_line":"  when StorageMode \u003d:\u003d couchstore;"},{"line_number":403,"context_line":"       StorageMode \u003d:\u003d magma -\u003e"},{"line_number":404,"context_line":"    DDocsURI \u003d bin_concat_path([\"pools\", \"default\", \"buckets\","},{"line_number":405,"context_line":"                                Id, \"ddocs\"]),"},{"line_number":406,"context_line":"    [{ddocs, {struct, [{uri, DDocsURI}]}},"}],"source_content_type":"text/x-erlang","patch_set":3,"id":"be0c8422_e412cc02","line":403,"range":{"start_line":402,"start_character":7,"end_line":403,"end_character":31},"in_reply_to":"906f595f_4647c24a","updated":"2020-01-09 21:37:08.000000000","message":"Done","commit_id":"5a3559375f66fea77185d1faefc5436be4f59294"},{"author":{"_account_id":1000208,"name":"Aliaksey Artamonau","email":"aliaksey.artamonau@couchbase.com","username":"aartamonau","avatars":[{"url":"https://www.gravatar.com/avatar/bb71c4f683f0911004c62e00ca56922a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/bb71c4f683f0911004c62e00ca56922a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/bb71c4f683f0911004c62e00ca56922a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/bb71c4f683f0911004c62e00ca56922a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"360d6e5c4b8b20fd85767e602d67373737c27657","unresolved":false,"context_lines":[{"line_number":418,"context_line":"                Conditional \u003d"},{"line_number":419,"context_line":"                    [{collections, collections:enabled(BucketConfig)},"},{"line_number":420,"context_line":"                     {durableWrite, cluster_compat_mode:is_cluster_65()},"},{"line_number":421,"context_line":"                     {couchapi, StorageMode \u003d:\u003d couchstore orelse"},{"line_number":422,"context_line":"                                StorageMode \u003d:\u003d magma}],"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"                [C || {C, true} \u003c- Conditional] ++"},{"line_number":425,"context_line":"                    [dcp, cbhello, touch, cccp, xdcrCheckpointing, nodesExt,"}],"source_content_type":"text/x-erlang","patch_set":3,"id":"0729aeed_d4885962","line":422,"range":{"start_line":421,"start_character":32,"end_line":422,"end_character":53},"updated":"2020-01-08 21:57:31.000000000","message":"Should use ns_bucket:can_have_views.","commit_id":"5a3559375f66fea77185d1faefc5436be4f59294"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"8d7386e314cb8fdfad9306edf126925dfe1bbd21","unresolved":false,"context_lines":[{"line_number":418,"context_line":"                Conditional \u003d"},{"line_number":419,"context_line":"                    [{collections, collections:enabled(BucketConfig)},"},{"line_number":420,"context_line":"                     {durableWrite, cluster_compat_mode:is_cluster_65()},"},{"line_number":421,"context_line":"                     {couchapi, StorageMode \u003d:\u003d couchstore orelse"},{"line_number":422,"context_line":"                                StorageMode \u003d:\u003d magma}],"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"                [C || {C, true} \u003c- Conditional] ++"},{"line_number":425,"context_line":"                    [dcp, cbhello, touch, cccp, xdcrCheckpointing, nodesExt,"}],"source_content_type":"text/x-erlang","patch_set":3,"id":"f3202f8c_f4425357","line":422,"range":{"start_line":421,"start_character":32,"end_line":422,"end_character":53},"in_reply_to":"0729aeed_d4885962","updated":"2020-01-09 21:37:08.000000000","message":"Done","commit_id":"5a3559375f66fea77185d1faefc5436be4f59294"},{"author":{"_account_id":1000208,"name":"Aliaksey Artamonau","email":"aliaksey.artamonau@couchbase.com","username":"aartamonau","avatars":[{"url":"https://www.gravatar.com/avatar/bb71c4f683f0911004c62e00ca56922a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/bb71c4f683f0911004c62e00ca56922a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/bb71c4f683f0911004c62e00ca56922a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/bb71c4f683f0911004c62e00ca56922a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"360d6e5c4b8b20fd85767e602d67373737c27657","unresolved":false,"context_lines":[{"line_number":1155,"context_line":"get_storage_mode_based_on_storage_backend(Params) -\u003e"},{"line_number":1156,"context_line":"    StorageBackend \u003d proplists:get_value(\"storageBackend\", Params,"},{"line_number":1157,"context_line":"                                         \"couchstore\"),"},{"line_number":1158,"context_line":"    {ok, storage_mode, list_to_atom(StorageBackend)}."},{"line_number":1159,"context_line":""},{"line_number":1160,"context_line":"get_conflict_resolution_type_and_thresholds(Params, _BucketConfig, true \u003d IsNew) -\u003e"},{"line_number":1161,"context_line":"    case proplists:get_value(\"conflictResolutionType\", Params) of"}],"source_content_type":"text/x-erlang","patch_set":3,"id":"2be09372_8047e55b","line":1158,"range":{"start_line":1158,"start_character":23,"end_line":1158,"end_character":35},"updated":"2020-01-08 21:57:31.000000000","message":"list_to_atom shouldn\u0027t be called on data supplied by the user without first validating it.","commit_id":"5a3559375f66fea77185d1faefc5436be4f59294"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"8d7386e314cb8fdfad9306edf126925dfe1bbd21","unresolved":false,"context_lines":[{"line_number":1155,"context_line":"get_storage_mode_based_on_storage_backend(Params) -\u003e"},{"line_number":1156,"context_line":"    StorageBackend \u003d proplists:get_value(\"storageBackend\", Params,"},{"line_number":1157,"context_line":"                                         \"couchstore\"),"},{"line_number":1158,"context_line":"    {ok, storage_mode, list_to_atom(StorageBackend)}."},{"line_number":1159,"context_line":""},{"line_number":1160,"context_line":"get_conflict_resolution_type_and_thresholds(Params, _BucketConfig, true \u003d IsNew) -\u003e"},{"line_number":1161,"context_line":"    case proplists:get_value(\"conflictResolutionType\", Params) of"}],"source_content_type":"text/x-erlang","patch_set":3,"id":"5ada9478_97e3ea09","line":1158,"range":{"start_line":1158,"start_character":23,"end_line":1158,"end_character":35},"in_reply_to":"2be09372_8047e55b","updated":"2020-01-09 21:37:08.000000000","message":"Done","commit_id":"5a3559375f66fea77185d1faefc5436be4f59294"},{"author":{"_account_id":1000487,"name":"Artem Stemkovski","email":"artem@couchbase.com","username":"astemkov","avatars":[{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e73ae7e79fa4e1ebf1159ca7603fd357d556da32","unresolved":false,"context_lines":[{"line_number":183,"context_line":"external_bucket_type(BucketConfig) -\u003e"},{"line_number":184,"context_line":"    external_bucket_type(ns_bucket:bucket_type(BucketConfig), BucketConfig)."},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"external_bucket_type(memcached \u003d _Type, _) -\u003e"},{"line_number":187,"context_line":"    memcached;"},{"line_number":188,"context_line":"external_bucket_type(membase \u003d _Type, BucketConfig) -\u003e"},{"line_number":189,"context_line":"    case ns_bucket:storage_mode(BucketConfig) of"},{"line_number":190,"context_line":"        couchstore -\u003e"},{"line_number":191,"context_line":"            membase;"},{"line_number":192,"context_line":"        magma -\u003e"},{"line_number":193,"context_line":"            membase;"},{"line_number":194,"context_line":"        ephemeral -\u003e"},{"line_number":195,"context_line":"            ephemeral"},{"line_number":196,"context_line":"    end."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"build_auto_compaction_info(BucketConfig) -\u003e"},{"line_number":199,"context_line":"    UsesAutoCompactionInfo \u003d ns_bucket:uses_auto_compaction_info(BucketConfig),"}],"source_content_type":"text/x-erlang","patch_set":6,"id":"0ddd0fb9_191afeb8","line":196,"range":{"start_line":186,"start_character":0,"end_line":196,"end_character":8},"updated":"2020-01-14 03:48:36.000000000","message":"can you move this to ns_bucket too?","commit_id":"2d8eb77cec45fb77e35b6d1a3e91ab6e56237335"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"203d0284de32798be72d83775cab252a49ba29de","unresolved":false,"context_lines":[{"line_number":183,"context_line":"external_bucket_type(BucketConfig) -\u003e"},{"line_number":184,"context_line":"    external_bucket_type(ns_bucket:bucket_type(BucketConfig), BucketConfig)."},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"external_bucket_type(memcached \u003d _Type, _) -\u003e"},{"line_number":187,"context_line":"    memcached;"},{"line_number":188,"context_line":"external_bucket_type(membase \u003d _Type, BucketConfig) -\u003e"},{"line_number":189,"context_line":"    case ns_bucket:storage_mode(BucketConfig) of"},{"line_number":190,"context_line":"        couchstore -\u003e"},{"line_number":191,"context_line":"            membase;"},{"line_number":192,"context_line":"        magma -\u003e"},{"line_number":193,"context_line":"            membase;"},{"line_number":194,"context_line":"        ephemeral -\u003e"},{"line_number":195,"context_line":"            ephemeral"},{"line_number":196,"context_line":"    end."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"build_auto_compaction_info(BucketConfig) -\u003e"},{"line_number":199,"context_line":"    UsesAutoCompactionInfo \u003d ns_bucket:uses_auto_compaction_info(BucketConfig),"}],"source_content_type":"text/x-erlang","patch_set":6,"id":"541b8aae_dfd16c70","line":196,"range":{"start_line":186,"start_character":0,"end_line":196,"end_character":8},"in_reply_to":"0ddd0fb9_191afeb8","updated":"2020-01-14 19:30:19.000000000","message":"I\u0027d like to leave this as is.  The reason is this is an external transformation that is more UI driven.  Or if we think this should change I\u0027d like to do so as an independent one from this.","commit_id":"2d8eb77cec45fb77e35b6d1a3e91ab6e56237335"},{"author":{"_account_id":1000487,"name":"Artem Stemkovski","email":"artem@couchbase.com","username":"astemkov","avatars":[{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"232e171ca00bfbd2995f23b39e9766a3cf691e3c","unresolved":false,"context_lines":[{"line_number":183,"context_line":"external_bucket_type(BucketConfig) -\u003e"},{"line_number":184,"context_line":"    external_bucket_type(ns_bucket:bucket_type(BucketConfig), BucketConfig)."},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"external_bucket_type(memcached \u003d _Type, _) -\u003e"},{"line_number":187,"context_line":"    memcached;"},{"line_number":188,"context_line":"external_bucket_type(membase \u003d _Type, BucketConfig) -\u003e"},{"line_number":189,"context_line":"    case ns_bucket:storage_mode(BucketConfig) of"},{"line_number":190,"context_line":"        couchstore -\u003e"},{"line_number":191,"context_line":"            membase;"},{"line_number":192,"context_line":"        magma -\u003e"},{"line_number":193,"context_line":"            membase;"},{"line_number":194,"context_line":"        ephemeral -\u003e"},{"line_number":195,"context_line":"            ephemeral"},{"line_number":196,"context_line":"    end."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"build_auto_compaction_info(BucketConfig) -\u003e"},{"line_number":199,"context_line":"    UsesAutoCompactionInfo \u003d ns_bucket:uses_auto_compaction_info(BucketConfig),"}],"source_content_type":"text/x-erlang","patch_set":6,"id":"649f399d_c33f3076","line":196,"range":{"start_line":186,"start_character":0,"end_line":196,"end_character":8},"in_reply_to":"541b8aae_dfd16c70","updated":"2020-01-15 00:05:25.000000000","message":"This is not just UI. It\u0027s there for REST API compat. I would prefer to have external_type function in ns_bucket just to keep all this spaghetti in one place","commit_id":"2d8eb77cec45fb77e35b6d1a3e91ab6e56237335"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"45093aa0f3ace833db0b1de953847c1a553ce330","unresolved":false,"context_lines":[{"line_number":183,"context_line":"external_bucket_type(BucketConfig) -\u003e"},{"line_number":184,"context_line":"    external_bucket_type(ns_bucket:bucket_type(BucketConfig), BucketConfig)."},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"external_bucket_type(memcached \u003d _Type, _) -\u003e"},{"line_number":187,"context_line":"    memcached;"},{"line_number":188,"context_line":"external_bucket_type(membase \u003d _Type, BucketConfig) -\u003e"},{"line_number":189,"context_line":"    case ns_bucket:storage_mode(BucketConfig) of"},{"line_number":190,"context_line":"        couchstore -\u003e"},{"line_number":191,"context_line":"            membase;"},{"line_number":192,"context_line":"        magma -\u003e"},{"line_number":193,"context_line":"            membase;"},{"line_number":194,"context_line":"        ephemeral -\u003e"},{"line_number":195,"context_line":"            ephemeral"},{"line_number":196,"context_line":"    end."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"build_auto_compaction_info(BucketConfig) -\u003e"},{"line_number":199,"context_line":"    UsesAutoCompactionInfo \u003d ns_bucket:uses_auto_compaction_info(BucketConfig),"}],"source_content_type":"text/x-erlang","patch_set":6,"id":"a46e2ee9_3887a3af","line":196,"range":{"start_line":186,"start_character":0,"end_line":196,"end_character":8},"in_reply_to":"649f399d_c33f3076","updated":"2020-01-15 00:32:56.000000000","message":"Ok, I\u0027ll do this as a change on the tail end of this set of changes.  I\u0027ve done quite a bit of testing and this will isolate any issues that arise.","commit_id":"2d8eb77cec45fb77e35b6d1a3e91ab6e56237335"},{"author":{"_account_id":1000487,"name":"Artem Stemkovski","email":"artem@couchbase.com","username":"astemkov","avatars":[{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e73ae7e79fa4e1ebf1159ca7603fd357d556da32","unresolved":false,"context_lines":[{"line_number":765,"context_line":"            [{replicaNumber, ?l2b(\"Warning: \" ++ Msg ++ \".\")}]"},{"line_number":766,"context_line":"    end."},{"line_number":767,"context_line":""},{"line_number":768,"context_line":"%% Default bucket type is now couchbase and not membase. Ideally, we should"},{"line_number":769,"context_line":"%% change the default bucket type atom to couchbase but the bucket type membase"},{"line_number":770,"context_line":"%% is used/checked at multiple locations. For similar reasons, the ephemeral"},{"line_number":771,"context_line":"%% bucket type also gets stored as \u0027membase\u0027 and to differentiate between the"},{"line_number":772,"context_line":"%% couchbase and ephemeral buckets we store an extra parameter called"},{"line_number":773,"context_line":"%% \u0027storage_mode\u0027. So to fix the log message to display the correct bucket type"},{"line_number":774,"context_line":"%% we use both type and storage_mode parameters of the bucket config."},{"line_number":775,"context_line":"display_type(membase \u003d _Type, couchstore \u003d _StorageMode) -\u003e"},{"line_number":776,"context_line":"    couchbase;"},{"line_number":777,"context_line":"display_type(membase \u003d _Type, magma \u003d _StorageMode) -\u003e"},{"line_number":778,"context_line":"    couchbase;"},{"line_number":779,"context_line":"display_type(membase \u003d _Type, ephemeral \u003d _StorageMode) -\u003e"},{"line_number":780,"context_line":"    ephemeral;"},{"line_number":781,"context_line":"display_type(Type, _) -\u003e"},{"line_number":782,"context_line":"    Type."},{"line_number":783,"context_line":""},{"line_number":784,"context_line":"handle_bucket_flush(_PoolId, Id, Req) -\u003e"},{"line_number":785,"context_line":"    XDCRDocs \u003d goxdcr_rest:find_all_replication_docs(),"}],"source_content_type":"text/x-erlang","patch_set":6,"id":"d1275369_5e436eaa","line":782,"range":{"start_line":768,"start_character":0,"end_line":782,"end_character":9},"updated":"2020-01-14 03:48:36.000000000","message":"can you move this to ns_bucket too?","commit_id":"2d8eb77cec45fb77e35b6d1a3e91ab6e56237335"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"203d0284de32798be72d83775cab252a49ba29de","unresolved":false,"context_lines":[{"line_number":765,"context_line":"            [{replicaNumber, ?l2b(\"Warning: \" ++ Msg ++ \".\")}]"},{"line_number":766,"context_line":"    end."},{"line_number":767,"context_line":""},{"line_number":768,"context_line":"%% Default bucket type is now couchbase and not membase. Ideally, we should"},{"line_number":769,"context_line":"%% change the default bucket type atom to couchbase but the bucket type membase"},{"line_number":770,"context_line":"%% is used/checked at multiple locations. For similar reasons, the ephemeral"},{"line_number":771,"context_line":"%% bucket type also gets stored as \u0027membase\u0027 and to differentiate between the"},{"line_number":772,"context_line":"%% couchbase and ephemeral buckets we store an extra parameter called"},{"line_number":773,"context_line":"%% \u0027storage_mode\u0027. So to fix the log message to display the correct bucket type"},{"line_number":774,"context_line":"%% we use both type and storage_mode parameters of the bucket config."},{"line_number":775,"context_line":"display_type(membase \u003d _Type, couchstore \u003d _StorageMode) -\u003e"},{"line_number":776,"context_line":"    couchbase;"},{"line_number":777,"context_line":"display_type(membase \u003d _Type, magma \u003d _StorageMode) -\u003e"},{"line_number":778,"context_line":"    couchbase;"},{"line_number":779,"context_line":"display_type(membase \u003d _Type, ephemeral \u003d _StorageMode) -\u003e"},{"line_number":780,"context_line":"    ephemeral;"},{"line_number":781,"context_line":"display_type(Type, _) -\u003e"},{"line_number":782,"context_line":"    Type."},{"line_number":783,"context_line":""},{"line_number":784,"context_line":"handle_bucket_flush(_PoolId, Id, Req) -\u003e"},{"line_number":785,"context_line":"    XDCRDocs \u003d goxdcr_rest:find_all_replication_docs(),"}],"source_content_type":"text/x-erlang","patch_set":6,"id":"f21ef918_b66c2c56","line":782,"range":{"start_line":768,"start_character":0,"end_line":782,"end_character":9},"in_reply_to":"d1275369_5e436eaa","updated":"2020-01-14 19:30:19.000000000","message":"Same here.  If we decide to move this I\u0027d like to do so as an independent change.","commit_id":"2d8eb77cec45fb77e35b6d1a3e91ab6e56237335"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"45093aa0f3ace833db0b1de953847c1a553ce330","unresolved":false,"context_lines":[{"line_number":765,"context_line":"            [{replicaNumber, ?l2b(\"Warning: \" ++ Msg ++ \".\")}]"},{"line_number":766,"context_line":"    end."},{"line_number":767,"context_line":""},{"line_number":768,"context_line":"%% Default bucket type is now couchbase and not membase. Ideally, we should"},{"line_number":769,"context_line":"%% change the default bucket type atom to couchbase but the bucket type membase"},{"line_number":770,"context_line":"%% is used/checked at multiple locations. For similar reasons, the ephemeral"},{"line_number":771,"context_line":"%% bucket type also gets stored as \u0027membase\u0027 and to differentiate between the"},{"line_number":772,"context_line":"%% couchbase and ephemeral buckets we store an extra parameter called"},{"line_number":773,"context_line":"%% \u0027storage_mode\u0027. So to fix the log message to display the correct bucket type"},{"line_number":774,"context_line":"%% we use both type and storage_mode parameters of the bucket config."},{"line_number":775,"context_line":"display_type(membase \u003d _Type, couchstore \u003d _StorageMode) -\u003e"},{"line_number":776,"context_line":"    couchbase;"},{"line_number":777,"context_line":"display_type(membase \u003d _Type, magma \u003d _StorageMode) -\u003e"},{"line_number":778,"context_line":"    couchbase;"},{"line_number":779,"context_line":"display_type(membase \u003d _Type, ephemeral \u003d _StorageMode) -\u003e"},{"line_number":780,"context_line":"    ephemeral;"},{"line_number":781,"context_line":"display_type(Type, _) -\u003e"},{"line_number":782,"context_line":"    Type."},{"line_number":783,"context_line":""},{"line_number":784,"context_line":"handle_bucket_flush(_PoolId, Id, Req) -\u003e"},{"line_number":785,"context_line":"    XDCRDocs \u003d goxdcr_rest:find_all_replication_docs(),"}],"source_content_type":"text/x-erlang","patch_set":6,"id":"4e320a3d_fad3b475","line":782,"range":{"start_line":768,"start_character":0,"end_line":782,"end_character":9},"in_reply_to":"f21ef918_b66c2c56","updated":"2020-01-15 00:32:56.000000000","message":"Will include this in the change at the end of this set.","commit_id":"2d8eb77cec45fb77e35b6d1a3e91ab6e56237335"},{"author":{"_account_id":1000487,"name":"Artem Stemkovski","email":"artem@couchbase.com","username":"astemkov","avatars":[{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"232e171ca00bfbd2995f23b39e9766a3cf691e3c","unresolved":false,"context_lines":[{"line_number":773,"context_line":"%% \u0027storage_mode\u0027. So to fix the log message to display the correct bucket type"},{"line_number":774,"context_line":"%% we use both type and storage_mode parameters of the bucket config."},{"line_number":775,"context_line":"display_type(membase \u003d _Type, couchstore \u003d _StorageMode) -\u003e"},{"line_number":776,"context_line":"    couchbase;"},{"line_number":777,"context_line":"display_type(membase \u003d _Type, magma \u003d _StorageMode) -\u003e"},{"line_number":778,"context_line":"    couchbase;"},{"line_number":779,"context_line":"display_type(membase \u003d _Type, ephemeral \u003d _StorageMode) -\u003e"}],"source_content_type":"text/x-erlang","patch_set":7,"id":"8856c724_5a1e48c8","line":776,"range":{"start_line":776,"start_character":0,"end_line":776,"end_character":14},"updated":"2020-01-15 00:05:25.000000000","message":"This makes couchstore and magma buckets undistinguishable in the user log. Not sure if this is ok.","commit_id":"fc050d463f011ff2d7d890e85dbe63447143801c"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"82fe06146e93984dafd9afb478e581737bfec645","unresolved":false,"context_lines":[{"line_number":773,"context_line":"%% \u0027storage_mode\u0027. So to fix the log message to display the correct bucket type"},{"line_number":774,"context_line":"%% we use both type and storage_mode parameters of the bucket config."},{"line_number":775,"context_line":"display_type(membase \u003d _Type, couchstore \u003d _StorageMode) -\u003e"},{"line_number":776,"context_line":"    couchbase;"},{"line_number":777,"context_line":"display_type(membase \u003d _Type, magma \u003d _StorageMode) -\u003e"},{"line_number":778,"context_line":"    couchbase;"},{"line_number":779,"context_line":"display_type(membase \u003d _Type, ephemeral \u003d _StorageMode) -\u003e"}],"source_content_type":"text/x-erlang","patch_set":7,"id":"94af4546_6a6eae61","line":776,"range":{"start_line":776,"start_character":0,"end_line":776,"end_character":14},"in_reply_to":"8856c724_5a1e48c8","updated":"2020-01-15 00:53:38.000000000","message":"From the user perspective they\u0027re both couchbase buckets but their backend storage attribute is different.  I had a change set where magma buckets were a different type but we decided to go down this path.","commit_id":"fc050d463f011ff2d7d890e85dbe63447143801c"},{"author":{"_account_id":1000487,"name":"Artem Stemkovski","email":"artem@couchbase.com","username":"astemkov","avatars":[{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"fab025ee4021255ca0419ea63a5a6afc7fc59e16","unresolved":false,"context_lines":[{"line_number":186,"context_line":"external_bucket_type(memcached \u003d _Type, _) -\u003e"},{"line_number":187,"context_line":"    memcached;"},{"line_number":188,"context_line":"external_bucket_type(membase \u003d _Type, BucketConfig) -\u003e"},{"line_number":189,"context_line":"    case ns_bucket:storage_mode(BucketConfig) of"},{"line_number":190,"context_line":"        couchstore -\u003e"},{"line_number":191,"context_line":"            membase;"},{"line_number":192,"context_line":"        magma -\u003e"}],"source_content_type":"text/x-erlang","patch_set":10,"id":"3d704eea_31ea46a1","line":189,"range":{"start_line":189,"start_character":4,"end_line":189,"end_character":48},"updated":"2020-01-21 19:29:18.000000000","message":"I would use is_persistent here too","commit_id":"e09cb20246803f1b4f9741aa6f0a0b5f5feeec71"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7f3a25368e2b6ea99c8ce6257c43c27de8985a74","unresolved":false,"context_lines":[{"line_number":186,"context_line":"external_bucket_type(memcached \u003d _Type, _) -\u003e"},{"line_number":187,"context_line":"    memcached;"},{"line_number":188,"context_line":"external_bucket_type(membase \u003d _Type, BucketConfig) -\u003e"},{"line_number":189,"context_line":"    case ns_bucket:storage_mode(BucketConfig) of"},{"line_number":190,"context_line":"        couchstore -\u003e"},{"line_number":191,"context_line":"            membase;"},{"line_number":192,"context_line":"        magma -\u003e"}],"source_content_type":"text/x-erlang","patch_set":10,"id":"0633c187_237e7376","line":189,"range":{"start_line":189,"start_character":4,"end_line":189,"end_character":48},"in_reply_to":"3d704eea_31ea46a1","updated":"2020-01-21 20:10:35.000000000","message":"Done","commit_id":"e09cb20246803f1b4f9741aa6f0a0b5f5feeec71"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7f3a25368e2b6ea99c8ce6257c43c27de8985a74","unresolved":false,"context_lines":[{"line_number":217,"context_line":"            case ns_bucket:storage_mode(BucketConfig) of"},{"line_number":218,"context_line":"                ephemeral -\u003e"},{"line_number":219,"context_line":"                    [];"},{"line_number":220,"context_line":"                _ -\u003e"},{"line_number":221,"context_line":"                    %% When the bucket type is memcached."},{"line_number":222,"context_line":"                    [{autoCompactionSettings, false}]"},{"line_number":223,"context_line":"            end"}],"source_content_type":"text/x-erlang","patch_set":10,"id":"bdd884ae_253dfedd","line":220,"updated":"2020-01-21 20:10:35.000000000","message":"undefined","commit_id":"e09cb20246803f1b4f9741aa6f0a0b5f5feeec71"},{"author":{"_account_id":1000487,"name":"Artem Stemkovski","email":"artem@couchbase.com","username":"astemkov","avatars":[{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"fab025ee4021255ca0419ea63a5a6afc7fc59e16","unresolved":false,"context_lines":[{"line_number":243,"context_line":"                ephemeral -\u003e"},{"line_number":244,"context_line":"                    [{purgeInterval, proplists:get_value(purge_interval,"},{"line_number":245,"context_line":"                                                         BucketConfig)}];"},{"line_number":246,"context_line":"                _ -\u003e"},{"line_number":247,"context_line":"                    %% When the bucket type is memcached."},{"line_number":248,"context_line":"                    []"},{"line_number":249,"context_line":"            end"}],"source_content_type":"text/x-erlang","patch_set":10,"id":"13ba0de4_7e9dd91b","line":246,"range":{"start_line":246,"start_character":16,"end_line":246,"end_character":17},"updated":"2020-01-21 19:29:18.000000000","message":"undefined","commit_id":"e09cb20246803f1b4f9741aa6f0a0b5f5feeec71"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7f3a25368e2b6ea99c8ce6257c43c27de8985a74","unresolved":false,"context_lines":[{"line_number":243,"context_line":"                ephemeral -\u003e"},{"line_number":244,"context_line":"                    [{purgeInterval, proplists:get_value(purge_interval,"},{"line_number":245,"context_line":"                                                         BucketConfig)}];"},{"line_number":246,"context_line":"                _ -\u003e"},{"line_number":247,"context_line":"                    %% When the bucket type is memcached."},{"line_number":248,"context_line":"                    []"},{"line_number":249,"context_line":"            end"}],"source_content_type":"text/x-erlang","patch_set":10,"id":"c50941b0_545ce5d4","line":246,"range":{"start_line":246,"start_character":16,"end_line":246,"end_character":17},"in_reply_to":"13ba0de4_7e9dd91b","updated":"2020-01-21 20:10:35.000000000","message":"Done","commit_id":"e09cb20246803f1b4f9741aa6f0a0b5f5feeec71"},{"author":{"_account_id":1000487,"name":"Artem Stemkovski","email":"artem@couchbase.com","username":"astemkov","avatars":[{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"fab025ee4021255ca0419ea63a5a6afc7fc59e16","unresolved":false,"context_lines":[{"line_number":306,"context_line":"                                            {rawRAM, ns_bucket:raw_ram_quota(BucketConfig)}]}},"},{"line_number":307,"context_line":"                          {basicStats, {struct, BasicStats}},"},{"line_number":308,"context_line":"                          {evictionPolicy, EvictionPolicy},"},{"line_number":309,"context_line":"                          {conflictResolutionType, ConflictResolutionType}"},{"line_number":310,"context_line":"                          | BucketCaps],"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"                     BucketParams1 \u003d"}],"source_content_type":"text/x-erlang","patch_set":10,"id":"4a6d4ea3_0cea0bd5","line":309,"range":{"start_line":309,"start_character":26,"end_line":309,"end_character":74},"updated":"2020-01-21 19:29:18.000000000","message":"I would add storageBackend parameter here. Just to make this long fun slightly shorter","commit_id":"e09cb20246803f1b4f9741aa6f0a0b5f5feeec71"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7f3a25368e2b6ea99c8ce6257c43c27de8985a74","unresolved":false,"context_lines":[{"line_number":306,"context_line":"                                            {rawRAM, ns_bucket:raw_ram_quota(BucketConfig)}]}},"},{"line_number":307,"context_line":"                          {basicStats, {struct, BasicStats}},"},{"line_number":308,"context_line":"                          {evictionPolicy, EvictionPolicy},"},{"line_number":309,"context_line":"                          {conflictResolutionType, ConflictResolutionType}"},{"line_number":310,"context_line":"                          | BucketCaps],"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"                     BucketParams1 \u003d"}],"source_content_type":"text/x-erlang","patch_set":10,"id":"bdf7a779_ed9fc275","line":309,"range":{"start_line":309,"start_character":26,"end_line":309,"end_character":74},"in_reply_to":"4a6d4ea3_0cea0bd5","updated":"2020-01-21 20:10:35.000000000","message":"Done","commit_id":"e09cb20246803f1b4f9741aa6f0a0b5f5feeec71"},{"author":{"_account_id":1000487,"name":"Artem Stemkovski","email":"artem@couchbase.com","username":"astemkov","avatars":[{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"fab025ee4021255ca0419ea63a5a6afc7fc59e16","unresolved":false,"context_lines":[{"line_number":359,"context_line":"    Suffix2 \u003d ACInfo ++ PIInfo ++ Suffix1 ,"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"    CanHaveViews \u003d ns_bucket:can_have_views(BucketConfig),"},{"line_number":362,"context_line":"    Suffix3 \u003d case build_ddocs_uri(CanHaveViews, Id, BucketConfig) of"},{"line_number":363,"context_line":"                  [] -\u003e"},{"line_number":364,"context_line":"                      Suffix2;"},{"line_number":365,"context_line":"                  Uri -\u003e"},{"line_number":366,"context_line":"                      Uri ++ Suffix2"},{"line_number":367,"context_line":"              end,"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    FlushEnabled \u003d proplists:get_value(flush_enabled, BucketConfig, false),"},{"line_number":370,"context_line":"    MaybeFlushController \u003d"}],"source_content_type":"text/x-erlang","patch_set":10,"id":"454ffea7_0ed65230","line":367,"range":{"start_line":362,"start_character":4,"end_line":367,"end_character":18},"updated":"2020-01-21 19:29:18.000000000","message":"this case can be replaced with just Uri ++ Suffix2","commit_id":"e09cb20246803f1b4f9741aa6f0a0b5f5feeec71"},{"author":{"_account_id":1000487,"name":"Artem Stemkovski","email":"artem@couchbase.com","username":"astemkov","avatars":[{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ac045ee03ca073179337366c028ce152f9841bd6","unresolved":false,"context_lines":[{"line_number":359,"context_line":"    Suffix2 \u003d ACInfo ++ PIInfo ++ Suffix1 ,"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"    CanHaveViews \u003d ns_bucket:can_have_views(BucketConfig),"},{"line_number":362,"context_line":"    Suffix3 \u003d case build_ddocs_uri(CanHaveViews, Id, BucketConfig) of"},{"line_number":363,"context_line":"                  [] -\u003e"},{"line_number":364,"context_line":"                      Suffix2;"},{"line_number":365,"context_line":"                  Uri -\u003e"},{"line_number":366,"context_line":"                      Uri ++ Suffix2"},{"line_number":367,"context_line":"              end,"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    FlushEnabled \u003d proplists:get_value(flush_enabled, BucketConfig, false),"},{"line_number":370,"context_line":"    MaybeFlushController \u003d"}],"source_content_type":"text/x-erlang","patch_set":10,"id":"ab147865_c6aa1faf","line":367,"range":{"start_line":362,"start_character":4,"end_line":367,"end_character":18},"in_reply_to":"454ffea7_0ed65230","updated":"2020-01-21 23:41:19.000000000","message":"Not addressed","commit_id":"e09cb20246803f1b4f9741aa6f0a0b5f5feeec71"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"cc45122facadf472fe5c7acd69e27669d6318de8","unresolved":false,"context_lines":[{"line_number":359,"context_line":"    Suffix2 \u003d ACInfo ++ PIInfo ++ Suffix1 ,"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"    CanHaveViews \u003d ns_bucket:can_have_views(BucketConfig),"},{"line_number":362,"context_line":"    Suffix3 \u003d case build_ddocs_uri(CanHaveViews, Id, BucketConfig) of"},{"line_number":363,"context_line":"                  [] -\u003e"},{"line_number":364,"context_line":"                      Suffix2;"},{"line_number":365,"context_line":"                  Uri -\u003e"},{"line_number":366,"context_line":"                      Uri ++ Suffix2"},{"line_number":367,"context_line":"              end,"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    FlushEnabled \u003d proplists:get_value(flush_enabled, BucketConfig, false),"},{"line_number":370,"context_line":"    MaybeFlushController \u003d"}],"source_content_type":"text/x-erlang","patch_set":10,"id":"aacb54e7_908c70c5","line":367,"range":{"start_line":362,"start_character":4,"end_line":367,"end_character":18},"in_reply_to":"ab147865_c6aa1faf","updated":"2020-01-22 00:24:13.000000000","message":"Sorry missed it.  Thanks for the help via slack.","commit_id":"e09cb20246803f1b4f9741aa6f0a0b5f5feeec71"}],"src/ns_bucket.erl":[{"author":{"_account_id":1000487,"name":"Artem Stemkovski","email":"artem@couchbase.com","username":"astemkov","avatars":[{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e73ae7e79fa4e1ebf1159ca7603fd357d556da32","unresolved":false,"context_lines":[{"line_number":84,"context_line":"         config_to_map_options/1,"},{"line_number":85,"context_line":"         needs_rebalance/2,"},{"line_number":86,"context_line":"         can_have_views/1,"},{"line_number":87,"context_line":"         uses_item_eviction/1,"},{"line_number":88,"context_line":"         uses_full_eviction/1,"},{"line_number":89,"context_line":"         uses_auto_compaction_info/1,"},{"line_number":90,"context_line":"         uses_autocompaction_based_purge_interval/1,"},{"line_number":91,"context_line":"         bucket_view_nodes/1,"}],"source_content_type":"text/x-erlang","patch_set":6,"id":"1225ae86_0ae11ddf","line":88,"range":{"start_line":87,"start_character":9,"end_line":88,"end_character":30},"updated":"2020-01-14 03:48:36.000000000","message":"maybe replace this 2 functions with one: eviction_type/1 which will return item or full?","commit_id":"2d8eb77cec45fb77e35b6d1a3e91ab6e56237335"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"203d0284de32798be72d83775cab252a49ba29de","unresolved":false,"context_lines":[{"line_number":84,"context_line":"         config_to_map_options/1,"},{"line_number":85,"context_line":"         needs_rebalance/2,"},{"line_number":86,"context_line":"         can_have_views/1,"},{"line_number":87,"context_line":"         uses_item_eviction/1,"},{"line_number":88,"context_line":"         uses_full_eviction/1,"},{"line_number":89,"context_line":"         uses_auto_compaction_info/1,"},{"line_number":90,"context_line":"         uses_autocompaction_based_purge_interval/1,"},{"line_number":91,"context_line":"         bucket_view_nodes/1,"}],"source_content_type":"text/x-erlang","patch_set":6,"id":"4e02a5e2_f9022f68","line":88,"range":{"start_line":87,"start_character":9,"end_line":88,"end_character":30},"in_reply_to":"1225ae86_0ae11ddf","updated":"2020-01-14 19:30:19.000000000","message":"These are used to determine values for two different params \"item_eviction_policy\" and \"ephemeral_full_policy\".  If this can be combined I\u0027ll do so in a future patch.","commit_id":"2d8eb77cec45fb77e35b6d1a3e91ab6e56237335"},{"author":{"_account_id":1000487,"name":"Artem Stemkovski","email":"artem@couchbase.com","username":"astemkov","avatars":[{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"232e171ca00bfbd2995f23b39e9766a3cf691e3c","unresolved":false,"context_lines":[{"line_number":84,"context_line":"         config_to_map_options/1,"},{"line_number":85,"context_line":"         needs_rebalance/2,"},{"line_number":86,"context_line":"         can_have_views/1,"},{"line_number":87,"context_line":"         uses_item_eviction/1,"},{"line_number":88,"context_line":"         uses_full_eviction/1,"},{"line_number":89,"context_line":"         uses_auto_compaction_info/1,"},{"line_number":90,"context_line":"         uses_autocompaction_based_purge_interval/1,"},{"line_number":91,"context_line":"         bucket_view_nodes/1,"}],"source_content_type":"text/x-erlang","patch_set":6,"id":"dc8a2ef2_4660d7cd","line":88,"range":{"start_line":87,"start_character":9,"end_line":88,"end_character":30},"in_reply_to":"4e02a5e2_f9022f68","updated":"2020-01-15 00:05:25.000000000","message":"the usage of these functions doesn\u0027t change the fact that they conceptually return a value of the same bucket property. I suggest to merge them.","commit_id":"2d8eb77cec45fb77e35b6d1a3e91ab6e56237335"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"abe16319c999a74e8ead8c8e01715acf1270271b","unresolved":false,"context_lines":[{"line_number":84,"context_line":"         config_to_map_options/1,"},{"line_number":85,"context_line":"         needs_rebalance/2,"},{"line_number":86,"context_line":"         can_have_views/1,"},{"line_number":87,"context_line":"         uses_item_eviction/1,"},{"line_number":88,"context_line":"         uses_full_eviction/1,"},{"line_number":89,"context_line":"         uses_auto_compaction_info/1,"},{"line_number":90,"context_line":"         uses_autocompaction_based_purge_interval/1,"},{"line_number":91,"context_line":"         bucket_view_nodes/1,"}],"source_content_type":"text/x-erlang","patch_set":6,"id":"cf2d5c06_0bc023be","line":88,"range":{"start_line":87,"start_character":9,"end_line":88,"end_character":30},"in_reply_to":"dc8a2ef2_4660d7cd","updated":"2020-01-15 17:16:12.000000000","message":"For the item_eviction_policy param the possible values are:\n    couchstore -\u003e\n        proplists:get_value(eviction_policy, BucketConfig, value_only);\n    magma -\u003e\n        proplists:get_value(eviction_policy, BucketConfig, value_only);\n    ephemeral -\u003e\n        undefined\n\nFor the ephemeral_full_policy param the possible values are:\n    couchstore -\u003e\n        undefined\n    magama -\u003e\n        undefined\n    ephemeral -\u003e\n        case \"eviction_policy\"\n            nru_eviction -\u003e\n                auto_delete\n            no_eviction -\u003e\n                fail_new_data\n\nThe only way to handle this in a single function is to pass \"item\" vs \"full\"\nas an argument to the function.  So I\u0027d like to leave this as two separate\nfunctions.\n~","commit_id":"2d8eb77cec45fb77e35b6d1a3e91ab6e56237335"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"45093aa0f3ace833db0b1de953847c1a553ce330","unresolved":false,"context_lines":[{"line_number":84,"context_line":"         config_to_map_options/1,"},{"line_number":85,"context_line":"         needs_rebalance/2,"},{"line_number":86,"context_line":"         can_have_views/1,"},{"line_number":87,"context_line":"         uses_item_eviction/1,"},{"line_number":88,"context_line":"         uses_full_eviction/1,"},{"line_number":89,"context_line":"         uses_auto_compaction_info/1,"},{"line_number":90,"context_line":"         uses_autocompaction_based_purge_interval/1,"},{"line_number":91,"context_line":"         bucket_view_nodes/1,"}],"source_content_type":"text/x-erlang","patch_set":6,"id":"ca1ca34b_1511e9cb","line":88,"range":{"start_line":87,"start_character":9,"end_line":88,"end_character":30},"in_reply_to":"dc8a2ef2_4660d7cd","updated":"2020-01-15 00:32:56.000000000","message":"and this one too","commit_id":"2d8eb77cec45fb77e35b6d1a3e91ab6e56237335"},{"author":{"_account_id":1000487,"name":"Artem Stemkovski","email":"artem@couchbase.com","username":"astemkov","avatars":[{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f31890e7d3e24ca5ccce7635d3933a0889874249","unresolved":false,"context_lines":[{"line_number":829,"context_line":"    StorageMode \u003d storage_mode(BucketConfig),"},{"line_number":830,"context_line":"    StorageMode \u003d:\u003d ephemeral."},{"line_number":831,"context_line":""},{"line_number":832,"context_line":"uses_auto_compaction_info(BucketConfig) -\u003e"},{"line_number":833,"context_line":"    StorageMode \u003d storage_mode(BucketConfig),"},{"line_number":834,"context_line":"    case StorageMode of"},{"line_number":835,"context_line":"        couchstore -\u003e true;"},{"line_number":836,"context_line":"        magma -\u003e true;"},{"line_number":837,"context_line":"        ephemeral -\u003e false;"},{"line_number":838,"context_line":"        _ -\u003e undefined"},{"line_number":839,"context_line":"    end."},{"line_number":840,"context_line":""},{"line_number":841,"context_line":"uses_autocompaction_based_purge_interval(BucketConfig) -\u003e"},{"line_number":842,"context_line":"    StorageMode \u003d storage_mode(BucketConfig),"},{"line_number":843,"context_line":"    case StorageMode of"},{"line_number":844,"context_line":"        couchstore -\u003e true;"},{"line_number":845,"context_line":"        magma -\u003e true;"},{"line_number":846,"context_line":"        ephemeral -\u003e false;"},{"line_number":847,"context_line":"        _ -\u003e undefined"},{"line_number":848,"context_line":"    end."},{"line_number":849,"context_line":""},{"line_number":850,"context_line":"bucket_uuid(BucketConfig) -\u003e"},{"line_number":851,"context_line":"    UUID \u003d proplists:get_value(uuid, BucketConfig),"}],"source_content_type":"text/x-erlang","patch_set":6,"id":"9c06262a_a86e6735","line":848,"range":{"start_line":832,"start_character":0,"end_line":848,"end_character":8},"updated":"2020-01-16 22:38:25.000000000","message":"It\u0027s quite obvious that compaction is for persistent buckets only. So I suggest to remove these and use is_persistent instead.","commit_id":"2d8eb77cec45fb77e35b6d1a3e91ab6e56237335"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"8aa038a73828b9e4753e419d8c46480439b1713b","unresolved":false,"context_lines":[{"line_number":829,"context_line":"    StorageMode \u003d storage_mode(BucketConfig),"},{"line_number":830,"context_line":"    StorageMode \u003d:\u003d ephemeral."},{"line_number":831,"context_line":""},{"line_number":832,"context_line":"uses_auto_compaction_info(BucketConfig) -\u003e"},{"line_number":833,"context_line":"    StorageMode \u003d storage_mode(BucketConfig),"},{"line_number":834,"context_line":"    case StorageMode of"},{"line_number":835,"context_line":"        couchstore -\u003e true;"},{"line_number":836,"context_line":"        magma -\u003e true;"},{"line_number":837,"context_line":"        ephemeral -\u003e false;"},{"line_number":838,"context_line":"        _ -\u003e undefined"},{"line_number":839,"context_line":"    end."},{"line_number":840,"context_line":""},{"line_number":841,"context_line":"uses_autocompaction_based_purge_interval(BucketConfig) -\u003e"},{"line_number":842,"context_line":"    StorageMode \u003d storage_mode(BucketConfig),"},{"line_number":843,"context_line":"    case StorageMode of"},{"line_number":844,"context_line":"        couchstore -\u003e true;"},{"line_number":845,"context_line":"        magma -\u003e true;"},{"line_number":846,"context_line":"        ephemeral -\u003e false;"},{"line_number":847,"context_line":"        _ -\u003e undefined"},{"line_number":848,"context_line":"    end."},{"line_number":849,"context_line":""},{"line_number":850,"context_line":"bucket_uuid(BucketConfig) -\u003e"},{"line_number":851,"context_line":"    UUID \u003d proplists:get_value(uuid, BucketConfig),"}],"source_content_type":"text/x-erlang","patch_set":6,"id":"6a130154_0c79f657","line":848,"range":{"start_line":832,"start_character":0,"end_line":848,"end_character":8},"in_reply_to":"9c06262a_a86e6735","updated":"2020-01-17 00:43:39.000000000","message":"Done","commit_id":"2d8eb77cec45fb77e35b6d1a3e91ab6e56237335"},{"author":{"_account_id":1000487,"name":"Artem Stemkovski","email":"artem@couchbase.com","username":"astemkov","avatars":[{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ffda974c541ff0ee49718fd83bec668f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"fab025ee4021255ca0419ea63a5a6afc7fc59e16","unresolved":false,"context_lines":[{"line_number":86,"context_line":"         config_to_map_options/1,"},{"line_number":87,"context_line":"         needs_rebalance/2,"},{"line_number":88,"context_line":"         can_have_views/1,"},{"line_number":89,"context_line":"         uses_item_eviction/1,"},{"line_number":90,"context_line":"         uses_full_eviction/1,"},{"line_number":91,"context_line":"         bucket_view_nodes/1,"},{"line_number":92,"context_line":"         bucket_config_view_nodes/1,"},{"line_number":93,"context_line":"         get_num_vbuckets/0,"}],"source_content_type":"text/x-erlang","patch_set":10,"id":"7b036044_99b4045c","line":90,"range":{"start_line":89,"start_character":9,"end_line":90,"end_character":30},"updated":"2020-01-21 19:29:18.000000000","message":"these are unused","commit_id":"e09cb20246803f1b4f9741aa6f0a0b5f5feeec71"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7f3a25368e2b6ea99c8ce6257c43c27de8985a74","unresolved":false,"context_lines":[{"line_number":86,"context_line":"         config_to_map_options/1,"},{"line_number":87,"context_line":"         needs_rebalance/2,"},{"line_number":88,"context_line":"         can_have_views/1,"},{"line_number":89,"context_line":"         uses_item_eviction/1,"},{"line_number":90,"context_line":"         uses_full_eviction/1,"},{"line_number":91,"context_line":"         bucket_view_nodes/1,"},{"line_number":92,"context_line":"         bucket_config_view_nodes/1,"},{"line_number":93,"context_line":"         get_num_vbuckets/0,"}],"source_content_type":"text/x-erlang","patch_set":10,"id":"372b53a3_ac119a5c","line":90,"range":{"start_line":89,"start_character":9,"end_line":90,"end_character":30},"in_reply_to":"7b036044_99b4045c","updated":"2020-01-21 20:10:35.000000000","message":"Good catch.","commit_id":"e09cb20246803f1b4f9741aa6f0a0b5f5feeec71"}]}